1. 06 May, 2008 1 commit
    • Christian Neumair's avatar
      Wrap to next row/column when pressing arrow key, except if a11y is used. · f9be809b
      Christian Neumair authored
      2008-05-06  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(next_row_leftmost), (previous_row_rightmost),
      	(next_column_highest), (previous_column_lowest),
      	(last_column_lowest), (keyboard_end), (keyboard_arrow_key),
      	(keyboard_right), (keyboard_left), (keyboard_down), (keyboard_up):
      	Wrap to next row/column when pressing arrow key, except if a11y is
      	used. Fixes #526802.
      	For vertical layout, make the "End" key select bottom item in last
      	column, instead of the last item in the bottom row.
      
      svn path=/trunk/; revision=14143
      f9be809b
  2. 05 May, 2008 3 commits
    • Andrew Walton's avatar
      Fixup broken GConf key define. Patch from Stephane Demurget. · 64a1632a
      Andrew Walton authored
      2008-05-05  A. Walton  <awalton@gnome.org>
      
      	* libnautilus-private/nautilus-global-preferences.h:
      	Fixup broken GConf key define. Patch from Stephane Demurget.
      
      
      svn path=/trunk/; revision=14141
      64a1632a
    • Andrew Walton's avatar
      reviewed by: Cosimo Cecchi · b1fa7911
      Andrew Walton authored
      2008-05-05  A. Walton  <awalton@gnome.org>
      
      	reviewed by: Cosimo Cecchi
      
      	* libnautilus-private/nautilus-module.c (nautilus_module_load):
      	* src/file-manager/fm-ditem-page.c (save_entry):
      	* src/nautilus-autorun-software.c (autorun):
      	Fixes build on toolchains with -Wformat enabled. 
      	Closes bug #531562.
      
      
      svn path=/trunk/; revision=14140
      b1fa7911
    • Tomáš Bžatek's avatar
      Don't allow recursive move/copy into itself. Fixes #530720. · 7c53ad15
      Tomáš Bžatek authored
      2008-05-05  Tomas Bzatek  <tbzatek@redhat.com> 
      
              * libnautilus-private/nautilus-file-operations.c:
              Don't allow recursive move/copy into itself. Fixes #530720.
      
      
      svn path=/trunk/; revision=14131
      7c53ad15
  3. 01 May, 2008 1 commit
  4. 30 Apr, 2008 2 commits
    • Andrew Walton's avatar
      Replace g_return_*() with g_assert() in private, internal functions. · a9b02ab3
      Andrew Walton authored
      2008-04-30  A. Walton  <awalton@gnome.org>
      
      	* libnautilus-private/nautilus-clipboard.c:
      	* libnautilus-private/nautilus-directory-async.c:
      	* libnautilus-private/nautilus-directory.c:
      	* libnautilus-private/nautilus-entry.c:
      	* libnautilus-private/nautilus-file.c:
      	* libnautilus-private/nautilus-horizontal-splitter.c:
      	* libnautilus-private/nautilus-icon-canvas-item.c:
      	* libnautilus-private/nautilus-icon-container.c:
      	* libnautilus-private/nautilus-metafile.c:
      	* libnautilus-private/nautilus-users-groups-cache.c:
      	* libnautilus-private/nautilus-vfs-directory.c:
      	* src/nautilus-emblem-sidebar.c:
      	* src/nautilus-file-management-properties.c:
      	* src/nautilus-window-manage-views.c:
      	* src/nautilus-window.c:
      	* src/nautilus-zoom-control.c:
      	Replace g_return_*() with g_assert() in private, internal
      	functions. Closes #530321.
      
      
      svn path=/trunk/; revision=14114
      a9b02ab3
    • David Zeuthen's avatar
      Fix how autorunning works. Instead of inhibiting autorunning every time we · 0e85a1ca
      David Zeuthen authored
      2008-04-29  David Zeuthen  <davidz@redhat.com>
      
              * libnautilus-private/nautilus-autorun.c:
              * libnautilus-private/nautilus-autorun.h:
              * libnautilus-private/nautilus-file-operations.c:
              (volume_mount_cb), (nautilus_file_operations_mount_volume):
              * libnautilus-private/nautilus-file-operations.h:
              * libnautilus-private/nautilus-mime-actions.c:
              (activation_mount_not_mounted_callback):
              * libnautilus-private/nautilus-vfs-file.c:
              (vfs_file_mount_callback):
              * src/nautilus-application.c: (startup_volume_mount_cb),
              (volume_added_callback):
              * src/nautilus-places-sidebar.c: (open_selected_bookmark),
              (mount_shortcut_cb):
              * src/nautilus-window-manage-views.c: (mount_not_mounted_callback):
              Fix how autorunning works. Instead of inhibiting autorunning
              every time we run something, we turn things around and instead
              allow automounting only in the instance where Nautilus automounted
              something itself. So in essence this patch is s/inhibit/allow/.
              This fixes an annoying problem where Nautilus would do autorun
              everytime something was mounted even from the command line. A
              consequence of this are windows popping up and other annoyances.
              This patch fixes that problem.
      
              * src/nautilus-x-content-bar.c: (nautilus_x_content_bar_init):
              Make sure the label is ellipsized.
      
      
      svn path=/trunk/; revision=14112
      0e85a1ca
  5. 27 Apr, 2008 2 commits
    • Cosimo Cecchi's avatar
      Report user cancel when all the files we're about to trash or delete are · dbd34bda
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_files),
      	(trash_files), (delete_job):
      	Report user cancel when all the files we're about to trash or delete
      	are skipped in the operation. This allows to use the same selection for
      	requesting another deletion from the view. (#519746).
      
      svn path=/trunk/; revision=14106
      dbd34bda
    • Andrew Walton's avatar
      reviewed by: Christian Neumair · f78a9799
      Andrew Walton authored
      2008-04-26  A. Walton  <awalton@gnome.org>
      
      	reviewed by: Christian Neumair
      
      	* libnautilus-private/nautilus-file-private.h:
      	* libnautilus-private/nautilus-file-utilities.c
      	(nautilus_compute_title_for_location):
      	* libnautilus-private/nautilus-file.c (update_info_internal),
      	(nautilus_file_get_description):
      	* libnautilus-private/nautilus-file.h:
      	Use standard::description in the window title when it's available.
      	Closes bug #516007.
      
      
      svn path=/trunk/; revision=14094
      f78a9799
  6. 26 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Properly handle selection changes when using keyboard navigation. We did · a6f7e3a2
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(emit_atk_focus_tracker_notify), (set_keyboard_focus),
      	(select_range), (select_one_unselect_others), (rubberband_select),
      	(keyboard_move_to):
      	Properly handle selection changes when using keyboard navigation. We
      	did not emit a "selection-change" signal when keyboard rubberbanding
      	was used, and all except one icon were deselected. Fixes #509432.
      	Thanks to Paweł Paprota.
      
      svn path=/trunk/; revision=14092
      a6f7e3a2
  7. 23 Apr, 2008 1 commit
  8. 15 Apr, 2008 1 commit
  9. 06 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Remove show/hide buttons. The entries can be toggled directly using mouse · cb037e32
      Christian Neumair authored
      2008-04-07  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-column-chooser.c (update_buttons),
      	(add_buttons):
      	Remove show/hide buttons. The entries can be toggled directly using
      	mouse or keyboard. Do not remove buttons to move entries, since
      	list DND may not be obvious for some users (#514394). Thanks to Marcin
      	Galazka.
      
      svn path=/trunk/; revision=14044
      cb037e32
  10. 05 Apr, 2008 1 commit
    • Cosimo Cecchi's avatar
      Disable autorun when detecting autorun.exe and autorun.inf, as we do not · fbb8e2f2
      Cosimo Cecchi authored
      2008-04-05  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-autorun.c:
      	(_g_mount_guess_content_type):
      	Disable autorun when detecting autorun.exe and autorun.inf,
      	as we do not support those yet (part of bug #524270).
      	* src/nautilus-autorun-software.c: (autorun), (main):
      	Plug some minor leaks.
      
      svn path=/trunk/; revision=14042
      fbb8e2f2
  11. 04 Apr, 2008 2 commits
    • Cosimo Cecchi's avatar
      Add new APIs for extensions to NautilusFileInfo (can_write, get_mount and · 957f93fd
      Cosimo Cecchi authored
      2008-04-04  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-extension/nautilus-file-info.c:
      	(nautilus_file_info_get_parent_info),
      	(nautilus_file_info_get_mount), (nautilus_file_info_can_write):
      	* libnautilus-extension/nautilus-file-info.h:
      	* libnautilus-private/nautilus-file.c:
      	(nautilus_file_info_iface_init):
      	Add new APIs for extensions to NautilusFileInfo (can_write, get_mount
      	and get_parent_info). (#521612).
      
      svn path=/trunk/; revision=14036
      957f93fd
    • Christian Neumair's avatar
      Inhibit autorun in mount callbacks after finishing mounts rather than · 00a42fe8
      Christian Neumair authored
      2008-04-04  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c (volume_mount_cb),
      	(nautilus_file_operations_mount_volume):
      	* libnautilus-private/nautilus-file-operations.h:
      	* libnautilus-private/nautilus-mime-actions.c
      	(activation_mount_not_mounted_callback),
      	(activation_mount_not_mounted):
      	* src/nautilus-application.c (startup_volume_mount_cb),
      	(automount_all_volumes), (volume_added_callback):
      	* src/nautilus-places-sidebar.c (open_selected_bookmark),
      	(mount_shortcut_cb):
      	* src/nautilus-window-manage-views.c (mount_not_mounted_callback),
      	(got_file_info_for_view_selection_callback):
      	Inhibit autorun in mount callbacks after finishing mounts rather than
      	before mounting.
      
      	It is neccessary because the mount may take a very long time (floppy,
      	password prompt), which may take longer than the inhibition timeout.
      
      	This approach works because with the current HAL volume monitor
      	implementation, GVolumeMonitor signal emission is scheduled, while the
      	mount callbacks are invoked synchronously.
      
      	This should also fix the not working inhibition on startup, which
      	could happen because parallel mounts in the background and the rest of
      	the startup process eat resources, so the mounts may also take longer
      	than the inhibition timeout.
      
      svn path=/trunk/; revision=14034
      00a42fe8
  12. 03 Apr, 2008 3 commits
  13. 02 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Subtract 1 from icon rectangle's x2/y2 positions before setting scroll · a5cf591c
      Christian Neumair authored
      2008-04-02  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(nautilus_icon_container_update_scroll_region),
      	(lay_down_icons_horizontal), (get_max_icon_dimensions),
      	(lay_down_icons_vertical),
      	(nautilus_icon_container_start_renaming_selected_item),
      	(nautilus_icon_container_is_layout_vertical):
      	* libnautilus-private/nautilus-icon-container.h:
      	* src/nautilus-window.c
      	(nautilus_window_set_initial_window_geometry):
      	Subtract 1 from icon rectangle's x2/y2 positions before setting scroll
      	area since the entire canvas codes requests 1 px more than it needs.
      	Wrap when the icon hits the canvas, rather than wrapping to late.
      	Fixes most of the "text besides icons" glitches.
      
      	Add container padding on the RHS for vertical layout, and consider
      	max. emblem rectangles when deciding whether to wrap. This may wrap
      	slightly to early in some (high zoom level) situations, but we will
      	never get scroll glitches.
      
      svn path=/trunk/; revision=14025
      a5cf591c
  14. 01 Apr, 2008 3 commits
    • Christian Neumair's avatar
      Remove unused "label" field of NautilusViewInfo and · 2966e3f4
      Christian Neumair authored
      2008-04-01  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-view-factory.h:
      	* src/file-manager/fm-desktop-icon-view.c
      	(fm_desktop_icon_view_register):
      	* src/file-manager/fm-icon-view.c:
      	* src/file-manager/fm-list-view.c (fm_list_view_register):
      	* src/nautilus-navigation-window.c (load_view_as_menu):
      	* src/nautilus-window-manage-views.c:
      	* src/nautilus-window-manage-views.h:
      	* src/nautilus-window.c (add_view_as_menu_item):
      	Remove unused "label" field of NautilusViewInfo and
      	nautilus_window_get_view_label().
      	Rename two other fields of NautilusViewInfo and make their use
      	more explicit. Remove redundand "View" from view menu label.
      
      svn path=/trunk/; revision=14024
      2966e3f4
    • Michael J. Chudobiak's avatar
      Skip the thumbnailing of unreadable files. This is more efficient than · e5085870
      Michael J. Chudobiak authored
      2008-04-01  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libnautilus-private/nautilus-file.c: (nautilus_file_get_icon):
              Skip the thumbnailing of unreadable files. This is more efficient
              than relying on failed thumbnails. (#525594).
      
      
      svn path=/trunk/; revision=14022
      e5085870
    • Cosimo Cecchi's avatar
      Do not use contractions in strings. (#145356). · 10053a33
      Cosimo Cecchi authored
      2008-04-01  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_dir),
      	(prompt_empty_trash), (verify_destination), (copy_move_directory),
      	(remove_target_recursively), (copy_move_file):
      	* libnautilus-private/nautilus-mime-actions.c:
      	(report_broken_symbolic_link), (activate_files):
      	* libnautilus-private/nautilus-program-choosing.c:
      	(application_cannot_open_location), (nautilus_launch_application),
      	(nautilus_launch_desktop_file):
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_loading_directory),
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/file-manager/fm-properties-window.c:
      	(fm_properties_window_drag_data_received),
      	(create_permissions_page):
      	* src/nautilus-application.c: (nautilus_application_startup):
      	* src/nautilus-connect-server-dialog-main.c:
      	(display_error_dialog):
      	* src/nautilus-connect-server-dialog.c: (connect_to_server):
      	* src/nautilus-emblem-sidebar.c:
      	(nautilus_emblem_sidebar_delete_cb), (rename_dialog_response_cb):
      	* src/nautilus-information-panel.c: (receive_dropped_uri_list):
      	* src/nautilus-property-browser.c: (remove_pattern),
      	(remove_emblem), (add_pattern_to_browser):
      	* src/nautilus-window-manage-views.c:
      	(display_view_selection_failure):
      	Do not use contractions in strings. (#145356).
      
      svn path=/trunk/; revision=14017
      10053a33
  15. 31 Mar, 2008 3 commits
  16. 30 Mar, 2008 1 commit
    • Christian Neumair's avatar
      For column layout, do not limit text width if each columns determines its · 4d712979
      Christian Neumair authored
      2008-03-31  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-canvas-item.c
      	(create_label_layout),
      	(nautilus_icon_canvas_item_get_max_text_width):
      	* libnautilus-private/nautilus-icon-container.c
      	(nautilus_icon_container_start_renaming_selected_item):
      	For column layout, do not limit text width if each columns determines
      	its own width.
      
      svn path=/trunk/; revision=14009
      4d712979
  17. 29 Mar, 2008 3 commits
    • Christian Neumair's avatar
      Added compact view. · b19cc767
      Christian Neumair authored
      2008-03-29  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/apps_nautilus_preferences.schemas.in:
      	* libnautilus-private/nautilus-global-preferences.c
      	(nautilus_global_preferences_get_default_folder_viewer_preference_a
      	s_iid):
      	* libnautilus-private/nautilus-global-preferences.h:
      	* libnautilus-private/nautilus-icon-canvas-item.c
      	(create_label_layout),
      	(nautilus_icon_canvas_item_get_max_text_width):
      	* libnautilus-private/nautilus-icon-container.c
      	(lay_down_one_column), (get_max_icon_dimensions),
      	(lay_down_icons_vertical), (lay_down_icons_vertical_desktop),
      	(lay_down_icons), (size_allocate),
      	(nautilus_icon_container_update_icon),
      	(nautilus_icon_container_set_layout_mode),
      	(nautilus_icon_container_start_renaming_selected_item),
      	(nautilus_icon_container_set_forced_icon_size),
      	(nautilus_icon_container_set_all_columns_same_width):
      	* libnautilus-private/nautilus-icon-container.h:
      	* libnautilus-private/nautilus-icon-private.h:
      	* libnautilus-private/nautilus-metadata.h:
      	* src/file-manager/fm-icon-container.c
      	(fm_icon_container_get_icon_images),
      	(fm_icon_container_get_icon_text):
      	* src/file-manager/fm-icon-view.c
      	(get_stored_icon_position_callback),
      	(fm_icon_view_supports_manual_layout),
      	(fm_icon_view_supports_tighter_layout), (update_layout_menus),
      	(fm_icon_view_real_set_directory_sort_reversed),
      	(fm_icon_view_get_directory_auto_layout),
      	(fm_icon_view_real_get_directory_auto_layout),
      	(fm_icon_view_set_directory_auto_layout),
      	(fm_icon_view_real_set_directory_auto_layout),
      	(fm_icon_view_real_set_directory_tighter_layout),
      	(real_supports_manual_layout), (get_default_zoom_level),
      	(set_labels_beside_icons), (set_columns_same_width),
      	(fm_icon_view_begin_loading), (fm_icon_view_set_zoom_level),
      	(fm_icon_view_zoom_to_level),
      	(fm_icon_view_restore_default_zoom_level),
      	(default_zoom_level_changed_callback),
      	(all_columns_same_width_changed_callback),
      	(fm_icon_view_set_property), (fm_icon_view_class_init),
      	(fm_icon_view_get_id), (fm_icon_view_init), (fm_icon_view_create),
      	(fm_compact_view_create), (fm_icon_view_is_compact),
      	(fm_icon_view_register):
      	* src/file-manager/fm-icon-view.h:
      	* src/nautilus-file-management-properties.c
      	(nautilus_file_management_properties_dialog_setup):
      	* src/nautilus-file-management-properties.glade:
      	Added compact view.
      
      svn path=/trunk/; revision=14003
      b19cc767
    • Cosimo Cecchi's avatar
      Use title capitalization for the File Operations dialog. (#516353). · 5f3fee55
      Cosimo Cecchi authored
      2008-03-29  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-progress-info.c:
      	(get_progress_window):
      	Use title capitalization for the File Operations dialog. (#516353).
      
      svn path=/trunk/; revision=14001
      5f3fee55
    • Cosimo Cecchi's avatar
      Add support for "Invert Selection". Patch by Amos Brocco · 47229472
      Cosimo Cecchi authored
      2008-03-29  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c:
      	(nautilus_icon_container_invert_selection):
      	* libnautilus-private/nautilus-icon-container.h:
      	* libnautilus-private/nautilus-view.c:
      	(nautilus_view_invert_selection):
      	* libnautilus-private/nautilus-view.h:
      	* src/file-manager/fm-actions.h:
      	* src/file-manager/fm-directory-view.c:
      	(action_invert_selection_callback),
      	(fm_directory_view_invert_selection), (real_update_menus),
      	(fm_directory_view_class_init):
      	* src/file-manager/fm-directory-view.h:
      	* src/file-manager/fm-icon-view.c: (fm_icon_view_invert_selection),
      	(fm_icon_view_class_init):
      	* src/file-manager/fm-list-view.c: (fm_list_view_invert_selection),
      	(fm_list_view_class_init):
      	* src/file-manager/nautilus-directory-view-ui.xml:
      	Add support for "Invert Selection". Patch by Amos Brocco
      	<amos.brocco@unifr.ch>. (#305295).
      
      svn path=/trunk/; revision=13999
      47229472
  18. 28 Mar, 2008 6 commits
  19. 26 Mar, 2008 1 commit
  20. 23 Mar, 2008 2 commits
    • Christian Neumair's avatar
      Do not follow symlinks. (#504980). · b49a82f2
      Christian Neumair authored
      2008-03-23  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-directory-async.c
      	(directory_count_start), (deep_count_load):
      	Do not follow symlinks. (#504980).
      
      svn path=/trunk/; revision=13976
      b49a82f2
    • Christian Neumair's avatar
      Fix compiler warnings about unused value by casting va_arg calls with · da4c64e2
      Christian Neumair authored
      2008-03-23  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c
      	(custom_full_name_skip), (custom_basename_skip),
      	(custom_size_skip), (custom_time_skip), (custom_mount_skip):
      	Fix compiler warnings about unused value by casting va_arg calls with
      	unused return values to void. (#523908).
      
      svn path=/trunk/; revision=13975
      da4c64e2
  21. 20 Mar, 2008 1 commit