Dušan Kazik authored Sep 27, 2022 and Administrator committed Sep 27, 2022

(cherry picked from commit 69bd3c42)

Dušan Kazik authored Sep 27, 2022 and Administrator committed Sep 27, 2022

(cherry picked from commit ffff26ca)

Fabio Tomat authored Sep 26, 2022 and Administrator committed Sep 26, 2022

(cherry picked from commit 3b2404df)

Currently, Nautilus crashes for redo operations after undoing a template create.

This is because we are passing the parse path, but we expect the base name for the redo operation.

To fix this, use g_file_get_basename instead of g_file_get_parse_name.

Closes #2344

Baurzhan Muftakhidinov authored Sep 18, 2022 and Administrator committed Sep 18, 2022

(cherry picked from commit bddda816)

Corey Berla authored Sep 14, 2022 and António Fernandes committed Sep 17, 2022

During the switch to GTK4 (e358c234), nautilus-x-content-bar
parent was changed from GtkInfoBar to AdwBin, but the G_DEFINE_TYPE
macro wasn't updated accordingly.

Fixes: #2477

Corey Berla authored Sep 17, 2022 and António Fernandes committed Sep 17, 2022

We used to select the first search result as soon as it arives,
in order to allow keyboard shortcuts to take effect on it. This
makes search more efficient to use with keyboard.

Prior to the gtk4 port (and the introduction of list-base,
canvas view and list view set the selection directly in `select_first`
through `icon_set_selected` and `gtk_tree_selection_select_iter`.

After the port to gtk4, list-base used the existing function
`nautilus_view_set_selection` which seemed to work, except
`nautilus_files_view_set_selection` only actually sets the selection
when the view is not loading.  In the meantime, it puts the selection
is a pending_selection to be set when the loading is complete.

This causes problems for search because loading generally takes
longer to complete in a search, and the user will have to wait
until the search is complete for the item to be selected.
As a matter of fact, the *only* time that select_first is used
is during a search (which was the original intention of the function
when introduced in 50711e28).

There's no need to add further complexity, beyond what the
GtkSelectionModel already provides.  Just as `real_select_all`
simples calls `gtk_selection_model_select_all`, make
`real_select_first` call `gtk_selection_model_select_item`.

Fixes: #2481

It hardcodes a color which matches only in light mode, and only if high
contrast is not enabled.

Instead derive from currentColor to get light/dark automatic support
and double the alpha opacity on high contrast.

The alpha values were copied from libadwaita's color used by level bar.

Remove inset borders from the former, add them to the later.

Also inset the pathbar border, to make it look look the same height as
buttons in the headerbar and overlap the secondary menu border.

The patches we want are actually only available in 3.7.2 at this time.

We rely on many DND and GtkListBase bugfixes for proper behavior or the
GTK 4 port.

Resolves: #2366

Antonio Teixeira authored Jun 15, 2022 and António Fernandes committed Sep 04, 2022

g_file_get_parse_name() returns a string with escaped special characters
for remote locations. Use g_file_get_uri() for remote bookmarks and
unescape the string before setting the tooltip to make sure it is always
a human-readable string. Use g_file_get_path() for local bookmarks.

Fixes #2016

If you change the sort order from the sort menu, the next time you
visit that location, the last sort option is remembered.

This is generally desirable behavior, but not in the case of Recent,
Search or Trash.

Fixes #2472

Corey Berla authored May 03, 2022 and António Fernandes committed Sep 04, 2022

Format option is displayed for mtp devices even though gnome-disks
doesn't support them.  Hide format option if uri starts with mtp://

This applies to MTP and PTP (gphoto2)

Fixes: #1358

Corey Berla authored May 03, 2022 and António Fernandes committed Sep 04, 2022

Reformat should_show_format_command() to allow for additional
checks.