1. 22 Mar, 2000 2 commits
    • Pavel Cisler's avatar
      Fixed an annoying bug that would sometimes cause the drag&drop feedback to · f7134226
      Pavel Cisler authored
      2000-03-21  Pavel Cisler  <pavel@eazel.com>
      
      	Fixed an annoying bug that would sometimes cause the drag&drop feedback
      	to come up delayed.
      f7134226
    • Darin Adler's avatar
      Did some of the items from RENAMING. · 1764f212
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/gnome-icon-container-dnd.c:
      	* libnautilus/gnome-icon-container-dnd.h:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/gnome-icon-container.h:
      	* libnautilus/gtkflist.c:
      	* libnautilus/gtkflist.h:
      	* libnautilus/nautilus-icon-canvas-item.c:
      	* libnautilus/nautilus-icon-canvas-item.h:
      	* libnautilus/nautilus-icon-container.c:
      	* libnautilus/nautilus-icon-container.h:
      	* libnautilus/nautilus-icon-dnd.c:
      	* libnautilus/nautilus-icon-dnd.h:
      	* libnautilus/nautilus-icon-grid.c:
      	* libnautilus/nautilus-icon-grid.h:
      	* libnautilus/nautilus-icon-private.h:
      	* libnautilus/nautilus-icons-view-icon-item.c:
      	* libnautilus/nautilus-icons-view-icon-item.h:
      	* libnautilus/nautilus-lib-self-check-functions.h:
      	* libnautilus/nautilus-list-column-title.c:
      	* libnautilus/nautilus-list.c:
      	* libnautilus/nautilus-list.h:
      	* src/file-manager/Makefile.am:
      	* src/file-manager/fm-directory-view-icons.c:
      	* src/file-manager/fm-directory-view-icons.h:
      	* src/file-manager/fm-directory-view-list.c:
      	* src/file-manager/fm-directory-view-list.h:
      	* src/file-manager/fm-icon-view.c:
      	* src/file-manager/fm-icon-view.h:
      	* src/file-manager/fm-list-view.c:
      	* src/file-manager/fm-list-view.h:
      	* src/ntl-app.c:
      	Did these RENAMING entries:
      	  FMDirectoryViewIcons -> FMIconView
      	  FMDirectoryViewList  -> FMListView
      	  GnomeIconContainer -> NautilusIconContainer
      	  GnomeIconContainerIcon -> NautilusIcon
      	  NautilusIconsViewIconItem -> NautilusIconCanvasItem
      
      	* RENAMING: Marked the renaming done.
      1764f212
  2. 21 Mar, 2000 4 commits
    • Darin Adler's avatar
      Fixed arrow keys and worked on the icon grid. · f09362cb
      Darin Adler authored
      	Fixes bugs #314, #324, and #325.
      
      	* components/help/hyperbola.goad:
      	Corrected repo_ids -> repo_id, reported by Richard Hult.
      
      	* src/nautilus.goad:
      	Added missing = character, reported by Richard Hult.
      
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/gnome-icon-container-private.h:
      	Made the icon grid handle negative coordinates.
      	Removed most of the icon grid code.
      	Reimplemented the arrow keys. They should work again.
      
      	* libnautilus/nautilus-gnome-extensions.c:
      	* libnautilus/nautilus-gnome-extensions.h:
      	(nautilus_art_irect_contains_irect):
      	Added another helper function.
      
      	* libnautilus/nautilus-icons-view-icon-item.c:
      
      	* libnautilus/nautilus-icons-view-icon-item.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/gnome-icon-container-private.h:
      	Added user data to each canvas item and got rid of the hash table
      	that maps canvas items to icons.
      
      	* RENAMING: Tweaks.
      f09362cb
    • John Sullivan's avatar
      f953548e
    • Pavel Cisler's avatar
      Center the sort order indicators inside a title better. Make the column · ec8d277e
      Pavel Cisler authored
      2000-03-20  Pavel Cisler  <pavel@eazel.com>
      
      	Center the sort order indicators inside a title better. Make the column
      	title label spacing more like the old CtkCList.
      ec8d277e
    • Pavel Cisler's avatar
      Use an offscreen bitmap to draw the column title during column resizing · a4b40782
      Pavel Cisler authored
      2000-03-20  Pavel Cisler  <pavel@eazel.com>
      
      	Use an offscreen bitmap to draw the column title during column resizing
      	and column prelighting.
      a4b40782
  3. 18 Mar, 2000 2 commits
    • Darin Adler's avatar
      Fixed the "tall line of icons" bug. · 857e8fa2
      Darin Adler authored
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container.c:
      	Rewrote the routines to not have a separate concept of the
      	actual grid height and the allocated grid height. Most important
      	change was to update the first_free variables when resizing.
      
      	* src/file-manager/fm-directory-view-icons.h:
      	* src/file-manager/fm-directory-view-icons.c:
      	(fm_directory_view_icons_line_up_icons):
      	Removed the unused line_up_icons call. This feature will return,
      	but for now it's just a waste of space.
      857e8fa2
    • Darin Adler's avatar
      *** empty log message *** · 777a75ae
      Darin Adler authored
      777a75ae
  4. 17 Mar, 2000 9 commits
  5. 16 Mar, 2000 6 commits
    • Darin Adler's avatar
      Did some of the renamings that were queued in RENAMING. · 8efa4d71
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/gdk-extensions.c:
      	* libnautilus/gdk-extensions.h:
      	* libnautilus/nautilus-gdk-extensions.c:
      	* libnautilus/nautilus-gdk-extensions.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/nautilus-background.c:
      	* libnautilus/nautilus-icons-view-icon-item.c:
      	Renamed gdk-extensions to add the nautilus- prefix and changed
      	all includers.
      
      	* src/Makefile.am:
      	* src/explorer-location-bar.c:
      	* src/explorer-location-bar.h:
      	* src/nautilus-location-bar.c:
      	* src/nautilus-location-bar.h:
      	* src/ntl-window-msgs.c:
      	* src/ntl-window.c:
      	Renamed ExplorerLocationBar to NautilusLocationBar.
      
      	* src/Makefile.am:
      	* src/nautilus-bookmarklist.c:
      	* src/nautilus-bookmarklist.h:
      	* src/nautilus-bookmark-list.c:
      	* src/nautilus-bookmark-list.h:
      	* src/nautilus-bookmarks-window.c:
      	* src/nautilus-bookmarks-window.h:
      	* src/nautilus-window-menus.c:
      	Renamed NautilusBookmarklist to NautilusBookmarkList.
      
      	* RENAMING: Marked items done and added some new ones.
      
      	* nautilus-widgets/nautilus-preferences-item.c:
      	* nautilus-widgets/nautilus-preferences.c:
      	* nautilus-widgets/test-nautilus-widgets.c:
      	* libnautilus/nautilus-icon-factory.c:
      	* src/file-manager/fm-directory-view-icons.c:
      	* src/file-manager/fm-directory-view.c:
      	* src/file-manager/fm-icon-text-window.c:
      	Cleaned up the interface to NautilusPreferences a bit.
      8efa4d71
    • John Sullivan's avatar
      Fixes for a couple of preferences bugs. · 3ffd2251
      John Sullivan authored
      3ffd2251
    • John Sullivan's avatar
    • Darin Adler's avatar
      Fixed the CRITICALs that I recently introduced. Made sure our unrefs match · 908efb2d
      Darin Adler authored
      	* src/file-manager/fm-directory-view.c:
      	(disconnect_model_handlers), (stop_load): Fixed the CRITICALs that
      	I recently introduced. Made sure our unrefs match our refs for
      	monitor_files.
      908efb2d
    • John Sullivan's avatar
    • Darin Adler's avatar
      Tell people about the gnome-xml branch. · ee495dba
      Darin Adler authored
      	* HACKING: Tell people about the gnome-xml branch.
      
      	* libnautilus/Makefile.am:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c:
      	Broke out the grid code from the main container code.
      	This is a first step toward improving the layout code.
      
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	* src/fm-directory-view.c:
      	Got started on making the directory I/O async.
      	There's still a long way to go, this was a baby step.
      
      	* libnautilus/nautilus-bookmark.c:
      	* libnautilus/nautilus-bookmark.h:
      	* libnautilus/nautilus-self-checks.c:
      	General cleanup.
      
      	* libnautilus/nautilus-file.h:
      	Rearranged a little bit.
      
      	* libnautilus/nautilus-file-utilities.c:
      	Put FIXME in where there's code that needs to be changed.
      ee495dba
  6. 15 Mar, 2000 3 commits
    • John Sullivan's avatar
      Used preferences mechanism for text under icons and · 4df4c1e1
      John Sullivan authored
      open-in-new-window-when-clicked.
      4df4c1e1
    • Darin Adler's avatar
      A quick cleanup of how we use gnome-xml. · b84f3f1d
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/nautilus-xml-extensions.c:
      	* libnautilus/nautilus-xml-extensions.h:
      	Added some new gnome-xml helper functions.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_get_file_metadata_node):
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_get_keywords):
      	(nautilus_file_set_keywords):
      	* libnautilus/nautilus-icon-factory.c:
      	(get_child_node_by_property):
      	(get_themed_icon_file_path):
      	* src/nautilus-bookmarklist.c:
      	(nautilus_bookmarklist_load_file):
      	Changed to use the new helper functions.
      
      	* src/nautilus-bookmarklist.c:
      	(nautilus_bookmarklist_save_file): Changed direct uses of root to
      	use xmlDocGet/SetRootElement while I was editing the file.  I
      	think this is the same change Pavel made but wasn't able to check
      	in.
      
      	* src/nautilus-bookmarklist.c:
      	General cleanup.
      b84f3f1d
    • Darin Adler's avatar
      Added additional data to icons so they can specify where the · bdf3c6c1
      Darin Adler authored
      	embedded text fits in each icon.
      
      	* icons/eazel/Makefile.am, icons/eazel/i-regular.xml: Added the
      	file to specify attributes of icons. Specifically added the
      	attribute that says there is space for embedded text in the
      	Eazel-theme regular icon.
      
      	* libnautilus/nautilus-icon-factory.h:
      	* libnautilus/nautilus-icon-factory.c:
      	(get_child_node_by_property), (get_themed_icon_file_path),
      	(get_icon_file_path), (nautilus_icon_factory_get_thumbnail_uri),
      	(load_specific_image), (load_image_for_scaling),
      	(get_image_from_cache), (load_image_scale_if_necessary),
      	(nautilus_icon_factory_get_pixbuf_for_icon),
      	(nautilus_icon_factory_get_pixbuf_for_file):
      	Added code to read a rectangle for the embedded text along with
      	the icon, cache it with the icon, scale it with the icon, and
      	return it to the caller along with the icon.
      
      	* libnautilus/nautilus-icons-view-icon-item.c:
      	(nautilus_icons_view_icon_item_initialize_class),
      	(nautilus_icons_view_icon_item_set_arg),
      	(nautilus_icons_view_icon_item_get_arg),
      	(nautilus_icons_view_icon_item_get_image),
      	(nautilus_icons_view_icon_item_set_image),
      	(nautilus_art_irect_to_gdk_rectangle),
      	(draw_mini_text), (draw_embedded_text),
      	(nautilus_icons_view_icon_item_draw):
      	Changed the code that draws the embedded text to respect the
      	text rectangle passed in. Changed the pixbuf setting to use a
      	function instead of the arg interface and take a text rectangle
      	along with the pixbuf.
      
      	* libnautilus/gnome-icon-container-dnd.c
      	(gnome_icon_container_dnd_begin_drag):
      	* libnautilus/gnome-icon-container.c:
      	(icon_get_actual_size): Got rid of callers who were using the arg
      	interface to get at the image of an icon
      	("NautilusIconsViewIconItem::pixbuf").
      
      	* src/file-manager/fm-directory-view-icons.c:
      	(get_icon_property_cb): Get rid of hard-coded rule that only
      	themes with eazel at the front of their names can display text
      	inside the icons.
      
      	* libnautilus/gnome-icon-container.c:
      	(icon_new): Fixed a bug where icons would be super-tiny if they
      	got too big, like if you entered a directory that was zoomed all
      	the way in.
      	(start_stretching), (ungrab_stretch_icon), (end_stretching),
      	(gnome_icon_container_show_stretch_handles): Added code to grab
      	the pointer while stretching an icon.
      	(item_event_cb): Added a return statement that John forgot when
      	he was editing. Without that, it was falling through to the next
      	case, which had the same effect anyway.
      	(update_icon): Pass the text rectangle through from the icon
      	factory to the icon canvas item, using the new call instead of the
      	old arg interface approach.
      
      	* components/help/.cvsignore: Added entries for
      	.la and .lo files.
      
      	* components/help/Makefile.am:
      	* components/help/hyperbola-nav-index.c:
      	* components/help/hyperbola-nav-search.c:
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* src/nautilus-bookmarklist.c:
      	Fixed flags for gnome-xml
      	includes. Someone pointed out that you are supposed to include
      	these as "#include <tree.h>", not "#include <gnome-xml/tree.h>" so
      	I fixed our uses to work that way.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_get_file_metadata_node): Fixed code that was
      	destroying something allocated by gnome-xml with g_free instead
      	of xmlFree.
      
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_get_keywords), (nautilus_file_set_keywords):
      	Fixed storage leak where we were getting a property and not freeing it.
      
      	* libnautilus/nautilus-default-file-icon.h:
      	* libnautilus/nautilus-default-file-icon.c:
      	* libnautilus/nautilus-icon-factory.c:
      	(load_image_for_scaling): Got rid of the global that tells whether
      	the default icon has an alpha channel -- it's not hardwired TRUE.
      bdf3c6c1
  7. 14 Mar, 2000 7 commits
  8. 13 Mar, 2000 7 commits
    • Darin Adler's avatar
      Fixed bug that caused a core dump when getting at the root directory · ec73da24
      Darin Adler authored
      	* libnautilus/nautilus-directory.c (nautilus_directory_get):
      	Fixed bug that caused a core dump when getting at the root
      	directory because all the '/' characters were stripped off
      	the URI.
      
      	* /src/file-manager/fm-directory-view.c:
      	* nautilus-widgets/nautilus-preferences.c:
      	Tiny formatting fixes.
      ec73da24
    • Maciej Stachowiak's avatar
      Connect to zoom_in and zoom_out singals of zoom control and view the zoom · 3b40873a
      Maciej Stachowiak authored
      	* src/ntl-window.c (nautilus_window_constructed): Connect to
      	zoom_in and zoom_out singals of zoom control and view the zoom in
      	such cases, when applicable.
      
      	* src/nautilus-zoom-control.c
      	(nautilus_zoom_control_class_initialize): Add zoom_in and zoom_out
      	signals.
      	(nautilus_zoom_control_reset_zoom_level): Quick hack to get some
      	semblance of sanity in view switching.
      
      	* file-manager/fm-directory-view.c: Add Zoomable interface; for
      	now only implement zoom_in and zoom_out methods.
      3b40873a
    • Maciej Stachowiak's avatar
      Added some comments. · bfaf42ec
      Maciej Stachowiak authored
      	* components/sample/nautilus-sample-content-view.c: Added some
      	comments.
      bfaf42ec
    • Elliot Lee's avatar
      Fix pointer <-> int conversion warnings. · e88dbf7f
      Elliot Lee authored
      
      
      * nautilus-widgets/nautilus-preferences.c, src/file-manager/fm-directory-view.c:
      Fix pointer <-> int conversion warnings.
      e88dbf7f
    • Darin Adler's avatar
      A quick cleanup pass on the NautilusStringList class: Changed uses of · fe7c58d2
      Darin Adler authored
      	* libnautilus/nautilus-string-list.h:
      	* libnautilus/nautilus-string-list.c:
      	A quick cleanup pass on the NautilusStringList class:
      	Changed uses of gchar to char, changed g_assert to g_return_if_fail
      	as appropriate. Fixed brace style to be emacs-friendly (open brace
      	on same line as if statement). Fixed spelling of delimiter.
      	Got rid of some unnecessary special cases for NULL and sped up
      	the _equal function be eliminating the redundant length check.
      	Changed the self-check so that it doesn't write a warning to the
      	log when it runs.
      fe7c58d2
    • Darin Adler's avatar
      Andy fixed a double-unref bug by removing an unref. The correct fix was to · 945b7f5c
      Darin Adler authored
      	* src/file-manager/fm-properties-window.c (create_properties_window):
      	Andy fixed a double-unref bug by removing an unref. The correct
      	fix was to add a ref. I rolled out his change and re-fixed the bug.
      945b7f5c
    • Ramiro Estrugo's avatar
      libnautilus/nautilus-global-preferences.c, Add a table of meta view iids · e58c19a4
      Ramiro Estrugo authored
      * libnautilus/nautilus-global-preferences.c,
      * libnautilus/nautilus-global-preferences.h:
      (nautilus_global_preferences_get_meta_view_iids) Add a table of
      meta view iids and a function to retrieve them.  This is a hack
      until we have better runtime detection of components.
      Add some better defaults for which meta views are shown.  By
      default none were shown.  Undo a previous gnome_config default
      hack.  There is now a better fix in place in the prefs code.
      
      * nautilus-widgets/nautilus-preferences.c:
      (nautilus_preferences_make_gnome_config_string) A new function to
      make a string as expected by gnome_config with a trailing default
      value.  Use this string to fetch the value of the preferences.
      
      * src/Makefile.am,
      src/ntl-prefs.c,
      src/ntl-prefs.h,
      src/nautilus-window-menus.c,
      src/nautilus.h:
      Retire ntl-prefs.c and ntl-prefs.h.  Remove these 2 from build and
      all references to them.
      
      * src/ntl-app.c:
      (nautilus_app_startup, nautilus_app_destroy) No need to call
      retired ntl-prefs functions.
      
      * src/ntl-uri-map.c:
      (add_meta_view_iids_from_preferences): New function.  Factor out
      meta iid setup code into one place.  Replace the static meta iid
      setup code with something that looks in preferences to see which
      meta views are enabled.  Next step is to make the meta view
      respond to pref changes.
      e58c19a4