1. 06 Mar, 2001 8 commits
    • Jiri (George) Lebl's avatar
      Darin <darin@eazel.com> said that while this patch causes fungal growth · d0ad9778
      Jiri (George) Lebl authored
      Tue Mar 06 12:24:24 2001  George Lebl <jirka@5z.com>
      
      	Darin <darin@eazel.com> said that while this patch causes fungal
      	growth between the toes, it is ok to apply.
      
      	* components/tree/nautilus-tree-view-dnd.c (do_get_data)
      	  (nautilus_tree_view_drag_drop)
      	  (nautilus_tree_view_ensure_drag_data)
      	  libnautilus-extensions/nautilus-icon-dnd.c (do_get_data)
      	  (nautilus_icon_container_ensure_drag_data)
      	  (drag_drop_callback)
      	  libnautilus-extensions/nautilus-list.c (do_get_data)
      	  (nautilus_list_ensure_drag_data)
      	  (nautilus_list_drag_drop):
      	  When doing gtk_drag_get_data, first find a target we support rather
      	  then just grabbing the first one.  We need to make a target list
      	  and do some gtk voodoo.  At some later date, this should be more
      	  generalized and stuffed somewhere in libnautilus-extentions.
      	  Fixes #7312
      
      	* libnautilus-extensions/nautilus-file-operations.c
      	  (parse_previous_duplicate_name):  s/strdup/g_strdup/ as the
      	  string will be later g_free'd
      	  Fixes #7440
      d0ad9778
    • Eric Fischer's avatar
      reviewed by: Christian Meyer <chrisime@gnome.org> · f590eb52
      Eric Fischer authored
      2001-03-06  Eric Fischer  <eric@eazel.com>
      
              reviewed by: Christian Meyer <chrisime@gnome.org>
      
              (Bug 7315.  Thanks to Christian Meyer for tracking down
              places where this needed to be fixed.)
      
              * components/help/converters/gnome-db2html2/Makefile.am:
              * components/help/converters/gnome-info2html2/Makefile.am:
              * cut-n-paste-code/widgets/e-paned/Makefile.am:
              * cut-n-paste-code/widgets/gimphwrapbox/Makefile.am:
              * cut-n-paste-code/widgets/nautilusclist/Makefile.am:
              * libnautilus-extensions/Makefile.am:
              In all of these, change GNOME_CFLAGS to GNOMEUI_CFLAGS so that
              they get the correct #include path for the GTK headers.
      f590eb52
    • Mike Engber's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 27a5f817
      Mike Engber authored
      
      	reviewed by: Darin Adler <darin@eazel.com>
      
      	* libnautilus-extensions/nautilus-bonobo-extensions.h:
      	Added NAUTILUS_BONOBO_X_BOILERPLATE.
      
      	* libnautilus-extensions/nautilus-directory-metafile-monitor.c:
      	(nautilus_metafile_monitor_class_init),
      	(nautilus_metafile_monitor_init):
      	* libnautilus-extensions/nautilus-directory-metafile-monitor.h:
      	* libnautilus-extensions/nautilus-metafile-factory.c:
      	(nautilus_metafile_factory_class_init),
      	(nautilus_metafile_factory_init):
      	* libnautilus-extensions/nautilus-metafile-factory.h:
      	* libnautilus-extensions/nautilus-metafile.c:
      	(nautilus_metafile_class_init), (nautilus_metafile_init):
      	* libnautilus-extensions/nautilus-metafile.h:
      	Switched NautilusMetafile, MetafileMonitor, and Metafile factory
      	to be based on BonoboXObject - this causes our corba object to
      	get freed properly - bug 7335.
      27a5f817
    • Pavel Cisler's avatar
      reviewed by: Ramiro Estrugo <ramiro@eazel.com> · 53ac3b8f
      Pavel Cisler authored
      2001-03-05  Pavel Cisler  <pavel@eazel.com>
      
      	reviewed by: Ramiro Estrugo  <ramiro@eazel.com>
      
      	Fix 7404: Clicking on "Install" in Eazel services fails.
      
      	* libnautilus-extensions/nautilus-font-manager.c:
      	(gnome_vfs_init_if_needed), (nautilus_font_manager_for_each_font),
      	(nautilus_font_manager_file_is_scalable_font):
      	Add lazy GnomeVFS initialization because the nautilus font manager
      	code now makes GnomeVFS calls.
      53ac3b8f
    • Rebecca Schulman's avatar
      Complete work for 5520, that cron should be running for medusa to work. · da53a4a2
      Rebecca Schulman authored
      2001-03-05  Rebecca Schulman  <rebecka@eazel.com>
      	Complete work for 5520, that cron should be running
      	for medusa to work.
      
      	reviewed by: <delete if not using a buddy>
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_use_fast_search_changed_callback):
      	Change the text to Vera's final copy.
      	* src/nautilus-first-time-druid.c: (druid_finished),
      	(back_update_page_callback), (set_up_medusa_page),
      	(next_medusa_page_callback), (set_up_cron_information_page),
      	(nautilus_first_time_druid_show):
      	Change the text to Vera's final copies, make medusa update
      	correctly when medusa is turned on in the first time druid
      da53a4a2
    • Arik Devens's avatar
    • Ramiro Estrugo's avatar
      reviewed by: John Harper <jsh@eazel.com> · 9c83efe5
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-font-picker.c:
      	More black listed fonts.  Fixes bug 7384.
      9c83efe5
    • Rebecca Schulman's avatar
      Complete most of bug 5520, that turning medusa on when cron isn't running · 87d6d540
      Rebecca Schulman authored
      2001-03-03  Rebecca Schulman  <rebecka@eazel.com>
      	Complete most of bug 5520, that turning medusa on when cron
      	isn't running should tell the user this, and, if possible,
      	how to start cron.
      
      	reviewed by: Mike Engber <engber@eazel.com>
      
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_use_fast_search_changed_callback):
      	Add dialog that comes up if the fast search preference is
      	enabled in the preference dialog when cron is off.
      	The dialog will tell the user about cron and how to
      	turn it on on linux systems.
      
      	* libnautilus-extensions/nautilus-medusa-support.c:
      	(nautilus_medusa_add_system_state_changed_callback),
      	(nautilus_medusa_check_cron_is_enabled):
      	* libnautilus-extensions/nautilus-medusa-support.h:
      	Add hack to check if cron is actually running using cron.
      	* acconfig.h:
      	* configure.in:
      	Add HAVE_PROC_PROCESS_FILES, so we know whether we can
      	check proc files for whether cron is running
      
      	* src/nautilus-first-time-druid.c: (back_update_page_callback),
      	(set_up_medusa_page), (next_medusa_page_callback),
      	(set_up_cron_information_page), (nautilus_first_time_druid_show):
      	Add cron interface to the first time druid that tells users how to
      	turn on cron if necessary, as per Arlo's design.
      	Final text still needs to be added here.
      
      
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	(application_can_handle_uri),
      	(nautilus_mime_has_any_applications_for_file),
      	(nautilus_mime_has_any_applications_for_file_type):
      	* libnautilus-extensions/nautilus-mime-actions.h:
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(choose_application_callback), (application_cannot_open_location):
      	Old change that never got committed, reviewed by Darin Adler
      	<darin@eazel.com>
      87d6d540
  2. 05 Mar, 2001 8 commits
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 27595df3
      John Sullivan authored
      	Fixed bug 7348 (duplicate styles in some fonts)
      
      	* libnautilus-extensions/nautilus-font-picker.c:
      	(font_style_entry_free): New function (extracted from
      	global_font_list_free).
      	(global_font_list_free): Use extracted function.
      	(list_contains_style): New function, looks for matching
      	font_file_name.
      	(global_font_list_populate_callback): free style rather
      	than appending to list if an equivalent is already in list.
      27595df3
    • Ramiro Estrugo's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 7799503c
      Ramiro Estrugo authored
      	Fix for bugs 7375 and 7370.
      
      	* libnautilus-extensions/nautilus-font-manager.c:
      	(font_ignore_directory): Black list the ISO8859-2 and ISO8859-7
      	encoded fonts which it turns out are missing all kinds of glyphs.
      	Also add another instance of the same Abisource fonts, but from an
      	older package that had a slightly different name.
      
      	* libnautilus-extensions/nautilus-font-picker.c:
      	Black list the Bookmark URW font which causes crashes on old
      	version of the urw package.
      7799503c
    • Darin Adler's avatar
      reviewed & checked in by: Darin Adler <darin@eazel.com> · f4cb6901
      Darin Adler authored
              Fix bug 7389 (crash when starting nautilus):
      
              * libnautilus-extensions/nautilus-directory-background.c
              (nautilus_background_get_desktop_background_window): check if
              the `icon_container' object data (a GtkLayout widget) is
              non-null before dereferencing it
      
              (image_loading_done_callback): only pass result of
              nautilus_background_get_desktop_background_window to
              gdk_window_set_back_pixmap if it's non-null
      f4cb6901
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · be4780c0
      Darin Adler authored
      	Fix bug 7381 (warning every time I start Nautilus because my
      	/usr/share/fonts/default/Type1/fonts.dir has no fonts in it):
      
      	* libnautilus-extensions/nautilus-font-manager.c:
      	(font_description_table_new): Tolerate files with 0 fonts in them,
      	but don't tolerate files where the count is > than the number of
      	lines in the file.
      
      	Fix bug 7362 (two font menus appear in preferences in non-smooth
      	mode):
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(appearance_pane_update): Fix spelling error.
      	(global_preferences_create_font_group): Fix wrong variable name
      	and spelling error.
      
      	* libnautilus-extensions/nautilus-string-list.c:
      	Fix spelling error ("supress" -> "suppress").
      be4780c0
    • Ramiro Estrugo's avatar
      reviewed by: Maciej Stachowiak <mjs@eazel.com> · 7d897765
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-font-manager.c:
      	(nautilus_self_check_font_manager):
      	Comment out the font manager checks out again!  Tinderbox wins
      	this round, but ill be back with a fix for bug 7343 and fix the
      	problem properly once and for all.
      7d897765
    • Ramiro Estrugo's avatar
      reviewed by: Glynn Foster <glynn.foster@ireland.sun.com> · 81e1c12d
      Ramiro Estrugo authored
      	No significant code changes.  Just adding bug numbers to FIXMEs.
      	The only real code change (which happens to be a commenting out of
      	something) is a workaround for a tinderbox problem.
      
      	* libnautilus-extensions/nautilus-font-factory.c:
      	(nautilus_font_factory_get_font_by_family):
      	Bug number for FIXME.
      
      	* libnautilus-extensions/nautilus-font-manager.c:
      	(nautilus_font_manager_get_default_font),
      	(nautilus_font_manager_get_default_bold_font):
      	Bug number for FIXME.
      	Comment out the SOURCE_DATADIR font hack until it works better.
      	Fixes broken tinderbox checks.  Checks will still run even if not
      	with the optimal setup.  I have an idea how to fix this later
      	using a configure.in hack.  Added FIXME and bug number for this
      	issue.
      
      	* libnautilus-extensions/nautilus-glyph.c:
      	(nautilus_glyph_draw_to_pixbuf):
      	Bug number for FIXME.
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	Bug number for FIXME and reworked FIXME blurb to match bug report.
      
      	(nautilus_icon_container_initialize):
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(nautilus_scalable_font_get_default_font),
      	(nautilus_scalable_font_get_default_bold_font):
      	Bug number for FIXMEs.
      81e1c12d
    • Ramiro Estrugo's avatar
      reviewed by: Maciej Stachowiak <mjs@eazel.com> · 750d1005
      Ramiro Estrugo authored
      	Fix bug 5813 - Remove workaround for bug 5712 when both GTK+ 1.2.9
      	and the new gdk-pixbuf are released and required by configure.in
      	and RPM spec file
      
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdk-pixbuf-drawable.c:
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdk-pixbuf-private.h:
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdkimage.c:
      	Retire these workaround cut n pasted code.
      
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	(nautilus_gdk_pixbuf_get_from_window_safe):
      	Remove the workaround, we can safely call the gdk and gdk-pixbuf
      	calls now that bugs in there have been fixed.
      750d1005
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 24faaf92
      Ramiro Estrugo authored
      		      Maciej Stachowiak  <mjs@eazel.com>
      
      		      Bugs:
      
      		      6368 - Multibyte font handling in non smooth mode.
      		      2673 - Need to hook up the new font picker to nautilus
      		      1274 - Add support for picking a custom font
      
      		      * components/history/Makefile.am:
      		      * components/history/nautilus-history-view.c: (main):
      		      Initialize gettext for the history component so it can display
      		      localized strings.
      
      		      * components/notes/nautilus-notes.c: (make_notes_view):
      		      Set the notes widget font from preferences so it can be properly
      		      localized.
      
      		      * components/text/nautilus-text-view.c:
      		      (nautilus_text_view_set_font):
      		      Use the localized font name to make this work in locales other
      		      than the default.
      
      		      * libnautilus-extensions/Makefile.am:
      		      Add a macro for finding data on the source tree for the situation
      		      when 'make install' has not be run.
      
      		      * libnautilus-extensions/nautilus-font-factory.c:
      		      (nautilus_font_factory_get_font_by_family): Workaround the problem
      		      that fully qualified localized fonts were being processed
      		      incorrectly.  We simply leave them alone now.
      		      (nautilus_font_factory_get_font_from_preferences): Use the
      		      localized font string to make this work on more locales.
      
      		      * libnautilus-extensions/nautilus-font-manager.h:
      		      * libnautilus-extensions/nautilus-font-manager.c:
      		      (font_description_table_find): New function to find a description
      		      in a table.
      		      (font_description_table_for_each): Change the return value to a
      		      boolean to indicate whether to stop the iteration or not.  Switch
      		      the order of an assert and assigned.
      		      (collect_fonts_from_directory): Use macros for the mime type
      		      strings.
      		      (font_ignore_directory): Add more directories to ignore.
      		      (font_manager_collect_font_tables): Change prepend to append to
      		      get fonts in a better order (fallback and user fonts first)
      		      , (font_table_list_find),
      		      (free_font_tables), (ensure_global_font_table),
      		      (nautilus_font_manager_for_each_font): Use just one global table
      		      for all fonts instead of 3.
      		      (nautilus_font_manager_get_default_font): Compute the default
      		      dynamically to take user choices into account.  Make it work on
      		      non installed nautilus builds.
      		      (nautilus_font_manager_get_default_bold_font): Same as above for a
      		      bold font.
      		      (nautilus_font_manager_file_is_scalable_font): New function to
      		      check that a file is really a scalable font:
      		      (font_list_find_bold_callback), (nautilus_font_manager_get_bold),
      		      (nautilus_font_manager_weight_is_bold): New functions to find a
      		      bold font in the global tables.
      		      (nautilus_self_check_font_manager): Make it work on not installed
      		      nautilus builds and remove the hack where checks would on run for
      		      the "ramiro" user.
      
      		      * libnautilus-extensions/nautilus-font-picker.c:
      		      (nautilus_font_picker_initialize), (font_list_find),
      		      (font_picker_update_styles), (font_picker_populate),
      		      (font_picker_font_changed_callback),
      		      (font_picker_style_changed_callback), (font_find_style),
      		      (ignore_font), (font_make_name), (font_make_style),
      		      (global_font_list_free), (font_list_count_families),
      		      (global_font_list_get), (global_font_list_populate_callback),
      		      (nautilus_font_picker_get_selected_font),
      		      (nautilus_font_picker_set_selected_font):
      		      Make the font list global and not per widget instance.  Use better
      		      labels for the font styles.  Use better labels for font names
      		      (foundry and family vs just family depending on how many families
      		      of the same font are found)
      
      		      * libnautilus-extensions/nautilus-global-preferences.h:
      		      * libnautilus-extensions/nautilus-global-preferences.c:
      		      (global_preferences_install_font_defaults): Add new smooth font
      		      preference for the icon container.
      		      (nautilus_global_preferences_get_smooth_font): New function to
      		      safely get a smooth font out of preferences.
      
      		      * libnautilus-extensions/nautilus-icon-container.c:
      		      (nautilus_icon_container_initialize): Use the localized version of
      		      the font strings and add a FIXME for the problem of checking these
      		      in many disparate places in nautilus.
      
      		      * libnautilus-extensions/nautilus-program-chooser.c:
      		      (program_file_pair_get_program_name_for_display): Use the
      		      localized version of the application name strings.
      
      		      * libnautilus-extensions/nautilus-scalable-font.h:
      		      * libnautilus-extensions/nautilus-scalable-font.c:
      		      (nautilus_scalable_font_initialize_class),
      		      (nautilus_scalable_font_initialize),
      		      (nautilus_scalable_font_destroy), (nautilus_scalable_font_new),
      		      (nautilus_scalable_font_make_bold),
      		      (nautilus_scalable_font_get_default_font),
      		      (nautilus_scalable_font_get_default_bold_font),
      		      (free_global_font_handle_table),
      		      (initialize_global_stuff_if_needed),
      		      (nautilus_scalable_font_get_rsvg_handle):
      		      Simplify this class a lot by using the font manager.  No longer
      		      need to manage font lookup and queries.
      
      		      * libnautilus-extensions/nautilus-smooth-text-layout-cache.c:
      		      (nautilus_self_check_smooth_text_layout_cache): Fix a comment.
      		      Dont hardcode the font family.  Use the default font.  Remove the
      		      #ifdef hacker for "before make install fonts broken" problem which
      		      is now fixed.
      
      		      * src/file-manager/fm-directory-view.h:
      		      * src/file-manager/fm-directory-view.c:
      		      (directory_view_smooth_font_changed_callback),
      		      (fm_directory_view_initialize), (fm_directory_view_destroy):
      		      Add method for responding to changes in the smooth font for AA
      		      mode of the icon container.
      
      		      * src/file-manager/fm-icon-view.c:
      		      (fm_icon_view_smooth_font_changed),
      		      (fm_icon_view_initialize_class),
      		      (fm_icon_view_update_icon_container_smooth_font),
      		      (create_icon_container):
      		      Add support for responding to change in the smooth font.  Update
      		      the icon container's smooth font on such changes.
      
      		      * src/nautilus-about.c: (nautilus_about_draw_info):
      		      Change the offset of the "Nautilus" title which broken when jsh
      		      make glyphs render properly taking the baseline into account.
      
      		      * src/nautilus-sidebar-title.c: (update_font):
      		      Use the localized font name.
      
      		      * src/nautilus-sidebar.c: (nautilus_sidebar_add_panel),
      		      (nautilus_sidebar_remove_panel):
      		      Use the localized sidebar tabs descriptions.
      
      		      * src/nautilus-window.c: (create_view_as_menu_item):
      		      Use the localized "View as" labels.
      
      		      * test/test-nautilus-font-manager.c: (font_iterator_callback):
      		      * test/test-nautilus-font-picker.c: (update_font),
      		      (font_changed_update_label_callback),
      		      (font_changed_update_file_name_callback),
      		      (use_defalt_font_callback), (use_defalt_bold_font_callback),
      		      (use_defalt_font_update_picker_callback),
      		      (use_defalt_bold_font_update_picker_callback), (main):
      		      * test/test.c: (test_quit):
      		      Updates for changes in font manager and font picker.
      24faaf92
  3. 04 Mar, 2001 1 commit
    • Pavel Cisler's avatar
      reviewed by: Darin Adler <darin@eazel.com> · b696fe22
      Pavel Cisler authored
      2001-03-04  Pavel Cisler <pavel@eazel.com>
      
      	reviewed by: Darin Adler  <darin@eazel.com>
      
      	* libnautilus-extensions/nautilus-preferences.c:
      	(preferences_key_make_for_visibility):
      
      	Fix a leak by adding a missing g_free.
      b696fe22
  4. 03 Mar, 2001 8 commits
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 5d984881
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-font-manager.c:
      	(nautilus_font_manager_get_fallback_font):
      	Add workaround for tinderbox lack of 'make install' problem.  Ill
      	fix this better tommorow.
      5d984881
    • Seth Nickell's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 78ab9bcb
      Seth Nickell authored
      2001-03-02  Seth Nickell  <seth@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      
      	Add UFS detection code to make Trash work on Solaris. Basically
      	a cut and paste of the equivalent ReiserFS code added earlier.
      78ab9bcb
    • Pavel Cisler's avatar
      reviewed by: Gene Z. Ragan <gzr@eazel.com> · 5aaf005c
      Pavel Cisler authored
      2001-03-02  Pavel Cisler  <pavel@eazel.com>
      
      	reviewed by: Gene Z. Ragan <gzr@eazel.com>
      
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	Turn off spew about unknown file systems.
      5aaf005c
    • Ramiro Estrugo's avatar
      reviewed by: <delete if not using a buddy> · a5eedddc
      Ramiro Estrugo authored
      2001-03-02  Ramiro Estrugo  <ramiro@eazel.com>
      
      	    reviewed by: <delete if not using a buddy>
      
      	    Bug 2673 - Need to hook up the new font picker to nautilus .
      
      	    * configure.in:
      	    Remove an old font setup hack that never really worked.
      
      	    * data/fonts/urw/fonts.dir:
      	    Rename the fonts to "Helvetica Default" in order not to clash with
      	    system fonts.
      
      	    * libnautilus-extensions/nautilus-font-manager.h:
      	    * libnautilus-extensions/nautilus-font-manager.c:
      	    (font_description_new): Add a font type parameter.
      	    (font_lists_total_num_fonts): New function to count the total
      	    number of scalable fonts detetected.
      	    (font_description_table_add): Pass in the detected font lists to
      	    do reality checks.
      	    (font_get_font_type): New function.
      	    (font_description_table_get_length),
      	    (font_description_table_peek_nth),
      	    (font_description_table_get_nth_file_name): Name the parameters
      	    more consistently.
      	    (font_description_table_for_each): Add font type parameter
      	    (font_description_table_new): Rework to not require storing the
      	    detected font list.  We now use that only for the duration of the
      	    constructor.  Lost the install_font_lists dumbness.
      	    (font_server_for_each_font_directory_internal): Use g_warning
      	    instead of g_print.
      	    (font_ignore_directory): New function to determine whether we
      	    should ignore a directory - makes things much faster.
      	    (font_manager_collect_font_tables): New function to handle all the
      	    work of collecting font directories into tables.
      	    (font_server_for_each_callback), (font_table_list_free),
      	    (font_table_list_for_each), (free_font_tables),
      	    (ensure_at_exit_handler), (ensure_fallback_font_table),
      	    (ensure_user_font_table), (ensure_system_font_tables): Add 3
      	    tables for fallback, system and users fonts.  These are populated
      	    as needed.
      	    (nautilus_font_manager_for_each_font): Iterate the 3 font talbles.
      	    (nautilus_font_manager_get_fallback_font) : New function to obtain
      	    a fallback font quickly without having to check the system.
      	    (call_chop_off_comments), (nautilus_self_check_font_manager):
      	    Rework the checks to not create a temp directory.  Unfortunately
      	    they now only run for me.
      
      	    * libnautilus-extensions/nautilus-font-picker.h:
      	    * libnautilus-extensions/nautilus-font-picker.c:
      	    (nautilus_font_picker_initialize_class),
      	    (nautilus_font_picker_initialize), (nautilus_font_picker_destroy),
      	    (font_entry_list_find), (font_picker_update),
      	    (font_name_picker_changed_callback),
      	    (style_picker_changed_callback), (ignore_font),
      	    (font_manager_callback), (style_list_for_each_callback),
      	    (font_entry_list_for_each_callback),
      	    (nautilus_font_picker_get_selected_font),
      	    (nautilus_font_picker_set_selected_font),
      	    (nautilus_font_picker_set_title_label):
      	    Use the new font manager.
      
      	    * libnautilus-extensions/nautilus-global-preferences.h:
      	    * libnautilus-extensions/nautilus-global-preferences.c:
      	    (global_preferences_install_descriptions),
      	    (global_preferences_install_defaults),
      	    (global_preferences_create_dialog), (appearnace_pane_update),
      	    (global_preferences_create_font_group),
      	    (global_preferences_install_home_location_defaults),
      	    (global_preferences_install_font_defaults):
      	    Add a new preference for the smooth font.
      	    Factor our the default font code to its own function.  Setup the
      	    font pickers items to be mutually exclusive according to the
      	    smooth graphics mode preference value.
      
      	    * libnautilus-extensions/nautilus-gtk-extensions.h:
      	    * libnautilus-extensions/nautilus-gtk-extensions.c:
      	    (nautilus_gtk_widget_set_shown):
      	    New function to show or hide a widget in one go.
      
      	    * libnautilus-extensions/nautilus-preferences-group.c:
      	    (nautilus_preferences_group_update):
      	    Dont show the widget if a controlling preference prevents it.
      
      	    * libnautilus-extensions/nautilus-preferences-item.h:
      	    * libnautilus-extensions/nautilus-preferences-item.c:
      	    (preferences_item_update_smooth_font),
      	    (preferences_smooth_font_changed_callback),
      	    (preferences_item_create_smooth_font): Add support for a smooth
      	    font picker.
      	    (preferences_item_destroy), (preferences_item_construct),
      	    (nautilus_preferences_item_set_control_preference),
      	    (nautilus_preferences_item_set_control_action),
      	    (nautilus_preferences_item_get_control_showing): Add support for
      	    using a controlling preference which can force the widget to be
      	    shown or hidden depending on its value.
      
      	    * libnautilus-extensions/nautilus-preferences-pane.c:
      	    (nautilus_preferences_pane_update):
      	    Use new gtk extension to show or hide the widget in one go.
      
      	    * libnautilus-extensions/nautilus-scalable-font.h:
      	    * libnautilus-extensions/nautilus-scalable-font.c:
      	    (font_family_string_map_new): Update fallback font name.
      	    (nautilus_scalable_font_new_from_file_name): New function to
      	    create a font directly from a font file name.
      	    (nautilus_scalable_font_get_default_font): Update fallback font name.
      	    (nautilus_scalable_font_get_default_bold_font): New function to
      	    get a fallback bold font.
      	    Remove some unsed functions.  Remove the font setup hack, the font
      	    manager takes care of that now.
      
      	    * libnautilus-extensions/nautilus-string-picker.h:
      	    * libnautilus-extensions/nautilus-string-picker.c:
      	    (nautilus_string_picker_clear):
      	    New function to clear the string picker.
      
      	    * libnautilus-extensions/nautilus-tabs.c:
      	    (nautilus_tabs_initialize):
      	    Fix the hard coded font name.
      
      	    * src/nautilus-first-time-druid.c: (new_title_label):
      	    Fix the hard coded font name.
      
      	    * src/nautilus-sidebar-tabs.c:
      	    (nautilus_sidebar_tabs_load_theme_data):
      	    Fix the hard coded font name.
      
      	    * test/Makefile.am:
      	    * test/test-nautilus-font-manager.c: (font_type_to_string),
      	    (font_iterator_callback), (font_table_for_each_callback), (main):
      	    * test/test-nautilus-font-picker.c: (font_picker_changed_callback),
      	    (main):
      	    * test/test-nautilus-glyph-simple.c: (main):
      	    * test/test-nautilus-label.c: (main):
      	    Update for new font picker and font manager changes.
      a5eedddc
    • John Harper's avatar
      disabled self check for now, since it won't work without make install · 2f9e30c0
      John Harper authored
      2001-03-02  John Harper  <jsh@eazel.com>
      
      	* libnautilus-extensions/nautilus-smooth-text-layout-cache.c:
      	disabled self check for now, since it won't work without make
      	install having been run
      2f9e30c0
    • Pavel Cisler's avatar
      Fix 7225 (emblem sorting locks up entire system for extended period of · 27d84092
      Pavel Cisler authored
      2001-03-02  Pavel Cisler  <pavel@eazel.com>
      
      	Fix 7225 (emblem sorting locks up entire system for extended
      		  period of time)
      
      	reviewed by: Darin Adler  <darin@eazel.com>
      
      	* libnautilus-extensions/nautilus-file-private.h:
      	* libnautilus-extensions/nautilus-file.c:
      	(fill_emblem_cache_if_needed), (compare_by_emblems):
      	Implement a simple cache for automatic and keyword emblems.
      
      	* libnautilus-extensions/nautilus-file.c:
      	(destroy), (nautilus_file_set_keywords),
      	(nautilus_file_emit_changed):
      	Nuke the cache when keywords change.
      27d84092
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 04eb5b85
      Gene Z. Ragan authored
      2001-03-02  Gene Z. Ragan  <gzr@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	Fixed bug 558, Items don't show up in trash: when dropped.
      
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	* libnautilus-extensions/nautilus-volume-monitor.h:
      	Added detection for ReiserFS.  ReiserFS is now a
      	supported type for the trash folder creation and
      	detection code.
      04eb5b85
    • Ian McKellar's avatar
      Added launchers to the congratulations page. This fixes 5513. · e07c3788
      Ian McKellar authored
      	* components/services/install-view/callbacks.c:
      	(nautilus_service_install_done):
      	* components/services/install-view/nautilus-service-install-view.c:
      	(nautilus_install_service_describe_menu_entry), (describe_dentry),
      	(drag_data_get), (drag_data_delete), (launcher_clicked_callback),
      	(make_dragable_icon_well),
      	(nautilus_install_service_add_menu_launchers):
      	* components/services/install-view/nautilus-service-install-view.h:
      	Added launchers to the congratulations page.
      	This fixes 5513.
      
      	* components/services/inventory/eazel-inventory-utils.c:
      	(eazel_inventory_clear_md5):
      	Fixed a crasher in the inventory upload.
      
      	* libnautilus-extensions/nautilus-clickable-image.c:
      	(ancestor_button_release_event):
      	Fixed NautilusClickableImage so that it doesn't generate click events
      	when you d-n-d from it.
      e07c3788
  5. 02 Mar, 2001 4 commits
    • John Harper's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 6ab518bc
      John Harper authored
      2001-03-02  John Harper  <jsh@eazel.com>
      
      	reviewed by: Darin Adler  <darin@eazel.com>
      
      	Work to cache smooth-text-layout objects. This increases the
      	speed of aa rendering so that there's no noticeable difference
      	when compared with non-aa mode (e.g. when dragging windows over
      	the top of the nautilus window)
      
      	* libnautilus-extensions/nautilus-smooth-text-layout-cache.c,
      	libnautilus-extensions/nautilus-smooth-text-layout-cache.h: new
      	class, a cache for the NautilusSmoothTextLayout objects
      
      	* libnautilus-extensions/nautilus-icon-canvas-item.c
      	(nautilus_icon_canvas_item_initialize_class): allocate a
      	NautilusSmoothTextLayoutCache for all canvas items. It will be
      	freed on program exit
      
      	(draw_or_measure_label_text_aa): use the layout cache when
      	rendering text
      
      	* libnautilus-extensions/Makefile.am: added layout cache files
      
      	* libnautilus-extensions/nautilus-glyph.c,
      	libnautilus-extensions/nautilus-glyph.c,
      	libnautilus-extensions/nautilus-smooth-text-layout.c,
      	libnautilus-extensions/nautilus-smooth-text-layout.c
      	(nautilus_glyph_compare, nautilus_smooth_text_layout_compare):
      	new functions, only defined when NAUTILUS_OMIT_SELF_CHECK isn't
      	#define'd. Used by the cache's self test code
      
      	* libnautilus-extensions/nautilus-lib-self-check-functions.h:
      	added nautilus_self_check_smooth_text_layout_cache to the list
      6ab518bc
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 7541ffd3
      Darin Adler authored
      	Fixed bug 7156 (Opening multiple folders with tree view on causes
      	timed wait dialogs for all but the first (folders never open)):
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(async_job_start), (async_job_end): Added some debug code (turned
      	off).
      	(dequeue_pending_idle_callback): Fix problem where in the cancel
      	case we did not do a nautilus_directory_async_state_changed. This
      	didn't actually cause the bug.
      	(nautilus_directory_stop_monitoring_file_list): The actual bug
      	fix. Use the correct cancel function here. The old one didn't do
      	all the cancelling work.
      	(cancel_loading_attributes),
      	(nautilus_directory_cancel_loading_file_attributes): Two more
      	cases where we needed a call to
      	nautilus_directory_async_state_changed. These didn't actually
      	cause the bug.
      7541ffd3
    • Ramiro Estrugo's avatar
      reviewed by: Eskil Heinous Olsen <eskil@eazel.com> · c82b8217
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-string-list.h:
      	* libnautilus-extensions/nautilus-string-list.c:
      	(nautilus_string_list_nth_as_integer),
      	(nautilus_self_check_string_list):
      	New function to get the nth string as an integer - and checks.
      
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/nautilus-font-manager.h:
      	* libnautilus-extensions/nautilus-font-manager.c:
      	* libnautilus-extensions/nautilus-lib-self-check-functions.h:
      	New files.  Support for collecting information about the scalable
      	fonts installed on the system.  Parts written by Pavel Cisler.
      
      	* components/text/nautilus-text-view.c:
      	(nautilus_text_view_initialize):
      	Mark a string for translation.
      
      	* libnautilus-extensions/nautilus-font-factory.c:
      	(nautilus_font_factory_get_font_by_family):
      	Take fontsets into account.  Patch submitted by
      	eungkyu@sparcs.kaist.ac.kr.
      
      	* libnautilus-extensions/nautilus-preferences-item.h:
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	(nautilus_preferences_item_initialize_class),
      	(nautilus_preferences_item_initialize), (preferences_item_destroy),
      	(preferences_item_construct), (preferences_item_update_enum),
      	(preferences_item_create_enum),
      	(preferences_item_update_short_enum),
      	(preferences_item_create_short_enum),
      	(preferences_item_update_boolean),
      	(preferences_item_create_boolean),
      	(preferences_item_update_editable_string),
      	(preferences_item_create_editable_string),
      	(preferences_item_update_integer),
      	(preferences_item_create_integer),
      	(preferences_item_update_font_family),
      	(preferences_item_create_font_family),
      	(nautilus_preferences_item_new),
      	(enum_radio_group_changed_callback),
      	(nautilus_preferences_item_update_displayed_value),
      	(update_text_settings_at_idle):
      	Clean this up a bit.  Follow nautilus coding conventions more.
      	Remove long unused theme picker.
      	Remove unused GtkArg stuff.
      
      	* libnautilus-extensions/nautilus-preferences-pane.c:
      	(nautilus_preferences_pane_new):
      	* libnautilus-extensions/nautilus-preferences-pane.h:
      	Remove unused pane description.
      
      	* libnautilus-extensions/nautilus-preferences-box.c:
      	(nautilus_preferences_box_add_pane):
      	* libnautilus-extensions/nautilus-preferences-box.h:
      	Remove unused pane description.
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_install_defaults): Mark font name for
      	translation.
      	(global_preferences_create_dialog),
      	(global_preferences_create_search_pane): Remove unused pane
      	description.
      
      	* test/.cvsignore:
      	* test/Makefile.am:
      	* test/test-nautilus-glyph-simple.c: (main):
      	* test/test-nautilus-glyph.c: (main):
      	* test/test-nautilus-labeled-image.c: (main):
      	* test/test-nautilus-smooth-text-layout.c: (main):
      	* test/test-nautilus-font-manager.c: (main):
      	* test/test.c: (test_quit):
      	* test/test.h:
      	Some minor changes.  New test for font manager.
      c82b8217
    • Rebecca Schulman's avatar
      Some leak checks that showed up on the top of the leak checker profile. · bccdd692
      Rebecca Schulman authored
      2001-03-01  Rebecca Schulman  <rebecka@eazel.com>
      	Some leak checks that showed up on the top of the
      	leak checker profile. (bugzilla.eazel.com 7253)
      	These changes reduce leakage in a short session
      	by 100,000 bytes
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-preferences.c:
      	(nautilus_preferences_get_user_level):
      	Remove leak of a string every time we checked user level
      	* libnautilus-extensions/nautilus-smooth-text-layout.c:
      	(nautilus_smooth_text_layout_destroy),
      	(smooth_text_layout_clear_lines):
      	Remove a leak of the text and some other characters every time
      	we created and used a text layout object, which was about 6000
      	times for a short run for me
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	Stop strdup'ing a string where we would have leaked the original.
      bccdd692
  6. 01 Mar, 2001 7 commits
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · d54e684f
      John Sullivan authored
      	Fixed bug 7164 (infinite redrawing in particular layout case)
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(lay_down_icons_horizontal): Fixed the math for determining
      	whether the current icon fits on the current row; added a
      	FIXME about a questionable design choice.
      	(size_allocate): Added a FIXME.
      d54e684f
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 625aa185
      Darin Adler authored
              Fix bug 7208 (History and Notes panels intermittently die at
              startup or window launch). The bug turned out to be a logic error
              at the shell level, not a panel crashing as I had been assuming.
      
              * src/nautilus-view-frame.c: (nautilus_view_frame_stop),
              (nautilus_view_frame_selection_changed),
              (nautilus_view_frame_title_changed), (send_history): Check whether
              the CORBA view object is NIL instead of looking at state. The view
              will be NIL at all the right times, and it's a simpler and more
              reliable check. In particular, it's correct during the early
              loading stage, when the state does not reflect whether the view is
              present yet or not.
      
              * libnautilus-extensions/nautilus-glib-extensions.c:
              (nautilus_g_hash_table_new_free_at_exit): Only complain on systems
              where NAUTILUS_DEBUG is set, because this could confuse real users
              (the message doesn't really represent a bug).
      625aa185
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 60a4a3a2
      Ramiro Estrugo authored
      	Fix bug 7155 - Nautilus dies trying to get bold font at startup if
      	using Finish locale.
      
      	Many bulletproofing fixes to make sure Nautilus doesnt crash in
      	systems with broken or limited font setups.
      
      	* libnautilus-extensions/nautilus-gdk-font-extensions.c:
      	(nautilus_gdk_font_get_italic): Use the cached font list as we do
      	for bold fonts.  Make sure the slant_pattern is valid.  If its
      	not, then return the source font.  Remove some not needed casts.
      	(font_scalable_get_by_size): Bulletproof.  Dont assert that the
      	font load always works - it doesnt.
      	(font_bitmap_get_by_size): Bulletproof.  Dont do any work if a
      	valid larger_font pattern cant be determined - simply return NULL
      	in this case, the callers should deal with that case.  Make sure
      	we actually found a matching (or close) font size.  Before we were
      	assuming that there would be at least one match.  Not so for
      	really broken font setups.
      	(nautilus_gdk_font_get_larger): Remove some not needed casts.
      	(nautilus_gdk_font_get_largest_fitting): Check that the candidate
      	font is not NULL before proceeding to check that it matches.
      	(font_get_bold): Use the cached font lists to make bold font
      	queries.  Remove some not needed casts.
      	(font_get_size_in_pixels):  Check for invalid XLFD names and
      	return 0 (not found indicator) for such cases.
      
      	Also added a FIXME for an improvement for the fallback font
      	strategy.
      
      	Fix two tiny regressions:
      
      	7206 - Sidebar title does not properly center justify
      	7198 - Zero length NautilusLabel doens't draw background tile
      
      	* libnautilus-extensions/nautilus-label.c:
      	(paint_label_smooth): We need to draw the background tile even if
      	the string has zero length.
      	(label_force_cached_requisition_flush): Remove the broken "phony
      	justification" hack.  Replace it with a simpler "phony pattern"
      	hack that works.
      60a4a3a2
    • Ramiro Estrugo's avatar
      Add newline at end of file to make redhat7 compiler happy. Fix emacs · 23adce2b
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-directory-metafile-monitor.c:
      	(corba_metafile_ready):
      	Add newline at end of file to make redhat7 compiler happy.  Fix
      	emacs header blurb.
      23adce2b
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 236d21ff
      Darin Adler authored
      	Found and fixed as many untranslated things as possible. John
      	Sullivan found them and I fixed them. This takes care of much of
      	bug 6977.
      
      	* check-strings-functions:
      	* check-strings-patterns:
      	More things to ignore and fixes to bad patterns done while John
      	and I did our pass over all the code.
      
      	* check-strings.pl: Fix comment.
      
      	* applets/preferences-applet/nautilus-preferences-applet.c: (main):
      	* components/hardware/nautilus-hardware-view.c: (setup_CPU_form),
      	(setup_RAM_form), (setup_IDE_form):
      	* components/rpmview/nautilus-rpm-verify-window.c:
      	(nautilus_rpm_verify_window_initialize):
      	* components/services/inventory-view/nautilus-inventory-config-page.c:
      	(nautilus_inventory_config_page_initialize),
      	(nautilus_inventory_config_page_destroy):
      	* components/services/inventory-view/nautilus-inventory-disable-page.c:
      	(nautilus_inventory_disable_page_initialize):
      	* helper-utilities/authenticate/nautilus-authenticate.c: (main):
      	* libnautilus-extensions/nautilus-password-dialog.c:
      	(nautilus_password_dialog_new):
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_show_no_choices_message):
      	Mark additional strings for translation.
      
      	* components/adapter/nautilus-adapter-embed-strategy.c:
      	(nautilus_adapter_embed_strategy_initialize_class): Fix misspelling
      	of signal names.
      
      	* components/services/install/lib/eazel-package-system-rpm3.c:
      	(rpmmonitorpiggybag_new): Fix a typo.
      	* components/services/install/lib/eazel-softcat.c:
      	(eazel_softcat_error_string): Write comment about why these strings
      	don't need translation.
      
      	* libnautilus-extensions/nautilus-gtk-extensions.c: Tweak formatting.
      
      	* libnautilus-extensions/nautilus-preferences-dialog.c:
      	(nautilus_preferences_dialog_construct): Use stock button instead of
      	hard-coded OK for translation purposes.
      236d21ff
    • Mike Engber's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 5dfa187d
      Mike Engber authored
      
      	reviewed by: Darin Adler <darin@eazel.com>
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(metafile_read_mark_done):
      	* libnautilus-extensions/nautilus-directory-metafile-monitor.c:
      	(nautilus_metafile_monitor_get_epv), (corba_metafile_changed),
      	(corba_metafile_ready):
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_find_file_by_relative_uri),
      	(nautilus_directory_find_file_by_internal_uri):
      	* libnautilus-extensions/nautilus-metafile-server.idl:
      	* libnautilus-extensions/nautilus-metafile.c: (corba_set),
      	(corba_set_list),
      	(nautilus_metafile_notify_metafile_ready),
      	(call_metafile_changed),
      	(call_metafile_changed_for_all_files_mentioned_in_metafile),
      	(call_metafile_changed_for_one_file):
      	* libnautilus-extensions/nautilus-metafile.h:
      	When a metafile is read in - change signals are sent to all
      	files rather than just the ones with metadata. Also fixed
      	it so change notifications to the "." file will happen. Bug 7044.
      5dfa187d
    • Ramiro Estrugo's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 7b19c21b
      Ramiro Estrugo authored
      	Fix bug 6368 - Multibyte font handling.
      
      	* librsvg/rsvg-ft.c: (rsvg_ft_get_glyph),
      	(rsvg_ft_measure_or_render_string):
      	Tell freetype to never load bitmaps when loading glyphs.  We only
      	use the outlines of scalable fonts.  This means our code will work
      	even for glyphs that have embedded bitmaps.
      
      	Add support for multi byte characters.  We do this by allocate a
      	wide character array and converting the source string to wide
      	chars.  If no wide characters are found in the source string, then
      	we fill in the wide char array with the regular single byte chars.
      
      	This changes are based on a patch contributed by Yukihiro Nakai
      	<nakai@gnome.gr.jp> - thanks much.
      
      
      	Unrelated change.
      
      	* libnautilus-extensions/nautilus-labeled-image.c:
      	(nautilus_labeled_image_initialize):
      	Remove a extraneous '+' that sneaked in here.
      7b19c21b
  7. 28 Feb, 2001 4 commits
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 91b66e65
      Darin Adler authored
      	* check-strings.pl:
      	* check-strings-functions:
      	* check-strings-patterns:
      	New script and correspoinding config files to help us find
      	untranslated strings. It's going to take some effort to make
      	this an easy-to-use tool.
      
      	* components/rpmview/nautilus-rpm-view.c:
      	(nautilus_rpm_view_initialize): Fixed string that would not
      	get translated properly since it was using N_ and nothing
      	was going to use _() on it.
      	(nautilus_rpm_view_update_from_uri): Marked strings for
      	translation as requested in bug report 7149.
      	(nautilus_rpm_view_verify_files): Format tweak.
      	(nautilus_rpm_view_drag_data_received): Remove old dead code.
      
      	* libnautilus-extensions/nautilus-tabs.c: (draw_tab_piece_aa):
      	Change to use C-style comments, not C++.
      
      	* src/nautilus-application.c: (check_required_directories): Mark
      	strings for translation that we had missed before.
      	* src/nautilus-first-time-druid.c: Fix port string define so it
      	doesn't have to be repeated twice (and doesn't show up as an
      	"untranslated string").
      
      	* src/nautilus-about.c: Formatting tweak.
      	* src/nautilus-location-bar.c: Fix typo.
      91b66e65
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · e4abb4d1
      Gene Z. Ragan authored
      2001-02-28  Gene Z. Ragan  <gzr@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	Fixed bug 7141, gconf entry "show_directory_item_counts"
      	stored in "preferencees" directory
      
      	* libnautilus-extensions/nautilus-global-preferences.h:
      	Corrected a typographical error.
      e4abb4d1
    • John Harper's avatar
      reviewed by Ramiro Estrugo <ramiro@eazel.com> · ed2c4bc3
      John Harper authored
      2001-02-28  John Harper  <jsh@eazel.com>
      
      	reviewed by Ramiro Estrugo <ramiro@eazel.com>
      
      	Fixed bug 7111 (Icons appear in formation, then shift, when
      	page first loads). This also fixed bugs 4174 (NautilusLabel
      	needs to handle text with descenders better.) and 2865 (Text
      	underlining should honor the rendered string's baseline):
      
      	* librsvg/rsvg-ft.c (rsvg_ft_measure_or_render_string): don't
      	use the union of the bounding boxes of the glyphs to find the
      	overall bounding box, for the vertical component use the actual
      	font metrics. Also set the underline_position and
      	underline_thickness fields of the returned glyph structure
      
      	* librsvg/rsvg-ft.h (struct _RsvgFTGlyph): added two new
      	fields: underline_position and underline_thickness
      
      	* libnautilus-extensions/nautilus-smooth-text-layout.c
      	(smooth_text_layout_line_list_draw_to_pixbuf): don't just draw
      	the underline under the glyph's rectangle, draw it where the
      	glyph object wants it to be (using
      	nautilus_glyph_get_underline_rectangle (), which for text uses
      	the actual underline information from the font)
      
      	* libnautilus-extensions/nautilus-glyph.h,
      	libnautilus-extensions/nautilus-glyph.c
      	(nautilus_glyph_get_underline_rectangle): new function, fills
      	in an ArtIRect corresponding to the underline of the given
      	glyph object
      
      	* components/services/nautilus-dependent-shared/eazel-services-header.c:
      	* libnautilus-extensions/nautilus-tabs.c,
      	libnautilus-extensions/nautilus-smooth-text-layout.c,
      	libnautilus-extensions/nautilus-icon-canvas-item.c
      	* src/nautilus-sidebar-title.c, src/nautilus-sidebar-tabs.c
      
      	Tweaked a few hardcoded constants to fix minor changes in font
      	layout (this part was checked by Arlo)
      ed2c4bc3
    • Pavel's avatar
      reviewed by: Arlo Rose <arlo@eazel.com> · ed256af1
      Pavel authored
      2001-02-27  Pavel  <pavel@eazel.com>
      
      	reviewed by: Arlo Rose <arlo@eazel.com>
      
      	Fix 1509: List view draws using incorrect design specification
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_setup_style_colors):
      	Tweak color shifting values with Arlo to get better color ranges
      	for the list view grid.
      ed256af1