1. 26 Sep, 2000 2 commits
    • Darin Adler's avatar
      Got leaks in "nautilus --check" down to 0. · cfe2dc48
      Darin Adler authored
      	Fixed bug 2488 (path name for link set determined incorrectly) by
      	using only paths for link sets, never URIs.
      
      	* tools/leak-checker/nautilus-leak-checker.c: Added more "known to
      	leak" symbols.
      
      	* libnautilus-extensions/nautilus-link-set.c: (create_new_link),
      	(nautilus_link_set_is_installed), (nautilus_link_set_remove):
      	Changed functions to always expect paths, so they can now use
      	nautilus_make_path instead of link_set_path_name.
      	* src/nautilus-sidebar.c: (metadata_button_callback): Changed to
      	turn the URI into a path before calling the link-set functions.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_notify_files_moved): Use
      	nautilus_file_list_free instead of
      	nautilus_g_list_free_deep_custom.
      	* libnautilus-extensions/nautilus-string-list.c:
      	(nautilus_string_list_clear): Use nautilus_g_list_free_deep
      	instead of nautilus_g_list_free_deep_custom.
      	* libnautilus-extensions/nautilus-view-identifier.c:
      	(nautilus_view_identifier_free_callback),
      	(nautilus_view_identifier_list_free): Fixed call to
      	nautilus_g_list_free_deep_custom so it doesn't need a function
      	pointer type cast any more.
      cfe2dc48
    • Darin Adler's avatar
      Fixed bug bug 3264 (Tree view shows no branches for directories, · 2cd5440e
      Darin Adler authored
      	...HACK... nodes visible), bug 3290 (changing directory or
      	refreshing causes Gdk to assert), bug 2420 (Need to free original
      	key when removing model node), and other assorted problems.
      
      	* components/tree/nautilus-tree-view.c: (insert_hack_node),
      	(remove_hack_node), (nautilus_tree_view_insert_model_node):
      	Fix problem where the hash table key was neither g_strdup'd on the
      	way in, nor g_free'd on the way out. This caused all the problems
      	with bad nesting in the tree view.
      
      	* nautilus-installer/src/installer.c: (create_pixmap):
      	* src/file-manager/fm-list-view.c: (install_row_images):
      	* src/nautilus-theme-selector.c: (add_theme):
      	Added more checks for NULL before calling gdk_bitmap_unref.
      
      	* src/file-manager/fm-directory-view.c: (no_items_showing):
      	Fixed a NautilusDirectory ref. count leak.
      
      	* libnautilus-extensions/nautilus-font-factory.c:
      	(unref_global_font_factory), (nautilus_get_current_font_factory):
      	Unref the font factory on exit.
      	(nautilus_font_factory_initialize_class), (font_hash_node_free),
      	(free_one_hash_node), (destroy): Added code to actually destroy
      	the font factory.
      	(unref_fixed_font), (nautilus_font_factory_get_fallback_font):
      	Unref the fixed font on exit.
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	(unref_global_volume_monitor), (nautilus_volume_monitor_get):
      	Unref the volume monitor on exit.
      	* src/nautilus-signaller.c: (unref_global_signaller),
      	(nautilus_signaller_get_current): Unref the signaller on exit.
      
      	* src/nautilus-component-adapter-factory.c:
      	(nautilus_component_adapter_factory_initialize): Replaced some
      	strange FIXMEs with a simpler one.
      	(nautilus_component_adapter_factory_destroy): Fix a CORBA object
      	reference leak.
      	(nautilus_component_adapter_factory_get): Did a ref/sink.
      
      	* components/adapter/nautilus-adapter-control-embed-strategy.c:
      	(nautilus_adapter_control_embed_strategy_new):
      	* components/adapter/nautilus-adapter-embeddable-embed-strategy.c:
      	(nautilus_adapter_embeddable_embed_strategy_new):
      	* components/adapter/nautilus-adapter-file-load-strategy.c:
      	(nautilus_adapter_file_load_strategy_new):
      	* components/adapter/nautilus-adapter-progressive-load-strategy.c:
      	(nautilus_adapter_progressive_load_strategy_new):
      	* components/adapter/nautilus-adapter-stream-load-strategy.c:
      	(nautilus_adapter_stream_load_strategy_new):
      	* components/adapter/nautilus-adapter.c: (nautilus_adapter_new):
      	* components/rpmview/nautilus-rpm-verify-window.c:
      	(nautilus_rpm_verify_window_new):
      	* components/services/install/lib/eazel-install-object.c:
      	(eazel_install_new), (eazel_install_new_with_config):
      	* components/services/time/service/trilobite-eazel-time-service.c:
      	(trilobite_eazel_time_service_new):
      	* components/services/trilobite/libtrilobite/trilobite-service-pass
      	wordquery.c: (trilobite_passwordquery_new):
      	* components/services/trilobite/libtrilobite/trilobite-service.c:
      	(trilobite_service_new):
      	* components/tree/nautilus-tree-expansion-state.c:
      	(nautilus_tree_expansion_state_new):
      	* components/tree/nautilus-tree-model.c: (nautilus_tree_model_new):
      	* components/tree/nautilus-tree-node.c: (nautilus_tree_node_new):
      	* cut-n-paste-code/widgets/e-paned/e-hpaned.c: (e_hpaned_new):
      	* cut-n-paste-code/widgets/e-paned/e-vpaned.c: (e_vpaned_new):
      	* libnautilus-extensions/bonobo-stream-vfs.c:
      	(bonobo_stream_create):
      	* libnautilus-extensions/nautilus-any-width-bin.c:
      	(nautilus_any_width_bin_new):
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_new):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_new_with_icon):
      	* libnautilus-extensions/nautilus-caption-table.c:
      	(nautilus_caption_table_new):
      	* libnautilus-extensions/nautilus-caption.c:
      	(nautilus_caption_new):
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_new):
      	* libnautilus-extensions/nautilus-druid-page-eazel.c:
      	(nautilus_druid_page_eazel_new),
      	(nautilus_druid_page_eazel_new_with_vals):
      	* libnautilus-extensions/nautilus-druid.c: (nautilus_druid_new):
      	* libnautilus-extensions/nautilus-entry.c: (nautilus_entry_new):
      	* libnautilus-extensions/nautilus-file-operations-progress.c:
      	(nautilus_file_operations_progress_new):
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_new_from_name), (nautilus_file_new_from_info):
      	* libnautilus-extensions/nautilus-font-picker.c:
      	(nautilus_font_picker_new):
      	* libnautilus-extensions/nautilus-horizontal-splitter.c:
      	(nautilus_horizontal_splitter_new):
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_new):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(get_icon_factory):
      	* libnautilus-extensions/nautilus-image.c: (nautilus_image_new):
      	* libnautilus-extensions/nautilus-keep-last-vertical-box.c:
      	(nautilus_keep_last_vertical_box_new):
      	* libnautilus-extensions/nautilus-label.c: (nautilus_label_new):
      	* libnautilus-extensions/nautilus-list-column-title.c:
      	(nautilus_list_column_title_new):
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_new_with_titles):
      	* libnautilus-extensions/nautilus-password-dialog.c:
      	(nautilus_password_dialog_new):
      	* libnautilus-extensions/nautilus-preference.c:
      	(nautilus_preference_new_from_type):
      	* libnautilus-extensions/nautilus-preferences-box.c:
      	(nautilus_preferences_box_new):
      	* libnautilus-extensions/nautilus-preferences-dialog.c:
      	(nautilus_preferences_dialog_new):
      	* libnautilus-extensions/nautilus-preferences-group.c:
      	(nautilus_preferences_group_new):
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	(nautilus_preferences_item_new):
      	* libnautilus-extensions/nautilus-preferences-pane.c:
      	(nautilus_preferences_pane_new):
      	* libnautilus-extensions/nautilus-radio-button-group.c:
      	(nautilus_radio_button_group_new):
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(nautilus_scalable_font_new):
      	* libnautilus-extensions/nautilus-string-picker.c:
      	(nautilus_string_picker_new):
      	* libnautilus-extensions/nautilus-text-caption.c:
      	(nautilus_text_caption_new):
      	* libnautilus-extensions/nautilus-undo-context.c:
      	(nautilus_undo_context_new):
      	* libnautilus-extensions/nautilus-undo-manager.c:
      	(nautilus_undo_manager_new):
      	* libnautilus-extensions/nautilus-user-level-manager.c:
      	(user_level_manager_new):
      	* libnautilus/nautilus-undo-transaction.c:
      	(nautilus_undo_transaction_new):
      	* libnautilus/nautilus-view.c:
      	(nautilus_view_new_from_bonobo_control):
      	* src/file-manager/nautilus-trash-monitor.c:
      	(nautilus_trash_monitor_get):
      	* src/nautilus-desktop-window.c: (nautilus_desktop_window_new):
      	* src/nautilus-property-browser.c: (nautilus_property_browser_new):
      	* src/nautilus-shell.c: (nautilus_shell_new):
      	* src/nautilus-sidebar-tabs.c: (nautilus_sidebar_tabs_new):
      	* src/nautilus-sidebar-title.c: (nautilus_sidebar_title_new):
      	* src/nautilus-sidebar.c: (nautilus_sidebar_create_context_menu),
      	(nautilus_sidebar_new):
      	* src/nautilus-theme-selector.c: (nautilus_theme_selector_new):
      	* src/nautilus-throbber.c: (nautilus_throbber_new):
      	* src/nautilus-view-frame.c: (nautilus_view_frame_new):
      	* src/nautilus-zoom-control.c: (nautilus_zoom_control_new):
      	* src/nautilus-about.c: (nautilus_about_new):
      	* src/nautilus-application.c: (nautilus_application_new),
      	(nautilus_application_create_window):
      	* src/nautilus-bookmark-list.c: (nautilus_bookmark_list_new):
      	After Tim Janik explained that gtk_type_new is a low-level call to
      	be avoided, changed most uses of gtk_type_new to gtk_object_new or
      	gtk_widget_new. Also, after Owen and Havoc explained that you
      	can't just ignore the floating bit, added ref/sink calls to the
      	functions used to create objects where we don't use the floating
      	scheme.
      
      	* src/nautilus-zoom-control.c:
      	(nautilus_zoom_control_button_press_event): Take advantage of the
      	fact that the new menu is floating and don't bother with ref'ing.
      
      	* libnautilus-extensions/nautilus-ctree.c:
      	(nautilus_ctree_new_with_titles):
      	Added a cast.
      
      	* components/adapter/main.c: (adapter_factory_make_object):
      	* components/hardware/main.c: (hardware_view_make_object):
      	* components/services/install/lib/eazel-install-corba-callback.c:
      	(eazel_install_callback_get_type), (eazel_install_callback_new):
      	* libnautilus-extensions/nautilus-theme.c:
      	(nautilus_theme_get_theme), (nautilus_theme_set_theme),
      	(nautilus_theme_get_theme_data):
      	Whitespace tweaks.
      2cd5440e
  2. 23 Sep, 2000 1 commit
    • Darin Adler's avatar
      Storage leak fixes. Today I concentrated on leaks that happen · cbf7c584
      Darin Adler authored
      	when you change views from Icon to List View and back.
      
      	* components/tree/nautilus-tree-view.c:
      	(nautilus_tree_view_insert_model_node): Unref a pixmap and bitmap,
      	free a string.
      	(nautilus_tree_view_update_model_node): Unref a pixmap and bitmap,
      	free a string.
      	(notify_node_seen): Free a string.
      	(nautilus_tree_view_uri_to_name): Removed extra g_strdup.
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	(free_hash_tables_at_exit): Free a list.
      	* libnautilus-extensions/nautilus-list.c: (draw_cell): Skip the
      	excess work of re-getting the pixmap and bitmap, not using them,
      	and leaking them.
      	* libnautilus-extensions/nautilus-preferences.c:
      	(preferences_hash_node_remove_callback): Free a list.
      	* src/file-manager/fm-directory-view.c: (queue_pending_files):
      	Free a list.
      	* src/file-manager/fm-icon-view.c: (get_icon_text_callback):
      	Free a string in all code paths (was freed in some before).
      	* src/file-manager/fm-list-view.c: (add_to_list): Free the column
      	text in a way that works even though some columns have NULL.
      	(install_row_images): Unref a pixmap and bitmap.
      
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(destroy_global_rsvg_ft_context),
      	(initialize_global_stuff_if_needed): Free the rsvg_ft font cache
      	at exit.
      	* libnautilus-extensions/nautilus-theme.c: (free_last_theme),
      	(nautilus_theme_get_theme_data): Free the cached theme XML
      	document at exit.
      
      	* components/help/converters/gnome-db2html2/gdb3html.c:
      	(remove_head), (start_element), (end_element), (cdata_block):
      	* components/tree/nautilus-tree-model.c:
      	(nautilus_tree_model_for_each_postorder),
      	(nautilus_tree_model_monitor_add):
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(remove_monitor_link), (dequeue_pending_idle_callback),
      	(remove_callback_link_keep_data), (remove_callback_link):
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_file_receive_dropped_keyword):
      	* libnautilus-extensions/nautilus-file-changes-queue.c:
      	(nautilus_file_changes_queue_get_change):
      	* libnautilus-extensions/nautilus-thumbnails.c:
      	(check_for_thumbnails):
      	* src/file-manager/fm-properties-window.c:
      	(property_button_toggled):
      	* src/nautilus-window-manage-views.c: (handle_go_back),
      	(handle_go_forward):
      	* src/nautilus-window.c: (nautilus_add_to_history_list):
      	Fixed a bunch of callers of g_list_remove_link to also free the
      	removed link. This seems to be an error-prone API from glib.
      	About half of the callers had it wrong.
      
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_delete_item_at),
      	(nautilus_bookmark_list_delete_items_with_uri):
      	* src/nautilus-sidebar.c: (receive_dropped_keyword):
      	Changed to use g_list_free_1 for clarity.
      
      	* src/nautilus-location-bar.c: Coding style tweaks.
      
      	* src/nautilus-main.c: (main): Run the self-checks a second time
      	if they succeed the first time. More thorough check this way (make
      	sure the test works even after it's been run once), and better to
      	notice one-time vs. per-test leaks.
      
      	* tools/leak-checker/nautilus-leak-checker.c: (g_slist_alloc),
      	(g_slist_free), (g_slist_free_1), (g_mem_chunk_new),
      	(g_mem_chunk_destroy), (g_mem_chunk_alloc), (g_mem_chunk_alloc0),
      	(g_mem_chunk_free), (g_mem_chunk_clean), (g_mem_chunk_reset),
      	(g_mem_chunk_print): Made the GSList and GMemChunk code dumb down
      	when using the leak checker.
      
      	* tools/leak-checker/nautilus-leak-checker.c: Added more symbols
      	of "known to leak" functions so we can see the real leakers.
      cbf7c584
  3. 22 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 3236 (Window titles are indistinguishable in taskbar) · ae1d8e76
      John Sullivan authored
      	Removed "Nautilus: " from the main Nautilus window and all
      	the dialogs. Took this opportunity to standardize book title
      	capitalization for all dialog titles. Also softened the caveat
      	text just a bit.
      
      	* components/music/nautilus-music-view.c: (play_current_file):
      	* components/rpmview/nautilus-rpm-view-install.c:
      	(nautilus_rpm_view_install_done):
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(handle_xfer_vfs_error), (handle_xfer_overwrite),
      	(nautilus_file_operations_copy_move),
      	(nautilus_file_operations_move_to_trash), (confirm_empty_trash):
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_new),
      	(nautilus_program_chooser_show_no_choices_message):
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	(nautilus_info_dialog), (nautilus_warning_dialog),
      	(nautilus_error_dialog), (nautilus_error_dialog_with_details),
      	(nautilus_yes_no_dialog):
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_confirm_multiple_windows),
      	(fm_directory_view_confirm_deletion), (confirm_delete_from_trash),
      	(report_broken_symbolic_link):
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/file-manager/fm-icon-text-window.c:
      	(create_icon_text_window):
      	* src/file-manager/fm-properties-window.c:
      	(update_properties_window_title):
      	* src/nautilus-application.c:
      	(nautilus_application_check_user_directories):
      	* src/nautilus-bookmarks-window.c: (create_bookmarks_window):
      	* src/nautilus-first-time-druid.c:
      	(nautilus_first_time_druid_show):
      	* src/nautilus-property-browser.c: (emblem_image_file_changed),
      	(add_background_to_browser):
      	* src/nautilus-shell.c: (display_caveat):
      	* src/nautilus-sidebar.c: (receive_dropped_uri_list):
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_update_title), (handle_unreadable_location),
      	(report_content_view_failure_to_user),
      	(report_sidebar_panel_failure_to_user),
      	(nautilus_window_end_location_change_callback):
      	* src/nautilus-window-menus.c: (forget_history_if_confirmed),
      	(user_level_customize_callback), (show_bogus_bookmark_window):
      ae1d8e76
  4. 21 Sep, 2000 1 commit
    • Gene Z. Ragan's avatar
      Fixed bug 2090, Sidebar panel shrinks when back from text or image view to · 1e2203eb
      Gene Z. Ragan authored
      2000-09-21  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 2090, Sidebar panel shrinks when back from text
      	or image view to directory view.
      
      	* src/nautilus-sidebar.c: (make_button_box),
      	(nautilus_sidebar_update_buttons):
      	Fixed logic where button centering was being shown
      	at the wrong time, messing up spacing of sidebar panels.
      
      	* components/image-viewer/nautilus-image-view.c: (redraw_view),
      	(configure_size), (view_factory_common):
      	Fixed cases where image data might be NULL.
      1e2203eb
  5. 19 Sep, 2000 1 commit
    • Gene Z. Ragan's avatar
      Fixed bug 3019, renaming special icons should be impossible or harmless. · f7b31b3e
      Gene Z. Ragan authored
      2000-09-19  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 3019, renaming special icons should be
      	impossible or harmless.
      
      	You can't rename any NautilusLinks now.  This makes
      	sense given the way we use them.
      
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_can_rename):
      	Add a check to see if file is NautilusLink.
      
      	* src/file-manager/fm-icon-view.c:
      	(special_link_in_selection):
      	Check and see if selection contains link files.
      
      	(fm_icon_view_create_selection_context_menu_items):
      	Call above funcion and disable rename if it returns TRUE.
      f7b31b3e
  6. 12 Sep, 2000 1 commit
  7. 11 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 2317 (Right-click on sidebar uses menu items in · f65934f0
      John Sullivan authored
      	a confusing way)
      
      	* src/nautilus-sidebar.c: (nautilus_sidebar_add_panel_items):
      	The bug was confusion over the gtk_check_menu_item API. It had
      	been calling set_show_toggle when it meant set_active.
      
      	* src/file-manager/fm-list-view.c: Updated a comment.
      f65934f0
  8. 08 Sep, 2000 3 commits
  9. 01 Sep, 2000 1 commit
    • John Sullivan's avatar
      Changed all nautilus dialog calls to take a window title · e6cad0aa
      John Sullivan authored
      	(or NULL to get "Nautilus: Error" and the like). Updated
      	all callers to pass a window title.
      
      	* libnautilus-extensions/nautilus-stock-dialogs.h,
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	(show_message_box), (show_ok_box), (nautilus_info_dialog),
      	(nautilus_warning_dialog), (nautilus_error_dialog),
      	(nautilus_error_dialog_with_details), (nautilus_yes_no_dialog):
      	Updated all public & private dialog-creating calls to take
      	a dialog_title parameter.
      
      	* components/rpmview/nautilus-rpm-view-install.c:
      	(nautilus_rpm_view_install_done):
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(confirm_empty_trash):
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_show_no_choices_message):
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application_parented):
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/nautilus-application.c:
      	(nautilus_application_check_user_directories),
      	(nautilus_application_startup):
      	* src/nautilus-first-time-druid.c:
      	(nautilus_first_time_druid_show):
      	* src/nautilus-property-browser.c: (emblem_image_file_changed),
      	(add_background_to_browser):
      	* src/nautilus-sidebar.c: (receive_dropped_uri_list):
      	* src/nautilus-window-manage-views.c: (handle_unreadable_location),
      	(report_content_view_failure_to_user),
      	(report_sidebar_panel_failure_to_user),
      	(nautilus_window_end_location_change_callback):
      	* src/nautilus-window-menus.c: (forget_history_if_confirmed),
      	(show_bogus_bookmark_window): Made up dialog titles for all
      	title-less dialogs. A few were already setting titles after
      	the fact, so I removed the now-extraneous set_title calls.
      e6cad0aa
  10. 29 Aug, 2000 1 commit
    • John Sullivan's avatar
      Added more bug numbers to FIXMEs. 77 to go. I am exhausted · adad2499
      John Sullivan authored
      	from creating bug reports, so the remaining ones will have
      	to wait until at least tomorrow.
      
      	* src/nautilus-complex-search-bar.c:
      	(nautilus_complex_search_bar_set_location),
      	(fewer_options_callback), (update_options_buttons_state):
      	* src/nautilus-search-bar.c:
      	* src/nautilus-sidebar-tabs.c: (draw_one_tab_themed),
      	(get_tab_width):
      	* src/nautilus-sidebar.c: (receive_dropped_uri_list),
      	(receive_dropped_keyword), (add_command_buttons):
      	* src/nautilus-simple-search-bar.c:
      	(nautilus_search_uri_to_simple_search_criteria),
      	(nautilus_simple_search_criteria_to_search_uri):
      	* src/nautilus-switchable-search-bar.c:
      	(search_bar_preference_changed_callback),
      	(nautilus_switchable_search_bar_set_location),
      	(nautilus_search_uri_is_displayable_by_mode):
      adad2499
  11. 28 Aug, 2000 1 commit
    • John Sullivan's avatar
      Some FIXME work. Removed some obsolete FIXMEs, and added · 7d5c496d
      John Sullivan authored
      	bug numbers to others (some existing bug reports, some new
      	bug reports). 236 FIXMES without bug numbers remain.
      
      	* src/file-manager/fm-directory-view.c:
      	(zoomable_zoom_to_fit_callback),
      	(fm_directory_view_can_move_file_to_trash),
      	(fm_directory_view_trash_or_delete_selection), (activate_callback),
      	(fm_directory_view_activate_file),
      	(fm_directory_view_get_context_menu_index):
      	* src/file-manager/fm-directory-view.h:
      	* src/file-manager/fm-error-reporting.c: (fm_rename_file):
      	* src/file-manager/fm-error-reporting.h:
      	* src/file-manager/fm-properties-window.c:
      	(activate_group_callback), (attach_group_menu),
      	(activate_owner_callback), (attach_owner_menu),
      	(create_basic_page), (create_permissions_page):
      	* src/file-manager/fm-search-list-view.c: (real_merge_menus):
      	* src/nautilus-sidebar.c: (receive_dropped_uri_list):
      7d5c496d
  12. 25 Aug, 2000 1 commit
    • Darin Adler's avatar
      Moved functions to gnome-vfs. · 9fd281ff
      Darin Adler authored
      	* components/music/nautilus-music-view.c: (play_current_file),
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_uri_known_not_to_exist):
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(theme_image_path_to_uri),
      	(nautilus_directory_background_read_desktop_settings),
      	(nautilus_directory_background_write_desktop_settings):
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_get_user_main_directory), (nautilus_is_remote_uri):
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	(nautilus_gdk_pixbuf_load):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(make_thumbnail_path), (path_represents_svg_image),
      	(load_specific_image), (nautilus_icon_factory_make_thumbnails):
      	* libnautilus-extensions/nautilus-link-set.c: (expand_uri):
      	* libnautilus-extensions/nautilus-link.c: (nautilus_link_create),
      	(nautilus_link_set_icon), (nautilus_link_set_link_uri),
      	(nautilus_link_set_type), (nautilus_link_get_root_property),
      	(make_local_path), (nautilus_link_get_image_uri):
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	(add_icon_themes):
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application_parented):
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	(get_volume_vfs_uri_if_writable):
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	(mount_volume_mount):
      	* src/file-manager/fm-desktop-icon-view.c:
      	(startup_create_mount_links), (volume_mounted_callback),
      	(place_home_directory), (get_local_path):
      	* src/file-manager/fm-directory-view.c: (activate_callback):
      	* src/file-manager/fm-icon-view.c: (play_file):
      	* src/file-manager/fm-properties-window.c:
      	(get_and_ref_file_to_display):
      	* src/nautilus-desktop-window.c: (nautilus_desktop_window_new):
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_drag_data_get), (remove_background),
      	(remove_emblem), (emblem_image_file_changed),
      	(add_background_to_browser), (emblem_dialog_clicked),
      	(make_properties_from_directory):
      	* src/nautilus-sidebar.c: (map_local_data_file),
      	(uri_is_local_image):
      	* src/nautilus-theme-selector.c: (populate_list_with_themes):
      	* src/nautilus-view-frame-bonobo-embeddable.c:
      	(bonobo_subdoc_load_location):
      	* src/nautilus-window.c: (nautilus_window_go_home):
      	Changed to use local path functions from gnome-vfs now that
      	they are moved there from Nautilus.
      
      	* libnautilus-extensions/nautilus-file-utilities.h:
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	Removed the local path functions since they are in gnome-vfs
      	now and all callers have been changed to use those.
      9fd281ff
  13. 22 Aug, 2000 1 commit
  14. 21 Aug, 2000 1 commit
    • Ramiro Estrugo's avatar
      Add a evil hack to keep track of background changes. I have a better fix · 1467f950
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-buffered-widget.c:
      	(nautilus_buffered_widget_realize):
      	Add a evil hack to keep track of background changes.  I have a
      	better fix for this that I will commit soon.
      
      	* src/nautilus-sidebar-title.c:
      	(nautilus_sidebar_title_initialize),
      	(nautilus_sidebar_title_destroy),
      	(nautilus_sidebar_title_select_text_color),
      	(nautilus_sidebar_title_theme_changed), (update_icon),
      	(update_font), (update_title), (update_more_info), (update_all),
      	(nautilus_sidebar_title_hit_test_icon),
      	(sidebar_create_smooth_components_if_needed),
      	(sidebar_create_normal_components_if_needed),
      	(anti_aliased_mode_changed_callback):
      	* src/nautilus-sidebar-title.h:
      	* src/nautilus-sidebar.c: (background_appearance_changed_callback):
      
      	Add support for smoother graphics.  Use new NautilusLabel and
      	NautilusImage widgets to render alpha composited pixbufs and anti
      	aliases text.
      
      	The old non-smooth widgets are still supported and should continue
      	to work as expected whenever the smooth graphics preference is
      	toggled.
      1467f950
  15. 15 Aug, 2000 1 commit
    • Mike Engber's avatar
      Second cut at syncing our desktop background with GNOME's (bug 1047) Now · 941f3cb4
      Mike Engber authored
      
      	Second cut at syncing our desktop background with GNOME's (bug 1047)
      	Now we support images being centered and scaled (not just tiled)
      	Although, there is no UI in nautilus to set this up (use the background
      	capplet) Still need to handle update issues.
      
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_destroy),
      	(nautilus_background_get_image_placement),
      	(nautilus_background_set_image_placement),
      	(nautilus_background_draw), (nautilus_background_draw_aa),
      	(nautilus_background_get_image_uri), (load_image_callback),
      	(start_loading_image),
      	(nautilus_background_receive_dropped_background_image),
      	(nautilus_background_set_image_uri), (nautilus_background_is_set),
      	(nautilus_background_real_reset),
      	(nautilus_background_is_too_complex_for_gtk_style),
      	(nautilus_background_is_dark),
      	(nautilus_background_receive_dropped_color):
      	* libnautilus-extensions/nautilus-background.h:
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(nautilus_directory_background_get_default_settings),
      	(nautilus_directory_background_read_desktop_settings),
      	(nautilus_directory_background_write_desktop_settings),
      	(nautilus_directory_background_write_desktop_default_settings),
      	(nautilus_directory_background_is_set),
      	(background_changed_callback), (directory_changed_callback),
      	(background_reset_callback):
      
      	nautilus_gdk_pixbuf_scale_to_fit was renamed to
      	nautilus_gdk_pixbuf_scale_down_to_fit and also changed
      	to not unref it's argument pixbuf. This involved fixing
      	up various places it was used.
      
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	(nautilus_gdk_pixbuf_scale_to_fit_helper),
      	(nautilus_gdk_pixbuf_scale_to_fit),
      	(nautilus_gdk_pixbuf_scale_down_to_fit):
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.h:
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_make_thumbnails):
      	* src/nautilus-property-browser.c: (make_drag_image),
      	(set_emblem_image_from_file),
      	(make_properties_from_directory_path):
      	* src/nautilus-sidebar.c: (background_settings_changed_callback),
      	(background_reset_callback), (nautilus_sidebar_update_appearance):
      	* src/nautilus-theme-selector.c: (add_theme):
      941f3cb4
  16. 12 Aug, 2000 1 commit
  17. 11 Aug, 2000 1 commit
    • Maciej Stachowiak's avatar
      Made copyright headers consistent in style; also made sure to refer to · 175ac684
      Maciej Stachowiak authored
      	* src/nautilus-applicable-views.c,
      	src/nautilus-applicable-views.h, src/nautilus-application.c,
      	src/nautilus-application.h, src/nautilus-bookmark-list.c,
      	src/nautilus-bookmark-list.h, src/nautilus-bookmark-parsing.c,
      	src/nautilus-bookmark-parsing.h, src/nautilus-bookmarks-window.c,
      	src/nautilus-bookmarks-window.h,
      	src/nautilus-complex-search-bar.c,
      	src/nautilus-complex-search-bar.h, src/nautilus-desktop-window.c,
      	src/nautilus-desktop-window.h, src/nautilus-first-time-druid.c,
      	src/nautilus-first-time-druid.h, src/nautilus-history-frame.c,
      	src/nautilus-history-frame.h, src/nautilus-link-set-window.c,
      	src/nautilus-link-set-window.h, src/nautilus-location-bar.c,
      	src/nautilus-location-bar.h, src/nautilus-main.c,
      	src/nautilus-navigation-bar.c, src/nautilus-navigation-bar.h,
      	src/nautilus-property-browser.c, src/nautilus-property-browser.h,
      	src/nautilus-search-bar-private.h, src/nautilus-search-bar.c,
      	src/nautilus-search-bar.h, src/nautilus-self-check-functions.c,
      	src/nautilus-self-check-functions.h, src/nautilus-shell.c,
      	src/nautilus-shell.h, src/nautilus-sidebar-tabs.c,
      	src/nautilus-sidebar-tabs.h, src/nautilus-sidebar-title.c,
      	src/nautilus-sidebar-title.h, src/nautilus-sidebar.c,
      	src/nautilus-sidebar.h, src/nautilus-signaller.c,
      	src/nautilus-signaller.h, src/nautilus-simple-search-bar.c,
      	src/nautilus-simple-search-bar.h,
      	src/nautilus-switchable-navigation-bar.c,
      	src/nautilus-switchable-navigation-bar.h,
      	src/nautilus-switchable-search-bar.c,
      	src/nautilus-switchable-search-bar.h, src/nautilus-toolbar.c,
      	src/nautilus-toolbar.h, src/nautilus-view-frame-bonobo-control.c,
      	src/nautilus-view-frame-bonobo-embeddable.c,
      	src/nautilus-view-frame-corba.c,
      	src/nautilus-view-frame-nautilus-view.c,
      	src/nautilus-view-frame-private.h,
      	src/nautilus-view-frame.c,src/nautilus-view-frame.h,
      	src/nautilus-window-manage-views.c,
      	src/nautilus-window-manage-views.h, src/nautilus-window-menus.c,
      	src/nautilus-window-private.h, src/nautilus-window-toolbars.c,
      	src/nautilus-window.c, src/nautilus-window.h,
      	src/nautilus-zoom-control.c, src/nautilus-zoom-control.h,
      	src/nautilus-zoomable-frame-corba.c: Made copyright headers
      	consistent in style; also made sure to refer to Nautilus as
      	Nautilus, not "this library" or "The GNOME Library".
      175ac684
  18. 09 Aug, 2000 1 commit
    • Jiri (George) Lebl's avatar
      Use the new application registry api. Also remove the hack for "merging" · 7ed27c17
      Jiri (George) Lebl authored
      Tue Aug 08 23:23:50 2000  George Lebl <jirka@5z.com>
      
      	* libnautilus-extensions/nautilus-mime-actions.c
      	  (nautilus_mime_get_default_application_fo)
      	  (nautilus_mime_get_short_list_application)
      	  (nautilus_mime_get_all_applications_for_u):
      	  Use the new application registry api.  Also remove the hack for
      	  "merging" (bug 1268) the application with short list as this
      	  should now be not necessary because of the application registry.
      
      	* src/nautilus-sidebar.c (command_button_callback):
      	  Use the new application registry api and check for NULL
      	  return from get_mime_application just for sanity's sake.
      7ed27c17
  19. 07 Aug, 2000 1 commit
    • Pavel Cisler's avatar
      Fix bug 1941 -- Context menus need to be clicked twice. · d2c7944a
      Pavel Cisler authored
      2000-08-07  Pavel Cisler  <pavel@eazel.com>
      
      	Fix bug 1941 -- Context menus need to be clicked twice.
      
      	* libnautilus-extensions/nautilus-gtk-extensions.c:
      	(nautilus_pop_up_context_menu):
      	* libnautilus-extensions/nautilus-gtk-extensions.h:
      	When invoked from anywhere but the button_press call, we need to
      	pass 0 for button otherwise the next click will not be handled.
      	Add a way to pass the button as a parameter.
      
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_pop_up_selection_context_menu),
      	(fm_directory_view_pop_up_background_context_menu):
      	Pass 0 for button
      
      	* src/nautilus-sidebar.c: (nautilus_sidebar_press_event):
      	* src/nautilus-window-toolbars.c:
      	(back_or_forward_button_clicked_callback):
      	Called from button_press, pass the actual button.
      d2c7944a
  20. 04 Aug, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 1908: Title in sidebar vanishes on theme change. · 44bea766
      John Sullivan authored
      	* src/nautilus-sidebar.c:
      	(nautilus_sidebar_set_uri), (nautilus_sidebar_update_info):
      	Separated update_info into the parts that were about changing
      	URI-based information and the parts that were about changing
      	appearance only. The appearance-only parts are now called
      	nautilus_sidebar_update_appearance. The	other parts were put
      	back into nautilus_sidebar_set_uri.
      	(nautilus_sidebar_theme_changed),
      	(receive_dropped_color), (receive_dropped_keyword),
      	(background_appearance_changed_callback): Made these callers
      	use nautilus_sidebar_set_appearance. The bug was that
      	theme_changed was passing NULL for the initial title text,
      	but passing NULL wipes it out rather than doing nothing as
      	was intended. The other callers were getting the current title
      	text and then passing it back in; now they just leave it alone.
      44bea766
  21. 31 Jul, 2000 1 commit
    • John Sullivan's avatar
      Finished rest of bug 762 (Framework for dealing with · 54effa81
      John Sullivan authored
      	component that crashes). Remaining component-failure issues
      	have been split off as separate bugs.
      
      	* src/nautilus-sidebar.c: (nautilus_sidebar_remove_panel),
      	* src/nautilus-view-frame.c: (check_object):
      	Just added FIXME comments with bug numbers.
      
      	* src/nautilus-window-manage-views.c:
      	(report_sidebar_panel_failure_to_user):
      	Turned this from a placeholder to a real function that puts up
      	a sensible error message.
      	(nautilus_window_update_state): Moved the report_to_user call
      	to a place where it is hit in all the error cases, not just some.
      
      	* src/nautilus-window.c:
      	(window_update_sidebar_panels_from_preferences):
      	Call nautilus_window_disconnect_view on sidebar panel before
      	removing it the normal way so that it doesn't trigger the
      	report-error-to-user code.
      54effa81
  22. 29 Jul, 2000 1 commit
  23. 19 Jul, 2000 1 commit
    • Darin Adler's avatar
      Change include style from <libtrilobite/xxx.h> to "xxx.h" to fix the · 8bd0fdd4
      Darin Adler authored
      2000-07-19  Darin Adler  <darin@eazel.com>
      
      	* components/services/trilobite/libtrilobite/libtrilobite.h:
      	* components/services/trilobite/libtrilobite/trilobite-root-client.c:
      	Change include style from <libtrilobite/xxx.h> to "xxx.h" to fix
      	the build.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(make_uri_canonical), (is_canonical_uri):
      	Add two new elements to the canonical URI rules in here: put a
      	"file:" in front of things that don't have a scheme, and
      	lower-case the scheme.
      
      	* libnautilus-extensions/nautilus-string.h:
      	* libnautilus-extensions/nautilus-string.c:
      	(nautilus_istr_has_prefix), (nautilus_istr_has_suffix):
      	Add case-insensitive versions of these calls. These terse names
      	are maybe a little lame; istr is not completely clear. (I guess I
      	now wish the "nautilus_" namespace was "n_" instead, like those
      	rad Evolution people and their bold "e_").
      
      	* components/music/nautilus-music-view.c: (is_mp3_file),
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_format_uri_for_display),
      	(nautilus_get_local_path_from_uri):
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_contains_text):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_for_file), (make_thumbnail_path),
      	(load_specific_image):
      	* libnautilus-extensions/nautilus-theme.c:
      	(nautilus_theme_make_selector):
      	* src/file-manager/fm-icon-view.c: (play_file), (preview_sound),
      	(icon_container_preview_callback):
      	* src/file-manager/fm-properties-window.c:
      	(get_property_names_from_uri):
      	* src/nautilus-location-bar.c: (try_to_expand_path):
      	* src/nautilus-property-browser.c: (ensure_uri_is_image),
      	(make_properties_from_directory_path):
      	* src/nautilus-sidebar.c: (map_local_data_file),
      	(add_command_buttons):
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(local_data_file_to_uri):
      	Use case-insensitive string functions when dealing with MIME
      	types, URI schemes, or file name extensions for file types that
      	are also used on Windows where file names are not case sensitive.
      
      	* libnautilus-extensions/nautilus-string.c:
      	(nautilus_self_check_string):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_icon_is_different):
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_delete_items_with_uri):
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_reset_title_internal), (handle_go_back),
      	(handle_go_forward), (handle_go_elsewhere):
      	* src/nautilus-window-menus.c:
      	(nautilus_window_add_bookmark_for_current_location):
      	Get rid of uses of nautilus_eat_strcmp since it's yucky.
      
      	* libnautilus-extensions/nautilus-debug.c:
      	(nautilus_str_equal_with_free):
      	Make a debug-only thing kind of like nautilus_eat_strcmp that's
      	good for asserts.
      
      	* src/nautilus-sidebar.c: (add_command_buttons):
      	Fixed a storage leak.
      
      	* libnautilus-extensions/nautilus-link-set.c: (link_set_path_name):
      	Added a FIXME.
      
      	* components/services/install/command-line/.cvsignore:
      	* cut-n-paste-code/freetype/.cvsignore:
      	Ignore some generated files.
      8bd0fdd4
  24. 11 Jul, 2000 1 commit
    • Darin Adler's avatar
      Changed history list to include a separate position field instead of · 88838071
      Darin Adler authored
      	* components/history/nautilus-history-view.c:
      	(history_view_update_icons), (get_history_list),
      	(hyperbola_navigation_history_load_location):
      	* libnautilus/nautilus-view-component.idl:
      	* src/nautilus-history-frame.c:
      	(impl_Nautilus_HistoryFrame_get_history_list):
      	* src/nautilus-view-frame.h:
      	* src/nautilus-view-frame.c:
      	(nautilus_view_frame_get_history_list):
      	* src/nautilus-window.c:
      	(nautilus_window_get_history_list_callback),
      	(nautilus_window_connect_view):
      	Changed history list to include a separate position field
      	instead of having a position in each entry.
      
      	* components/notes/nautilus-notes.c: (done_with_file):
      	Name changed from nautilus_file_cancel_callback to
      	nautilus_file_cancel_call_when_ready to reduce confusion with
      	nautilus_file_cancel.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_get): Made NULL for URI be legal (and result
      	in NULL for the directory object).
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	(get_mime_type_from_uri): Made NULL for URI be legal (and result
      	in NULL for MIME type).
      
      	* libnautilus-extensions/nautilus-entry.c:
      	(nautilus_entry_set_text): Minor tweak.
      
      	* libnautilus-extensions/nautilus-file.h:
      	* libnautilus-extensions/nautilus-file-private.h:
      	* libnautilus-extensions/nautilus-file.c: (operation_new),
      	(operation_free), (operation_complete), (operation_cancel),
      	(rename_update_info_and_metafile), (rename_callback),
      	(nautilus_file_rename), (nautilus_file_cancel),
      	(nautilus_file_set_owner), (nautilus_file_cancel_call_when_ready):
      	Added cancelling to rename as a prelude to doing the same for
      	set_file_info-based calls.
      
      	* libnautilus-extensions/nautilus-graphic.c:
      	Fixed a formatting mistake and a typo.
      
      	* libnautilus-extensions/nautilus-stock-dialogs.h:
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	(timed_wait_hash), (timed_wait_hash_equal),
      	(nautilus_timed_wait_start), (nautilus_timed_wait_free),
      	(nautilus_timed_wait_stop): Re-did timed wait API now that
      	we are really using it. Still unimplemented.
      
      	* src/Makefile.am:
      	Since IDL dependencies are not understood by automake, added
      	an explicit one so we pick up the change to the libnautilus
      	view component IDL.
      
      	* src/file-manager/fm-error-reporting.h:
      	* src/file-manager/fm-error-reporting.c: (rename_callback),
      	(cancel_rename_callback), (fm_rename_file): Moved code for
      	renaming into here so it can be shared between the icon view
      	and the properties dialog. Perhaps it needs to be renamed.
      
      	* src/file-manager/fm-icon-view.c:
      	(fm_icon_view_icon_text_changed_callback): Use the shared
      	code instead of having the rename code here.
      
      	* src/nautilus-application.c: (create_object): Make a new
      	shell object each time instead of trying to share one.
      	(nautilus_application_startup): Activate the shell object
      	using OAF. This makes it work across processes and adds
      	the feature.
      
      	* src/nautilus-main.c: (main): Call bonobo_activate explicitly so
      	CORBA calls work before the main loop.
      
      	* src/nautilus-shell.c: (display_caveat_first_time),
      	(corba_manage_desktop): Got rid of all state in NautilusShell
      	so we can use multiple shell objects if we want.
      
      	* src/nautilus-sidebar.c: (nautilus_sidebar_update_info):
      	Got rid of code that checks for NULL.
      88838071
  25. 09 Jul, 2000 1 commit
  26. 06 Jul, 2000 1 commit
    • Andy Hertzfeld's avatar
      fixed long-standing bug where the sidebar tabs would display the wrong · 3cc4d739
      Andy Hertzfeld authored
      
      	fixed long-standing bug where the sidebar tabs would display the
      	wrong view by decrementing the appropriate index when a view
      	is removed; gave sidebar views more room and solved the variable
      	height problem by hiding the sidebar title when a sidebar view
      	is displayed; reduced slop on splitter to avoid accidental
      	toggling; and some new images from Susan.
      3cc4d739
  27. 30 Jun, 2000 1 commit
  28. 29 Jun, 2000 1 commit
  29. 28 Jun, 2000 4 commits
    • Darin Adler's avatar
      Changed to use new call that's for receiving dropped images. · 711e7694
      Darin Adler authored
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_drag_data_received):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(receive_dropped_tile_image):
      	* src/nautilus-sidebar.c: (receive_dropped_uri_list):
      	Changed to use new call that's for receiving dropped images.
      
      	* src/nautilus-sidebar.c: (background_settings_changed_callback),
      	(background_appearance_changed_callback),
      	(background_reset_callback), (nautilus_sidebar_update_info):
      	Changed signal handlers to use the normal form instead of
      	connect_object. Changed the reset callback to stop the reset
      	signal from going any further now that there's a default handler
      	for reset.
      
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(background_reset_callback): Add a call to stop the reset signal
      	from going any further now that there's a default handler for
      	reset.
      
      	* libnautilus-extensions/nautilus-background.h:
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_initialize_class),
      	(nautilus_background_receive_dropped_background_image),
      	(nautilus_background_set_tile_image_uri),
      	(nautilus_background_reset), (nautilus_background_real_reset):
      	Made nautilus_background_reset set the color and image to NULL by
      	default instead of doing nothing. Also added a new call to receive
      	a dropped background image and only pay attention to the special
      	"reset" image name there instead of hacking it into
      	_set_tile_image_uri itself.
      
      	* libnautilus-extensions/nautilus-stock-dialogs.h:
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	(find_message_label), (find_message_label_callback),
      	(show_message_box), (show_ok_box), (nautilus_info_dialog),
      	(nautilus_warning_dialog), (nautilus_error_dialog),
      	(clicked_callback), (nautilus_error_dialog_with_details),
      	(nautilus_yes_no_dialog): Change the API for stock dialogs
      	to be a little simpler, getting rid of the separate parented
      	variant. Also added a new dialog for errors that have a second
      	more detailed error message.
      
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_show_no_choices_message):
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application_parented):
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/nautilus-property-browser.c: (emblem_image_file_changed),
      	(add_background_to_browser):
      	* src/nautilus-window-manage-views.c:
      	(handle_unreadable_location),
      	(nautilus_window_end_location_change_callback),
      	(report_content_view_failure_to_user):
      	* src/nautilus-window-menus.c: (show_bogus_bookmark_window):
      	Change to use new API for stock dialogs.
      
      	* src/nautilus-application.c: (create_factory),
      	(nautilus_application_initialize),
      	(nautilus_application_check_user_directories),
      	(nautilus_application_startup):
      	Moved OAF registration to application_startup and added some
      	error handling for the case where we have two copies of Nautilus.
      
      	* libnautilus-extensions/nautilus-file.h: Move get_mapped_uri
      	out of the "good part" of the header and add a FIXME.
      
      	* components/services/install/lib/.cvsignore:
      	Ignore some new generated files. Maybe some day I can get Eskil to
      	make these himself as he adds new things.
      711e7694
    • John Sullivan's avatar
      Added a couple of NULL uri checks to get us cleanly past the case where · f6185af8
      John Sullivan authored
      	* src/nautilus-sidebar-title.c: (nautilus_sidebar_title_set_uri),
      	* src/nautilus-sidebar.c: (nautilus_sidebar_update_info): Added
      	a couple of NULL uri checks to get us cleanly past the case where
      	the URI is temporarily null at startup time when the theme is set.
      f6185af8
    • Andy Hertzfeld's avatar
      added theme framework so clients can access theme data and made the · 5be0629b
      Andy Hertzfeld authored
      
      	added theme framework so clients can access theme data and made
      	the sidebar use it.
      5be0629b
    • Andy Hertzfeld's avatar
      made convenience routine nautilus_is_remote_uri and removed similar code · 411e258a
      Andy Hertzfeld authored
      
      	made convenience routine nautilus_is_remote_uri and removed
      	similar code from nautilus_link.  Fixed bug 1494, couldn't set
      	custom icons on directories with blanks in their name by
      	properly escaping/unescaping paths<->uris.
      411e258a
  30. 27 Jun, 2000 3 commits
    • Andy Hertzfeld's avatar
      made the sidebar draw the background determined by the current theme when · 693a5eec
      Andy Hertzfeld authored
      
      	made the sidebar draw the background determined by the current
      	theme when reset.
      693a5eec
    • Andy Hertzfeld's avatar
      fixed sidebar theming by adding a gtk_signal_handler_block_by_func call · 3c4ab33c
      Andy Hertzfeld authored
      
      	fixed sidebar theming by adding a gtk_signal_handler_block_by_func
      	call (with corresponding unblock) to avoid the background data
      	being written out to the metafile, since it just came from the theme
      	and didn't really change
      3c4ab33c
    • Darin Adler's avatar
      Removed a bunch of incorrect calls to bonobo_object_unref. An error in the · a93b99ab
      Darin Adler authored
      	* components/hardware/nautilus-hardware-view.c:
      	(nautilus_hardware_view_destroy):
      	* components/loser/content/nautilus-content-loser.c:
      	(nautilus_content_loser_destroy):
      	* components/loser/sidebar/nautilus-sidebar-loser.c:
      	(nautilus_sidebar_loser_destroy):
      	* components/mozilla/nautilus-mozilla-content-view.c:
      	(nautilus_mozilla_content_view_destroy):
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_destroy):
      	* components/rpmview/nautilus-rpm-view.c:
      	(nautilus_rpm_view_destroy):
      	* components/sample/nautilus-sample-content-view.c:
      	(nautilus_sample_content_view_destroy):
      	* components/services/time/nautilus-view/trilobite-eazel-time-view.c:
      	(trilobite_eazel_time_view_destroy):
      	* components/tree/nautilus-tree-view.c:
      	(nautilus_tree_view_destroy):
      	Removed a bunch of incorrect calls to bonobo_object_unref.
      	An error in the sample can be an insidious thing.
      
      	* components/tree/main.c: (tree_object_destroyed),
      	(tree_make_object), (main): Removed some stray debugging stuff.
      
      	* libnautilus-extensions/Makefile.am: Got rid of the grid
      	* libnautilus-extensions/nautilus-icon-private.h: Got rid of the
      	grid.
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(keyboard_icon_reveal_timeout_callback): Took out unneeded use of
      	thread locking macros. Maybe someday I'll regret this, but we can
      	add them back then.
      	(get_all_icon_bounds): Added shared function.
      	(update_scroll_region): Renamed set_scroll_region and made it use
      	the shared function. Also got rid of grid code.
      	(resort): Got rid of grid code.
      	(lay_down_icons): Got rid of grid code.
      	(relayout): Made it lay down new icons before doing any layout
      	work. Also made sure it doesn't do the resort while stretching.
      	(reload_icon_positions): Got rid of grid code.
      	(rubberband_select): Got rid of grid code. This was the one place
      	that it might have made things a little faster but probably not
      	due to the complexity of what it was doing.
      	(rubberband_timeout_callback): Took out unneeded use of thread
      	locking macros. Maybe someday I'll regret this, but we can add
      	them back then.
      	(destroy): Got rid of grid code.
      	(world_width_changed): Got rid of grid code.
      	(nautilus_icon_container_initialize): Got rid of grid code and
      	an extra idle cycle that wasn't needed.
      	(nautilus_icon_container_clear): Got rid of grid code and added
      	code to update the scroll region on clear.
      	(icon_destroy): Got rid of grid code.
      	(assign_icon_position), (finish_adding_icon),
      	(finish_adding_new_icons), (finish_adding_new_icons_callback),
      	(nautilus_icon_container_add): Replaced old idle code with
      	something specific to adding new icons. This does the proper
      	layout for manual as well as automatic layout cases.
      
      	* libnautilus-extensions/nautilus-background.h:
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_initialize_class): Made two signals instead
      	of one. One for when the background's settings change and another
      	for when the appearance changes.
      	(nautilus_background_set_color): Emit both signals.
      	(load_image_callback): Emit only the appearance change signal.
      	(nautilus_background_set_tile_image_uri): Emit both signals.
      	(nautilus_get_widget_background): Connect to the
      	appearance_changed signal.
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(nautilus_connect_background_to_directory_metadata):
      	Connect to the settings_changed signal.
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_real_merge_menus): Connect to the
      	settings_changed signal.
      	* src/nautilus-sidebar.c: (nautilus_sidebar_update_info): Connect
      	to the appearance_changed signal.
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_set_up_background): Connect to the
      	settings_changed signal.
      
      	* HACKING: Gratuitious reformatting.
      	* RENAMING: Added notes about how we do renaming, at the request
      	of one of the hackers.
      
      	* nautilus-clean.sh: Added nautilus-tree-view to the things that
      	are killed, and made gratuitous changes to the script.
      a93b99ab
  31. 26 Jun, 2000 2 commits
    • Darin Adler's avatar
      Fixed use of hash table in here. The old code would destroy the wrong key. · f5309aed
      Darin Adler authored
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(set_metadata_eat_value): Fixed use of hash table in here. The
      	old code would destroy the wrong key. (Thanks to Ian for pointing
      	that when you insert a value into GHashTable it keeps the old key
      	instead of overwriting with the new one.)
      
      	* libnautilus-extensions/nautilus-gtk-extensions.c:
      	(nautilus_gtk_signal_connect_free_data):
      	* src/file-manager/fm-properties-window.c: (attach_value_field),
      	(create_emblems_page), (add_permissions_row_label):
      	* src/nautilus-link-set-window.c: (make_link_set_check_box):
      	* src/nautilus-property-browser.c:
      	(make_properties_from_directory_path),
      	(make_properties_from_xml_node), (make_category_link):
      	* src/nautilus-sidebar.c: (nautilus_sidebar_add_panel_items):
      	Got rid of unnecessary casts to (GtkDestroyNotify).
      f5309aed
    • Andy Hertzfeld's avatar
      implemented an xml-based general theme mechanism, and used it for the · a59d6685
      Andy Hertzfeld authored
      
      	implemented an xml-based general theme mechanism, and used it
      	for the sidebar backgrounds, which isn't quite working yet.  Added
      	xml files to our themes.
      a59d6685