1. 15 Aug, 2001 5 commits
    • Darin Adler's avatar
      A pass at cleaning up the volume monitor. Made all the details of · c4b8cdd4
      Darin Adler authored
      	NautilusVolume private.
      
      	* libnautilus-private/filesystem-attributes.xml: Changed the
      	"description" string to be named "default_volume_name" and also
      	marked it to be localized.
      
      	* libnautilus-private/nautilus-file-utilities.h:
      	* libnautilus-private/nautilus-file-utilities.c:
      	(nautilus_get_data_file_path):
      	Added a new utility function to locate a file that's either in the
      	user's directory or in the Nautilus datadir.
      
      	* src/nautilus-property-browser.c: (read_browser_xml): Use
      	nautilus_get_data_file_path.
      
      	* libnautilus-private/nautilus-trash-directory.c:
      	(get_trash_volume):
      	* libnautilus-private/nautilus-trash-monitor.c:
      	(add_one_volume_trash):
      	* src/file-manager/fm-desktop-icon-view.c: (volume_in_black_list),
      	(create_unique_volume_name), (create_mount_link),
      	(volume_unmounted_callback), (update_disks_menu):
      	* src/nautilus-application.c: (volume_mounted_callback),
      	(volume_unmounted_callback):
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_get_file_path):
      	Use only calls from the NautilusVolume public API -- no getting at
      	the structure directly. Also fix callers that were using
      	nautilus_volume_monitor_get_volume_mount_uri to correctly
      	understand that they get the mount path, not the mount URI.
      
      	* libnautilus-private/nautilus-volume-monitor.h:
      	* libnautilus-private/nautilus-volume-monitor.c:
      	(load_file_system_table): Fix storage leaks. Use the new
      	nautilus_get_data_file_path. Translate the default volume names as
      	they are loaded. Check for duplicate entries while loading the
      	table. Don't bother checking the name of the root node, since
      	there are plenty of other things about the file that we don't
      	check and there's no reason we particularly need to check that.
      	Fix some storage leaks. Free the doc, since I'm not seeing a
      	"nautilus --quit" segfault.
      	(nautilus_volume_monitor_initialize): Only initialize stuff that
      	g_new0 won't set up for us.
      	(nautilus_volume_is_removable): Rename so it's a call on
      	NautilusVolume, not the NautilusVolumeMonitor.
      	(volume_is_removable): Fix logic so we don't have to have so many
      	different calls to fclose.
      	(nautilus_volume_get_name): Rename so it's a call on
      	NautilusVolume, not the NautilusVolumeMonitor.
      	(modify_volume_name_for_display): Don't bother supplying a name if
      	passed NULL, since that won't ever be helpful the way this is used.
      	(nautilus_volume_get_target_uri): Rename so it's a call on
      	NautilusVolume, not the NautilusVolumeMonitor.
      	(nautilus_volume_should_integrate_trash): Rename so it's a call on
      	NautilusVolume, not the NautilusVolumeMonitor. Get the information
      	from the file system type, so we don't have to copy it into each
      	NautilusVolume object.
      	(nautilus_volume_get_mount_path): Rename so it's a call on
      	NautilusVolume, and don't call it a URI since it's really a path.
      	(nautilus_volume_get_device_type): New call.
      	(make_volume_name_from_path): Get the default from the file system
      	type rather than passing it in.
      	(free_mount_list): Get rid of some dumb extra code.
      	(copy_volume), (nautilus_volume_free): Update for smaller set of
      	fields.
      	(create_volume), (finish_creating_volume),
      	(finish_creating_volume_and_prepend): Restructure so we don't need
      	to keep so much stuff around in the NautilusVolume object.
      
      	* src/nautilus-first-time-druid.c:
      	(druid_set_first_time_file_flag): Some tiny tweaking.
      c4b8cdd4
    • Maciej Stachowiak's avatar
      Revert accidental commit of not quite done change. · bda50441
      Maciej Stachowiak authored
      	* components/music/Makefile.am: Revert accidental commit of not
      	quite done change.
      bda50441
    • Darin Adler's avatar
      Use a 64K buffer size instead of a 4K buffer size. · f234e681
      Darin Adler authored
      	* components/image-viewer/nautilus-image-view.c:
      	(load_image_from_stream): Use a 64K buffer size instead of a 4K
      	buffer size.
      f234e681
    • Maciej Stachowiak's avatar
      A bunch of code cleanup; stop using hidden columns in the list view and · 6e1255de
      Maciej Stachowiak authored
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_initialize), (get_song_text), (sort_list),
      	(click_column_callback), (ensure_uri_is_image),
      	(nautilus_music_view_update): A bunch of code cleanup; stop using
      	hidden columns in the list view and try to pave the way for better
      	model/view separation.
      
      	* src/nautilus-main.c (main): set DISPLAY variable to
      	canonicalized version; this is needed to make
      6e1255de
    • Seth Nickell's avatar
      Load filesystems from an XML file rather than hardcoding the various · 64ff8e32
      Seth Nickell authored
      2001-08-14  Seth Nickell  <snickell@stanford.edu>
      
      	Load filesystems from an XML file rather than hardcoding
      	the various attributes and behaviors. Some properties, such
      	as for CDDA and NFS, are still hardcoded because they require
      	actual code. This also makes it easier to add new filesystems.
      
      	* libnautilus-private/filesystem-attributes.xml
      
      	Filesystem description file.
      
      	* libnautilus-private/Makefile.am:
      
      	Add filesystem-attribute.xml to the build.
      
      	* libnautilus-private/nautilus-volume-monitor.c:
      
      	(mount_volume_prepend_filesystem):
      
      	Don't try to detect filesystem strings and associate them
      	with an enumeration type...nix the enumeration altogether
      	since its not compatible with dynamically loading the
      	filesystems.
      
      	(get_xml_path), (load_filesystem_attributes_table)
      
      	Functions for reading in filesystem-attribute.xml and
      	loading the various filesystems into a hashtable.
      
      	(nautilus_volume_monitor_initialize)
      
      	Read in the filesystem attributes table.
      
      	(get_removable_volumes), (mount_volume_deactivate),
      	(get_mount_list), (get_current_mount_list),
      	(verify_current_mount_state)
      
      	Take a file attributes hashtable, or pass one to a
      	subfunction.
      
      	(nautilus_volume_monitor_get_target_uri),
      
      	CDDA is the only system we need to deal with in an unusual
      	way. Take out a long list and just check for CDDA.
      
      	(nautilus_volume_monitor_should_integrate_trash)
      
      	Use information read from the file rather than hardcoding
      	a list of filesystems that can use trash (should be the
      	same for now).
      
      	(make_volume_name_from_path), (mount_volume_make_name)
      
      	Get name out of the filesystem table rather than hardcoding.
      
      	(mount_volume_iso9660_add)
      
      	We were deciding if a device was *really* a CDROM by
      	doing an ioctl on it to determine the drive status. This
      	is a good check...except that on systems using DevFS
      	devices can be user mountable without being user readable
      	by default. Also, on my system it fails if there's no
      	disk in the drive itself.
      
      	(mount_volume_auto_add)
      
      	Continue setting the device if its a floppy drive (eventually
      	this should probably be cleaned out too), but don't set the
      	filesystem type since we don't use the enum anymore.
      
      	(mount_volume_cdda_add)
      
      	Set as a CDDA device, but not a CDDA volume (since we don't
      	have hardcoded volume types anymore).
      
      	(mount_volume_nfs_add)
      
      	Don't set NFS type since the enum was blown away.
      
      	(create_volume)
      
      	Accept a filesystem table and set attributes read from
      	filesystem-attributes.xml if a volume's filesystem is found
      	in the table. Perhaps eventually we should just assign a
      	reference to the volume entry, but this was simpler for
      	now since some functions modify things like the description.
      
      	(copy_volume)
      
      	Deal with copying the new attributes.
      
      	* libnautilus-private/nautilus-volume-monitor.h:
      
      	Nix the filesystem enumeration. Change NAUTILUS_DEVICE_CD_ROM
      	to NAUTILUS_DEVICE_CDROM
      
      	* src/file-manager/fm-desktop-icon-view.c: (create_mount_link),
      	(update_disks_menu):
      
      	Deal with rename of NAUTILUS_DEVICE_CD_ROM
      
      	* src/nautilus-application.c: (volume_mounted_callback):
      
      	Deal with rename of NAUTILUS_DEVICE_CD_ROM
      
      	* AUTHORS:
      
      	Update E-mail address.
      
      	* configure.in:
      
      	Make "FAM not found" warning a little more serious and
      	informative. We particularly want to encourage distributors
      	to enable FAM support.
      64ff8e32
  2. 11 Aug, 2001 1 commit
    • Seth Nickell's avatar
      Trying to make nautilus volume monitor work more reliably. First step is · 8c287d3b
      Seth Nickell authored
      2001-08-11  Seth Nickell  <snickell@stanford.edu>
      
      	Trying to make nautilus volume monitor work more
      	reliably. First step is to make the codebase more
      	maintainable so I can start tracking down bugs in
      	the volume monitor more easily.
      	(I get complaints about this from friends, family, and
      	coworkers all the time, so there must be some/one bugs).
      
      	* libnautilus-private/nautilus-volume-monitor.h:
      	* libnautilus-private/nautilus-volume-monitor.c:
      	(nautilus_volume_monitor_initialize_class),
      	(nautilus_volume_monitor_get_target_uri),
      	(nautilus_volume_monitor_should_integrate_trash),
      	(mount_volume_make_name), (mount_volume_deactivate),
      	(mount_volume_generic_add), (mount_volume_prepend_filesystem):
      
      	Remove mount_volume_*_add for filesystems that do
      	effectively the same thing. This added a large amount of
      	clutter to a module that already has a lot of similar
      	functions. Add a generic function that accepts the filesystem
      	type, and change calls to use this.
      
      	Fix signal in initialize_class to be "nautilus_volume_unmount_failed"
      	rather than "nautilus_volume_unmoun_failed" (nobody was assuming
      	the broken behavior eithe, I checked, maybe this will fix something).
      
      	Renamed NAUTILUS_VOLUME_REISER to NAUTILUS_VOLUME_REISERFS
      	to maintain the naming convention the other filesystems use.
      
      	Changed "unsdos" to "umsdos" everywhere. I don't think a unsdos
      	filesystem exists, after web searches, and umsdos *is* one of
      	the basic Linux filesystems. I suspect somebody misread a filesystem
      	name browsing the kernel compilation menu or somesuch.
      
      	Removed redundant (and erroneous) check for "ufs" type filesystems
      	(the check was already listed in the if then statement above).
      8c287d3b
  3. 10 Aug, 2001 1 commit
  4. 08 Aug, 2001 2 commits
  5. 07 Aug, 2001 1 commit
  6. 06 Aug, 2001 3 commits
  7. 03 Aug, 2001 2 commits
  8. 02 Aug, 2001 1 commit
    • Michael Fleming's avatar
      Added gnome-vfs authentication dialog support. Currently works with HTTP · 77cb5a29
      Michael Fleming authored
      
              Added gnome-vfs authentication dialog support.
              Currently works with HTTP basic and proxy authentication.
      
              A bug causes the dialog to appear more than once in quick succession
              in some cases.
      
              Separate processes (eg sidebar components) that need to access
              a protected URL will also pop open their own individual dialogs
              at this point
      
              There's also no integration with Mozilla at this point, so
              Mozilla too will prompt separately.
      
              This code works against gnome-vfs head and the gnome-vfs-1-0
              branch, as well as the soon-to-be-released gnome-vfs 1.0.2
      77cb5a29
  9. 01 Aug, 2001 1 commit
  10. 31 Jul, 2001 1 commit
  11. 29 Jul, 2001 1 commit
  12. 28 Jul, 2001 1 commit
  13. 27 Jul, 2001 1 commit
    • Darin Adler's avatar
      Fixed bug 8438 (changing desktop between $HOME and .gnome-desktop · b071ed5d
      Darin Adler authored
      	breaks desktop DnD from other apps).
      
      	* src/file-manager/fm-desktop-icon-view.c:
      	(desktop_directory_changed_callback): New function to update the
      	local variable when the desktop directory changes.
      	(fm_desktop_icon_view_initialize): Set up the callback rather than
      	just setting up the global variable.
      
      	* configure.in: Fixed code to set up compile-time options. It
      	was putting the options into VFS_CFLAGS.
      b071ed5d
  14. 26 Jul, 2001 1 commit
    • Maciej Stachowiak's avatar
      Fixed bug 6776 (In-place file rename allowed (but doesn't occur) · 821fac83
      Maciej Stachowiak authored
      	at 25% zoom level):
      
      	* src/file-manager/fm-icon-view.c: (fm_icon_view_set_zoom_level):
      	Update menus since the sensitivity of "Rename" now depends on the
      	zoom level.
      	(fm_icon_view_update_menus): Disable the "Rename" item when at
      	smallest zoom level, since renaming won't happen anyway.
      821fac83
  15. 24 Jul, 2001 9 commits
  16. 23 Jul, 2001 9 commits
    • Chyla Zbigniew's avatar
      Updated Polish translation · 1e8bcd24
      Chyla Zbigniew authored
      1e8bcd24
    • Andy Hertzfeld's avatar
      changed thumbnailing to not draw the frame into the thumbnail images · 56504756
      Andy Hertzfeld authored
      
      	changed thumbnailing to not draw the frame into the
      	thumbnail images themselves anymore; instead, draw it at the time
      	they're loaded. This makes anti-aliased thumbnail variants no
      	longer necessary, so they're no longer used.  There's a cheap test so
      	old thumbnails aren't framed twice.
      
      	* libnautilus-private/nautilus-thumbnails.c: (make_thumbnail_uri),
      	(make_thumbnails), (pixel_matches_value), (pixbuf_is_framed),
      	(nautilus_thumbnail_load_framed_image):
      	don't frame the thumbnails at creation time; instead, provide
      	a routine to frame them at load time if necessary.
      
      	* libnautilus-private/nautilus-thumbnails.h:
      	added nautilus_thumbnail_load_framed_image
      
      	* libnautilus-private/nautilus-icon-factory-private.h:
      	added nautilus_icon_factory_get_thumbnail_frame
      
      	* libnautilus-private/nautilus-icon-factory.c:
      	(load_thumbnail_frames), (nautilus_icon_factory_initialize),
      	(nautilus_icon_factory_destroy), (icon_theme_changed_callback),
      	(load_icon_from_path), (load_named_icon), (load_specific_icon),
      	(nautilus_icon_factory_get_thumbnail_frame):
      	made it call nautilus_thumbnail_load_framed_image to load
      	thumbnails; made the icon factory load the thumbnail frames so it
      	doesn't have to be done repeatedly; changed how the aa flag is
      	passed around a little, although this could be cleaned up more now.
      56504756
    • Benedikt Roth's avatar
      Fix the tip for the "Delete from Trash" item in the right-click menu · 8b1d7f68
      Benedikt Roth authored
      2001-07-23 Benedikt Roth  <Benedikt.Roth@gmx.net>
      
      	* src/file-manager/fm-directory-view.c: (real_update_menus):
      	Fix the tip for the "Delete from Trash" item in the right-click menu
      8b1d7f68
    • Maciej Stachowiak's avatar
      Update the icon even when newly creating it, in case the trash state · 763194bf
      Maciej Stachowiak authored
      	* src/file-manager/fm-desktop-icon-view.c
      	(update_trash_link_and_delete_copies): Update the icon even when
      	newly creating it, in case the trash state changed while the
      	desktop was off. This fixes bug 7956 (improper Trash icon state
      	after desktop toggle )
      763194bf
    • Maciej Stachowiak's avatar
      Avoid a ref underflow. This was causing a crash noticed by Anders · 8d074785
      Maciej Stachowiak authored
      	* libnautilus-private/nautilus-directory-async.c
      	(nautilus_file_invalidate_count_and_mime_list): Avoid a ref
      	underflow. This was causing a crash noticed by Anders
      	Carlsson. I'm so embarassed!
      
      	* src/file-manager/fm-desktop-icon-view.c
      	(fm_desktop_icon_view_destroy, delayed_init): Make sure to
      	disconnect signals on destroy to avoid a possible crash when
      	turning the desktop off and back on, and not using fam.
      8d074785
    • Maciej Stachowiak's avatar
      Fix bug 5242 (Selection not kept on-screen after column resort) by · 70bf6de4
      Maciej Stachowiak authored
      	* components/music/nautilus-music-view.c (click_column_callback):
      	Fix bug 5242 (Selection not kept on-screen after column resort) by
      	scrolling the selected item into view on a resort if it's not in
      	view already.
      70bf6de4
    • Maciej Stachowiak's avatar
      Fix the remainer of bug 3769 (Music View window redraws upon clicking a · c61c49b7
      Maciej Stachowiak authored
      	* components/music/nautilus-music-view.c: (get_song_text): Fix the
      	remainer of bug 3769 (Music View window redraws upon clicking a
      	different song) by making songs with no title show up with "-" for
      	the title (I have quite a collection of broken mp3s).
      c61c49b7
    • Maciej Stachowiak's avatar
      Fix bug 5175 (Music View displays year fields of '0'.) by filtering out · 8d103fdb
      Maciej Stachowiak authored
      	* components/music/nautilus-music-view.c:
      	(read_id_tag): Fix bug 5175 (Music View displays year fields of
      	'0'.) by filtering out years that are all zeros or all spaces.
      	(filter_out_unset_year): New helper function.
      8d103fdb
    • Kjartan Maraas's avatar
      Updated Norwegian (bokml) translation. Updated Norwegian (nynorsk) · f59daaa7
      Kjartan Maraas authored
      2001-07-22  Kjartan Maraas  <kmaraas@gnome.org>
      
      	* no.po: Updated Norwegian (bokml) translation.
      	* nn.po: Updated Norwegian (nynorsk) translation.
      f59daaa7