1. 13 Dec, 2000 4 commits
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · ac2ec5b5
      Darin Adler authored
      	Fixed bug 1948 ("Open in New Window" menu item reuses existing
      	window if it exists) by separating the explicit "open in new
      	window" feature (always gives a new window) from the "open all
      	items in new windows" preference (reuses window if one with the
      	right location already exists).
      
      	* libnautilus/nautilus-view-component.idl: Added new
      	open_location_prefer_existing_window call. Renamed open_location
      	to open_location_in_this_window and open_location_in_new_window to
      	open_location_force_new_window for clarity.
      
      	* libnautilus/nautilus-view.h:
      	* libnautilus/nautilus-view.c:
      	(nautilus_view_open_location_in_this_window),
      	(nautilus_view_open_location_prefer_existing_window),
      	(nautilus_view_open_location_force_new_window):
      	* src/nautilus-view-frame-corba.c:
      	(impl_Nautilus_ViewFrame_open_location_in_this_window),
      	(impl_Nautilus_ViewFrame_open_location_prefer_existing_window),
      	(impl_Nautilus_ViewFrame_open_location_force_new_window):
      	* src/nautilus-view-frame-private.h:
      	* src/nautilus-view-frame.c:
      	(nautilus_view_frame_initialize_class),
      	(nautilus_view_frame_open_location_in_this_window),
      	(nautilus_view_frame_open_location_prefer_existing_window),
      	(nautilus_view_frame_open_location_force_new_window):
      	* src/nautilus-view-frame.h:
      	Add new call, rename old ones.
      
      	* src/file-manager/fm-directory-view.c: (open_callback): Pass parameter
      	to tell the open code to respect the "use new windows" preference.
      	(open_location): Take new WindowChoice parameter to respect preference
      	as appropriate.
      	(switch_location_and_view): Tell the code to respect the preference in
      	this case (opening from Open With).
      	(show_trash_callback): Use code that respects the preference instead of
      	always opening in this case.
      	(open_one_in_new_window): Always force a new window (used by Open
      	in New Window command).
      	(activate_callback): Pass through new WindowChoice instead of boolean.
      	(fm_directory_view_activate_file): Pass through new WindowChoice
      	instead of boolean.,
      	(fm_directory_view_activate_files): Respect the user preference if
      	opening only one file, do the "use existing window or make new one"
      	mode if opening more than one.
      
      	* src/nautilus-window-manage-views.c: (handle_unreadable_location):
      	Move check for empty location string in here.
      	(open_location): Moved the code for reusing existing windows out
      	of here. Also changed code structure to avoid redoing the
      	handle_unreadable_location check.
      	(open_location_in_this_window_callback): Renamed.
      	(open_location_prefer_existing_window_callback): Here's where
      	the code for reusing existing windows went. New callback for the
      	new call/signal.
      	(open_location_force_new_window_callback): Renamed.
      
      	* src/file-manager/fm-search-list-view.c:
      	(reveal_selected_items_callback): Change to use
      	nautilus_view_open_location_force_new_window by its new name.
      
      	* src/nautilus-window-manage-views.h: Got rid of
      	nautilus_window_open_location_in_new_window, which was public and
      	unused.
      
      	* components/adapter/nautilus-adapter.c:
      	(nautilus_adapter_open_location_callback):
      	* components/help/hyperbola-nav-index.c:
      	(hyperbola_navigation_index_select_row):
      	* components/help/hyperbola-nav-search.c:
      	(hyperbola_navigation_search_select_row):
      	* components/help/hyperbola-nav-tree.c:
      	(hyperbola_navigation_tree_select_row):
      	* components/history/nautilus-history-view.c:
      	(history_button_release):
      	* components/mozilla/nautilus-mozilla-content-view.c:
      	(mozilla_open_uri_callback), (mozilla_dom_mouse_click_callback):
      	* components/rpmview/nautilus-rpm-view.c: (go_to_button_callback):
      	* components/services/login/nautilus-view/nautilus-change-password-view.c:
      	(run_away_timer), (authn_failed), (maintenance_button_cb):
      	* components/services/summary/nautilus-view/nautilus-summary-callbacks.c:
      	(logged_in_callback), (logged_out_callback),
      	(preferences_button_cb), (forgot_password_button_cb),
      	(register_button_cb):
      	* components/services/summary/nautilus-view/nautilus-summary-dialogs.c:
      	(error_dialog_cancel_cb):
      	* components/services/summary/nautilus-view/nautilus-summary-footer.c:
      	(footer_item_clicked_callback):
      	* components/services/summary/nautilus-view/nautilus-summary-view.c:
      	(goto_service_cb), (goto_update_cb):
      	* components/text/nautilus-text-view.c: (handle_service_menu_item):
      	* components/tree/nautilus-tree-view.c: (tree_select_row_callback):
      	Change to use new nautilus_view_open_location_in_this_window
      	name. It's better because it's more explicit, but also, it's the
      	new name!
      
      	* libnautilus-extensions/nautilus-gdk-extensions.c:
      	(nautilus_gdk_window_bring_to_front): Fixed indentation.
      
      	* libnautilus-extensions/nautilus-gtk-extensions.c:
      	(nautilus_gtk_window_present): Put in a new implementation that
      	uses nautilus_gdk_window_bring_to_front instead of the old one
      	that did a hide followed by a show. Corrected an assert that
      	should have been a return_if_fail.
      ac2ec5b5
    • Arlo Rose's avatar
      Making changes to the side bar in the "Eazel" theme. Tabs will come later. · 366f425a
      Arlo Rose authored
      
              * icons/eazel/Makefile.am:
              * icons/eazel/eazel.xml:
              * icons/eazel/side_bar_image.png:
              Making changes to the side bar in the "Eazel" theme.
              Tabs will come later.
      366f425a
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 6212c377
      John Sullivan authored
      	Fixed bug 2327 (Alt-key combinations to show menus work on
      	Desktop, but shouldn't)
      
      	Had to abandon the old-Bonobo approach for this and make a
      	new-Bonobo approach.
      
      	* src/file-manager/nautilus-desktop-icon-view-ui.xml:
      	Redefine all top-level menus' labels to be "" so there won't
      	be any underline accelerator
      
      	* src/nautilus-desktop-window.c: (nautilus_desktop_window_new):
      	* src/nautilus-window-menus.c:
      	(remove_underline_accelerator_from_menu_title),
      	(nautilus_window_disable_keyboard_navigation_for_menus):
      	* src/nautilus-window.h: Remove the old now-useless trick to
      	do this.
      6212c377
    • Gene Z. Ragan's avatar
      Fixed bug 4145, Music view fails if sound device in use Fixed bug, 4903, · 9658bc5f
      Gene Z. Ragan authored
      2000-12-12  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 4145, Music view fails if sound device in use
      	Fixed bug, 4903, slider state bleeds between music views
      
      	Changed the way that the view stects availability of sound
      	hardware.  We now use a more just in time approach. If the
      	sound hardware is unavailable, a dialog is displayed with
      	a warning and some info about the problem. The downside
      	to this is that the controls always appear active.  I think
      	this is a good tradeoff. It avoids having the controls inactive
      	when the sound hardware is available, as in the case of bug
      	4145.
      
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_initialize), (get_song_text),
      	(play_current_file), (add_play_controls):
      9658bc5f
  2. 12 Dec, 2000 25 commits
    • Mike Engber's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 2422343c
      Mike Engber authored
      
      	reviewed by: John Sullivan <sullivan@eazel.com>
      
      	* src/nautilus-window-menus.c:
      	(nautilus_window_bookmarks_preference_changed_callback),
      	(nautilus_window_initialize_bookmarks_menu):
      	* src/nautilus-window-private.h:
      	* src/nautilus-window.c: (nautilus_window_destroy):
      	Added a preference remove callback - which fixes bug 5147.
      2422343c
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 1cfc4f6e
      John Sullivan authored
      	Fixed a couple of places that were causing zillions of failed
      	assertions about hash tables on boot.
      
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(create_metafile_root): Use nautilus_directory_set_metafile_contents
      	instead of setting field directly.
      	(get_file_node): Don't futz with hashtable if its NULL.
      1cfc4f6e
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 910cbea4
      John Sullivan authored
      	While investigating bug 5147, which I couldn't reproduce, I found
      	and fixed a crashing bug with similar steps.
      
      	* src/file-manager/fm-desktop-icon-view.c:
      	(fm_desktop_icon_view_destroy): remove preferences callback for
      	home_uri_changed, so we won't crash trying to execute it after the
      	desktop view has been destroyed.
      
      	Fixed bug 4226 (Non-standard text field auto-selection behavior
      	wreaks havoc with finely tuned middle-click paste feature)
      
      	The problem here was that I had done some automatic selection
      	changing on focus-in and focus-out a long time ago in an attempt
      	to make the behavior more usable for real copy/paste and tabbing.
      	Unfortunately my attempt to improve the default behavior ran afoul
      	of the hellish X middle-click-to-paste-selected-text feature that
      	is a staple of every poor X window user's life. For now, I just took
      	out my non-standard behaviors as they aren't clearly an overall
      	improvement and I hadn't even tried to deploy them across Nautilus,
      	much less across GTK.
      
      	* src/file-manager/fm-properties-window.c:
      	(name_field_focus_in): Removed this function, which used to select
      	all the text in the field.
      	(name_field_focus_out): No longer deselects contents.
      	(create_basic_page): Don't connect to focus-in signal.
      
      	* src/nautilus-bookmarks-window.c:
      	(on_text_field_focus_in_event): Removed this function, which used to
      	select all the text in the field.
      	(on_text_field_focus_out_event): No longer deselects contents.
      	(create_bookmarks_window): Don't connect to focus-in signal.
      910cbea4
    • Andy Hertzfeld's avatar
      fixed bug 4212, emblem doesn't show up when the image is a JPEG file, by · ed19a4c7
      Andy Hertzfeld authored
      
      	* libnautilus-extensions/nautilus-icon-factory.c: (cache_icon_new),
      	(load_icon_for_scaling), (scale_icon), (get_icon_from_cache),
      	(nautilus_icon_factory_get_pixbuf_for_icon),
      	(nautilus_icon_factory_get_pixbuf_for_file):
      
      	fixed bug 4212, emblem doesn't show up when the image is a JPEG
      	file, by adding ".jpg" to extensions checked in the icon factory.
      
      	Fixed bug 3208, generic icon shows up for deleted emblems, by adding
      	a "wants_default" parameter to the icon factory get_pixbuf_for_icon
      	call.  If "wants_default" is false, it returns NULL instead of the
      	generic icon.  Emblem callers pass FALSE so they don't get pixmaps
      	for deleted emblems.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_get_pixbuf):
      	added boolean parameter to get_pixbuf_for_icon call
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_update_icon):
      	added boolean parameter to get_pixbuf_for_icon call
      	* libnautilus-extensions/nautilus-icon-factory.h:
      	added "wants_default" boolean to get_pixbuf_for_icon definition
      	* src/file-manager/fm-list-view.c:
      	(fm_list_view_get_emblem_pixbufs_for_file):
      	added boolean parameter to get_pixbuf_for_icon call
      	* src/file-manager/fm-properties-window.c:
      	(create_image_widget_for_emblem):
      	added boolean parameter to get_pixbuf_for_icon call
      	* src/nautilus-sidebar-title.c: (update_emblems):
      	added boolean parameter to get_pixbuf_for_icon call
      ed19a4c7
    • Darin Adler's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 47462dc1
      Darin Adler authored
      	Fixed bug 650 (moving a large number of files is extremely slow)
      	by using a hash table to find metafile nodes given a file name.
      	Fixed bug 3410 (sorting not locale-sensitive) by making
      	nautilus_strcoll suitable for wider use and using it a lot more.
      
      	* libnautilus-extensions/nautilus-directory-private.h: Add a
      	new hash table for locating metafile nodes by file name.
      
      	* libnautilus-extensions/nautilus-directory-metafile.h: Add
      	nautilus_directory_set_metafile_contents call so the metafile
      	code will have a crack at the metafile contents right when
      	they are first read in.
      
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(get_file_node): Locate the file node using the hash table,
      	and create a hash table entry when making a new file node.
      	(destroy_xml_string_key), (nautilus_directory_metafile_destroy):
      	Destroy the hash table when the directory is destroyed.
      	(nautilus_directory_rename_file_metadata): Remove the old hash
      	table entry and make a new one when the node's name is changed.
      	(nautilus_directory_set_metafile_contents): Create the hash
      	table and populate it when the metafile is read in.
      
      	* libnautilus-extensions/nautilus-string.h:
      	* libnautilus-extensions/nautilus-string.c: (nautilus_strcoll):
      	Treat a locale that can't be fetched by setlocale the same as
      	locale "C" and "POSIX", fall back on strcmp if strcoll says two
      	strings are equal, so that only identical strings get a 0.
      	(nautilus_strcmp_compare_func): New name for nautilus_str_compare.
      	(nautilus_strcoll_compare_func): New function.
      	(nautilus_strcasecmp_compare_func): New name for nautilus_istr_compare.
      
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	(nautilus_g_str_list_copy): Removed an unnecessary check for NULL.
      	(nautilus_g_str_list_alphabetize): Replaced the old sort calls
      	with this single call. It sorts in a locale-sensitive way, using
      	nautilus_strcoll.
      
      	* libnautilus-extensions/nautilus-file.c: (compare_by_name),
      	(compare_by_directory_name), (compare_by_emblems),
      	(compare_by_type), (nautilus_file_compare_name): Use
      	nautilus_strcoll instead of nautilus_strcmp_case_breaks_ties so we
      	use local sorting conventions in locales other than "C" and
      	"POSIX".
      	(nautilus_get_user_names), (nautilus_get_group_names_including):
      	(sort_keyword_list_and_remove_duplicates): Use the new
      	nautilus_g_str_list_alphabetize to sort by locale-specific
      	conventions.
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(compare_icons_by_name): Use nautilus_strcoll instead of
      	nautilus_strcmp_case_breaks_ties so we use local sorting
      	conventions in locales other than "C" and "POSIX".
      
      	* src/file-manager/fm-properties-window.c: (get_property_names):
      	Use the new nautilus_g_str_list_alphabetize
      	* src/nautilus-window-manage-views.c: (change_selection): Use the
      	new nautilus_g_str_list_alphabetize
      	* src/nautilus-window.c: (load_view_as_menu_callback): Use the new
      	nautilus_g_str_list_alphabetize
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(metafile_read_done_callback),
      	(nautilus_directory_set_up_request): Use nautilus_str_compare
      	under its new name, nautilus_strcmp_compare_func.
      
      	* components/services/install/command-line/.cvsignore: Added
      	eazel-test-types, a new generated file.
      
      	* libnautilus-extensions/nautilus-string-list.c:
      	(nautilus_string_list_new): Use nautilus_str_compare and
      	nautilus_istr_compare under their new names,
      	nautilus_strcmp_compare_func and nautilus_strcasecmp_compare_func.
      
      	* libnautilus-extensions/nautilus-xml-extensions.c:
      	(nautilus_xml_get_child_by_name): Fixed indenting.
      47462dc1
    • Kjartan Maraas's avatar
      Updated Norwegian (bokmål) translation. Updated this. · 718bc535
      Kjartan Maraas authored
      2000-12-11  Kjartan Maraas  <kmaraas@gnome.org>
      
      	* no.po: Updated Norwegian (bokmål) translation.
      	* POTFILES.in: Updated this.
      718bc535
    • Gene Z. Ragan's avatar
      Fixed bug 4901, Music view displays "()" when MP3 lacks Year tag · fd866aac
      Gene Z. Ragan authored
      2000-12-12  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 4901, Music view displays "()" when MP3 lacks
      	Year tag
      
      	* components/music/nautilus-music-view.c: (get_song_text),
      	(read_id_tag):
      	Don't display Year parentheses if year tad is absent or empty
      
      	* components/music/mpg123.c: (mpg123_id3v1_to_id3v2):
      	* components/music/mpg123.h:
      	More cleanup to support ID3v2 tags. This fixes breakage
      	in displaying ID3v1 track numbers.
      fd866aac
    • Maciej Stachowiak's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 3458b96e
      Maciej Stachowiak authored
      	Improve New Window performance when the tree view is enabled, to
      	partially address bug 4922 (Opening new windows is really slow
      	when the tree view is enabled). This affects only the New Window
      	case, not the initial window. Here's some timings before and after
      	on my laptop with a bunch of stuff expanded (times in seconds):
      
      	                          First window    New window
      	Tree View Off                  8              5
      	w/ Tree Before My Change      16              37
      	w/ Tree After My Change       16	      20
      
      	I made this change by altering tree view semantics slightly. The
      	tree view used to do a force reload any time it expanded a
      	directory. Now it does a normal load the first time any given
      	directory is expanded (as at startup, or when you first expand the
      	node), but a force reload on subsequent collapse and
      	expansion. This is more in line with the way the rest of Nautilus
      	works.
      
      	* components/tree/nautilus-tree-expansion-state.h,
      	components/tree/nautilus-tree-expansion-state.c:
      	(nautilus_tree_expansion_state_was_ever_expanded): New function to
      	see if a node was ever expanded. Being initially expanded does not
      	count; only being expanded through an API call to
      	`nautilus_tree_expansion_state_expand_node' does.
      	(nautilus_tree_expansion_state_load_foreach_callback,
      	nautilus_tree_expansion_state_initialize,
      	nautilus_tree_expansion_state_destroy,
      	nautilus_tree_expansion_state_expand_node_internal,
      	nautilus_tree_expansion_state_expand_node): Adjusted to track
      	"was_ever_expanded" property right.
      
      	* components/tree/nautilus-tree-model.h,
      	components/tree/nautilus-tree-model.c
      	(nautilus_tree_model_monitor_node): Add force_reload parameter.
      	(nautilus_tree_model_node_begin_monitoring_no_connect): New helper
      	function.
      	(nautilus_tree_model_node_begin_monitoring,
      	nautilus_tree_model_node_end_monitoring): Slightly adjusted helper
      	functions.
      
      	* components/tree/nautilus-tree-view.c:
      	(filtering_changed_callback): Do a reload of the whole tree, but
      	not a force reload.
      	(expand_uri_sequence_and_select_end): Simplify logic a bit.
      	(expand_node_for_file): Force reload only if this node has been
      	expanded before.
      	(reload_model_node, reload_model_node_recursive,
      	reload_whole_tree): Make force reload an option.
      3458b96e
    • Maciej Stachowiak's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 9961215d
      Maciej Stachowiak authored
      	Fix an infinite loop problem that my last change caused:
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(activation_uri_read_done): Remove setting of
      	activation_uri_is_up_to_date to TRUE
      	(activation_uri_done): and move it here, because this function
      	gets called directly for files that are not nautilus or gmc links,
      	as well as being called from activation_uri_done.
      
      	* components/services/install/command-line/.cvsignore: Add
      	eazel-softcat
      9961215d
    • Eskil Heyn Olsen's avatar
      Stupid stupid stupid mistake in the conditionals. · c75c2ff6
      Eskil Heyn Olsen authored
      
      	* components/services/install/lib/Makefile.am:
      	Stupid stupid stupid mistake in the conditionals.
      c75c2ff6
    • Andy Hertzfeld's avatar
      fixed bug 2390, uri-activating security hole, by following Frank's · 285823fa
      Andy Hertzfeld authored
      
      	* src/file-manager/fm-directory-view.c: (activate_callback):
      	fixed bug 2390, uri-activating security hole, by following
      	Frank's recommendation, which is to not allow any parameters
      	to the launch command, which is enforced by using execlp
      	instead of system.
      285823fa
    • Eskil Heyn Olsen's avatar
      Same as last · f781a28d
      Eskil Heyn Olsen authored
      f781a28d
    • Eskil Heyn Olsen's avatar
      Not reviewed, I have no buddies... · 604190ea
      Eskil Heyn Olsen authored
      
      	Not reviewed, I have no buddies...
      
      	* components/services/install/lib/Makefile.am:
      	* configure.in:
      	automake conditionals are a complete joke.
      604190ea
    • Eskil Heyn Olsen's avatar
      Fixed the types, now back to automakes lack of conditionals... · efd5ecac
      Eskil Heyn Olsen authored
      	* components/services/install/lib/eazel-package-system-rpm3-private
      	.h:
      	* components/services/install/lib/eazel-package-system-rpm3.c:
      	(eazel_package_system_rpm3_query):
      	Fixed the types, now back to automakes lack of conditionals...
      efd5ecac
    • Eskil Heyn Olsen's avatar
      automake conditionals are figments of your imagination. · 3c240cbe
      Eskil Heyn Olsen authored
      	* components/services/install/lib/Makefile.am:
      	automake conditionals are figments of your imagination.
      
      	* configure.in:
      	More rpmcheck voodoo, might even make this compile on rh62 agains.
      
      	* ChangeLog
      	Comments about changes... duh
      3c240cbe
    • Maciej Stachowiak's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 9b17b7cf
      Maciej Stachowiak authored
      	Fix bug 4919 (Tree view crashes when you expand and collapse the
      	root node). I did this by changing the design of file attribute
      	forgetting, which I implemented recently - now when you forget an
      	attribute, it is merely marked out of date, not thrown away; the
      	old value is still available until the fresh value is actually
      	loaded. This fixes other potential UI problems with the old
      	approach but I am not sure if bugs were filed for those.
      
      	* libnautilus-extensions/nautilus-file-private.h: Added new
      	is_up_to_date booleans, converted all booleans and the
      	RequestStatus enum to bitfields. This saved 200-300k or so for me
      	on runs of Nautilus with the tree view on and expanded a lot.
      
      	* libnautilus-extensions/nautilus-file.h,
      	libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_invalidate_attributes_internal,
      	nautilus_file_invalidate_attributes,
      	nautilus_file_invalidate_all_attributes): Renamed to match new
      	semantics.
      	(update_info_internal): Mark file info up to date.
      	(invalidate_directory_count), (invalidate_deep_counts),
      	(invalidate_mime_list), (invalidate_top_left_text),
      	(invalidate_file_info), (invalidate_activation_uri): renamed from
      	forget_*, and changed to only mark the attributes invalid, not
      	actually throw them out.
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(lacks_directory_count, lacks_top_left, lacks_info,
      	lacks_mime_list, lacks_activation_uri): Check _is_up_to_date bit
      	for relevant attribute, not got_ or _failed bits. If the info is
      	out of date, we want to retry eve if we already got it or it
      	already failed.
      	(directory_count_callback, mime_list_callback,
      	top_left_read_callback, get_info_callback,
      	activation_uri_read_done): Mark corresponding attributes up to
      	date.
      	(dequeue_pending_idle_callback): Mark directory_count and
      	mime_list up to date if appropriate.
      	(file_info_start): Mark file info up to date on invalid URI error.
      	(nautilus_directory_invalidate_counts): Mark directory count and
      	mime list out of date, but do not forget them.
      
      	(nautilus_directory_invalidate_file_attributes): Renamed.
      	(nautilus_directory_force_reload): Deal with rename.
      	(cancel_loading_attributes,
      	nautilus_directory_cancel_loading_file_attributes): Replace forget
      	with invalidate in some comments.
      
      	* libnautilus-extensions/nautilus-link.c
      	(forget_file_activation_uri): Handle function renames.
      	* src/nautilus-window-manage-views.c
      	(nautilus_window_begin_location_change): Likewise
      9b17b7cf
    • Eskil Heyn Olsen's avatar
      Created a private part for EazelPackageSystemRpm3 · 1b563955
      Eskil Heyn Olsen authored
      
      	* components/services/install/lib/eazel-package-system-rpm3-private
      	.h:
      	* components/services/install/lib/eazel-package-system-rpm3.h:
      	* components/services/install/lib/eazel-package-system-rpm3.c:
      	(make_rpm_argument_list), (eazel_package_system_rpm3_create_dbs),
      	(rpm_open_db), (eazel_package_system_rpm3_open_dbs),
      	(eazel_package_system_rpm3_close_dbs),
      	(eazel_package_system_rpm3_free_dbs),
      	(eazel_package_system_rpm3_query_impl),
      	(eazel_package_system_rpm3_query_substr),
      	(eazel_package_system_rpm3_query_requires),
      	(eazel_package_system_rpm3_query),
      	(eazel_package_system_rpm3_finalize),
      	(eazel_package_system_rpm3_initialize),
      	(eazel_package_system_rpm3_new):
      	Created a private part for EazelPackageSystemRpm3
      
      	* components/services/install/lib/eazel-install-rpm-glue.c:
      	(eazel_install_do_rpm_dependency_check):
      	Fondle the private parts of EazelPackageSystemRpm3 (eew,
      	can't wait to get rid of this code).
      
      	* components/services/install/lib/eazel-package-system-rpm4.h:
      	* components/services/install/lib/eazel-package-system-rpm4.c:
      	(eazel_package_system_rpm4_query_foreach),
      	(eazel_package_system_rpm4_finalize),
      	(eazel_package_system_rpm4_initialize),
      	(eazel_package_system_rpm4_new),
      	(eazel_package_system_implementation):
      	Began hacking on the missing RPM4 pieces.
      1b563955
    • Gene Z. Ragan's avatar
      Fixed bug 4900, Nautilus doesn't support ID3 v2.x tags · 0b371e17
      Gene Z. Ragan authored
      2000-12-11  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 4900, Nautilus doesn't support ID3 v2.x tags
      
      	* components/music/mpg123.c:
      	* components/music/mpg123.h:
      	* components/music/nautilus-music-view.c: (read_id_tag):
      	Add support for both v1 and v2 ID3 tags.
      0b371e17
    • Christian Rose's avatar
      Updated Swedish translation. · c4d87226
      Christian Rose authored
      c4d87226
    • Eskil Heyn Olsen's avatar
      Blabla about rpm 4 on redhat 7.0 · fd6746a0
      Eskil Heyn Olsen authored
      	* README:
      	Blabla about rpm 4 on redhat 7.0
      
      	* configure.in:
      	* nautilus.spec.in:
      	configure now carves the rpm version found into the spec file as a
      	requirement.
      fd6746a0
    • Michael Fleming's avatar
      bugzilla.eazel.com 5035 · 46715d92
      Michael Fleming authored
      	* components/mozilla/main.c: (main):
      	* src/nautilus-window-service-ui.c: (goto_online_storage),
      	(goto_software_catalog):
      
      	bugzilla.eazel.com 5035
      
      	removed ammonite_shutdown call, ammonite_init is now resiliant
      	to multiple calls and registers an atexit function.
      46715d92
    • John Sullivan's avatar
      Doh! Said "too wide" when I meant "too narrow" in last ChangeLog entry, thus · d5a13d87
      John Sullivan authored
      further confusing an already tangled issue.
      d5a13d87
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · ed5bab01
      Gene Z. Ragan authored
      2000-12-11  Gene Z. Ragan  <gzr@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	Fixed bug 3818, Sorting of album is case insensitive
      
      	* libnautilus-extensions/nautilus-string.c:
      	* libnautilus-extensions/nautilus-string.h:
      	(nautilus_strcmp_case_breaks_ties), (nautilus_strcoll):
      	New function that wraps strcoll. It checks the locale and if it is
      	specific, uses strcoll. If the locale is generic "C" or "POSIX",
      	sorting is done using nautilus_strcmp_case_breaks_ties.
      
      
      	Fixed bug 5126, Press "Pause" and "Play", music view returns
      	to start of track.
      
      	* components/music/nautilus-music-view.c: (selection_callback),
      	(value_changed_callback), (sort_by_title), (sort_by_artist),
      	(sort_by_year), (play_button_callback), (pause_button_callback),
      	(get_player_state):
      	Some state machine logic cleanup to fix bug 5216.
      ed5bab01
    • John Sullivan's avatar
      Added reviewer name · bcd7ca3f
      John Sullivan authored
      bcd7ca3f
    • John Sullivan's avatar
      Fixed bug 4820 (default Nautilus window too wide; web · 5a324986
      John Sullivan authored
      	pages look bad)
      
      	* src/nautilus-window-private.h: Changed
      	NAUTILUS_WINDOW_DEFAULT_WIDTH from 700 to 800. Read the
      	bug report for some of the rationale discussion.
      5a324986
  3. 11 Dec, 2000 11 commits
    • Mike Engber's avatar
      Fixed dragging a new background image onto the dekstop so that it; writes · 0e6fab85
      Mike Engber authored
      
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_set_image_placement_no_emit),
      	(nautilus_background_set_image_placement),
      	(nautilus_background_receive_dropped_background_image):
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(nautilus_file_background_get_default_settings),
      	(nautilus_file_background_write_desktop_settings):
      	Fixed dragging a new background image onto the dekstop
      	so that it; writes out the new color (white) instead of
      	leaving the old, wrong, color setting; sets the image
      	placement to tiled, since all Nautilus images are
      	currently meant to be tiled. Bugs 3477 & 3022.
      0e6fab85
    • Eskil Heyn Olsen's avatar
      reviewed by: A donkey with a rather large shrubbery · ab3d18e8
      Eskil Heyn Olsen authored
      
      	reviewed by: A donkey with a rather large shrubbery
      
      	* components/rpmview/Makefile.am:
      	* components/rpmview/nautilus-rpm-verify-window.c:
      	(nautilus_rpm_verify_window_update_message):
      	* components/services/install/command-line/Makefile.am:
      	* components/services/install/command-line/eazel-test-packsys.c:
      	(main):
      	* components/services/install/lib/Makefile.am:
      	* components/services/install/lib/eazel-install-rpm-glue.c:
      	* components/services/install/lib/eazel-package-system-rpm3.c:
      	(rpm_create_db), (eazel_package_system_rpm3_query):
      	* components/services/install/lib/eazel-package-system-rpm4.c:
      	(eazel_package_system_rpm4_finalize),
      	(eazel_package_system_rpm4_new):
      	* components/services/install/lib/eazel-package-system-types.c:
      	(packagedata_list_prune):
      	* components/services/install/lib/eazel-package-system.c:
      	(eazel_package_system_load_implementation):
      	* components/services/install/nautilus-view/Makefile.am:
      	* components/services/install/server/Makefile.am:
      	Muy untested RedHat 7.0/RPM4 related stuff. Let's watcht the build
      	blow up.
      
      	* acconfig.h:
      	HAVE_RPM_x0 for different rpm.s
      
      	* configure.in:
      	More weird rpm checks
      
      	* nautilus.spec.in
      	No more libeazelsoftcat
      ab3d18e8
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · c415a8e0
      Darin Adler authored
      	Fixed bug 5112 (Segfault on startup using non C locale). The error
      	was caused by localized text making it through bonobo to
      	gnome-xml, which only happened because we were using an incorrect
      	attribute name.
      
      	* libnautilus-extensions/nautilus-bonobo-extensions.c:
      	* libnautilus-extensions/nautilus-bonobo-extensions.h:
      	Removed nautilus_bonobo_set_description because there is no
      	attribute named "description" any more. It's now "tip".
      
      	* src/file-manager/fm-directory-view.c: (real_update_menus):
      	Use set_tip instead of set_description.
      
      	Another cut at the placeholder changes. I caught one problem and
      	John caught some others when he reviewed my last check-in.
      
      	* src/file-manager/nautilus-directory-view-ui.xml:
      	* src/file-manager/nautilus-icon-view-ui.xml:
      	* src/nautilus-service-ui.xml:
      	Removed some "delimit" and added others. Only the file that
      	actually defines a placeholder should use a delimit, and you must
      	always use a delimit when defining the placeholder.
      c415a8e0
    • J Shane Culpepper's avatar
      reviewed by: <eskil@eazel.com> · 25107f9c
      J Shane Culpepper authored
      2000-12-11  J Shane Culpepper  <pepper@eazel.com>
      
      	reviewed by: <eskil@eazel.com>
      
      	* components/services/install/lib/Makefile.am:
      
      	Minor Makefile fix for Eskil.
      25107f9c
    • Darin Adler's avatar
      Changed all placeholders that are not supposed to be "transparent" to use · 89c60f92
      Darin Adler authored
      	* src/file-manager/nautilus-directory-view-ui.xml:
      	* src/file-manager/nautilus-icon-view-ui.xml:
      	* src/nautilus-service-ui.xml:
      	* src/nautilus-shell-ui.xml:
      	Changed all placeholders that are not supposed to be "transparent"
      	to use an explict 'delimit="none"' to make it clear to the bonobo
      	merging code that they are not transparent. This subtle rule about
      	the 2 different kinds of placeholder resulted in a number of bugs
      	that were then "fixed" by a Bonobo change that was then rolled out.
      89c60f92
    • John Sullivan's avatar
      I broke the Arlo theme with my earlier checkin by changing references to · 6710b02d
      John Sullivan authored
      	* icons/arlo/arlo.xml: I broke the Arlo theme with my earlier
      	checkin by changing references to ./backgrounds to ./patterns;
      	this changes them back. ./backgrounds is a directory inside the
      	Arlo theme folder, whose name has not been changed.
      6710b02d
    • Gene Z. Ragan's avatar
      Fixed bug 3767, Click through MP3s, multiple MP3s often selected Fixed bug · 6ceaf265
      Gene Z. Ragan authored
      2000-12-11  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 3767, Click through MP3s, multiple MP3s often selected
      	Fixed bug 2263, Scroll in music view, text redrawn on top
      	of self
      
      	Both of these bugs are caused by a bug in GtkCList.  There
      	is a case where the gcs are set to invalid. I work around
      	this by queueing redraws when a new item is selected and
      	when the adjustment is changed during scrolling.
      
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_initialize), (selection_callback),
      	(value_changed_callback):
      6ceaf265
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 19804290
      John Sullivan authored
      	Terminology change -- the window & menu item formerly known
      	as "Customization" are now known as "Backgrounds and Emblems";
      	the swatches of image formerly known as "backgrounds" are
      	now known as "patterns".
      
      	After 1.0 if this window acquires more varied content we will
      	have to redo the menu item & window label, though we will
      	continue to distinguish between "backgrounds" and "patterns",
      	since "backgrounds" encompasses colors as well as images.
      
      	Note that this change will only appear in full (and your
      	"Backgrounds and Emblems" window work in full) after you've
      	deleted your ~/.nautilus directory and let Nautilus make you
      	a new one.
      
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	(file_opened_callback): Set vfs_handle to NULL on failure.
      	(load_done): Don't try to close pixbuf loader if it's NULL.
      	These two bugs were flushed out by a temporary state on my
      	machine where the theme was using a non-existent file for
      	its background image.
      
      	* data/backgrounds/Makefile.am: removed this file, as well as
      	all the image files in this directory.
      
      	* data/patterns/.cvsignore:
      	* data/patterns/Makefile.am: New files, copied from data/backgrounds.
      	Also copied over all image files from data/backgrounds, which is now
      	obsolete.
      
      	* data/Makefile.am: Changed "backgrounds" subdir to "patterns"
      
      	* configure.in: changed data/backgrounds/Makefile to
      	data/patterns/Makefile
      
      	* nautilus.spec.in: Changed regular expressions with "backgrounds"
      	to use "patterns"
      
      	* data/browser.xml: Changed "background" to "pattern" in the
      	terminology in this file, which gets installed into ~/.nautilus.
      	You have to remove your ~/.nautilus to get a fresh one of these;
      	without doing so the "Backgrounds and Emblems" window will be
      	confused (won't crash, will use wrong terminology and sometimes
      	have blank content).
      
      	* icons/ardmore/ardmore.xml:
      	* icons/arlo/arlo.xml:
      	* icons/default.xml:
      	* icons/eazel/eazel.xml:
      	* icons/gnome/gnome.xml:
      	* icons/vector/vector.xml:
      	* icons/villanova/villanova.xml: Changed "backgrounds" directory
      	references to "patterns"
      
      	* libnautilus-extensions/nautilus-customization-data.h:
      	* libnautilus-extensions/nautilus-customization-data.c:
      	(nautilus_customization_data_new),
      	(nautilus_customization_data_get_next_element_for_display),
      	(nautilus_customization_data_destroy),
      	(nautilus_customization_make_pattern_chit): Change "background" to
      	"pattern" in many places, including one public function name.
      
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_initialize),
      	(nautilus_property_browser_drag_data_get), (make_drag_image),
      	(make_color_drag_image), (remove_pattern), (remove_emblem),
      	(nautilus_property_browser_remove_element),
      	(add_pattern_to_browser), (add_new_pattern),
      	(add_new_button_callback), (element_clicked_callback),
      	(make_properties_from_directories), (add_reset_property),
      	(nautilus_property_browser_update_contents),
      	(nautilus_property_browser_set_category): Change "background" to
      	"pattern" in many places. Also change window title from
      	"Customization Options" to "Backgrounds and Emblems".
      
      	* src/nautilus-shell-ui.xml: Change "Customization..." to
      	"Backgrounds and Emblems...".
      
      	* test/test-nautilus-background.c: (main):
      	* test/test-nautilus-font.c: (create_named_background):
      	* test/test-nautilus-label.c:
      	(widget_set_nautilus_background_image): Changed test code that was
      	using sample images from backgrounds directory to look in patterns
      	directory instead.
      19804290
    • Gene Z. Ragan's avatar
      Fixed bug 2242, fstat /etc/mtab to check if needs to reread (for speed) · a9963ace
      Gene Z. Ragan authored
      2000-12-11  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 2242, fstat /etc/mtab to check if needs
      	to reread (for speed)
      
      	I now use a read of /proc/mounts. This is not only faster, but
      	it avoids a read to disk thus saving power for portable users.
      
      	* libnautilus-extensions/nautilus-volume-monitor.c: (find_volumes):
      a9963ace
    • Ramiro Estrugo's avatar
      Move us to use gconf from a stable branch (gconf-1-0). · b3b16ba6
      Ramiro Estrugo authored
      	* README:
      	Move us to use gconf from a stable branch (gconf-1-0).
      b3b16ba6
    • Kjartan Maraas's avatar
      Updated Norwegian (bokml) translation. · 97a90895
      Kjartan Maraas authored
      2000-12-11  Kjartan Maraas  <kmaraas@gnome.org>
      
      	* no.po: Updated Norwegian (bokml) translation.
      97a90895