1. 30 May, 2000 2 commits
    • Ramiro Estrugo's avatar
      Change preferences startup code to occur in only one place. · 9a05e06f
      Ramiro Estrugo authored
      * components/history/nautilus-history-view.c: (main):
      * libnautilus-extensions/nautilus-global-preferences.c:
      (nautilus_global_preferences_startup):
      * libnautilus-extensions/nautilus-global-preferences.h:
      * src/nautilus-application.c: (nautilus_app_class_init):
      * src/nautilus-main.c: (main):
      
      Change preferences startup code to occur in only one place.
      9a05e06f
    • Andy Hertzfeld's avatar
      implemented task 259, simple UI for previewing sounds, by making the icon · d11a03fb
      Andy Hertzfeld authored
      
              implemented task 259, simple UI for previewing sounds, by making the
      	icon container emit a preview signal when an icon is moused-over.
      	Connect the signal in fm-icon-view, where we inspect the type.
      	For now we just support mp3s, but more sound types are coming soon,
      	and the door's open for other types of previewing.  Use a timeout
      	task to provide an adjustable delay before playing.
      d11a03fb
  2. 29 May, 2000 9 commits
    • John Sullivan's avatar
      Removed unused variable. · 17b8049c
      John Sullivan authored
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_drag_drop): Removed unused variable.
      17b8049c
    • Pavel Cisler's avatar
      Start splitting out drag&drop code common between icon view and list view · 1356a678
      Pavel Cisler authored
      2000-05-29  Pavel Cisler <pavel@eazel.com>
      
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/nautilus-drag.c:
      	* libnautilus-extensions/nautilus-drag.h:
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	* libnautilus-extensions/nautilus-icon-dnd.h:
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_drag_selection_item_new), (drag_selection_item_destroy),
      	(nautilus_drag_destroy_selection_list),
      	(nautilus_drag_build_selection_list),
      	(create_selection_shadow),
      	(nautilus_icon_container_dropped_icon_feedback),
      	(drag_data_received_callback),
      	(nautilus_icon_container_ensure_drag_data), (drag_end_callback),
      	(nautilus_icon_container_selection_items_local),
      	(nautilus_icon_canvas_item_can_accept_items), (handle_local_move),
      	(handle_nonlocal_move),
      	(nautilus_icon_container_receive_dropped_icons),
      	(nautilus_icon_container_free_drag_data), (nautilus_icon_dnd_fini),
      	(drag_drop_callback), (nautilus_list_initialize), (nautilus_list_drag_end),
      	(nautilus_list_drag_leave), (nautilus_list_drag_drop),
      	(nautilus_list_drag_data_received):
      	Start splitting out drag&drop code common between icon view and list view
      	into a new file.
      	Start adding drag&drop calls to list view.
      	Bunch of renamings.
      1356a678
    • Ramiro Estrugo's avatar
      New function to access the index for a given string. · 2923a788
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-string-list.c:
      (nautilus_string_list_get_index_for_string),
      (nautilus_self_check_string_list):
      * libnautilus-extensions/nautilus-string-list.h:
      New function to access the index for a given string.
      2923a788
    • Ramiro Estrugo's avatar
      Add preference for filename fonts. Not wired up to anything yet. · 428bf455
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-global-preferences.c:
      (global_preferences_create_dialog),
      (global_preferences_register_for_ui):
      * libnautilus-extensions/nautilus-global-preferences.h:
      
      Add preference for filename fonts.  Not wired up to anything yet.
      
      * nautilus-widgets/nautilus-preferences-item.c,
      (preferences_item_construct),
      (preferences_item_create_font_family),
      (enum_radio_group_changed_callback),
      (boolean_button_toggled_callback), (font_family_changed_callback):
      * nautilus-widgets/nautilus-preferences-item.h:
      
      Add UI support for choosing a font family via preferences.
      
      * nautilus-widgets/nautilus-string-picker.c:
      (nautilus_string_picker_initialize),
      (nautilus_string_picker_destroy),
      (nautilus_string_picker_set_string_list),
      (nautilus_string_picker_get_text),
      (nautilus_string_picker_set_text):
      * nautilus-widgets/nautilus-string-picker.h:
      
      Add methods to set/get the current text.  Keep track of the string
      list ourselves so that we dont have to peek/poke into internal
      stuff in the gtkcombo.
      428bf455
    • Ramiro Estrugo's avatar
      nautilus-widgets/nautilus-string-picker.c, New widget to pick a string · 7b4e5be3
      Ramiro Estrugo authored
      * nautilus-widgets/nautilus-string-picker.c,
      * nautilus-widgets/nautilus-string-picker.h:
      New widget to pick a string from a list.
      
      * nautilus-widgets/test-nautilus-preferences.c:
      New test program.  Test prefrences things.
      
      * nautilus-widgets/test-nautilus-widgets.c:
      Remove preference tests.  Test only non preference widgetry.
      
      * nautilus-widgets/Makefile.am,
      * nautilus-widgets/.cvsignore:
      Add test-nautilus-preferences.
      7b4e5be3
    • Ramiro Estrugo's avatar
      libnautilus-extensions/nautilus-string-list.h, New function to return the · b6046f5e
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-string-list.h,
      * libnautilus-extensions/nautilus-string-list.c:
      (nautilus_string_list_as_g_list): New function to return the
      string list as a GList.
      b6046f5e
    • Ramiro Estrugo's avatar
      Remove unneeded inclusion of nautilus-string-list.h · 7de61352
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-global-preferences.h:
      
      Remove unneeded inclusion of nautilus-string-list.h
      
      * libnautilus-extensions/nautilus-global-preferences.c:
      
      Fix a user visible typo in appearance/graphics.
      Add a better description for the sidebar panels pane (bug 304)
      7de61352
    • Andy Hertzfeld's avatar
      added preference for Susan's alternative toolbar icons, which still · 60f644a4
      Andy Hertzfeld authored
      
              added preference for Susan's alternative toolbar icons, which still
      	default to the standard Gnome ones.
      60f644a4
    • Ramiro Estrugo's avatar
      Make sure the preference values are indeed different than the · 69748988
      Ramiro Estrugo authored
      currently stored ones.  Otherwise, bogus callbacks get emitted
      causing innefecient (and unneeded!) things such as directories
      reloading.
      69748988
  3. 28 May, 2000 1 commit
    • Pavel Cisler's avatar
      Used the fixed-up gnome_vfs_shutdown to properly synchronize with GnomeVFS · 3bc14c44
      Pavel Cisler authored
      2000-05-27  Pavel Cisler  <pavel@eazel.com>
      
      	* src/nautilus-application.c: (nautilus_app_quit):
      	Used the fixed-up gnome_vfs_shutdown to properly synchronize
      	with GnomeVFS threads that are still finishing up. Got rid of
      	nautilus_app_real_quit and the other hacky code that I used
      	to do this before gnome_vfs_shutdown was working properly.
      	Got rid of a bunch of FIXMEs that are now take care of.
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(cancel_directory_counts), (top_left_read_close),
      	(cancel_top_left_read), (nautilus_metafile_read_cancel),
      	(start_getting_directory_counts), (start_getting_top_lefts):
      	Added cancel calls to the different GnomeVFS async tasks that
      	can be running when opening a Nautilus window, called them
      	from the NautilusDirectory destroy call.
      
      	Nautilus now shuts down GnomeVFS jobs cleanly during a quit.
      	There is still a problem where in some cases it will take a
      	while before the async jobs go away. This seems to be because
      	the corresponding NautilusDirectory doesn't get destroyed right
      	away when a window is closed. I need to get Darin to help me fix
      	this.
      3bc14c44
  4. 27 May, 2000 4 commits
    • Maciej Stachowiak's avatar
      Removed these unused files. Remove them from the build. · 6b25b672
      Maciej Stachowiak authored
      	* libnautilus-extensions/nautilus-scroll-frame.c,
      	libnautilus-extensions/nautilus-scroll-frame.h: Removed these
      	unused files.
      	* libnautilus-extensions/Makefile.am: Remove them from the build.
      6b25b672
    • Maciej Stachowiak's avatar
      components/history/ntl-history-view.c -> · a15fd9f8
      Maciej Stachowiak authored
      	* Renamed files as follows, as per RENAMING:
      	components/history/ntl-history-view.c -> components/history/nautilus-history-view.c
      	components/history/ntl-history-view.oafinfo -> components/history/nautilus-history-view.oafinfo
      	components/notes/ntl-notes.c -> components/notes/nautilus-notes.c
      	components/notes/ntl-notes.oafinfo -> components/notes/nautilus-notes.oafinfo
      	libnautilus-extensions/gtkscrollframe.c -> libnautilus-extensions/nautilus-scroll-frame.c
      	libnautilus-extensions/gtkscrollframe.h -> libnautilus-extensions/nautilus-scroll-frame.h
      	libnautilus/nautilus-view-frame.c -> libnautilus/nautilus-view.c
      	libnautilus/nautilus-view-frame.h -> libnautilus/nautilus-view.h
      	src/nautilus-index-tabs.c -> src/nautilus-sidebar-tabs.c
      	src/nautilus-index-tabs.h -> src/nautilus-sidebar-tabs.h
      	src/nautilus-index-title.c -> src/nautilus-sidebar-title.c
      	src/nautilus-index-title.h -> src/nautilus-sidebar-title.h
      	src/nautilus-zoomable-frame-svr.c -> src/nautilus-zoomable-frame-corba.c
      	src/ntl-app.c -> src/nautilus-application.c
      	src/ntl-app.h -> src/nautilus-application.h
      	src/ntl-index-panel.c -> src/nautilus-sidebar.c
      	src/ntl-index-panel.h -> src/nautilus-sidebar.h
      	src/ntl-main.c -> src/nautilus-main.c
      	src/ntl-miniicon.c -> libnautilus-extensions/nautilus-mini-icon.c
      	src/ntl-miniicon.h -> libnautilus-extensions/nautilus-mini-icon.h
      	src/ntl-uri-map.c -> src/nautilus-applicable-views.c
      	src/ntl-uri-map.h -> src/nautilus-applicable-views.h
      	src/ntl-view-bonobo-control.c -> src/nautilus-view-frame-bonobo-control.c
      	src/ntl-view-bonobo-subdoc.c -> src/nautilus-view-frame-bonobo-embeddable.c
      	src/ntl-view-frame-svr.c -> src/nautilus-view-frame-corba.c
      	src/ntl-view-nautilus.c -> src/nautilus-view-frame-nautilus-view.c
      	src/ntl-view-private.h -> src/nautilus-view-frame-private.h
      	src/ntl-view.c -> src/nautilus-view-frame.c
      	src/ntl-view.h -> src/nautilus-view-frame.h
      	src/ntl-window-msgs.c -> src/nautilus-window-manage-views.c
      	src/ntl-window-msgs.h -> src/nautilus-window-manage-views.h
      	src/ntl-window-private.h -> src/nautilus-window-private.h
      	src/ntl-window-state.c -> src/nautilus-window-state.c
      	src/ntl-window-state.h -> src/nautilus-window-state.h
      	src/ntl-window.c -> src/nautilus-window.c
      	src/ntl-window.h -> src/nautilus-window.h
      
      	* components/history/Makefile.am, components/notes/Makefile.am,
      	libnautilus-extensions/Makefile.am, libnautilus/Makefile.am,
      	po/POTFILES.in, src/Makefile.am,
      	components/hardware/nautilus-hardware-view.h,
      	components/loser/content/nautilus-content-loser.h,
      	components/loser/sidebar/nautilus-sidebar-loser.h,
      	components/mozilla/nautilus-mozilla-content-view.h,
      	components/music/nautilus-music-view.h,
      	components/rpmview/nautilus-rpm-view.h,
      	components/sample/nautilus-sample-content-view.h,
      	components/services/startup/nautilus-view/nautilus-service-startup-view.h,
      	libnautilus/libnautilus.h, src/nautilus-desktop-window.h,
      	src/nautilus-window-menus.c, src/nautilus-window-toolbars.c,
      	src/file-manager/fm-directory-view.h : Updated for renamings.
      
      	* RENAMING: removed old renamings
      a15fd9f8
    • Darin Adler's avatar
      A little more desktop window work. · 63d4a318
      Darin Adler authored
      	* src/nautilus-desktop-window.c:
      	(nautilus_desktop_window_initialize_class),
      	(nautilus_desktop_window_initialize),
      	(nautilus_desktop_window_new):
      	* src/nautilus-desktop-window.h:
      	* src/ntl-app.c: (nautilus_app_startup), (nautilus_app_quit),
      	(nautilus_app_create_window):
      	* src/ntl-app.h:
      	* src/ntl-main.c: (main):
      	Made a desktop window that's created when you start the program
      	if you pass the --desktop option. At the moment it's a normal
      	window and not set up to take over the desktop.
      
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	(nautilus_self_check_glib_extensions): Fixed some broken self-
      	checks. Now we have one really broken self-check in the
      	nautilus-directory.c file. I might turn that one off soon so we
      	can at least run the others.
      
      	* libnautilus-extensions/nautilus-gtk-macros.h:
      	Changed how some of the macros work. Few of these macros were used
      	in Nautilus. I hope they aren't used in the Mozilla component,
      	because then I broke it.
      
      	* libnautilus-extensions/nautilus-list-column-title.c:
      	(nautilus_list_column_title_motion),
      	(nautilus_list_column_title_button_press),
      	(nautilus_list_column_title_button_release):
      	Updated to use NAUTILUS_INVOKE_METHOD instead of NAUTILUS_KLASS,
      	because I renamed it to NAUTILUS_CLASS and had to change these
      	anyway.
      
      	A little sweep for code that should be using
      	CORBA_Object_is_nil instead of direct compares with
      	CORBA_OBJECT_NIL.
      
      	* components/html/main.c: (url_requested_cb):
      	* libnautilus-extensions/bonobo-stream-vfs.c:
      	(bonobo_stream_create):
      	* libnautilus/nautilus-undo-manager.c:
      	(set_up_bonobo_control):
      	* libnautilus/nautilus-undoable.c: (nautilus_undo_register_full),
      	(nautilus_undo_unregister), (nautilus_undo):
      	* src/file-manager/dfos.c: (dfos_new):
      	Switch to use CORBA_Object_is_nil.
      
      	* libnautilus/nautilus-undo-manager.c: (undo_manager_unref),
      	(nautilus_attach_undo_manager), (nautilus_share_undo_manager),
      	(set_up_bonobo_control):
      	Do some missing duplicate and release calls.
      
      	* libnautilus/nautilus-undoable.c: (nautilus_undo_unregister):
      	Fix a place where we'd keep a reference to a freed list.
      	Change O(n^2) walk of list by index to O(n) walk by pointer.
      
      	* src/ntl-index-panel.c: (nautilus_index_panel_remove_meta_view):
      	Changed g_warning to a g_return_if_fail, which was designed for
      	cases just like this one.
      
      	* src/ntl-view-bonobo-subdoc.c:
      	(bonobo_subdoc_notify_location_change):
      	Put in a better version of the FIXME.
      
      	* RENAMING: More updates.
      63d4a318
    • Ramiro Estrugo's avatar
      Add a function that returns the disabled sidebar panels. Needed so that · 3e1a1af2
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-global-preferences.c:
      (nautilus_global_preferences_get_enabled_sidebar_panel_view_identifiers),
      (nautilus_global_preferences_get_disabled_sidebar_panel_view_identifiers):
      * libnautilus-extensions/nautilus-global-preferences.h:
      
      Add a function that returns the disabled sidebar panels.  Needed
      so that on-the-fly sidebar panel toggling can be smart about
      adding and removing views.
      
      Also rename some variabled to make it obvious which are the enabled
      and disabled lists.
      3e1a1af2
  5. 26 May, 2000 9 commits
    • John Sullivan's avatar
      Fixed bug 992 ("Fully Decorate Remote Views" is not a · cbf780ad
      John Sullivan authored
      	sensible preference). Note that before making the
      	quick wording fix Darin, Ian, and I came up with a
      	longer-term plan for handling this general kind of
      	thing well (bug 995).
      
      	* libnautilus-extensions/nautilus-global-preferences.h:
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(state_changed):
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_create_dialog),
      	(global_preferences_register_for_ui):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_for_file):
      	Changed "Fully Decorate Remote Views" to "Display text in
      	icons even for remote text files"
      	Changed NAUTILUS_PREFERENCES_REMOTE_VIEWS to
      	NAUTILUS_PREFERENCES_SHOW_TEXT_IN_REMOTE_ICONS
      cbf780ad
    • Ramiro Estrugo's avatar
      Expose only a single function to deal with sidebar panels. Return a list · 371919a9
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-global-preferences.c:
      (global_preferences_create_dialog),
      (global_preferences_get_sidebar_panel_view_identifiers),
      (nautilus_global_preferences_get_enabled_sidebar_panel_view_identifiers),
      (global_preferences_register_sidebar_panels_preferences_for_ui),
      (global_preferences_is_sidebar_panel_enabled),
      (nautilus_global_preferences_shutdown):
      * libnautilus-extensions/nautilus-global-preferences.h:
      
      Expose only a single function to deal with sidebar panels.  Return
      a list of enabled view indentifiers, saving callers the work and
      complication of figuring out which panels are on.
      
      Make NAUTILUS_PREFERENCES_SIDEBAR_PANELS_NAMESPACE cause i need it
      to later keep track of sidebar panel changes in NautilusWindow.
      
      * src/ntl-uri-map.c: (got_file_info_callback),
      (nautilus_navigation_info_free):
      * src/ntl-uri-map.h:
      * src/ntl-window-msgs.c: (nautilus_window_update_state):
      Exorcise the 'sidebar_panel_identifiers' member.  Instead of
      complicating life by managing this list, simply obtain it when
      needed from global preferences.
      371919a9
    • Ramiro Estrugo's avatar
      Install only ONE gconf notification for each preference or namespace that · f4bb9210
      Ramiro Estrugo authored
      * nautilus-widgets/nautilus-preferences.c: (pref_hash_node_alloc),
      (pref_hash_node_free), (pref_hash_node_add_callback),
      (pref_hash_node_remove_callback), (pref_callback_info_alloc),
      (preferences_gconf_callback):
      
      Install only ONE gconf notification for each preference or
      namespace that we care about.  Otherwise we get an exponential
      number of notifications.  Move the gconf_connection from the
      callback list info to the preference hash node.
      
      Remove lingering gconf notifications on destruction of hash
      nodes.
      f4bb9210
    • Ramiro Estrugo's avatar
      Add support for keeping track of changes within a whole preference · c774ab97
      Ramiro Estrugo authored
      * nautilus-widgets/nautilus-preferences.c:
      (pref_hash_node_add_callback), (pref_hash_node_remove_callback),
      (preferences_gconf_callback):
      
      Add support for keeping track of changes within a whole preference
      namespace.
      
      Pass in the expected preference to the gconf callback.  Do this so
      that we can compare the expected prefrence name with the one that
      gconf reports.  If they dont match, then we have something that
      changed within a namespace and not an individual key.
      
      Also fix some memory leaks.  Was forgetting to free a couple of
      returned preference names.
      c774ab97
    • Gene Z. Ragan's avatar
      More work on undo. Note that undo in text entry fields still misbehaves. · 7c045c92
      Gene Z. Ragan authored
      2000-05-25  Gene Z. Ragan  <gzr@eazel.com>
      
      	More work on undo.  Note that undo in text entry fields still
      	misbehaves.  More improvements are on the way.
      
      	* components/websearch/ntl-web-search.c:
      	(make_obj):
      	Removed obsolete enable undo code.
      
      	* libnautilus-extensions/nautilus-entry.c:
      	* libnautilus-extensions/nautilus-entry.h:
      	(nautilus_entry_initialize_class), (nautilus_entry_key_press),
      	(nautilus_entry_insert_text), (nautilus_entry_delete_text),
      	(register_edit_undo), (nautilus_entry_set_undo_key):
      	Removed the enable_undo function and made undo functionality
      	a default feature of NautilusEntry.
      
      	* libnautilus/nautilus-undo-transaction.c:
      	(nautilus_undo_transaction_add_undoable),
      	(nautilus_undo_transaction_undo):
      
      	* libnautilus/nautilus-undoable.c:
      	* libnautilus/nautilus-undoable.h:
      	(nautilus_undoable_save_undo_snapshot), (nautilus_undo_unregister):
      
      	* src/file-manager/fm-properties-window.c: (create_basic_page):
      	Removed obsolete enable undo code.
      
      	* src/nautilus-bookmarks-window.c: (on_text_field_focus_in_event),
      	(on_text_field_focus_out_event), (on_window_delete_event):
      	Removed obsolete enable undo code.
      
      	* src/nautilus-location-bar.c:
      	* src/nautilus-location-bar.h:
      	(nautilus_location_bar_set_location):
      	Removed obsolete enable undo code.
      
      	* src/ntl-window.c: (nautilus_window_constructed):
      	Removed obsolete enable undo code.
      7c045c92
    • John Sullivan's avatar
      Added a missing space. · e52cc990
      John Sullivan authored
      2000-05-25  John Sullivan  <sullivan@eazel.com>
      
      	* src/ntl-app.c: (display_caveat): Added a missing space.
      
      
      	More work on the "Open with Other" dialogs. Most of
      	the UI features are present now, but they don't do
      	anything since there's no API to call yet.
      
      	* libnautilus-extensions/nautilus-gtk-extensions.h,
      	* libnautilus-extensions/nautilus-gtk-extensions.c:
      	(nautilus_gtk_clist_get_first_selected_row),
      	(nautilus_gtk_clist_get_last_selected_row):
      	Moved these functions to here from NautilusList, since
      	they only require a GtkCList and I needed to use one
      	of them outside of NautilusList.
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_get_first_selected_row),
      	(nautilus_list_get_last_selected_row),
      	(nautilus_list_keyboard_navigation_key_press),
      	(nautilus_list_new_with_titles):
      	Removed get_first and get_last_selected_row, and updated
      	callers to call new nautilus_gtk_clist versions.
      
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(populate_program_list), (nautilus_program_chooser_get_file),
      	(nautilus_program_chooser_get_clist),
      	(nautilus_program_chooser_get_frame),
      	(nautilus_program_chooser_get_status_label),
      	(nautilus_program_chooser_set_file),
      	(nautilus_program_chooser_set_clist),
      	(nautilus_program_chooser_set_frame),
      	(nautilus_program_chooser_set_status_label), (is_in_short_list),
      	(is_in_metadata_list), (update_selected_item_details),
      	(program_list_selection_changed_callback), (pack_radio_button),
      	(run_program_configurator_callback),
      	(nautilus_program_chooser_new):
      	Whole bunch of changes to push the "Open with Other" dialogs
      	closer to reality.
      
      	* src/ntl-window.c:
      	(view_menu_choose_view_callback): Comment changes only.
      	(nautilus_window_load_content_view_menu): Changed menu item
      	text from "View as ..." to "View as Other..."
      e52cc990
    • Darin Adler's avatar
      I am getting a little careless. This must end. · 082b0a23
      Darin Adler authored
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_denies_access_permission): Fixed some checks
      	that I had reversed.
      
      	* src/ntl-app.c: (display_caveat): Took out some test code I
      	checked in.
      082b0a23
    • Darin Adler's avatar
      88d96d50
    • Darin Adler's avatar
      Made the permission check match the Unix access model. Maciej points out · 0e9ba92d
      Darin Adler authored
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_denies_access_permission),
      	(nautilus_file_can_set_permissions): Made the permission check
      	match the Unix access model. Maciej points out that this is
      	still not good enough, and Pavel points out that bug 458 is
      	about just this problem.
      
      	* libnautilus-extensions/nautilus-gnome-extensions.c:
      	(turn_on_line_wrap_flag): Got rid of a bad g_free that was
      	trashing memory when locating the label for line wrapping.
      
      	* src/ntl-app.c: (display_caveat): Used line wrapping, now that
      	I know wrapping wasn't the cause of the bug before.
      0e9ba92d
  6. 25 May, 2000 4 commits
    • Ramiro Estrugo's avatar
      Cleanup cut-n-paste code for dealing the sidebar panels. · 8cbb5d30
      Ramiro Estrugo authored
      * libnautilus-extensions/nautilus-global-preferences.c:
      (global_preferences_create_dialog),
      (global_preferences_register_sidebar_panels_preferences_for_ui),
      (global_preferences_get_sidebar_panel_key),
      (nautilus_global_preferences_is_sidebar_panel_enabled),
      (global_preferences_register_for_ui),
      (user_level_changed_callback),
      (nautilus_global_preferences_startup):
      Added define for sidebar panels namespace.
      
      Rename preference defines to make it clear whether they are keys
      or namespaces.
      
      Add function to obtain a sidebar panel key from an iid.
      
      Use "sidebar panels" consistently in both code and preferences
      dialog.
      
      * libnautilus-extensions/nautilus-global-preferences.h:
      New public function
      nautilus_global_preferences_is_sidebar_panel_enabled () that
      returns whether a sidebar panel is enabled.
      
      * src/ntl-uri-map.c: (sidebar_panel_preference_is_on):
      Use nautilus_global_preferences_is_sidebar_panel_enabled() instead
      of hard-coding the namespace string.
      8cbb5d30
    • Darin Adler's avatar
      Updated to reflect completed tasks. · 78899d39
      Darin Adler authored
      	* RENAMING: Updated to reflect completed tasks.
      
      	* components/notes/ntl-notes.c: (make_notes_view):
      	* components/websearch/ntl-web-search.c: (make_obj):
      	Changed to use simplified clipboard API.
      
      	* components/services/trilobite/libtrilobite/.cvsignore:
      	Ignore generated files.
      
      	* libnautilus-extensions/gtkscrollframe.c:
      	* libnautilus-extensions/gtkscrollframe.h:
      	Renamed GtkScrollFrame to NautilusScrollFrame so we won't conflict
      	if a GtkScrollFrame actually gets added to gtk some day. The file
      	still needs renaming (mentioned in RENAMING).
      
      	* libnautilus/nautilus-clipboard.h:
      	* libnautilus/nautilus-clipboard.c: (cut_callback),
      	(copy_callback), (paste_callback), (clear_callback),
      	(add_menu_item), (add_menu_items_callback),
      	(remove_menu_items_callback), (nautilus_clipboard_set_up_editable):
      	Simplified clipboard implementation. Does the same thing the old
      	code did without needing a class and with a simpler API.
      
      	* nautilus-widgets/nautilus-preferences-item.c:
      	* src/file-manager/fm-icon-text-window.c:
      	* src/nautilus-zoom-control.c:
      	* src/ntl-window.c:
      	Renamed _cb to _callback. Some other (minor) cleanup.
      
      	* src/file-manager/Makefile.am:
      	* src/file-manager/desktop-canvas.c: [removed]
      	* src/file-manager/desktop-canvas.h: [removed]
      	* src/file-manager/desktop-menu.c: [removed]
      	* src/file-manager/desktop-menu.h: [removed]
      	* src/file-manager/gnome-desktop.c: [removed]
      	Now that I'm doing the desktop work, I know we don't need these.
      	I'll be deleting the desktop source files that Havoc added as I
      	harvest the useful code from them.
      
      	* src/file-manager/fm-directory-view.c:
      	(bonobo_control_activate_callback): Add comments.
      
      	* src/nautilus-zoom-control.h: Fixed problem where the zoom
      	control didn't know if it was an event box or a pixmap.
      
      	* src/ntl-index-panel.c: (nautilus_index_panel_add_meta_view):
      	Fixed bug that was trashing the sidebar panel names. I put
      	the g_free call in the wrong place.
      
      	* src/ntl-uri-map.c: (sidebar_panel_preference_is_on):
      	Fixed bug where the sidebar preference wasn't saved. I found
      	another place with another copy of the preference path. This
      	sort of thing really needs to go in a header file, I think.
      78899d39
    • Gene Ragan's avatar
      *** empty log message *** · 31890627
      Gene Ragan authored
      31890627
    • Darin Adler's avatar
      Oops. Missed one case of "metaview" -> "sidebar-view". · fef5f321
      Darin Adler authored
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_create_dialog): Oops. Missed one case of
      	"metaview" -> "sidebar-view".
      
      	* libnautilus-extensions/nautilus-icon-canvas-item.c:
      	(draw_pixbuf_aa), (draw_label_text_aa),
      	(nautilus_icon_canvas_item_render): Some minor code tweaks.
      fef5f321
  7. 24 May, 2000 8 commits
    • Gene Ragan's avatar
      *** empty log message *** · 1aedbe58
      Gene Ragan authored
      1aedbe58
    • Gene Ragan's avatar
      *** empty log message *** · ca8660c9
      Gene Ragan authored
      ca8660c9
    • Darin Adler's avatar
      [deleted] [deleted] · 70659f55
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/libnautilus.h:
      	* libnautilus/nautilus-meta-view-frame.c: [deleted]
      	* libnautilus/nautilus-meta-view-frame.h: [deleted]
      	* libnautilus/nautilus-view-component.idl:
      	* po/POTFILES.in:
      	* src/ntl-index-panel.c: (nautilus_index_panel_add_meta_view):
      	* src/ntl-window.c: (nautilus_window_add_meta_view):
      	Removed Nautilus::MetaView and all the related classes.
      	We still have Nautilus::MetaViewFrame (will go soon).
      
      	* components/help/hyperbola-nav-index.c:
      	(hyperbola_navigation_index_new):
      	* components/help/hyperbola-nav-search.c:
      	(hyperbola_navigation_search_new):
      	* components/help/hyperbola-nav-tree.c:
      	(hyperbola_navigation_tree_new):
      	* components/history/ntl-history-view.c: (make_obj):
      	* components/loser/sidebar/nautilus-sidebar-loser.c:
      	(nautilus_sidebar_loser_initialize),
      	(loser_notify_location_change_callback):
      	* components/loser/sidebar/nautilus-sidebar-loser.h:
      	* components/notes/ntl-notes.c: (make_notes_view):
      	* components/websearch/ntl-web-search.c: (make_obj):
      	Changed to use just plain view insetad of meta_view.
      
      	* libnautilus-extensions/nautilus-global-preferences.h:
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_create_dialog),
      	(nautilus_global_preferences_get_sidebar_panel_view_identifiers),
      	(nautilus_global_preferences_get_sidebar_view_iids),
      	(nautilus_preferences_register_sidebar_view_preferences_for_ui),
      	(global_preferences_register_for_ui):
      	Changed naming to call them sidebar views instead of meta views,
      	and got rid of code that depends on MetaView interface. We now
      	use the sidebar_panel_name to determine if a view should show
      	up in the sidebar.
      
      	* src/ntl-view.h: Fixed a comment to reflect the future
      	instead of the past.
      70659f55
    • John Sullivan's avatar
      Some work on the innards of the program-choosing dialogs. Still not wired · f68147a3
      John Sullivan authored
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(populate_program_list), (nautilus_program_chooser_new):
      	Some work on the innards of the program-choosing dialogs.
      	Still not wired up to any actual data.
      f68147a3
    • Darin Adler's avatar
      Moved to make clear that popt must build first. · 3f2b83b1
      Darin Adler authored
      	* HACKING: Moved to make clear that popt must build first.
      
      	* RENAMING: Added some new file renamings.
      
      	* src/nautilus-zoomable-frame-svr.c:
      	* src/nautilus.h: [removed]
      	* src/ntl-app.c:
      	* src/ntl-main.c:
      	* src/ntl-meta-view.c:
      	* src/ntl-types.h: [removed]
      	* src/ntl-uri-map.c:
      	* src/ntl-view-bonobo-control.c:
      	* src/ntl-view-bonobo-subdoc.c:
      	* src/ntl-view-frame-svr.c:
      	* src/ntl-view-nautilus.c:
      	* src/ntl-view-private.h:
      	* src/ntl-view.c:
      	* src/ntl-window-msgs.c:
      	* src/ntl-window-state.c:
      	* src/ntl-window.c:
      	Got rid of "nautilus.h" and "ntl-types.h".
      
      	* libnautilus/nautilus-undo-context.c:
      	(impl_Nautilus_Undo_Context__destroy),
      	(impl_Nautilus_Undo_Context__create),
      	(impl_Nautilus_Undo_Context__get_undo_manager),
      	(nautilus_undo_context_new), (nautilus_undo_context_initialize),
      	(destroy):
      	* libnautilus/nautilus-undo-manager.c:
      	(impl_Nautilus_Undo_Manager__destroy),
      	(impl_Nautilus_Undo_Manager__create),
      	(impl_Nautilus_Undo_Manager__append),
      	(impl_Nautilus_Undo_Manager__forget),
      	(impl_Nautilus_Undo_Manager__undo), (nautilus_undo_manager_new),
      	(nautilus_undo_manager_initialize),
      	(nautilus_undo_manager_initialize_class),
      	(nautilus_undo_manager_undo), (nautilus_undo_manager_redo),
      	(nautilus_undo_manager_add_transaction),
      	(nautilus_undo_manager_unregister_object),
      	(nautilus_undo_manager_can_undo), (nautilus_undo_manager_can_redo),
      	(destroy), (nautilus_undo_manager_enable_redo),
      	(nautilus_undo_manager_set_queue_depth), (free_undo_manager_list):
      	Various code cleanups. Specifically, get rid of unused
      	bonobo_object and rename gtk_object to bonobo_object.
      	Get rid of some yucky function pointer casts.
      
      	* src/ntl-app.c: (nautilus_app_init):
      	Got rid of bogus extra ref.
      
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_new): Reindent part just to annoy John.
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application): Newline at end of file (ugh).
      
      	* src/ntl-index-panel.c: (add_command_buttons): Format tweaking.
      3f2b83b1
    • Andy Hertzfeld's avatar
      made the text beneath the icons draw properly for the anti-aliased canvas. · 59c9a694
      Andy Hertzfeld authored
      
              made the text beneath the icons draw properly for the anti-aliased
      	canvas.
      59c9a694
    • Gene Z. Ragan's avatar
      Added call to CORBA_Object_duplicate(). This fixed an explosive bug. · 539ae559
      Gene Z. Ragan authored
      2000-05-23  Gene Z. Ragan  <gzr@eazel.com>
      
      	* libnautilus/nautilus-undo-context.c:
      	(impl_Nautilus_Undo_Context__get_undo_manager):
      	Added call to CORBA_Object_duplicate().  This
      	fixed an explosive bug.
      
      	* libnautilus/nautilus-undo-manager.c:
      	* libnautilus/nautilus-undo-manager.h:
      	(nautilus_undo_manager_stash_global_undo),
      	(nautilus_undo_manager_get_global_undo):
      	New functions to save application global instance of Nautilus_Undo_Manager
      
      	* src/ntl-app.c: (nautilus_app_init):
      	Add call to nautilus_undo_manager_stash_global_undo.
      
      	* src/ntl-view.c:
      	(nautilus_view_frame_load_client):
      	Coonected Nautilus_Undo_Context interface to view frame.
      539ae559
    • John Sullivan's avatar
      A few cleanup tweaks inspired by debugging session · e4d87678
      John Sullivan authored
      	with Darin.
      
      	* libnautilus-extensions/nautilus-program-choosing.h,
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_choose_application_for_file): Make callback
      	take a const char * instead of a char *.
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_chose_application_callback): take
      	a const char * instead of a char *.
      	* src/ntl-index-panel.c:
      	(nautilus_index_panel_chose_application_callback):
      	take a const char * instead of a char *.
      	(open_with_callback): unref file
      	(add_command_buttons): Use gtk_signal_connect instead of
      	nautilus_gtk_signal_connect_free_data when passing NULL
      	as the data (Doh!).
      e4d87678
  8. 23 May, 2000 3 commits
    • Andy Hertzfeld's avatar
      made emblems draw properly in anti-aliased mode · 04bcb022
      Andy Hertzfeld authored
      
             made emblems draw properly in anti-aliased mode
      04bcb022
    • John Sullivan's avatar
      Some pieces of the application and component-choosing UI. · 08a71e32
      John Sullivan authored
      	They don't do anything useful yet.
      
      	* libnautilus-extensions/nautilus-program-chooser.h,
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	New files with code for creating a program-choosing
      	dialog (which is really degenerate right now).
      
      	* libnautilus-extensions/nautilus-program-choosing.h,
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	New files with functions for choosing a component or other
      	program to display or open a file with. This uses the
      	dialog in nautilus-program-chooser, but callers don't
      	need to know that.
      
      	* libnautilus-extensions/Makefile.am: add these new
      	files to the build.
      
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_chose_application_callback),
      	(fm_directory_view_chose_component_callback), (choose_application),
      	(choose_component), (bonobo_menu_other_program_callback),
      	(other_application_callback), (other_viewer_callback):
      	New functions that connect the program-choosing UI to the
      	menu items.
      	(compute_menu_item_info): Stop desensitizing the "Other ..." items.
      	(append_gtk_menu_item): Eliminated this function, made callers use
      	more elaborate append_gtk_menu_item_with_view instead.
      	(fm_directory_view_real_create_background_context_menu_items),
      	(create_open_with_gtk_menu):
      	Updated callers to append_gtk_menu_item.
      	(fm_directory_view_real_create_selection_context_menu_items):
      	Pass view to create_open_with_gtk_menu.
      	(reset_bonobo_open_with_menu): Now takes an FMDirectoryView and
      	uses it as callback data for "Other..." items.
      	(fm_directory_view_real_merge_menus),
      	(fm_directory_view_real_update_menus): Pass view to
      	reset_bonobo_open_with_menu.
      
      	* src/ntl-index-panel.c: (command_button_callback): Renamed from
      	command_button_cb, also broke out application-launching code and
      	moved it to libnautilus-extensions/nautilus-program-choosing.c.
      	(nautilus_index_panel_chose_application_callback),
      	(open_with_callback): New functions, used to wire up functionality
      	of "Open with ..." button.
      	(add_command_buttons): Stop desensitizing "Open with ..." button,
      	and wire it up to do something.
      
      	* src/ntl-window.h: Renamed field "option_cvtype" to "view_as_option_menu".
      	* src/ntl-window.c:
      	(nautilus_window_constructed): Updated to match field name change.
      	(nautilus_window_switch_views): New function, broken out of
      	view_menu_switch_views_callback; switches window to new content view.
      	(view_menu_switch_views_callback): Now calls nautilus_window_switch_views.
      	(synch_view_as_menu): New function, resets displayed name of "View as"
      	menu to match current content view.
      	(chose_component_callback), (view_menu_choose_view_callback): New
      	functions, used to implement "View as ..." menu item.
      	(nautilus_window_load_content_view_menu): Store iid in menu item;
      	call synch_view_as_menu; wire up "View as ..." menu item.
      
      
      	* src/ntl-window-msgs.c: (handle_unreadable_location):
      	Tweaked wording of an error message.
      
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file): Tweaked wording of an error message.
      08a71e32
    • Darin Adler's avatar
      Some cleanup of the undo code, including a first cut of the · 9970b3cb
      Darin Adler authored
      	* libnautilus/nautilus-undo-manager.c:
      	(impl_Nautilus_Undo_Manager__append), (nautilus_undo_manager_undo),
      	(nautilus_undo_manager_redo),
      	(nautilus_undo_manager_add_transaction),
      	(nautilus_undo_manager_unregister_object), (destroy),
      	(nautilus_undo_manager_set_queue_depth), (free_undo_manager_list),
      	(prune_undo_manager_list), (nautilus_get_undo_manager),
      	(undo_manager_unref), (undo_manager_ref),
      	(nautilus_attach_undo_manager), (set_up_bonobo_control),
      	(nautilus_undo_set_up_bonobo_control):
      	Some cleanup of the undo code, including a first cut of the
      	set_up_bonobo_control function. Also got rid of all the excess
      	unrefs that we didn't need. I hope this is right now. Also fixed
      	bug where code was trying to bonobo_object_unref a CORBA object
      	directly.
      
      	* libnautilus/nautilus-undo-manager.c:
      	(nautilus_undo_set_up_bonobo_control):
      	* libnautilus/nautilus-undo-manager.h:
      	* libnautilus/nautilus-view-frame.c:
      	(nautilus_view_real_set_bonobo_control):
      	Change from setup to set_up. Setup is a noun, set up a verb phrase.
      
      	* libnautilus/nautilus-undoable.c: (nautilus_undo_register_full),
      	(nautilus_undo): Some minor cleanup and unrefing the transaction
      	after adding it to the undo manager.
      9970b3cb