1. 28 Mar, 2000 1 commit
  2. 26 Mar, 2000 2 commits
  3. 25 Mar, 2000 3 commits
  4. 24 Mar, 2000 1 commit
  5. 23 Mar, 2000 2 commits
    • John Sullivan's avatar
    • Darin Adler's avatar
      Fixed bug 336 (merged menu items don't go away when component · e14985a9
      Darin Adler authored
      	is swapped out).
      
      	* src/file-manager/fm-directory-view.c: (fm_directory_view_destroy):
      	While debugging, I noticed that the view_frame was allocated by the
      	FMDirectoryView and never unref'd. The exact connection of this to
      	why the widgets don't go away is now lost in time. We added a call
      	to bonobo_object_unref to get rid of the view frame.
      
      	* src/ntl-window.h, src/ntl-window.c, src/ntl-window-msgs.c:
      	(Nautilus_NavigationInfo_free): Got rid of this routine. It turns
      	out that this was an incorrect hack to work around the error in
      	the surrounding code that was copying CORBA object references
      	without calling	CORBA_Object_duplicate.
      	(nautilus_window_destroy), (nautilus_window_request_selection_change):
      	Changed code that was calling Nautilus_NavigationInfo_free to just
      	call CORBA_free now that the incorrect hack is not needed.
      	(nautilus_window_request_selection_change),
      	(nautilus_window_update_view),
      	(nautilus_window_update_internals),
      	(nautilus_window_load_content_view): Changed all code that was
      	manipulating content_view to use CORBA_Object_duplicate when
      	storing a reference and CORBA_Object_release when overwriting
      	a reference.
      e14985a9
  6. 22 Mar, 2000 6 commits
    • Darin Adler's avatar
      Fixed bug 334 (Need proper hit detection when hit-testing icons. · 433efe12
      Darin Adler authored
      	* libnautilus/nautilus-icon-canvas-item.c: (hit_test_pixbuf):
      	Fixed a typo-type error where we were checking every pixel of the
      	pixbuf instead of only the pixels that we were hit testing against.
      
      	* libnautilus/nautilus-icon-container.c: Tweaks.
      433efe12
    • John Sullivan's avatar
    • John Sullivan's avatar
    • John Sullivan's avatar
    • Pavel Cisler's avatar
      Fixed an annoying bug that would sometimes cause the drag&drop feedback to · f7134226
      Pavel Cisler authored
      2000-03-21  Pavel Cisler  <pavel@eazel.com>
      
      	Fixed an annoying bug that would sometimes cause the drag&drop feedback
      	to come up delayed.
      f7134226
    • Darin Adler's avatar
      Did some of the items from RENAMING. · 1764f212
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/gnome-icon-container-dnd.c:
      	* libnautilus/gnome-icon-container-dnd.h:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/gnome-icon-container.h:
      	* libnautilus/gtkflist.c:
      	* libnautilus/gtkflist.h:
      	* libnautilus/nautilus-icon-canvas-item.c:
      	* libnautilus/nautilus-icon-canvas-item.h:
      	* libnautilus/nautilus-icon-container.c:
      	* libnautilus/nautilus-icon-container.h:
      	* libnautilus/nautilus-icon-dnd.c:
      	* libnautilus/nautilus-icon-dnd.h:
      	* libnautilus/nautilus-icon-grid.c:
      	* libnautilus/nautilus-icon-grid.h:
      	* libnautilus/nautilus-icon-private.h:
      	* libnautilus/nautilus-icons-view-icon-item.c:
      	* libnautilus/nautilus-icons-view-icon-item.h:
      	* libnautilus/nautilus-lib-self-check-functions.h:
      	* libnautilus/nautilus-list-column-title.c:
      	* libnautilus/nautilus-list.c:
      	* libnautilus/nautilus-list.h:
      	* src/file-manager/Makefile.am:
      	* src/file-manager/fm-directory-view-icons.c:
      	* src/file-manager/fm-directory-view-icons.h:
      	* src/file-manager/fm-directory-view-list.c:
      	* src/file-manager/fm-directory-view-list.h:
      	* src/file-manager/fm-icon-view.c:
      	* src/file-manager/fm-icon-view.h:
      	* src/file-manager/fm-list-view.c:
      	* src/file-manager/fm-list-view.h:
      	* src/ntl-app.c:
      	Did these RENAMING entries:
      	  FMDirectoryViewIcons -> FMIconView
      	  FMDirectoryViewList  -> FMListView
      	  GnomeIconContainer -> NautilusIconContainer
      	  GnomeIconContainerIcon -> NautilusIcon
      	  NautilusIconsViewIconItem -> NautilusIconCanvasItem
      
      	* RENAMING: Marked the renaming done.
      1764f212
  7. 21 Mar, 2000 4 commits
    • Darin Adler's avatar
      Fixed arrow keys and worked on the icon grid. · f09362cb
      Darin Adler authored
      	Fixes bugs #314, #324, and #325.
      
      	* components/help/hyperbola.goad:
      	Corrected repo_ids -> repo_id, reported by Richard Hult.
      
      	* src/nautilus.goad:
      	Added missing = character, reported by Richard Hult.
      
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/gnome-icon-container-private.h:
      	Made the icon grid handle negative coordinates.
      	Removed most of the icon grid code.
      	Reimplemented the arrow keys. They should work again.
      
      	* libnautilus/nautilus-gnome-extensions.c:
      	* libnautilus/nautilus-gnome-extensions.h:
      	(nautilus_art_irect_contains_irect):
      	Added another helper function.
      
      	* libnautilus/nautilus-icons-view-icon-item.c:
      
      	* libnautilus/nautilus-icons-view-icon-item.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/gnome-icon-container-private.h:
      	Added user data to each canvas item and got rid of the hash table
      	that maps canvas items to icons.
      
      	* RENAMING: Tweaks.
      f09362cb
    • John Sullivan's avatar
      f953548e
    • Pavel Cisler's avatar
      Center the sort order indicators inside a title better. Make the column · ec8d277e
      Pavel Cisler authored
      2000-03-20  Pavel Cisler  <pavel@eazel.com>
      
      	Center the sort order indicators inside a title better. Make the column
      	title label spacing more like the old CtkCList.
      ec8d277e
    • Pavel Cisler's avatar
      Use an offscreen bitmap to draw the column title during column resizing · a4b40782
      Pavel Cisler authored
      2000-03-20  Pavel Cisler  <pavel@eazel.com>
      
      	Use an offscreen bitmap to draw the column title during column resizing
      	and column prelighting.
      a4b40782
  8. 18 Mar, 2000 2 commits
    • Darin Adler's avatar
      Fixed the "tall line of icons" bug. · 857e8fa2
      Darin Adler authored
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container.c:
      	Rewrote the routines to not have a separate concept of the
      	actual grid height and the allocated grid height. Most important
      	change was to update the first_free variables when resizing.
      
      	* src/file-manager/fm-directory-view-icons.h:
      	* src/file-manager/fm-directory-view-icons.c:
      	(fm_directory_view_icons_line_up_icons):
      	Removed the unused line_up_icons call. This feature will return,
      	but for now it's just a waste of space.
      857e8fa2
    • Darin Adler's avatar
      *** empty log message *** · 777a75ae
      Darin Adler authored
      777a75ae
  9. 17 Mar, 2000 9 commits
  10. 16 Mar, 2000 6 commits
    • Darin Adler's avatar
      Did some of the renamings that were queued in RENAMING. · 8efa4d71
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/gdk-extensions.c:
      	* libnautilus/gdk-extensions.h:
      	* libnautilus/nautilus-gdk-extensions.c:
      	* libnautilus/nautilus-gdk-extensions.h:
      	* libnautilus/gnome-icon-container.c:
      	* libnautilus/nautilus-background.c:
      	* libnautilus/nautilus-icons-view-icon-item.c:
      	Renamed gdk-extensions to add the nautilus- prefix and changed
      	all includers.
      
      	* src/Makefile.am:
      	* src/explorer-location-bar.c:
      	* src/explorer-location-bar.h:
      	* src/nautilus-location-bar.c:
      	* src/nautilus-location-bar.h:
      	* src/ntl-window-msgs.c:
      	* src/ntl-window.c:
      	Renamed ExplorerLocationBar to NautilusLocationBar.
      
      	* src/Makefile.am:
      	* src/nautilus-bookmarklist.c:
      	* src/nautilus-bookmarklist.h:
      	* src/nautilus-bookmark-list.c:
      	* src/nautilus-bookmark-list.h:
      	* src/nautilus-bookmarks-window.c:
      	* src/nautilus-bookmarks-window.h:
      	* src/nautilus-window-menus.c:
      	Renamed NautilusBookmarklist to NautilusBookmarkList.
      
      	* RENAMING: Marked items done and added some new ones.
      
      	* nautilus-widgets/nautilus-preferences-item.c:
      	* nautilus-widgets/nautilus-preferences.c:
      	* nautilus-widgets/test-nautilus-widgets.c:
      	* libnautilus/nautilus-icon-factory.c:
      	* src/file-manager/fm-directory-view-icons.c:
      	* src/file-manager/fm-directory-view.c:
      	* src/file-manager/fm-icon-text-window.c:
      	Cleaned up the interface to NautilusPreferences a bit.
      8efa4d71
    • John Sullivan's avatar
      Fixes for a couple of preferences bugs. · 3ffd2251
      John Sullivan authored
      3ffd2251
    • John Sullivan's avatar
    • Darin Adler's avatar
      Fixed the CRITICALs that I recently introduced. Made sure our unrefs match · 908efb2d
      Darin Adler authored
      	* src/file-manager/fm-directory-view.c:
      	(disconnect_model_handlers), (stop_load): Fixed the CRITICALs that
      	I recently introduced. Made sure our unrefs match our refs for
      	monitor_files.
      908efb2d
    • John Sullivan's avatar
    • Darin Adler's avatar
      Tell people about the gnome-xml branch. · ee495dba
      Darin Adler authored
      	* HACKING: Tell people about the gnome-xml branch.
      
      	* libnautilus/Makefile.am:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c:
      	Broke out the grid code from the main container code.
      	This is a first step toward improving the layout code.
      
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	* src/fm-directory-view.c:
      	Got started on making the directory I/O async.
      	There's still a long way to go, this was a baby step.
      
      	* libnautilus/nautilus-bookmark.c:
      	* libnautilus/nautilus-bookmark.h:
      	* libnautilus/nautilus-self-checks.c:
      	General cleanup.
      
      	* libnautilus/nautilus-file.h:
      	Rearranged a little bit.
      
      	* libnautilus/nautilus-file-utilities.c:
      	Put FIXME in where there's code that needs to be changed.
      ee495dba
  11. 15 Mar, 2000 3 commits
    • John Sullivan's avatar
      Used preferences mechanism for text under icons and · 4df4c1e1
      John Sullivan authored
      open-in-new-window-when-clicked.
      4df4c1e1
    • Darin Adler's avatar
      A quick cleanup of how we use gnome-xml. · b84f3f1d
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* libnautilus/nautilus-xml-extensions.c:
      	* libnautilus/nautilus-xml-extensions.h:
      	Added some new gnome-xml helper functions.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_get_file_metadata_node):
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_get_keywords):
      	(nautilus_file_set_keywords):
      	* libnautilus/nautilus-icon-factory.c:
      	(get_child_node_by_property):
      	(get_themed_icon_file_path):
      	* src/nautilus-bookmarklist.c:
      	(nautilus_bookmarklist_load_file):
      	Changed to use the new helper functions.
      
      	* src/nautilus-bookmarklist.c:
      	(nautilus_bookmarklist_save_file): Changed direct uses of root to
      	use xmlDocGet/SetRootElement while I was editing the file.  I
      	think this is the same change Pavel made but wasn't able to check
      	in.
      
      	* src/nautilus-bookmarklist.c:
      	General cleanup.
      b84f3f1d
    • Darin Adler's avatar
      Added additional data to icons so they can specify where the · bdf3c6c1
      Darin Adler authored
      	embedded text fits in each icon.
      
      	* icons/eazel/Makefile.am, icons/eazel/i-regular.xml: Added the
      	file to specify attributes of icons. Specifically added the
      	attribute that says there is space for embedded text in the
      	Eazel-theme regular icon.
      
      	* libnautilus/nautilus-icon-factory.h:
      	* libnautilus/nautilus-icon-factory.c:
      	(get_child_node_by_property), (get_themed_icon_file_path),
      	(get_icon_file_path), (nautilus_icon_factory_get_thumbnail_uri),
      	(load_specific_image), (load_image_for_scaling),
      	(get_image_from_cache), (load_image_scale_if_necessary),
      	(nautilus_icon_factory_get_pixbuf_for_icon),
      	(nautilus_icon_factory_get_pixbuf_for_file):
      	Added code to read a rectangle for the embedded text along with
      	the icon, cache it with the icon, scale it with the icon, and
      	return it to the caller along with the icon.
      
      	* libnautilus/nautilus-icons-view-icon-item.c:
      	(nautilus_icons_view_icon_item_initialize_class),
      	(nautilus_icons_view_icon_item_set_arg),
      	(nautilus_icons_view_icon_item_get_arg),
      	(nautilus_icons_view_icon_item_get_image),
      	(nautilus_icons_view_icon_item_set_image),
      	(nautilus_art_irect_to_gdk_rectangle),
      	(draw_mini_text), (draw_embedded_text),
      	(nautilus_icons_view_icon_item_draw):
      	Changed the code that draws the embedded text to respect the
      	text rectangle passed in. Changed the pixbuf setting to use a
      	function instead of the arg interface and take a text rectangle
      	along with the pixbuf.
      
      	* libnautilus/gnome-icon-container-dnd.c
      	(gnome_icon_container_dnd_begin_drag):
      	* libnautilus/gnome-icon-container.c:
      	(icon_get_actual_size): Got rid of callers who were using the arg
      	interface to get at the image of an icon
      	("NautilusIconsViewIconItem::pixbuf").
      
      	* src/file-manager/fm-directory-view-icons.c:
      	(get_icon_property_cb): Get rid of hard-coded rule that only
      	themes with eazel at the front of their names can display text
      	inside the icons.
      
      	* libnautilus/gnome-icon-container.c:
      	(icon_new): Fixed a bug where icons would be super-tiny if they
      	got too big, like if you entered a directory that was zoomed all
      	the way in.
      	(start_stretching), (ungrab_stretch_icon), (end_stretching),
      	(gnome_icon_container_show_stretch_handles): Added code to grab
      	the pointer while stretching an icon.
      	(item_event_cb): Added a return statement that John forgot when
      	he was editing. Without that, it was falling through to the next
      	case, which had the same effect anyway.
      	(update_icon): Pass the text rectangle through from the icon
      	factory to the icon canvas item, using the new call instead of the
      	old arg interface approach.
      
      	* components/help/.cvsignore: Added entries for
      	.la and .lo files.
      
      	* components/help/Makefile.am:
      	* components/help/hyperbola-nav-index.c:
      	* components/help/hyperbola-nav-search.c:
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* src/nautilus-bookmarklist.c:
      	Fixed flags for gnome-xml
      	includes. Someone pointed out that you are supposed to include
      	these as "#include <tree.h>", not "#include <gnome-xml/tree.h>" so
      	I fixed our uses to work that way.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_get_file_metadata_node): Fixed code that was
      	destroying something allocated by gnome-xml with g_free instead
      	of xmlFree.
      
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_get_keywords), (nautilus_file_set_keywords):
      	Fixed storage leak where we were getting a property and not freeing it.
      
      	* libnautilus/nautilus-default-file-icon.h:
      	* libnautilus/nautilus-default-file-icon.c:
      	* libnautilus/nautilus-icon-factory.c:
      	(load_image_for_scaling): Got rid of the global that tells whether
      	the default icon has an alpha channel -- it's not hardwired TRUE.
      bdf3c6c1
  12. 14 Mar, 2000 1 commit