1. 28 Jan, 2003 1 commit
  2. 13 Feb, 2001 1 commit
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 37f08cd6
      Darin Adler authored
      	Fix bug 6408 (nautilus_view_report_load_failed causes Nautilus to
      	segfault in an idle callback):
      	* libnautilus/nautilus-idle-queue.c: (execute_queued_functions),
      	(nautilus_idle_queue_destroy): Changed the idle queue so it can
      	handle being destroyed while inside one of the queued functions.
      	Fix bug 6402 (Click desktop icon -> Nautilus window not moved to
      	* src/nautilus-window-manage-views.c: (open_location): Bring the
      	existing window up when it's reused in the "open icon on desktop"
      	in single-window mode.
      	Other changes:
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(is_theme_in_user_directory): Rename from "check_local_theme"
      	and changed it to use a normal function result instead of taking
      	a gboolean pointer.
      	(set_theme): Use new function and booleans by their new names.
      	"in_user_directory" instead of "local".
      	(make_full_icon_path): Just the name change.
      	(get_themed_icon_file_path): Take a boolean parameter instead of
      	trying to figure out if the theme is in the user directory, because
      	the old way would get it wrong for the default theme.
      	(get_icon_file_path): Pass in the boolean to say if the theme is
      	in the user directory or not.
      	* libnautilus-extensions/nautilus-string.h: Remove repeated
      	declaration for nautilus_str_get_prefix.
      	reviewed by: Ramiro Estrugo <ramiro@eazel.com>
      	* librsvg/rsvg-ft.c: (rsvg_ft_glyph_evict): Fix code that was
      	looking at the "prev" pointer of a victim after freeing it. Also
      	made some other code simplifications.
      	* src/nautilus-theme-selector.c:
      	(render_theme_name_and_description): Added an explicit call to
      	gtk_widget_realize before grabbing the style field and expecting
      	it to have gc's in it. Not sure why no one ran into this before.
  3. 01 Feb, 2001 9 commits
    • Maciej Stachowiak's avatar
      rolled over to ChangeLog-20010201. · c83cd904
      Maciej Stachowiak authored
      	* ChangeLog: rolled over to ChangeLog-20010201.
    • Ramiro Estrugo's avatar
      A little better documentation. · 02ccd115
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-clickable-image.h:
      	A little better documentation.
      	* libnautilus-extensions/nautilus-labeled-image.c:
      	* libnautilus-extensions/nautilus-labeled-image.h:
      	New functions for creating stock buttons from pixbuf filenames.
      	Also a little better documentation.
      	reviewed by: Maciej Stachowiak  <mjs@eazel.com>
      	* libnautilus-extensions/nautilus-clickable-image.c:
      	* libnautilus-extensions/nautilus-clickable-image.h:
      	Need to store the connection ids to properly diconnect them on
      	unrealize.  Otheriwse bad things happen.
      	* components/services/nautilus-dependent-shared/eazel-services-extensions.h:
      	* components/services/nautilus-dependent-shared/eazel-services-extensions.c:
      	(eazel_services_label_new), (eazel_services_label_new_clickable):
      	Add new functions to create clickable images and labels.
      	* components/services/nautilus-dependent-shared/eazel-services-footer.c:
      	(eazel_services_footer_initialize), (footer_destroy),
      	(footer_item_clicked_callback), (footer_item_enter_callback),
      	(footer_item_leave_callback), (footer_item_new):
      	Made a lot simpler by using clickable images.  It could be even
      	simpler if the clickable images handled all the prelighting
      	details.  Thats a possible improvement.
    • Eskil Heyn Olsen's avatar
      This patch is temporarily going to break a few things, will sync up with · d9cc084e
      Eskil Heyn Olsen authored
      2001-02-01  Eskil Heyn Olsen  <eskil@eazel.com>
      	This patch is temporarily going to break a few things, will sync
      	up with Robey tomorrow. Eg. eazel-install (cli tool) now sigsegvs
      	on error.
      	* components/rpmview/nautilus-rpm-view-install.c:
      	* components/rpmview/nautilus-rpm-view.c:
      	* components/services/install/command-line/eazel-alt-install-corba.
      	c: (eazel_preflight_check_signal):
      	If there were problems, abort.
      	* components/services/install/command-line/eazel-test-softcat.c:
      	* components/services/install/lib/eazel-install-corba-callback.c:
      	(impl_download_progress), (impl_download_failed), (impl_dep_check),
      	(impl_install_progress), (impl_uninstall_progress),
      	* components/services/install/lib/eazel-install-corba.c:
      	* components/services/install/lib/eazel-install-logic.c:
      	(eazel_install_check_for_file_conflicts), (ei_revert_transaction),
      	(eazel_install_prune_packages), (eazel_install_fetch_dependencies),
      	ifdeffed out a lot of old code that's no longer used, but it still
      	compiles. logic.c will soon be entirely removed.
      	Uninstall stuff uses the new PackageBreaks objects.
      	* components/services/install/lib/eazel-install-logic2.c:
      	(dump_tree_helper), (eazel_install_check_existing_packages),
      	(get_softcat_info), (dedupe_foreach_depends), (is_satisfied),
      	(check_update_for_no_more_file_conflicts), (check_tree_helper),
      	(find_break_by_package_name), (add_file_conflict),
      	(check_feature_consistency), (install_packages_helper):
      	Nicer output.
      	Fixes 6172 and 6173.
      	* components/services/install/lib/eazel-install-protocols.c:
      	Removed unused define
      	* components/services/install/lib/eazel-install-rpm-glue.c:
      	More code ifdeffed out, see comment for eazel-install-logic.c
      	* components/services/install/lib/eazel-install-xml-package-list.c:
      	(parse_package), (eazel_install_packagedata_to_xml_int),
      	(eazel_install_packagelist_to_xml), (osd_parse_shared):
      	Use the new PackageBreak objects.
      	* components/services/install/lib/eazel-package-system-rpm3.c:
      	(make_rpm_argument_list), (rpm_packagedata_new_from_file),
      	* components/services/install/lib/eazel-package-system-types.h:
      	* components/services/install/lib/eazel-package-system-types.c:
      	(categorydata_destroy_foreach), (packagedependency_new),
      	(packagedependency_copy), (packagedependency_destroy),
      	(packagedata_finalize), (packagedata_class_initialize),
      	(packagedata_initialize), (packagedata_copy),
      	(packagedata_remove_soft_dep), (packagedata_get_readable_name),
      	(packagedata_add_pack_to), (packagedata_add_to_breaks),
      	(packagedata_add_pack_to_modifies), (packagedata_list_prune),
      	(add_string_list), (dump_package_break_list),
      	(packagedata_dump_int), (packagebreaks_finalize),
      	(packagebreaks_class_initialize), (packagebreaks_initialize),
      	(packagebreaks_get_type), (packagebreaks_new),
      	(packagebreaks_set_package), (packagebreaks_get_package),
      	(packagefileconflict_initialize), (packagefileconflict_get_type),
      	(packagefileconflict_new), (packagefeaturemissing_finalize),
      	(packagefeaturemissing_get_type), (packagefeaturemissing_new):
      	Wrote some objects representing package breakage.
      	* components/services/install/lib/eazel-package-system.c:
      	* components/services/install/lib/eazel-softcat.c:
      	Fixed the function so it matches the intended semantics
      	* components/services/install/nautilus-view/nautilus-service-instal
      	l-view.c: (nautilus_service_install_view_update_from_uri):
      	Merge from PR3 branch
      	2001-01-26  Eskil Olsen  <eskil@eazel.com>
       	reviewed by: Ramiri Estrugo <ramiro@eazel.com>
       	* components/services/install/command-line/eazel-test-packsys.c:
       	Testing the Mozilla hack...
       	* components/services/install/lib/eazel-package-system-rpm3.c:
       	Special case for Mxx versions because rpmvercmp is not obeying
       	the laws of mathematics...
       	* components/services/install/lib/eazel-softcat.c:
       	Fix for 6055 - no longer use hardcoded RedHat62 as distro.
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 33f219c3
      Ramiro Estrugo authored
      	* libnautilus-extensions/Makefile.am:
      	New files.
      	* libnautilus-extensions/nautilus-art-extensions.c:
      	* libnautilus-extensions/nautilus-art-extensions.h:
      	Make the align function actually work.  The previous version was
      	copied from GtkPixmap and i didnt realize it did not work.  Remove
      	the padding parameters which are not really needed for alignment.
      	* libnautilus-extensions/nautilus-clickable-image.h:
      	* libnautilus-extensions/nautilus-clickable-image.c:
      	New class.  A clickable image.
      	* libnautilus-extensions/nautilus-labeled-image.h:
      	* libnautilus-extensions/nautilus-labeled-image.c:
      	New class.  A labeled image.
      	* libnautilus-extensions/nautilus-image.h:
      	* libnautilus-extensions/nautilus-image.c:
      	(nautilus_image_expose_event), (image_get_pixbuf_bounds),
      	(image_is_smooth), (nautilus_image_set_is_smooth),
      	(nautilus_image_get_is_smooth), (nautilus_image_new_solid),
      	Add never smooth attribute to force behavior to match GTK+ for
      	cases when consistency is most important.
      	Update for alignment art extensions api change.
      	Some minor paramter name changes to lose abbreviations.
      	* libnautilus-extensions/nautilus-label.h:
      	* libnautilus-extensions/nautilus-label.c:
      	(nautilus_label_size_request), (nautilus_label_expose_event),
      	(label_get_text_bounds), (label_is_smooth),
      	(nautilus_label_set_is_smooth), (nautilus_label_get_is_smooth),
      	(nautilus_label_new_solid), (nautilus_label_set_never_smooth):
      	Add never smooth attribute to force behavior to match GTK+ for
      	cases when consistency is most important.
      	Update for alignment art extensions api change.
      	Update for alignment art extensions api change.
      	Some minor paramter name changes to lose abbreviations.
      	* libnautilus-extensions/nautilus-smooth-widget.c:
      	Add some comments explaining why using 0 for ancestor offsets
      	Fix a really dumb bug, the paddings where multiplies by 2 twice
      	instead of once.
      	* test/.cvsignore:
      	* test/Makefile.am:
      	* test/test-nautilus-clickable-image.c: (clicked_callback),
      	(enter_callback), (leave_callback), (clickable_image_new), (main):
      	* test/test-nautilus-label-background.c:
      	* test/test-nautilus-label-scrolled.c: (label_window_new_scrolled),
      	* test/test-nautilus-label-simple.c: (main):
      	* test/test-nautilus-label.c: (main):
      	* test/test-nautilus-labeled-image.c: (labeled_image_new),
      	(labeled_image_window_new), (labeled_image_button_window_new),
      	* test/test-nautilus-pixbuf-tile.c:
      	(drawable_drawing_area_expose_event), (main):
      	* test/test-nautilus-preferences-change.c: (main):
      	* test/test.c: (test_init):
      	New tests for clickable and labeled images.  Many updates to other
      	Also, changed many instances of NautilusFooDetail to
              NautilusFooDetails as well as the corresponding members.
    • Gene Z. Ragan's avatar
      Additional work on first time druid gmc to nautilus conversion routines. · 93ea1a9d
      Gene Z. Ragan authored
      2001-02-01  Gene Z. Ragan  <gzr@eazel.com>
      	Additional work on first time druid gmc to nautilus conversion routines.
      	* src/nautilus-first-time-druid.c: (druid_finished),
      	(convert_gmc_desktop_icons), (transition_value_changed):
      	Make gmc link to Nautilus link conversion more complete
      	* libnautilus-extensions/nautilus-gnome-extensions.c:
      	* libnautilus-extensions/nautilus-gnome-extensions.h:
      	New utility routine to return path to an installed terminal application
      	Call above function
      	* libnautilus-extensions/nautilus-link.c:
      	* libnautilus-extensions/nautilus-link.h:
      	New function to create a nautilus link from .desktop entry data
      	It's hard to be hated by millions.  Make gmc to nautilus link transition much better.
      	We now can support converted .desktop links that require a terminal. Also, get rid
      	of gnome-vfs symlinks and use the command: specifier to launch instead.  This was not possible
      	earlier, but due to a recent bug fix by me, we can now use this specifier in a
      	Nautilus link.
      	* src/file-manager/fm-desktop-icon-view.c: (create_mount_link),
    • Maciej Stachowiak's avatar
      reviewed by: Darin Adler <darin@eazel.com> and Eli Goldberg · 5f911e3c
      Maciej Stachowiak authored
      	* THANKS: Gave credit where it's due. Added a section for testers.
      	* check-THANKS.pl: Don't fail if the about box file is not present
      	so this script can be used on modules other than Nautilus; also,
      	added some address aliases.
    • Rebecca Schulman's avatar
      Fixed bug 5245, that words used in the search bar were used elsewhere, · c1e44284
      Rebecca Schulman authored
      2001-01-31  Rebecca Schulman  <rebecka@eazel.com>
      	Fixed bug 5245, that words used in the search bar were used
      	elsewhere, such that they could not be translated correctly for
      	both contexts.  The fix was to wrap all of the strings used to
      	display both the search bar, and the description of
      	search results in bracketed context and write a function
      	to remove the bracketed text before displaying.
      	reviewed by: Darin Adler <darin@eazel.com>
      	* libnautilus-extensions/nautilus-search-uri.c:
      	Added comments and wrapped the text to be translated in bracketed
      	(get_translated_criterion), (get_nth_criterion_prefix),
      	(parse_uri):  Call nautilus_str_remove_bracketed_text
      	on appropriate strings before displaying.
      	* libnautilus-extensions/nautilus-string.h:
      	* libnautilus-extensions/nautilus-string.c:
      	(nautilus_str_remove_bracketed_text), (nautilus_self_check_string):
      	Add the debracketing function and tests for it.
      	* src/nautilus-search-bar-criterion.c:
      	Added comments and wrapped the text to be translated in bracketed
      	Call nautilus_str_remove_bracketed_text on appropriate strings
      	before displaying.
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 6252fcac
      John Sullivan authored
      	Fixed bug 6162 (need option to stop "xx items" from being
      	calculated for ftp:// locations)
      	Added a speed tradeoff preference for showing directory
      	counts. It's "local-only" for Beginner and "always" (but
      	changeable) for Intermediate/Advanced.
      	Fixed bug 1856 (fix hideous hack to kick-start embedded-text
      	reading when preference changes)
      	Fixed bug 2396 (properties window doesn't show/hide
      	"special flags" when preference changes)
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(dequeue_pending_idle_callback): Update for name change.
      	(lacks_directory_count): Now checks preference by calling
      	(should_get_directory_count_now): Renamed to add the "_now"
      	to help distinguish from
      	(directory_count_start): Update for name change.
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(emit_change_signals_for_all_files): New function, emits change
      	signals for self-as-file (if applicable) and all contained files.
      	(async_state_changed_one): New hash-table function, calls
      	emit_change_signals_for_all_files on a directory.
      	(async_data_preference_changed_callback): New preferences-changed
      	callback, calls async_state_changed_one on each directory.
      	(add_preferences_callbacks): Renamed from add_filtering_callbacks,
      	now adds callbacks for top-left text and item counts preferences.
      	(remove_preferences_callbacks): Renamed from remove_filtering_callbacks,
      	now removes callbacks for top-left text and item counts preferences.
      	(nautilus_directory_get_internal): Update for name change.
      	(nautilus_directory_emit_change_signals): renamed from
      	_emit_change_signals_deep to avoid recursion connotation.
      	(call_files_changed_unref_free_list): Update for name change.
      	* libnautilus-extensions/nautilus-file.c:
      	(get_speed_tradeoff_preference_for_file): New utility function,
      	returns boolean based on local-ness of file and value of
      	specified speed-tradeoff preference.
      	(nautilus_file_should_get_top_left_text): Now calls
      	(nautilus_file_should_show_directory_item_count): New function,
      	calls get_speed_tradeoff_preference_for_file.
      	(nautilus_file_get_deep_counts): Bail out early without computation
      	if _should_show_directory_item_count is FALSE.
      	(nautilus_file_changed): Update for name change.
      	* libnautilus-extensions/nautilus-file.h: Make
      	nautilus_file_should_show_directory_item_count public so the
      	preferences window can make UI decisions based on it.
      	* libnautilus-extensions/nautilus-global-preferences.h:
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_create_dialog): Add new preference
      	default values and UI.
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_initialize), (fm_directory_view_destroy):
      	Remove hideous hack.
      	* src/file-manager/fm-properties-window.c:
      	(append_separator): Return widget instead of row number.
      	(attach_directory_contents_value_field): Return widget.
      	(update_visibility_of_table_rows): New helper function to
      	update visibility of a series of table rows & contained
      	(update_visibility_of_item_count_fields): New function
      	to update visibility of directory item count widgetry.
      	(update_visibility_of_item_count_fields_wrapper): Simple
      	wrapper for above.
      	(append_directory_contents_fields): Remember item counts
      	widgetry so it can be shown/hidden later; set up prefs
      	callback; change signature for to pass window.
      	(create_basic_page), (create_permissions_page):
      	store table in window->details; update for changed signatures.
      	(append_special_execution_checkbox): Now takes window,
      	don't use GTK_EXPAND to avoid resizing column unnecessarily,
      	count number of special flags rows.
      	(update_visibility_of_special_flags_widgets): New function
      	to update visibility of special flags widgetry.
      	Simple wrapper for above.
      	(append_special_execution_flags): Remember special flags
      	widgetry so it can be shown/hidden later; set up prefs
      	callback; change signature to pass window.
      	(real_destroy): free widget lists.
    • Maciej Stachowiak's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 9f375cda
      Maciej Stachowiak authored
      	* src/nautilus-application.c (nautilus_application_startup): Don't
      	loop more than 20 times when we get OAF_REG_ALREADY_ACTIVE trying
      	to register the factory, instead display an error message that
      	suggests killing oafd.
  4. 31 Jan, 2001 14 commits
    • Arik Devens's avatar
      Updated insert function to evict everytime we are above the cache 'limit' not... · ec198c12
      Arik Devens authored
      Updated insert function to evict everytime we are above the cache 'limit' not just when adding the glyph would put us above.
    • Darin Adler's avatar
      reviewed by: Michael Engber <engber@eazel.com> · 140b9c15
      Darin Adler authored
      	Fix bug 6192 ("mapped before underway" warning when clicking on
      	any sidebar tab).
      	* src/nautilus-view-frame.c: (nautilus_view_frame_map): Remove
      	inappropriate check of state, and replace it with a simple NULL
      	check that handles the failed case.
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(nautilus_file_background_is_set): Fixed backwards logic by
      	removing an erroneous "!".
      	* libnautilus-extensions/nautilus-icon-factory.c: Formatting
      	* src/file-manager/fm-directory-view.c: Formatting tweak.
      	* src/nautilus-application.c: (nautilus_application_startup):
      	Fixed comment.
      	(check_for_and_run_as_super_user): Formatting tweak.
    • Pavel Cisler's avatar
      reviewed by: Gene Z. Ragan <gzr@eazel.com> · 17955b15
      Pavel Cisler authored
      2001-01-31  Pavel Cisler  <pavel@eazel.com>
      	reviewed by: Gene Z. Ragan <gzr@eazel.com>
      	Fix 5324 (Should get rid of stack-based GnomeVFSFileInfo)
      	* components/adapter/bonobo-stream-vfs.c: (vfs_get_info):
      	Nuked some unused code that contained gnome_vfs_file_info_init.
      	* components/adapter/nautilus-adapter-progressive-load-strategy.c:
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(path_represents_svg_image), (get_cache_time):
      	* libnautilus-extensions/nautilus-thumbnails.c:
      	* src/nautilus-window-menus.c: (get_static_bookmarks_file_path):
      	Get rid of gnome_vfs_file_info_init.
      	Replace all instances of stack-based GnomeVFSFileInfo
      	structures, replace all calls to gnome_vfs_file_info_init
      	with gnome_vfs_file_info_new.
      	Replace most calls to gnome_vfs_file_info_clear with
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	Rework to use gnome_vfs_uri_exists instead of trying to get
      	file info.
      	* components/adapter/nautilus-adapter-progressive-load-strategy.c:
      	Fixed a bug where file info fields were being used after a
      	gnome_vfs_file_info_clear call
      	Fix 6146 ("Duplicate File" reports "You cannot copy a file
      		   over itself")
      	* libnautilus-extensions/nautilus-file-operations.c:
      	Make copying iside the same directory while the
      	GNOME_VFS_XFER_USE_UNIQUE_NAMES move_option is set legal.
    • Ian McKellar's avatar
      reviewed by: Maciej Stachowiak <mjs@eazel.com> · 0e35d70c
      Ian McKellar authored
      	reviewed by: Maciej Stachowiak  <mjs@eazel.com>
      	* components/services/inventory/Trilobite_Service_inventory.oaf.in:
      	Fixed a tyop in the path to the trilobite-inventory-service
      	* components/services/inventory/eazel-inventory-utils.h:
      	* components/services/inventory/eazel-inventory-service.c:
      	Moved the GConf path for machine name to
      	Improved error reporting / debugging. Actually save the MD5.
      	* components/services/inventory/eazel-inventory-utils.c:
      	(add_package_info), (add_software_info),
      	Fixed memory leaks.
      	Added a function to store the MD5.
      	* nautilus.spec.in:
      	Add inventory files to the right RPMs.
    • Arik Devens's avatar
    • Arik Devens's avatar
    • Maciej Stachowiak's avatar
      reviewed by: George Lebl <jirka@5z.com> · 0f36e565
      Maciej Stachowiak authored
      	Fix bug 4448 (install-server needs session management juju)
      	* components/services/install/server/main.c: (main): Add call to
      	* components/services/trilobite/sample/service/main.c: (main): Add
      	call to `gnome_client_disable_master_connection'
    • Maciej Stachowiak's avatar
      reviewed by: Ramiro Estrugo <ramiro@eazel.com> · 54f40d3b
      Maciej Stachowiak authored
      	Mass refactoring of summary view code to make needed summary view
      	fixes more managable. In the process, fixed bugs 4555 (Version
      	display for featured softcat downloads) and 5795 (Summary View
      	text doesn't wrap.) Also, cleaned up assorted pieces of text.
      	* components/services/summary/nautilus-view/nautilus-summary-view.c
      	: (update_header), (create_header), (update_footer),
      	(create_footer), (summary_view_button_callback),
      	(summary_view_button_new), (summary_view_item_label_new),
      	(summary_view_item_body_label_new), (append_hseparator_to_vbox),
      	(generate_eazel_news_entry_row), (summary_view_update_pane),
      	(summary_view_create_pane), (update_news_pane),
      	(generate_service_entry_row), (update_services_list_pane),
      	(create_services_list_pane), (generate_update_news_entry_row),
      	(generate_summary_form), (nautilus_summary_view_initialize),
      	(nautilus_summary_view_destroy), (summary_load_location_callback),
      	(text_resize_callback): Factor the monolithic summary view code up
      	more. The next step is to create a widget class to manage each
      	pane, and to create the base layout once and only change the pane
      	contents on recipt of summary XML or login.
      	* components/services/summary/nautilus-view/nautilus-summary-callbacks.h,
      	Remove tab selected callbacks since they are no longer used.
      	* components/services/summary/nautilus-view/nautilus-summary-view-private.h:
      	Removed lots of unneeded fields in the details struct; changed
      	button labels, "Go There!" --> "Go There", "More Info!" --> "More
      	Info", "Install Me!" --> "Install"
    • Ramiro Estrugo's avatar
      reviewed by: Gene Z. Ragan <gzr@eazel.com> · 00452d37
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-debug-drawing.c:
      	* libnautilus-extensions/nautilus-gdk-extensions.c:
      	* libnautilus-extensions/nautilus-gdk-extensions.h:
      	Remove unused code.
    • Robey Pointer's avatar
      reviewed by: Eskil Heyn Olsen <eskil@eazel.com> · 3aab1848
      Robey Pointer authored
      	* components/services/install/lib/eazel-install-corba-types.c:
      	* components/services/install/lib/eazel-install-logic.c:
      	* components/services/install/lib/eazel-install-problem.c:
      	* components/services/install/lib/eazel-package-system-types.c:
      	(packagedata_initialize), (packagedata_finalize),
      	(packagedata_copy), (packagedata_fill_in_missing),
      	(packagedata_destroy), (packagedata_dump_int):
      	* components/services/install/lib/eazel-package-system-types.h:
      	* components/rpmview/nautilus-rpm-view-install.c:
      	Remove unused hard_depends member from PackageData.
      	* components/services/install/lib/eazel-install-logic2.c:
      	(dump_tree_helper), (prune_failed_packages_helper),
      	(prune_failed_packages), (eazel_install_check_existing_packages),
      	(get_softcat_info), (dedupe_foreach_depends), (is_satisfied),
      	(check_tree_helper), (check_tree_for_conflicts),
      	(download_packages), (set_toplevel), (install_packages):
      	* components/services/install/lib/eazel-install-protocols.c:
      	(eazel_install_fetch_package), (flatten_tree_func):
      	* components/services/install/lib/eazel-package-system-rpm3.c:
      	* components/services/install/lib/eazel-package-system.c:
      	Backport Eskil's recursive-dep fix from PR3.  Use
      	name/sense/version to hash completed dependencies, so files will
      	work (not just softcat packages).
      	* components/services/install/lib/eazel-install-xml-package-list.c:
      	(parse_package), (eazel_install_packagedata_to_xml_int),
      	(eazel_install_packagedata_to_xml), (osd_parse_shared):
      	The best of all worlds: some backported PR3 patches from Eskil,
      	some removal of hard_depends usage, and some new code to encode &
      	decode the RPM filesize from the XML generated across the corba
      	* components/services/install/nautilus-view/nautilus-service-instal
      	l-view.c: (nautilus_service_install_view_destroy),
      	(nautilus_install_parse_uri), (update_package_info_display),
      	(nautilus_service_install_done), (nautilus_service_install_failed),
      	* components/services/install/nautilus-view/nautilus-service-instal
      	Backport changes to the install view from PR3 (I should've done
      	this when I checked them into PR3 but I was brain-fried): No
      	longer cylon (use the throbber to indicate busy-ness) and handle
      	early cancels better.  Also some new stuff to use the more
      	accurate filesize counts.
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 1479770a
      Ramiro Estrugo authored
      	Fix bug 5763 - Largest fitting font logic in Sidebar title causes
      	font criticals.  Cleanup some related stuff in the process.
      	* libnautilus-extensions/nautilus-font-factory.h:
      	* libnautilus-extensions/nautilus-font-factory.c:
      	Move these functions to nautilus-gdk-font-extensions.[ch].
      	* libnautilus-extensions/nautilus-gdk-font-extensions.h:
      	* libnautilus-extensions/nautilus-gdk-font-extensions.c:
      	(nautilus_gdk_font_get_largest_fitting), Rewrite the function to
      	not depend on any hard coded font sizes or XLFD names.
      	(nautilus_gdk_font_get_name), New function.
      	(nautilus_gdk_font_get_size_in_pixels), (unref_fixed_font),
      	(nautilus_gdk_font_xlfd_string_new), Move these 2 here from
      	* libnautilus-extensions/nautilus-scalable-font.h:
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(parse_font_description_file), (font_compare),
      	(font_family_find_font), (font_family_lookup),
      	(font_family_lookup_with_insertion), (font_family_table_add_fonts),
      	(nautilus_scalable_font_largest_fitting_font_size), Rewrite this
      	function to work just like nautilus_gdk_font_get_largest_fitting()
      	for greater consistency.
      	(nautilus_scalable_font_query_font), (text_layout_free_row),
      	(nautilus_text_layout_new), (nautilus_text_layout_paint):
      	Use signed integers for dimensions.  Lots of cleanup to comply
      	with the Nautilus coding style.
      	* libnautilus-extensions/nautilus-string-list.h:
      	* libnautilus-extensions/nautilus-string-list.c:
      	Use signed integers instead of guint.
      	* src/nautilus-sidebar-title.c: (update_font):
      	Update for largest fitting font api changes.  Get rid of the hard
      	coded list of font sizes.
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · e6396973
      Darin Adler authored
      	Fixed bug 5726 (In single-window mode, activating desktop icons
      	should use frontmost window).
      	* src/nautilus-window-manage-views.c:
      	(get_topmost_nautilus_window): New function.
      	(open_location): For desktop in one-window mode, reuse the topmost
      	window if there is one instead of making new window every time.
    • Ramiro Estrugo's avatar
      reviewed by: Gene Z. Ragan <gzr@eazel.com> · 0a186a4b
      Ramiro Estrugo authored
      	* applets/preferences-applet/nautilus-preferences-applet.c:
      	(quit_button_clicked_callback), (main):
      	Add a quit button that invokes "nautilus --quit."
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · ce4e7c67
      Darin Adler authored
      	Fix bug 6147 (selected icons flash unselected/selected rapidly):
      	* src/nautilus-window-manage-views.c: (change_selection): Don't
      	send out selection change notices to the view that reported the
      	selection change.
      	(change_selection_callback): Pass in view that requested the
      	change so we can know not to send a selection change to that view.
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_send_selection_change): Clear flag that says we
      	have a selection change for the shell.
      	(selection_changed_callback): Add code to indicate this selection
      	change is due to the shell, so we don't tell the shell about
      	something it just told us.
      	(done_loading): Set flag so we don't tell the shell about selection
      	changes that are part of the first load of the directory.
      	(display_selection_info_idle_callback): Only send a selection change
      	to the shell if the change was initiated here. Also remove the code
      	that ref's the NautilusView object -- wasn't helping.
      	(update_menus_timeout_callback), (display_pending_idle_callback),
      	(display_pending_timeout_callback): Remove the code that ref's the
      	NautilusView object -- wasn't helping.
      	(fm_directory_view_notify_selection_changed): Propagate flag that
      	tells the idle code we have made the change to the selection and
      	the shell should be notified.
      	Fix bug 6158 (nautilus --quit shouldn't check for
      	* src/nautilus-main.c: (main): Don't do the first-time druid check
      	when the --quit or --restart option is used.
      	Fix bug 803 (All metafile tags should be lower case).
      	* libnautilus-extensions/nautilus-metadata.h: Use lower-case for
      	metadata tags.
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(create_metafile_root), (get_file_node),
      	(nautilus_directory_set_metafile_contents): Change metadata tags
      	to be lower-case.
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_self_check_directory): Use lower-case in metadata
      	self-test for clarity.
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_get_keywords), (nautilus_file_set_keywords): Change
      	metadata tags to be lower-case.
      	* data/top/.nautilus-metafile.xml
      	* icons/ardmore/ardmore.xml:
      	* icons/arlo/arlo.xml:
      	* icons/arlo/i-directory.xml:
      	* icons/arlo/i-regular.xml:
      	* icons/crux_eggplant/crux_eggplant.xml:
      	* icons/crux_eggplant/i-directory.xml:
      	* icons/crux_eggplant/i-regular.xml:
      	* icons/default.xml:
      	* icons/gnome/gnome.xml:
      	* icons/i-directory-accept.xml:
      	* icons/i-directory.xml:
      	* icons/i-regular.xml:
      	* icons/villanova/villanova.xml:
      	Change XML to use lower-case.
      	* libnautilus-extensions/nautilus-link-set.c: (create_new_link):
      	Use lower-case for link XML tags.
      	* libnautilus-extensions/nautilus-link.c:
      	(nautilus_link_local_create), (nautilus_link_local_set_link_uri),
      	(nautilus_link_get_link_uri_given_file_contents): Use lower-case
      	for link XML tags.
      	* src/nautilus-sidebar-title.c:
      	(nautilus_sidebar_title_theme_changed): Use lower-case for theme
      	XML tags.
      	* components/throbber/nautilus-throbber.c:
      	(get_bonobo_properties), (nautilus_throbber_initialize),
      	(nautilus_throbber_button_press_event): Change theme XML tags to be
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(start_rubberbanding): Use lower-case for theme XML tags.
      	(nautilus_icon_container_initialize): Fix comment.
      	(update_label_color), (nautilus_icon_container_theme_changed): Use
      	lower-case for theme XML tags.
      	* libnautilus-extensions/nautilus-icon-factory.c: (set_theme): Use
      	lower-case for theme XML tags.
      	(get_themed_icon_file_path): Use lower-case for icon XML file
      	(icon_theme_changed_callback): Use lower-case for theme XML tags.
      	* src/nautilus-sidebar-tabs.c:
      	(nautilus_sidebar_tabs_load_theme_data), (get_text_offset): Use
      	lowe-case for theme XML tags.
      	* src/nautilus-sidebar.c: (nautilus_sidebar_update_appearance):
      	Use lower-case for theme XML tags.
      	* src/nautilus-window-toolbars.c: (get_file_name_from_icon_name):
      	Use lower-case for theme XML tags.
      	* src/nautilus-zoom-control.c: (draw_number): Use lower-case for
      	theme XML tags.
      	Change code that used GSList when it should use GList. We use
      	GList so that we can share utility functions. It's arbitrary. We
      	could have decided to use all GSList instead, but we chose GList
      	(because of its name, initially).
      	* components/tree/nautilus-tree-expansion-state.c:
      	(hash_table_get_keys_callback), (hash_table_get_keys),
      	(nautilus_tree_expansion_state_save_table_to_gconf): Update to use
      	GList instead of GSList.
      	* libnautilus-extensions/nautilus-gconf-extensions.h:
      	* libnautilus-extensions/nautilus-gconf-extensions.c:
      	(nautilus_gconf_handle_error), (nautilus_gconf_set_string_list),
      	(nautilus_gconf_get_string_list): Change to work with GList
      	instead of GSList to match the rest of Nautilus, so that the lists
      	can be manipulated with all the GList utility functions.
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	(nautilus_round): Changed name from nautilus_g_round -- "g" for
      	(nautilus_g_list_from_g_slist), (nautilus_g_slist_from_g_list):
      	Added utility functions to help make GSLists from GLists and vice
      	versa. Useful when dealing with functions that yield/expect
      	* libnautilus-extensions/nautilus-icon-text-item.c: (iti_destroy),
      	(iti_update), (iti_paint_text), (iti_draw), (iti_render),
      	(iti_event): Use nautilus_round by its new name.
      	* libnautilus-extensions/nautilus-preferences.h:
      	* libnautilus-extensions/nautilus-preferences.c:
      	(nautilus_preferences_default_get_string_list): Change to use
      	GList instead of GSList.
      	* libnautilus-extensions/nautilus-search-uri.c:
      	(free_tokenized_uri), (tokenize_uri), (get_translated_criterion),
      	(get_nth_criterion_prefix), (parse_uri): Change to use GList
      	instead of GSList.
      	* src/nautilus-application.h:
      	* src/nautilus-application.c:
      	(nautilus_application_get_window_list): Renamed from
      	nautilus_application_windows and changed to use GList instead of
      	(nautilus_application_create_window), (volume_unmounted_callback):
      	Change to use GList instead of GSList.
      	* src/nautilus-shell.c: (save_window_states),
      	(restore_window_states): Use GList instead of GSList.
      	* src/nautilus-window-manage-views.c: (just_one_window): Use GList
      	instead of GSList.
      	(open_location_prefer_existing_window_callback): Use GList instead
      	of GSList.
      	* src/nautilus-window.c: (nautilus_forget_history): Use GList
      	instead of GSList and the new name for
      	Other changes.
      	* src/nautilus-shell.c: (display_caveat_first_time): Turn off the
      	caveat -- we're close enough to 1.0.
      	* libnautilus-extensions/nautilus-view-identifier.c:
      	(nautilus_view_identifier_new_from_oaf_server_info): Use free_deep
      	* libnautilus/nautilus-view-standard-main.h: Use
      	* src/file-manager/fm-desktop-icon-view.c: Remove unneeded
  5. 30 Jan, 2001 12 commits
    • Maciej Stachowiak's avatar
      reviewed by: Gene Z. Ragan <gzr@eazel.com> · edae9104
      Maciej Stachowiak authored
      	* components/tree/libmain.c: (tree_shlib_object_destroyed):
      	Removed accidentally checked in call to `oaf_plugin_unuse' to fix
      	bug 6154 (creating new window after closing initial window crashes
      	creating tree view). It's not actually safe to unload a shared
      	library that declares a GtkType because it makes Gtk unhappy.
    • Ramiro Estrugo's avatar
      Fix bug 5899 - "Do slower, complete search" preference needs to include · 38fc7f36
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	* libnautilus-extensions/nautilus-preferences.c:
      	Fix bug 5899 - "Do slower, complete search" preference needs to
      	include explanation.
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 6f97df33
      John Sullivan authored
      	Fixed bug 6153 (confusing error message after trying to
      	navigate to "foo")
      	* src/nautilus-window-manage-views.c:
      	Improved the error message for this case so that it's
      	more likely to be helpful.
    • Martin Norbäck's avatar
      Marked string for translation. · a8801cf4
      Martin Norbäck authored
      2001-01-30  Martin Norbäck  <d95mback@dtek.chalmers.se>
              * libnautilus-extensions/nautilus-file-operations-progress.c:
              Marked string for translation.
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · a4307b0b
      John Sullivan authored
      	Fixed bug 5863 (visiting a directory makes its property-window
      	deep count start again from scratch)
      	* libnautilus-extensions/nautilus-directory-async.c:
      	Renamed from _invalidate_counts, no longer resets the
      	deep count when resetting the shallow count and MIME
      	list. (There's already a separately-used API for resetting
      	the deep count.)
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(invalidate_one_count), (invalidate_count_and_unref):
      	Updated for name change.
    • Ramiro Estrugo's avatar
      Add an example of how to do dynamic wrapping. · b6916e3f
      Ramiro Estrugo authored
      	* test/test-nautilus-label-wrapped.c: (size_allocate_callback),
      	Add an example of how to do dynamic wrapping.
    • Robey Pointer's avatar
      reviewed by: Eskil Heyn Olsen <eskil@eazel.com> · b1e4974e
      Robey Pointer authored
      	* components/services/install/idl/trilobite-eazel-install.idl:
      	* components/services/install/lib/eazel-install-corba-types.c:
      	* components/services/install/lib/eazel-package-system-types.c:
      	(packagedata_initialize), (packagedata_finalize),
      	(packagedata_copy), (packagedata_fill_in_missing),
      	* components/services/install/lib/eazel-package-system-types.h:
      	* components/services/install/lib/eazel-softcat.c:
      	(get_search_url_for_package), (eazel_softcat_get_info):
      	Add "suite_id" field to the PackageData and corba struct, for
      	packages that actually refer to a group of packages, not just one.
      	* components/services/install/lib/eazel-install-logic.c:
      	* components/services/install/lib/eazel-install-logic.h:
      	* components/services/install/lib/eazel-install-object.c:
      	(eazel_install_start_signal), (eazel_install_end_signal),
      	(eazel_install_progress_signal), (eazel_install_failed_signal):
      	Move four signal calls into the file they're used in, so that
      	someday in the startrek future, we can get rid of the old
      	logic.[ch] files.
    • Pavel Cisler's avatar
      reviewed by: Gene Z. Ragan <gzr@eazel.com> · d4b025f1
      Pavel Cisler authored
      2001-01-29  Pavel Cisler  <pavel@eazel.com>
      	reviewed by: Gene Z. Ragan <gzr@eazel.com>
      	Fixed 5781 (results of load_directory must be passed in chunks
      		instead of the entire list)
      	Fixed 1438 (use plain GList instead of GnomeVFSDirectoryList)
      	* components/music/nautilus-music-view.c:
      	* components/services/vault/command-line/vault-operations.c:
      	* components/text/nautilus-text-view.c: (add_services_to_menu):
      	* libnautilus-extensions/nautilus-customization-data.c:
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(directory_load_callback), (directory_count_callback),
      	(start_monitoring_file_list), (directory_count_start),
      	(deep_count_callback), (deep_count_load), (mime_list_callback),
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	* src/file-manager/fm-directory-view.c:
      	* src/nautilus-link-set-window.c: (get_link_set_names):
      	* src/nautilus-location-bar.c: (try_to_expand_path):
      	* src/nautilus-theme-selector.c:
      	Switch the uses of GnomeVFSDirectoryList to a simple GList.
      	Get rid of the sort and reverse arguments to the load_directory
    • Arik Devens's avatar
    • John Sullivan's avatar
      Fixed bug 5974 (menu item to change Nautilus theme · 183bbff9
      John Sullivan authored
      	should mention "theme" in its name)
      	* src/nautilus-shell-ui.xml: After bugzilla discussion
      	with Vera, renamed "Change Appearance..." -> "Nautilus Themes..."
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	Reduced timed-wait initial timeout from 5 seconds to
      	3 after playing around with the gnome-vfs test-method.
    • Darin Adler's avatar
      reviewed by: Maciej Stachowiak <mjs@eazel.com> · e37c17c0
      Darin Adler authored
      	Fixed bug 2131 (Change Nautilus to use OAF asynchronous activation
      	interface). In making view activation work right, I also
      	eliminated the state machine that was almost gone from
      	NautilusWindow. There's still some additional simplification we
      	can do, but it's simpler than it was. At the same time, made sure
      	all incoming CORBA calls are deferred until idle time. This is
      	most of what the old state machine was accomplishing, believe it
      	or not, although it didn't do it 100%.
      	Also fixes bug 2457 (Silent error loading content view), bug 2461
      	(progress from old and new content view sometimes confused), and
      	bug 6109 (Assertion hit on clicking the refresh button many times
      	very quickly). Perhaps others too, we need to test some old bugs
      	to see if they have changed behavior.
      	* libnautilus-extensions/nautilus-bonobo-extensions.c:
      	(activation_handle_done), (activation_idle_callback),
      	(activation_cancel), (oaf_activation_callback),
      	(nautilus_bonobo_activate_cancel): Change implementation so that
      	the actual callback happens at idle time, since CORBA callbacks
      	can happen at almost any time.
      	* libnautilus/Makefile.am:
      	* libnautilus/nautilus-idle-queue.h:
      	* libnautilus/nautilus-idle-queue.c: (execute_queued_functions),
      	(nautilus_idle_queue_new), (nautilus_idle_queue_add),
      	(nautilus_idle_queue_destroy): Factored out the idle queueing that
      	I added to NautilusView so we can use it on the NautilusViewFrame
      	side too.
      	* libnautilus/nautilus-view.c: (queue_incoming_call),
      	(nautilus_view_initialize), (nautilus_view_destroy): Change to use
      	the new NautilusIdleQueue so we can share code.
      	* src/nautilus-view-frame-private.h:
      	* src/nautilus-view-frame-corba.c: (list_free_deep_callback),
      	(free_location_and_selection_callback), (open_in_this_window),
      	(open_prefer_existing_window), (open_force_new_window),
      	(report_selection_change), (report_status),
      	(report_load_underway), (report_load_progress),
      	(report_load_complete), (report_load_failed), (set_title),
      	(impl_Nautilus_ViewFrame_set_title): Deal with all incoming CORBA
      	calls through the idle queue.
      	* src/nautilus-view-frame.h: Moved all the fields into
      	details. Renamed client_loaded to view_loaded. Renamed load_client
      	to load_view. Eliminated load_client_sync. Renamed get_iid to
      	get_view_iid. Eliminated get_is_underway. Added
      	* src/nautilus-view-frame.c:
      	(nautilus_view_frame_queue_incoming_call): Simple cover for
      	putting an incoming CORBA call on the idle queue.
      	(nautilus_view_frame_initialize_class): Change client_loaded
      	signal name to view_loaded.
      	(nautilus_view_frame_initialize): Allocate the idle queue.
      	(stop_activation): New function that stops a load_view that is
      	(destroy_view): Use the "view" field to tell if a view was
      	loaded. The old code used the "iid" field, but now we set that
      	even before the load is completed.
      	(nautilus_view_frame_destroy): Destroy the idle queue. Also put
      	the view into "failed" state once it's destroyed so additional
      	calls are harmless.
      	(nautilus_view_frame_finalize): Check that we're in the failed
      	(emit_zoom_parameters_changed): New function so we can share more
      	(view_frame_activated): Emit the zoom_parameters_changed signal
      	here since a new view should always should get this signal.
      	(view_frame_underway): Make this do nothing in the failed case
      	instead of complaining.
      	(view_frame_loaded): Make this do nothing in the failed case
      	instead of complaining.
      	(view_frame_failed): Stop whatever's in progress when the view
      	fails. Also, allow calling this on a view that's already failed.
      	(check_if_view_is_gone): Consolidate the calls to
      	deregister_dead_components so we don't need an explicit call here.
      	(emit_zoom_level_changed_callback), (zoom_level_changed_callback):
      	Redo these so they queue onto the idle queue, since they are
      	triggered by incoming CORBA calls that can happen at any time.
      	(create_corba_objects): Factor out the part of the code that makes
      	the CORBA objects. Make error handling more complete and keep
      	around pointers to the Bonobo objects for various parts of the
      	aggregate so we can connect the appropriate signal handlers.
      	(attach_view): Change code so it no longer connects signals to the
      	BonoboObjectClient, since the signals won't go out on that
      	GtkObject. Connect to the exception signals for all objects in the
      	aggregate (any failure means "view failed"). Also connect to the
      	"destroy" signal for one object (doesn't matter which since the
      	entire aggregate goes away at once) and to the zoom-related
      	signals. Report errors with signals rather than returning a
      	(activation_callback): Add code to handle failure case.
      	(nautilus_view_frame_load_view): Renamed. Got rid of "sync."
      	(nautilus_view_frame_stop): Stop OAF activation of the view if
      	it's in progress.
      	(nautilus_view_frame_selection_changed): Make it a quiet no-op to
      	send a selection change notice if no view is loaded. This helps
      	keep the code simple for sidebars. Later we may make the view
      	frame responsible for sending the selection on once the view is
      	(nautilus_view_frame_title_changed): Same change as for selection,
      	same idea.
      	(nautilus_view_frame_zoom_in), (nautilus_view_frame_zoom_out),
      	(nautilus_view_frame_zoom_to_fit): Since a failed view has a
      	zoomable_frame field set to NULL, got rid of all the explicit
      	failure-case code for these functions.
      	(nautilus_view_frame_get_view_iid): Renamed from get_iid.
      	(nautilus_view_frame_report_load_failed): Moved the "quiet"
      	handling of failed views down into the underlying functions, so
      	these no longer need explicit failure-case code.
      	(nautilus_view_frame_set_label): It's OK to allow this even for a
      	failed view.
      	(nautilus_view_frame_map): Use a kept-around reference to the
      	control frame instead of relying on query_local_interface.
      	(nautilus_view_frame_get_is_view_loaded): Add this so callers can
      	tell when a sidebar view is not yet loaded. Might not need this
      	when we clean things up more, but it's no big deal either way.
      	* src/nautilus-window-manage-views.c: (update_title): No need to
      	send the title change to the new content view -- it gets a title
      	change once it comes up "for real".
      	(set_displayed_location): Handle location of NULL here so we don't
      	need to worry about it elsewhere.
      	(check_bookmark_location_matches): Remove "uri" from name.
      	(location_has_really_changed): Now that the state machine is gone,
      	it's easy to see that this is never called with pending_ni equal
      	to cancel_tag, so remove the code for that and add an assert.
      	(set_view_location_and_selection): New name for what was called
      	(set_sidebar_panels_location_and_selection): Cover since this loop
      	occurs in two places.
      	(update_for_new_location_and_selection): New name for what was
      	called set_view_location_and_selection. Since it's now clear this
      	can't be called with new_content_view equal to NULL, remove the
      	code to handle that (fixes bug 2457).
      	(load_content_view): Use async. view loading here. Get rid of
      	"Avoid being fooled by extra done notifications from the last
      	view. This is a HACK because the state machine SUCKS." by
      	eliminating the "cv_progress_done" and "cv_progress_error" flags
      	altogether. In the case where we reuse the same view, just call
      	update_for_new_location_and_selection -- the old code set
      	"view_activation_complete", but I eliminated that flag.
      	(handle_view_failure): Remove the old view using
      	nautilus_window_set_content_view_widget instead of having
      	duplicate code here. Use a call to cancel_location_change instead
      	of setting the "reset_to_idle" and "cv_progress_error" flags
      	(both gone now).
      	(free_location_change): No need to clean up "error_views" any
      	more, because that field is gone.
      	(end_location_change): New helper to stop the throbber from
      	throbbing and then free the location change state.
      	(cancel_location_change): Get rid of special case for NULL
      	location now that set_displayed_location can handle it.
      	(nautilus_window_end_location_change_callback): Remove
      	"superstitiously" added call to update_state and call
      	load_content_view_for_new_location directly.
      	(nautilus_window_begin_location_change): Use a call to
      	cancel_location_change to deal with the possibility that we may
      	have a change already in progress.
      	(nautilus_window_stop_loading): Use cancel_location_change to stop
      	the loading.
      	(nautilus_window_set_content_view): Remove calls to update_state
      	-- there's no state to update any more.
      	(nautilus_window_set_sidebar_panels): Do an async. load here and
      	finish the setup in the view_loaded callback.
      	(failed_callback): Do a handle_view_failed right here, now that we
      	have no state machine to satisfy.
      	(load_underway_callback): Change code to handle the two
      	interesting cases separately without a state machine. When the new
      	content view says "underway", it's time for
      	location_has_really_changed. When an existing content view says
      	"underway", we restart the throbber (fixes 1/2 of bug 2461).
      	(load_complete_callback): Since view frames now ensure we get an
      	underway call before a complete call, we can simplify the
      	logic. If the main content view says "complete", it's time to stop
      	the throbber (fixes other 1/2 of bug 2461).
      	(view_loaded_callback): Renamed the client_loaded callback. Also
      	made it update location and selection for sidebar panels when they
      	are loaded. Also made it update the title for any view when it's
      	* src/nautilus-window.h:
      	* src/nautilus-window.c: (nautilus_window_synch_view_as_menu):
      	Handle case of NULL content view.
      	(nautilus_window_set_content_view_widget): Destroy the view when
      	it's going away instead of removing it from the parent. Also make
      	this function handle the NULL case so we can use it to remove the
      	old view, not just to add the new one.
      	* libnautilus-extensions/nautilus-bonobo-extensions.h: Whitespace
      	* src/nautilus-sidebar.c:
      	(nautilus_sidebar_active_panel_matches_id): Update for
      	nautilus_view_frame_get_view_iid name change.
    • Arik Devens's avatar
      Added a new utility funtion to take a pane and find its row in the clist,... · 71d4af26
      Arik Devens authored
      Added a new utility funtion to take a pane and find its row in the clist, updated the preference box to use it to set the users last selected pane when they switch user levels unless they are not visible in your user level.
  6. 29 Jan, 2001 3 commits
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 0919c257
      Gene Z. Ragan authored
      2001-01-29  Gene Z. Ragan  <gzr@eazel.com>
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      	Fixed bug 5508, Nautilus crashes when pressing 'Esc' in
      	copy/duplicate progress dialog
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(handle_close_callback), (create_transfer_dialog):
      	Set the cancel state to true if the user uses the Escape key
      	or close box to dismiss the dialog.  This will cancel the
      	transfer properly.
    • Ramiro Estrugo's avatar
      Justify labels to the left. · d38855b6
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	Justify labels to the left.
    • Robey Pointer's avatar
      Un-revert some changes Andy accidentally reverted last week that · ed7ef6cb
      Robey Pointer authored
      	cause the password-change view to display incorrectly.