1. 21 Mar, 2001 1 commit
    • John Sullivan's avatar
      Fixed bug 4355: Built-in bookmarks icons change after first view · 65e9e66c
      John Sullivan authored
      	Also reduced the number of times that refresh_bookmarks_menu
      	is called since it was showing up in some profiling.
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name),
      	(bookmark_file_changed_callback): Split the "changed" signal into
      	"appearance_changed" and "content_changed". "appearance_changed" is
      	emitted only if the name or icon change. "content_changed" is emitted
      	if the URI changes.
      	* src/nautilus-bookmark-list.c: (insert_bookmark_internal):
      	Connect to both appearance_changed and content_changed.
      	* src/nautilus-window-menus.c: (bookmark_holder_new):
      	Refresh menu only on appearance_changed, not content_changed.
      	* data/static_bookmarks.xml: Added "i-web" as icon name for
      	all the built-in bookmarks, since this is the icon they will
      	end up with after being visited. (Now, visiting a built-in
      	bookmark will not cause a refresh of the bookmarks menu.)
  2. 08 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 2218 (Duplicate items appear in history list) · 069f8b16
      John Sullivan authored
      	Also changed a few places to compare uris with the new
      	nautilus_uris_match instead of strcmp.
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_compare_with): Use nautilus_uris_match.
      	(nautilus_bookmark_compare_uris): New function, compares
      	bookmarks' uris with nautilus_uris_match; ignores names.
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_set_displayed_location), (handle_go_elsewhere),
      	(open_location): Use nautilus_uris_match.
      	* src/nautilus-window.c: (nautilus_add_to_history_list):
      	Use nautilus_bookmark_compare_uris instead of _compare_with.
      	This was the source of the bug. Due to asynchronicity introduced
      	sometime after this code was written, when the bookmark for the
      	current location was created it did not	yet know what name to use,
      	and so it did not match any of the old History items that had the
      	correct name. But for the History list we only want one entry per
      	uri anyway, so it needn't have been comparing the names in the
      	first place.
  3. 27 Jun, 2000 1 commit
    • John Sullivan's avatar
      Finished task 461 (bookmarks to "Bad URI" should have · 2bc0425b
      John Sullivan authored
      	an icon). I picked arbitrary existing icons (gnome foot
      	for "generic bookmark", gnome-foot-question-mark for
      	"bookmark with known-bad URI"); Arlo and/or Susan will
      	have to come up with real ones. I'll write a separate
      	bug report about that.
      	* icons/i-bookmark.png:
      	* icons/i-bookmark-20.png:
      	* icons/i-bookmark-missing.png:
      	* icons/i-bookmark-missing-20.png: New icons to use
      	for bookmarks. I supplied the base size and the 20
      	pixel size because that's the one used in menus, where
      	bookmarks usually appear. These need to be replaced with
      	better images.
      	* icons/Makefile.am: Add new icons to installed set.
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_uri_known_not_to_exist): New public
      	function, moved some code from elsewhere to encapsulate this.
      	(nautilus_bookmark_set_icon_to_default): Choose between the
      	generic and bad-URI icon if there's no better icon.
      	* src/nautilus-window-menus.c: (activate_bookmark_in_menu_item):
      	Now calls nautilus_bookmark_uri_known_not_to_exist instead
      	of doing the work here.
  4. 17 Jun, 2000 1 commit
    • John Sullivan's avatar
      More work towards bug 1401 (bookmark icon never updates). · a773b187
      John Sullivan authored
      	You can avoid some warnings if you get the latest Bonobo.
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name):
      	Define "changed" signal for bookmarks and wire it up (though
      	not yet to the icon-changing case). Remove never-implemented
      	and never-to-be-implemented "nautilus_bookmark_get_file" since
      	I changed my mind on the design.
      	* src/nautilus-window-menus.c: (append_bookmark_to_menu),
      	(clear_appended_bookmark_items): Connect and disconnect
      	signals from the window to the bookmarks in the Go and
      	Bookmarks menus.
  5. 16 Jun, 2000 3 commits
    • John Sullivan's avatar
      Some work towards bug 1401 (bookmark icon never updates). · 1fd31530
      John Sullivan authored
      	No visible effect yet.
      	* libnautilus-extensions/nautilus-bookmark.h:
      	Added nautilus_bookmark_get_file prototype, not yet
      	called or implemented.
      	* libnautilus-extensions/nautilus-file.h,
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_check_if_ready): New function, does
      	nothing yet.
      	* libnautilus-extensions/nautilus-icon-factory.h:
      	Added nautilus_icon_factory_is_icon_ready_for_file
      	prototype, not yet called or implemented.
      	* src/nautilus-window-menus.c:
      	(schedule_refresh_bookmarks_menu), (refresh_go_menu),
      	(refresh_go_menu_idle_callback), (schedule_refresh_go_menu):
      	Made the code that rebuilds the Go and Bookmarks menus when
      	there's been a change to the bookmarks use idle handling to
      	batch up requests. This will be important when bookmarks
      	broadcast updates for their icons.
      	* src/nautilus-window-private.h: Defined NautilusWindowDetails
      	struct. We should eventually migrate all of the fields
      	of NautilusWindow in here, but I didn't do that now.
      	Added two fields used by bookmark-menu-updating code.
      	* src/nautilus-window.h: Made a details field using
      	* src/nautilus-window.c:
      	(nautilus_window_init): Create details field.
      	(nautilus_window_destroy): Clean up any pending idle bookmark
      	refreshing stuff.
    • John Sullivan's avatar
      Modernized some NautilusBookmark code that had been written · 4e90eb7b
      John Sullivan authored
      	in the dark ages (by me).
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_compare_with), (nautilus_bookmark_copy),
      	(nautilus_bookmark_get_pixbuf), (nautilus_bookmark_get_icon),
      	(nautilus_bookmark_get_uri), (create_pixmap_widget_for_bookmark),
      	(nautilus_bookmark_menu_item_new): Eliminated the use of
      	const NautilusBookmark *; made _get_name and _get_uri return
      	copies instead of the original text; tweaked a little formatting.
      	* components/history/nautilus-history-view.c: (install_icon),
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* src/nautilus-bookmark-list.c: (append_bookmark_node),
      	(nautilus_bookmark_list_append), (nautilus_bookmark_list_contains),
      	* src/nautilus-bookmark-list.h:
      	* src/nautilus-bookmarks-window.c: (install_bookmark_icon),
      	(on_select_row), (repopulate):
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_reset_title_internal), (handle_go_back),
      	(handle_go_forward), (handle_go_elsewhere):
      	* src/nautilus-window-menus.c: (bookmark_holder_new),
      	(show_bogus_bookmark_window), (activate_bookmark_in_menu_item),
      	* src/nautilus-window.c: (nautilus_window_back_or_forward):
      	Eliminated the use of const NautilusBookmark *; changed all
      	callers of nautilus_bookmark_get_name and _get_uri to free
      	the results.
    • John Sullivan's avatar
      Fixed bug 705 (Need to avoid network hit on startup for · 22c0f773
      John Sullivan authored
      	each remote bookmark). Bookmarks now get their icon only
      	when they're initially created, and then store a text
      	version of it to disk for future sessions. We might have
      	to update the icon at certain times later (maybe when it's
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_copy), (nautilus_bookmark_get_pixbuf),
      	(nautilus_bookmark_get_icon), (get_icon_for_uri),
      	(nautilus_bookmark_new), (nautilus_bookmark_new_with_icon):
      	Changed guts of NautilusBookmark to keep a
      	NautilusScalableIcon around. Also some miscellaneous
      	cleanup in this ancient file (need to do more).
      	* libnautilus-extensions/nautilus-icon-factory.h,
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(get_themed_icon_file_path): Added icon != NULL assert.
      	(get_icon_file_path): Handle NULL icon name by returning NULL;
      	some style fixes.
      	(nautilus_scalable_icon_get_text_pieces): New function,
      	returns all four pieces of text used to define a
      	Renamed from nautilus_scalable_icon_get and made public.
      	(load_image_with_embedded_text): Updated for function renaming.
      	* src/nautilus-bookmark-list.c: (append_bookmark_node),
      	(make_bookmark_from_node), (nautilus_bookmark_list_load_file):
      	Save & restore NautilusScalableIcon with each bookmark.
      	Added custom error message when trying to open a location
      	fails with GNOME_VFS_LOGINFAILED
      	* src/nautilus-applicable-views.h: Define
      	* src/nautilus-applicable-views.c:
      	Support GNOME_VFS_LOGINFAILED, and tweak message for
      	unhandled case.
      	* src/nautilus-window-manage-views.c:
      	remove message for unhandled case since complaining
      	about unhandled cases is done elsewhere.
  6. 20 Apr, 2000 1 commit
    • John Sullivan's avatar
      Darin and I started out thinking we were going to start entering · 406ed6a9
      John Sullivan authored
      	bugs for the FIXME items but we were distracted into fixing bugs
      	and tweaking code that we found while doing so.
      	* check-FIXME.pl: Won't search old ChangeLogs for FIXMEs either;
      	changed FIXME format from "FIXME bug xxx" to "FIXME bugzilla.eazel.com xxx"
      	* components/history/ntl-history-view.c:
      	(hyperbola_navigation_history_notify_location_change): Moved bookmark
      	naming hack here and added FIXME explaining it.
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_new), (nautilus_bookmark_new_with_name):
      	Combined these two into one routine that takes both the uri and
      	title; removed hack for trying to come up with good name for
      	bookmark here.
      	(nautilus_bookmark_get_pixmap_and_mask): Changed to call
      	_get_pixbuf instead of duplicating code.
      	(nautilus_bookmark_get_pixbuf): Changed interface to return
      	pixbuf or NULL instead of boolean result & "out" parameter.
      	* src/nautilus-bookmark-list.c,
      	* src/nautilus-bookmarks-window.c,
      	* src/nautilus-window-menus.c,
      	* src/ntl-window-msgs.c:
      	Updated callers of nautilus_bookmark_new and _new_with_name.
  7. 15 Apr, 2000 1 commit
    • Darin Adler's avatar
      After a chat with Rebecca, named nautilus_str_underscore_escape to · f388c79d
      Darin Adler authored
      	* libnautilus-extensions/nautilus-string.c:
      	* libnautilus-extensions/nautilus-string.h:
      	After a chat with Rebecca, named nautilus_str_underscore_escape to
      	nautilus_str_double_underscores since the latter name more
      	accurately describes what it does.
      	(nautilus_str_double_underscores): Changed the function to allow
      	NULL and return NULL instead of doing g_return_val_if_fail.
      	(Also reformatted a bit and made a few gratuitous changes.)
      	* libnautilus-extensions/nautilus-bookmark.c:
      	* libnautilus-extensions/nautilus-bookmark.h:
      	Moved the logic about escaping menu characters up one level so
      	the bookmark class doesn't have to know about it. This removes
      	the function from NautilusBookmark completely.
      	* src/nautilus-window-menus.c:
      	(append_bookmark_to_menu): Fixed a storage leak and moved the
      	double-underscore escaping in here.
  8. 14 Apr, 2000 1 commit
  9. 11 Apr, 2000 1 commit
    • Gene Z. Ragan's avatar
      components/sample/nautilus-sample-content-view.c Added icon data to · 2ac3c5da
      Gene Z. Ragan authored
      2000-04-11 Gene Z. Ragan <gzr@eazel.com>
      	* components/sample/nautilus-sample-content-view.c
      	Added icon data to BonoboUiHandler.  This is GdkPixbuf
      	data and demonstrates the pixbuf data features
      	added to bonobo ui handlers.
      	* libnautilus/nautilus-bookmark.c
      	bonobo_ui_handler_menu_new_item modified to take advantage
      	of new bonobo ui handler pixbuf functionality. Components and
      	menu items can now display pixbuf data.
      	Added nautilus_bookmark_get_pixbuf() routine.
      	* libnautilus/nautilus-bookmark.h
      	Added nautilus_bookmark_get_pixbuf() routine.
      	* src/nautilus-window-menus.c
      	bonobo_ui_handler_menu_new_item modified to take advantage
      	of new bonobo ui handler pixbuf functionality.
  10. 28 Mar, 2000 1 commit
  11. 16 Mar, 2000 1 commit
    • Darin Adler's avatar
      Tell people about the gnome-xml branch. · ee495dba
      Darin Adler authored
      	* HACKING: Tell people about the gnome-xml branch.
      	* libnautilus/Makefile.am:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c:
      	Broke out the grid code from the main container code.
      	This is a first step toward improving the layout code.
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	* src/fm-directory-view.c:
      	Got started on making the directory I/O async.
      	There's still a long way to go, this was a baby step.
      	* libnautilus/nautilus-bookmark.c:
      	* libnautilus/nautilus-bookmark.h:
      	* libnautilus/nautilus-self-checks.c:
      	General cleanup.
      	* libnautilus/nautilus-file.h:
      	Rearranged a little bit.
      	* libnautilus/nautilus-file-utilities.c:
      	Put FIXME in where there's code that needs to be changed.
  12. 18 Feb, 2000 1 commit
  13. 15 Feb, 2000 2 commits
  14. 28 Jan, 2000 1 commit
  15. 03 Jan, 2000 1 commit
  16. 31 Dec, 1999 1 commit
  17. 30 Dec, 1999 1 commit
  18. 29 Dec, 1999 2 commits
  19. 20 Dec, 1999 1 commit