1. 21 Mar, 2001 1 commit
    • John Sullivan's avatar
      Fixed bug 4355: Built-in bookmarks icons change after first view · 65e9e66c
      John Sullivan authored
      	Also reduced the number of times that refresh_bookmarks_menu
      	is called since it was showing up in some profiling.
      
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name),
      	(bookmark_file_changed_callback): Split the "changed" signal into
      	"appearance_changed" and "content_changed". "appearance_changed" is
      	emitted only if the name or icon change. "content_changed" is emitted
      	if the URI changes.
      
      	* src/nautilus-bookmark-list.c: (insert_bookmark_internal):
      	Connect to both appearance_changed and content_changed.
      
      	* src/nautilus-window-menus.c: (bookmark_holder_new):
      	Refresh menu only on appearance_changed, not content_changed.
      
      	* data/static_bookmarks.xml: Added "i-web" as icon name for
      	all the built-in bookmarks, since this is the icon they will
      	end up with after being visited. (Now, visiting a built-in
      	bookmark will not cause a refresh of the bookmarks menu.)
      65e9e66c
  2. 23 Feb, 2001 1 commit
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 764d936a
      Darin Adler authored
      	Fix bug 6859 (GTK signal macros don't work in non-GCC compilers
      	for void return types).
      
      	* libnautilus-extensions/nautilus-gtk-macros.h:
      	Replaced old macros that accidentally relied on gccisms with
      	new ones that are portable to other compilers.
      
      		NAUTILUS_CALL_PARENT_CLASS is replaced by
      			NAUTILUS_CALL_PARENT
      		    and NAUTILUS_CALL_PARENT_WITH_RETURN_VALUE.
      
      		NAUTILUS_CALL_VIRTUAL is replaced by
      			NAUTILUS_CALL_METHOD
      		    and NAUTILUS_CALL_METHOD_WITH_RETURN_VALUE
      
      	* components/adapter/nautilus-adapter-control-embed-strategy.c:
      	(nautilus_adapter_control_embed_strategy_destroy):
      	* components/adapter/nautilus-adapter-embed-strategy.c:
      	(nautilus_adapter_embed_strategy_destroy),
      	(nautilus_adapter_embed_strategy_get_widget),
      	(nautilus_adapter_embed_strategy_get_zoomable):
      	* components/adapter/nautilus-adapter-embeddable-embed-strategy.c:
      	(nautilus_adapter_embeddable_embed_strategy_destroy):
      	* components/adapter/nautilus-adapter-factory-server.c:
      	(nautilus_adapter_factory_server_destroy):
      	* components/adapter/nautilus-adapter-file-load-strategy.c:
      	(nautilus_adapter_file_load_strategy_destroy):
      	* components/adapter/nautilus-adapter-load-strategy.c:
      	(nautilus_adapter_load_strategy_destroy),
      	(nautilus_adapter_load_strategy_load_location),
      	(nautilus_adapter_load_strategy_stop_loading):
      	* components/adapter/nautilus-adapter-progressive-load-strategy.c:
      	(nautilus_adapter_progressive_load_strategy_destroy):
      	* components/adapter/nautilus-adapter-stream-load-strategy.c:
      	(nautilus_adapter_stream_load_strategy_destroy):
      	* components/adapter/nautilus-adapter.c:
      	(nautilus_adapter_destroy):
      	* components/hardware/nautilus-hardware-view.c:
      	(nautilus_hardware_view_destroy):
      	* components/history/nautilus-history-view.c:
      	(nautilus_history_view_destroy):
      	* components/loser/content/nautilus-content-loser.c:
      	(nautilus_content_loser_destroy):
      	* components/loser/sidebar/nautilus-sidebar-loser.c:
      	(nautilus_sidebar_loser_destroy):
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_destroy):
      	* components/rpmview/nautilus-rpm-verify-window.c:
      	(nautilus_rpm_verify_window_destroy):
      	* components/rpmview/nautilus-rpm-view.c:
      	(nautilus_rpm_view_destroy):
      	* components/sample/nautilus-sample-content-view.c:
      	(nautilus_sample_content_view_destroy):
      	* components/services/install/nautilus-view/nautilus-service-instal
      	l-view.c: (nautilus_service_install_view_destroy),
      	(nautilus_service_install_view_finalize):
      	* components/services/inventory-view/nautilus-inventory-config-page
      	.c: (nautilus_inventory_config_page_destroy):
      	* components/services/inventory-view/nautilus-inventory-view.c:
      	(nautilus_inventory_view_destroy):
      	* components/services/login/nautilus-view/nautilus-change-password-
      	view.c: (nautilus_change_password_view_destroy):
      	* components/services/nautilus-dependent-shared/eazel-services-foot
      	er.c: (footer_destroy):
      	* components/services/nautilus-dependent-shared/eazel-services-head
      	er.c: (header_destroy):
      	* components/services/summary/nautilus-summary-view.c:
      	(nautilus_summary_view_destroy):
      	* components/services/time/nautilus-view/trilobite-eazel-time-view.
      	c: (trilobite_eazel_time_view_destroy):
      	* components/text/nautilus-text-view.c:
      	(nautilus_text_view_destroy):
      	* components/throbber/nautilus-throbber.c:
      	(nautilus_throbber_destroy), (nautilus_throbber_map),
      	(nautilus_throbber_size_allocate):
      	* components/tree/nautilus-tree-change-queue.c:
      	(nautilus_tree_change_queue_destroy):
      	* components/tree/nautilus-tree-expansion-state.c:
      	(nautilus_tree_expansion_state_destroy):
      	* components/tree/nautilus-tree-model.c:
      	(nautilus_tree_model_destroy):
      	* components/tree/nautilus-tree-node.c:
      	(nautilus_tree_node_destroy):
      	* components/tree/nautilus-tree-view.c:
      	(nautilus_tree_view_destroy):
      	* help/nautilus-quick-reference/.cvsignore:
      	* help/nautilus-quick-reference/C/.cvsignore:
      	* libnautilus-extensions/nautilus-background-canvas-group.c:
      	(nautilus_background_canvas_group_update),
      	(nautilus_background_canvas_group_draw),
      	(nautilus_background_canvas_group_render):
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_destroy):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_destroy):
      	* libnautilus-extensions/nautilus-caption.c:
      	(nautilus_caption_destroy), (nautilus_font_picker_show_all):
      	* libnautilus-extensions/nautilus-clickable-image.c:
      	(nautilus_clickable_image_destroy),
      	(nautilus_clickable_image_realize),
      	(nautilus_clickable_image_expose_event):
      	* libnautilus-extensions/nautilus-debug-drawing.c:
      	(debug_pixbuf_viewer_destroy):
      	* libnautilus-extensions/nautilus-directory-metafile-monitor.c:
      	(destroy):
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_destroy),
      	(nautilus_directory_get_name_for_self_as_new_file),
      	(nautilus_directory_are_all_files_seen),
      	(nautilus_directory_contains_file),
      	(nautilus_directory_call_when_ready),
      	(nautilus_directory_cancel_callback),
      	(nautilus_directory_file_monitor_add),
      	(nautilus_directory_file_monitor_remove),
      	(nautilus_directory_force_reload),
      	(nautilus_directory_is_not_empty):
      	* libnautilus-extensions/nautilus-druid-page-eazel.c:
      	(nautilus_druid_page_eazel_destroy),
      	(nautilus_druid_page_eazel_finalize),
      	(nautilus_druid_page_eazel_size_allocate),
      	(nautilus_druid_page_eazel_size_request):
      	* libnautilus-extensions/nautilus-ellipsizing-label.c:
      	(real_size_request), (real_size_allocate), (real_style_set):
      	* libnautilus-extensions/nautilus-entry.c:
      	(nautilus_entry_destroy), (nautilus_entry_key_press),
      	(nautilus_entry_motion_notify), (nautilus_entry_set_selection),
      	(nautilus_entry_insert_text), (nautilus_entry_delete_text),
      	(nautilus_entry_selection_clear):
      	* libnautilus-extensions/nautilus-file.c: (destroy),
      	(nautilus_file_monitor_add), (nautilus_file_monitor_remove),
      	(nautilus_file_get_date), (nautilus_file_get_where_string),
      	(nautilus_file_get_directory_item_count),
      	(nautilus_file_get_deep_counts), (nautilus_file_get_file_type),
      	(nautilus_file_check_if_ready), (nautilus_file_call_when_ready),
      	(nautilus_file_cancel_call_when_ready):
      	* libnautilus-extensions/nautilus-font-factory.c: (destroy):
      	* libnautilus-extensions/nautilus-font-picker.c:
      	(nautilus_font_picker_destroy):
      	* libnautilus-extensions/nautilus-horizontal-splitter.c:
      	(nautilus_horizontal_splitter_destroy),
      	(nautilus_horizontal_splitter_button_press):
      	* libnautilus-extensions/nautilus-icon-canvas-item.c:
      	(nautilus_icon_canvas_item_destroy),
      	(nautilus_icon_canvas_item_update):
      	* libnautilus-extensions/nautilus-icon-container.c: (destroy),
      	(size_allocate), (realize), (unrealize), (button_press_event),
      	(button_release_event), (motion_notify_event), (key_press_event):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_destroy):
      	* libnautilus-extensions/nautilus-image-table.c:
      	(nautilus_image_table_destroy),
      	(nautilus_image_table_expose_event),
      	(nautilus_image_table_realize), (nautilus_image_table_unrealize),
      	(nautilus_image_table_remove):
      	* libnautilus-extensions/nautilus-image.c:
      	(nautilus_image_destroy):
      	* libnautilus-extensions/nautilus-keep-last-vertical-box.c:
      	(nautilus_keep_last_vertical_box_size_allocate):
      	* libnautilus-extensions/nautilus-label.c:
      	(nautilus_label_destroy), (nautilus_label_size_request),
      	(nautilus_label_size_allocate), (label_paint_pixbuf_callback):
      	* libnautilus-extensions/nautilus-labeled-image.c:
      	(nautilus_labeled_image_destroy):
      	* libnautilus-extensions/nautilus-list-column-title.c:
      	(nautilus_list_column_title_finalize):
      	* libnautilus-extensions/nautilus-list.c: (nautilus_list_destroy),
      	(nautilus_list_button_press), (nautilus_list_button_release),
      	(nautilus_list_key_press), (nautilus_list_style_set),
      	(nautilus_list_realize), (nautilus_list_unrealize), (draw_rows),
      	(draw_all), (nautilus_list_draw), (nautilus_list_expose),
      	(nautilus_list_resize_column), (nautilus_list_set_cell_contents),
      	(set_list_cell), (nautilus_list_track_new_column_width),
      	(nautilus_list_motion), (nautilus_list_clear), (insert_row):
      	* libnautilus-extensions/nautilus-merged-directory.c:
      	(merged_destroy):
      	* libnautilus-extensions/nautilus-metafile-factory.c: (destroy):
      	* libnautilus-extensions/nautilus-metafile.c: (destroy):
      	* libnautilus-extensions/nautilus-preferences-box.c:
      	(nautilus_preferences_box_destroy):
      	* libnautilus-extensions/nautilus-preferences-pane.c:
      	(nautilus_preferences_pane_destroy):
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(nautilus_scalable_font_destroy):
      	* libnautilus-extensions/nautilus-string-picker.c:
      	(nautilus_string_picker_destroy):
      	* libnautilus-extensions/nautilus-tabs.c: (nautilus_tabs_destroy):
      	* libnautilus-extensions/nautilus-text-caption.c:
      	(nautilus_text_caption_destroy):
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	(trash_destroy):
      	* libnautilus-extensions/nautilus-trash-file.c: (trash_destroy):
      	* libnautilus-extensions/nautilus-undo-context.c: (destroy):
      	* libnautilus-extensions/nautilus-undo-manager.c: (destroy):
      	* libnautilus-extensions/nautilus-vfs-directory.c: (vfs_destroy):
      	* libnautilus-extensions/nautilus-vfs-file.c: (vfs_destroy):
      	* libnautilus-extensions/nautilus-viewport.c:
      	(nautilus_viewport_destroy), (nautilus_viewport_realize):
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	(nautilus_volume_monitor_destroy):
      	* libnautilus-extensions/nautilus-wrap-table.c:
      	(nautilus_wrap_table_destroy):
      	* libnautilus/nautilus-undo-transaction.c:
      	(nautilus_undo_transaction_destroy):
      	* libnautilus/nautilus-view.c: (nautilus_view_destroy):
      	* src/file-manager/fm-desktop-icon-view.c:
      	(fm_desktop_icon_view_destroy), (real_update_menus),
      	(real_merge_menus):
      	* src/file-manager/fm-directory-view.c:
      	(text_attribute_names_changed_callback),
      	(image_display_policy_changed_callback),
      	(directory_view_font_family_changed_callback),
      	(click_policy_changed_callback),
      	(smooth_graphics_mode_changed_callback),
      	(fm_directory_view_destroy),
      	(fm_directory_view_file_limit_reached),
      	(fm_directory_view_bump_zoom_level),
      	(fm_directory_view_zoom_to_level),
      	(fm_directory_view_restore_default_zoom_level),
      	(fm_directory_view_can_zoom_in), (fm_directory_view_can_zoom_out),
      	(fm_directory_view_get_background_widget),
      	(fm_directory_view_get_selection), (reveal_newly_added_folder),
      	(fm_directory_view_get_emblem_names_to_exclude),
      	(fm_directory_view_merge_menus), (fm_directory_view_select_all),
      	(fm_directory_view_set_selection),
      	(fm_directory_get_selected_icon_locations),
      	(fm_directory_view_reveal_selection),
      	(fm_directory_view_is_read_only), (fm_directory_view_is_empty),
      	(fm_directory_view_supports_creating_files),
      	(fm_directory_view_accepts_dragged_files),
      	(fm_directory_view_supports_properties),
      	(fm_directory_view_supports_zooming),
      	(fm_directory_view_update_menus):
      	* src/file-manager/fm-icon-view.c: (fm_icon_view_destroy),
      	(fm_icon_view_clean_up), (fm_icon_view_get_directory_sort_by),
      	(fm_icon_view_set_directory_sort_by),
      	(fm_icon_view_get_directory_sort_reversed),
      	(fm_icon_view_set_directory_sort_reversed),
      	(fm_icon_view_get_directory_auto_layout),
      	(fm_icon_view_set_directory_auto_layout),
      	(fm_icon_view_get_directory_tighter_layout),
      	(fm_icon_view_set_directory_tighter_layout),
      	(fm_icon_view_supports_auto_layout),
      	(fm_icon_view_start_renaming_item), (fm_icon_view_merge_menus),
      	(fm_icon_view_update_menus):
      	* src/file-manager/fm-list-view.c: (fm_list_view_adding_file),
      	(fm_list_view_removing_file), (fm_list_view_file_still_belongs),
      	(get_number_of_columns), (get_link_column),
      	(get_default_sort_attribute), (get_column_specification):
      	* src/file-manager/fm-properties-window.c: (real_shutdown),
      	(real_destroy), (real_finalize):
      	* src/file-manager/fm-search-list-view.c: (real_destroy),
      	(real_add_file), (real_adding_file), (real_removing_file),
      	(real_merge_menus), (real_update_menus):
      	* src/nautilus-about.c: (nautilus_about_destroy):
      	* src/nautilus-application.c: (nautilus_application_destroy),
      	(nautilus_application_startup):
      	* src/nautilus-complex-search-bar.c:
      	(nautilus_complex_search_bar_destroy):
      	* src/nautilus-desktop-window.c: (destroy), (realize):
      	* src/nautilus-location-bar.c: (destroy):
      	* src/nautilus-navigation-bar.c:
      	(nautilus_navigation_bar_get_location),
      	(nautilus_navigation_bar_set_location):
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_destroy):
      	* src/nautilus-search-bar-criterion.c:
      	(nautilus_search_bar_criterion_destroy):
      	* src/nautilus-shell.c: (destroy):
      	* src/nautilus-sidebar-tabs.c: (nautilus_sidebar_tabs_destroy),
      	(nautilus_sidebar_tabs_size_allocate):
      	* src/nautilus-sidebar-title.c: (nautilus_sidebar_title_destroy),
      	(nautilus_sidebar_title_size_allocate):
      	* src/nautilus-sidebar.c: (nautilus_sidebar_destroy),
      	(nautilus_sidebar_size_allocate), (nautilus_sidebar_realize):
      	* src/nautilus-simple-search-bar.c:
      	(nautilus_simple_search_bar_destroy):
      	* src/nautilus-switchable-navigation-bar.c:
      	(nautilus_switchable_navigation_bar_destroy):
      	* src/nautilus-switchable-search-bar.c:
      	(nautilus_switchable_search_bar_destroy):
      	* src/nautilus-theme-selector.c: (nautilus_theme_selector_destroy):
      	* src/nautilus-view-frame.c: (nautilus_view_frame_destroy),
      	(nautilus_view_frame_finalize), (nautilus_view_frame_map):
      	* src/nautilus-window.c: (nautilus_window_destroy),
      	(nautilus_window_realize), (nautilus_window_size_request),
      	(nautilus_window_add_current_location_to_history_list),
      	(nautilus_window_show):
      	* src/nautilus-zoom-control.c: (nautilus_zoom_control_destroy),
      	(nautilus_zoom_control_size_allocate):
      	Use the macros by their new names.
      
      	* RENAMING: Updated for some name changes and name change ideas.
      
      	* user-guide/C/.cvsignore:
      	* user-guide/C/html/.cvsignore:
      	* user-guide/C/img/.cvsignore:
      	* user-guide/C/sgml/.cvsignore:
      	Added missing cvsignores.
      764d936a
  3. 12 Dec, 2000 1 commit
    • Andy Hertzfeld's avatar
      fixed bug 4212, emblem doesn't show up when the image is a JPEG file, by · ed19a4c7
      Andy Hertzfeld authored
      
      	* libnautilus-extensions/nautilus-icon-factory.c: (cache_icon_new),
      	(load_icon_for_scaling), (scale_icon), (get_icon_from_cache),
      	(nautilus_icon_factory_get_pixbuf_for_icon),
      	(nautilus_icon_factory_get_pixbuf_for_file):
      
      	fixed bug 4212, emblem doesn't show up when the image is a JPEG
      	file, by adding ".jpg" to extensions checked in the icon factory.
      
      	Fixed bug 3208, generic icon shows up for deleted emblems, by adding
      	a "wants_default" parameter to the icon factory get_pixbuf_for_icon
      	call.  If "wants_default" is false, it returns NULL instead of the
      	generic icon.  Emblem callers pass FALSE so they don't get pixmaps
      	for deleted emblems.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_get_pixbuf):
      	added boolean parameter to get_pixbuf_for_icon call
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_update_icon):
      	added boolean parameter to get_pixbuf_for_icon call
      	* libnautilus-extensions/nautilus-icon-factory.h:
      	added "wants_default" boolean to get_pixbuf_for_icon definition
      	* src/file-manager/fm-list-view.c:
      	(fm_list_view_get_emblem_pixbufs_for_file):
      	added boolean parameter to get_pixbuf_for_icon call
      	* src/file-manager/fm-properties-window.c:
      	(create_image_widget_for_emblem):
      	added boolean parameter to get_pixbuf_for_icon call
      	* src/nautilus-sidebar-title.c: (update_emblems):
      	added boolean parameter to get_pixbuf_for_icon call
      ed19a4c7
  4. 07 Dec, 2000 1 commit
    • John Sullivan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 9643a99a
      John Sullivan authored
      	Addressed bug 4208 (Opening new window is slow)
      
      	Pavel identified the 2nd biggest performance bottleneck in
      	opening a new window (1st being tree view) as the code that
      	sets up the bookmark menus. I found some good speedups; time
      	to profile again.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(bookmark_file_changed_callback): nautilus_uris_match returns
      	a gboolean, not a strcmp-style int. Doh! Sense of test was
      	reversed, causing many unnecessary rebuild-bookmarks-menus.
      
      	* src/nautilus-window-menus.c:
      	(append_static_bookmarks), (refresh_bookmarks_menu): Wrapped
      	some Bonobo-ui-manipulating code with freeze/thaw; this speeds
      	up rebuild-bookmarks_menu by an order of magnitude or so.
      
      	Fixed bug 4334: (Icon name being edited can get separated
      	from icon on restore-original-size)
      
      	* libnautilus-extensions/nautilus-icon_container.c:
      	(nautilus_icon_container_move_icon): End renaming mode
      	if icon being renamed is moved.
      9643a99a
  5. 30 Nov, 2000 1 commit
    • John Sullivan's avatar
      reviewed by: Rebecca Schulman <rebecka@eazel.com> · a9542b95
      John Sullivan authored
      	Fixed bug 4899 (Bookmark for nonexistent file can cause
      	infinite loop at startup)
      
      	Changed NautilusBookmark's internal logic so that it doesn't
      	keep around a file object for known non-existent URIs. The
      	trick is to get it to notice when the URI is no longer non-existent
      	and get a fresh file object then. This is done imperfectly, but
      	the new symptom is very minor and deferrable (wrote it up as bug 4906).
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_connect_file): Don't get a new NautilusFile
      	object if we know the URI doesn't exist; instead just set the
      	missing-bookmark icon. Also made it safe to call this routine
      	when there's already a file object in hand (just bails out early).
      	(nautilus_bookmark_get_icon), (nautilus_bookmark_get_uri):
      	Call nautilus_bookmark_connect_file so that it will connect to a
      	now-existing file if possible (and thus	get the right icon).
      	Since callers that try to activate the bookmark will call get_uri,
      	one way to kick a reincarnated bookmark's icon into appearing is
      	to select it in a menu.
      	(nautilus_bookmark_get_pixbuf): Call nautilus_bookmark_get_icon to
      	benefit from its connect_file logic.
      
      
      	Fixed bug 3847 (Icon in properties window flashes while
      	folder count increments)
      
      	* libnautilus-extensions/nautilus-image.c:
      	(nautilus_image_set_pixbuf): Don't call gtk_widget_queue_resize if
      	the pixbuf hasn't changed.
      
      
      	Fixed bug 1454 (Properties dialog needs mucho tweaking)
      
      	Mostly this was changes to match Arlo's design that he gave me
      	ages ago. I also fixed a few other problems.
      
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_get_date_as_string): Change format of date
      	strings from "<date> <time>" to "<date> at <time>" to match
      	Arlo's design.
      	* src/file-manager/fm-properties-window.c:
      	(attach_label): Now handles requests for a bold font.
      	(attach_value_label): Renamed from attach_left_aligned_label, use bold
      	font here.
      	(attach_value_field),(attach_directory_contents_value_field):
      	updated for name change.
      	(attach_right_aligned_label): Removed, guts moved to caller.
      	(attach_title_field): Use bold font here.
      	(attach_option_menu): New helper function to share code between
      	attach_group_menu and attach_owner_menu; now uses gtk_alignment
      	to make the menu be minimally-sized and left-aligned.
      	(attach_group_menu), (attach_owner_menu): Use attach_option_menu.
      	(attach_separator): New helper function to install a separator
      	across both columns of a properties window table.
      	(create_basic_page): Use gtk_alignment to make the icon right-aligned;
      	make the blank row above date rows be standard height.
      	(create_emblems_page): Changed layout so name appears below emblem
      	rather than to its right; this matches Customize window and allows
      	the Properties window to be a smaller width, which looks much better
      	for the other panes. Also, the emblems are now layed out lrtb instead of
      	tblr.
      	(add_permissions_column_label): Make these labels bold.
      	(add_special_execution_flags): Attach a separator.
      	(get_adjusted_permissions_row): Helper function to account for the "special
      	flags" rows, which are not always displayed.
      	(create_permissions_page): Deploy get_adjusted_permissions_row wherever a
      	raw row number was used; insert separators.
      	(create_properties_window): Allow window to be stretched, since the emblems
      	don't all fit at initial window height (so user can stretch rather than
      	scrolling if desired).
      a9542b95
  6. 26 Sep, 2000 1 commit
    • Darin Adler's avatar
      Fixed bug bug 3264 (Tree view shows no branches for directories, · 2cd5440e
      Darin Adler authored
      	...HACK... nodes visible), bug 3290 (changing directory or
      	refreshing causes Gdk to assert), bug 2420 (Need to free original
      	key when removing model node), and other assorted problems.
      
      	* components/tree/nautilus-tree-view.c: (insert_hack_node),
      	(remove_hack_node), (nautilus_tree_view_insert_model_node):
      	Fix problem where the hash table key was neither g_strdup'd on the
      	way in, nor g_free'd on the way out. This caused all the problems
      	with bad nesting in the tree view.
      
      	* nautilus-installer/src/installer.c: (create_pixmap):
      	* src/file-manager/fm-list-view.c: (install_row_images):
      	* src/nautilus-theme-selector.c: (add_theme):
      	Added more checks for NULL before calling gdk_bitmap_unref.
      
      	* src/file-manager/fm-directory-view.c: (no_items_showing):
      	Fixed a NautilusDirectory ref. count leak.
      
      	* libnautilus-extensions/nautilus-font-factory.c:
      	(unref_global_font_factory), (nautilus_get_current_font_factory):
      	Unref the font factory on exit.
      	(nautilus_font_factory_initialize_class), (font_hash_node_free),
      	(free_one_hash_node), (destroy): Added code to actually destroy
      	the font factory.
      	(unref_fixed_font), (nautilus_font_factory_get_fallback_font):
      	Unref the fixed font on exit.
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	(unref_global_volume_monitor), (nautilus_volume_monitor_get):
      	Unref the volume monitor on exit.
      	* src/nautilus-signaller.c: (unref_global_signaller),
      	(nautilus_signaller_get_current): Unref the signaller on exit.
      
      	* src/nautilus-component-adapter-factory.c:
      	(nautilus_component_adapter_factory_initialize): Replaced some
      	strange FIXMEs with a simpler one.
      	(nautilus_component_adapter_factory_destroy): Fix a CORBA object
      	reference leak.
      	(nautilus_component_adapter_factory_get): Did a ref/sink.
      
      	* components/adapter/nautilus-adapter-control-embed-strategy.c:
      	(nautilus_adapter_control_embed_strategy_new):
      	* components/adapter/nautilus-adapter-embeddable-embed-strategy.c:
      	(nautilus_adapter_embeddable_embed_strategy_new):
      	* components/adapter/nautilus-adapter-file-load-strategy.c:
      	(nautilus_adapter_file_load_strategy_new):
      	* components/adapter/nautilus-adapter-progressive-load-strategy.c:
      	(nautilus_adapter_progressive_load_strategy_new):
      	* components/adapter/nautilus-adapter-stream-load-strategy.c:
      	(nautilus_adapter_stream_load_strategy_new):
      	* components/adapter/nautilus-adapter.c: (nautilus_adapter_new):
      	* components/rpmview/nautilus-rpm-verify-window.c:
      	(nautilus_rpm_verify_window_new):
      	* components/services/install/lib/eazel-install-object.c:
      	(eazel_install_new), (eazel_install_new_with_config):
      	* components/services/time/service/trilobite-eazel-time-service.c:
      	(trilobite_eazel_time_service_new):
      	* components/services/trilobite/libtrilobite/trilobite-service-pass
      	wordquery.c: (trilobite_passwordquery_new):
      	* components/services/trilobite/libtrilobite/trilobite-service.c:
      	(trilobite_service_new):
      	* components/tree/nautilus-tree-expansion-state.c:
      	(nautilus_tree_expansion_state_new):
      	* components/tree/nautilus-tree-model.c: (nautilus_tree_model_new):
      	* components/tree/nautilus-tree-node.c: (nautilus_tree_node_new):
      	* cut-n-paste-code/widgets/e-paned/e-hpaned.c: (e_hpaned_new):
      	* cut-n-paste-code/widgets/e-paned/e-vpaned.c: (e_vpaned_new):
      	* libnautilus-extensions/bonobo-stream-vfs.c:
      	(bonobo_stream_create):
      	* libnautilus-extensions/nautilus-any-width-bin.c:
      	(nautilus_any_width_bin_new):
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_new):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_new_with_icon):
      	* libnautilus-extensions/nautilus-caption-table.c:
      	(nautilus_caption_table_new):
      	* libnautilus-extensions/nautilus-caption.c:
      	(nautilus_caption_new):
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_new):
      	* libnautilus-extensions/nautilus-druid-page-eazel.c:
      	(nautilus_druid_page_eazel_new),
      	(nautilus_druid_page_eazel_new_with_vals):
      	* libnautilus-extensions/nautilus-druid.c: (nautilus_druid_new):
      	* libnautilus-extensions/nautilus-entry.c: (nautilus_entry_new):
      	* libnautilus-extensions/nautilus-file-operations-progress.c:
      	(nautilus_file_operations_progress_new):
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_new_from_name), (nautilus_file_new_from_info):
      	* libnautilus-extensions/nautilus-font-picker.c:
      	(nautilus_font_picker_new):
      	* libnautilus-extensions/nautilus-horizontal-splitter.c:
      	(nautilus_horizontal_splitter_new):
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_new):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(get_icon_factory):
      	* libnautilus-extensions/nautilus-image.c: (nautilus_image_new):
      	* libnautilus-extensions/nautilus-keep-last-vertical-box.c:
      	(nautilus_keep_last_vertical_box_new):
      	* libnautilus-extensions/nautilus-label.c: (nautilus_label_new):
      	* libnautilus-extensions/nautilus-list-column-title.c:
      	(nautilus_list_column_title_new):
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_new_with_titles):
      	* libnautilus-extensions/nautilus-password-dialog.c:
      	(nautilus_password_dialog_new):
      	* libnautilus-extensions/nautilus-preference.c:
      	(nautilus_preference_new_from_type):
      	* libnautilus-extensions/nautilus-preferences-box.c:
      	(nautilus_preferences_box_new):
      	* libnautilus-extensions/nautilus-preferences-dialog.c:
      	(nautilus_preferences_dialog_new):
      	* libnautilus-extensions/nautilus-preferences-group.c:
      	(nautilus_preferences_group_new):
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	(nautilus_preferences_item_new):
      	* libnautilus-extensions/nautilus-preferences-pane.c:
      	(nautilus_preferences_pane_new):
      	* libnautilus-extensions/nautilus-radio-button-group.c:
      	(nautilus_radio_button_group_new):
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(nautilus_scalable_font_new):
      	* libnautilus-extensions/nautilus-string-picker.c:
      	(nautilus_string_picker_new):
      	* libnautilus-extensions/nautilus-text-caption.c:
      	(nautilus_text_caption_new):
      	* libnautilus-extensions/nautilus-undo-context.c:
      	(nautilus_undo_context_new):
      	* libnautilus-extensions/nautilus-undo-manager.c:
      	(nautilus_undo_manager_new):
      	* libnautilus-extensions/nautilus-user-level-manager.c:
      	(user_level_manager_new):
      	* libnautilus/nautilus-undo-transaction.c:
      	(nautilus_undo_transaction_new):
      	* libnautilus/nautilus-view.c:
      	(nautilus_view_new_from_bonobo_control):
      	* src/file-manager/nautilus-trash-monitor.c:
      	(nautilus_trash_monitor_get):
      	* src/nautilus-desktop-window.c: (nautilus_desktop_window_new):
      	* src/nautilus-property-browser.c: (nautilus_property_browser_new):
      	* src/nautilus-shell.c: (nautilus_shell_new):
      	* src/nautilus-sidebar-tabs.c: (nautilus_sidebar_tabs_new):
      	* src/nautilus-sidebar-title.c: (nautilus_sidebar_title_new):
      	* src/nautilus-sidebar.c: (nautilus_sidebar_create_context_menu),
      	(nautilus_sidebar_new):
      	* src/nautilus-theme-selector.c: (nautilus_theme_selector_new):
      	* src/nautilus-throbber.c: (nautilus_throbber_new):
      	* src/nautilus-view-frame.c: (nautilus_view_frame_new):
      	* src/nautilus-zoom-control.c: (nautilus_zoom_control_new):
      	* src/nautilus-about.c: (nautilus_about_new):
      	* src/nautilus-application.c: (nautilus_application_new),
      	(nautilus_application_create_window):
      	* src/nautilus-bookmark-list.c: (nautilus_bookmark_list_new):
      	After Tim Janik explained that gtk_type_new is a low-level call to
      	be avoided, changed most uses of gtk_type_new to gtk_object_new or
      	gtk_widget_new. Also, after Owen and Havoc explained that you
      	can't just ignore the floating bit, added ref/sink calls to the
      	functions used to create objects where we don't use the floating
      	scheme.
      
      	* src/nautilus-zoom-control.c:
      	(nautilus_zoom_control_button_press_event): Take advantage of the
      	fact that the new menu is floating and don't bother with ref'ing.
      
      	* libnautilus-extensions/nautilus-ctree.c:
      	(nautilus_ctree_new_with_titles):
      	Added a cast.
      
      	* components/adapter/main.c: (adapter_factory_make_object):
      	* components/hardware/main.c: (hardware_view_make_object):
      	* components/services/install/lib/eazel-install-corba-callback.c:
      	(eazel_install_callback_get_type), (eazel_install_callback_new):
      	* libnautilus-extensions/nautilus-theme.c:
      	(nautilus_theme_get_theme), (nautilus_theme_set_theme),
      	(nautilus_theme_get_theme_data):
      	Whitespace tweaks.
      2cd5440e
  7. 22 Sep, 2000 1 commit
    • Mathieu Lacage's avatar
      replace strcmp by nautilus_uri_matchs: this took me a lot of time to find · f55fd914
      Mathieu Lacage authored
      2000-09-21  Mathieu Lacage  <mathieu@eazel.com>
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(bookmark_file_changed_callback): replace strcmp by
      	nautilus_uri_matchs: this took me a lot of time to find
      	out.
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_get_internal): remove is_canonical_uri
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_uri_is_local_scheme), (nautilus_handle_trailing_slashes),
      	(nautilus_make_uri_canonical), (nautilus_uri_is_canonical_uri),
      	(nautilus_self_check_file_utilities): make nautilus know the difference
      	between foo and foo/ so that we do not cache too aggressively.
      	* libnautilus-extensions/nautilus-file-utilities.h: add prototype for
      	nautilus_uri_is_canonical.
      f55fd914
  8. 21 Sep, 2000 1 commit
    • Darin Adler's avatar
      First step fixing storage leaks: Fixed some ref. count leaks of · 257366a5
      Darin Adler authored
      	NautilusFile, NautilusDirectory, and NautilusScalableIcon.
      
      	* components/tree/nautilus-tree-model.c: (remove_all_nodes):
      	Unref the root node when we are done with it.
      	(report_root_node_if_possible): Use report_node_changed for
      	new nodes as well.
      	(report_node_changed): Since a new node and a changed node are
      	really the same, just use this instead of using a different call
      	for added vs. changed.
      	(nautilus_tree_model_directory_files_changed_callback): Ref
      	the node when it's being added to the hash table. Get rid of
      	the misguided code that would ref "because remove will unref"
      	and instead use a more normal model.
      	(nautilus_tree_model_directory_files_added_callback): Fix a
      	storage leak in the case where we generate a warning. Changed it
      	from a printf to a g_warning. Use report_node_changed for new
      	nodes as well. Unref the node after adding it to use a more normal
      	ref model; handles cases where it's already in there properly, for
      	one thing.
      	* components/tree/nautilus-tree-node.c:
      	(nautilus_tree_node_set_parent): Changed an assert to a
      	return_if_fail.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_update_icon): Change the code to take the fact
      	that nautilus_icon_factory_get_icon_for_file yields a new ref into
      	account to plug a NautilusScalableIcon leak.
      
      	* src/nautilus-bookmark-parsing.c:
      	(nautilus_bookmark_new_from_node): Unref the icon after creating a
      	new bookmark. If the bookmark needs to keep it, it will ref it.
      
      	* src/file-manager/fm-icon-view.c: (get_icon_images_callback):
      	Extra space in here.
      257366a5
  9. 20 Sep, 2000 1 commit
    • Darin Adler's avatar
      Fixed compiling with newer gcc. Freetype was trying to use token pasting · e2aaa07e
      Darin Adler authored
      	* cut-n-paste-code/freetype/ftdebug.h: Fixed compiling with newer
      	gcc. Freetype was trying to use token pasting to attach the name
      	of a function (FTMessage) onto the parameters to that
      	function. There's no need to attempt this, and it's incorrect. I
      	removed the token pasting attempt. Perhaps Raph should get this
      	rolled back into the main freetype soruces.
      
      	* libnautilus-extensions/bonobo-stream-vfs.c: Cleaned up the code
      	a bit to match Nautilus coding style and remove some redundant
      	stuff.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_update_icon): Fixed a place where we unref the
      	old value before ref'ing the new one. It's not really a bug, but
      	it's a good habit to ref the new value first. Ran into this when
      	I started looking for NautilusScalableIcon leaks.
      e2aaa07e
  10. 12 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 884 (Long URI in Go menu doesn't get cut off) · 958002b3
      John Sullivan authored
      	Fixed bug 2667 (Really long bookmark titles stretch bookmarks menu)
      
      	* libnautilus-extensions/nautilus-gtk-extensions.h:
      	* libnautilus-extensions/nautilus-gtk-extensions.c:
      	(nautilus_truncate_text_for_menu_item): New function,
      	uses nautilus_str_middle_truncate to create a string
      	that isn't ridiculously long.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_menu_item_new): Use new function to
      	keep the menu items in the Back/Forward context menus
      	from getting too wide.
      	* src/nautilus-window-menus.c: (append_bookmark_to_menu):
      	Use new function to keep the menu items in the Go and
      	Bookmarks menus from getting too wide.
      958002b3
  11. 08 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 2218 (Duplicate items appear in history list) · 069f8b16
      John Sullivan authored
      	Also changed a few places to compare uris with the new
      	nautilus_uris_match instead of strcmp.
      
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_compare_with): Use nautilus_uris_match.
      	(nautilus_bookmark_compare_uris): New function, compares
      	bookmarks' uris with nautilus_uris_match; ignores names.
      
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_set_displayed_location), (handle_go_elsewhere),
      	(open_location): Use nautilus_uris_match.
      
      	* src/nautilus-window.c: (nautilus_add_to_history_list):
      	Use nautilus_bookmark_compare_uris instead of _compare_with.
      	This was the source of the bug. Due to asynchronicity introduced
      	sometime after this code was written, when the bookmark for the
      	current location was created it did not	yet know what name to use,
      	and so it did not match any of the old History items that had the
      	correct name. But for the History list we only want one entry per
      	uri anyway, so it needn't have been comparing the names in the
      	first place.
      069f8b16
  12. 01 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 1476 (Using bogus local bookmark should update · 2bef7d2c
      John Sullivan authored
      	its icon). The specific bug led me to changing some of
      	the internals of NautilusBookmark in a way that has nice
      	UI consequences. Now if you use Nautilus to move a bookmarked
      	file, the bookmark will continue to find the moved file, and
      	if you delete a file, the bookmark's icon will change to the
      	"missing location" icon.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_disconnect_file),
      	(nautilus_bookmark_connect_file): New helper functions that
      	handle wiring or unwiring the connection between a bookmark
      	and its NautilusFile.
      	(nautilus_bookmark_destroy): Use nautilus_bookmark_disconnect_file.
      	(nautilus_bookmark_new_with_icon): Use nautilus_bookmark_connect_file.
      	(bookmark_file_changed_callback): Notice changes in the file's URI
      	and update the bookmark to use the new URI; notice when the file
      	is gone and disconnect/reconnect to file.
      
      	Miscellaneous tweaks:
      
      	* src/file-manager/fm-search-list-view.c:
      	(compute_reveal_item_name_and_sensitivity): At the suggestion of
      	a localizer (menthos), added explanatory comments before the use
      	of "Reveal in New Window" and "Reveal in <n> New Windows". It turns
      	out that a comment just before a translatable text string will
      	appear in the .pot files that localizers use.
      	* src/nautilus-first-time-druid.c: (set_up_user_level_page):
      	Fixed two misspellings of "technical" and one missing period. Thanks
      	to menthos for pointing these out.
      	* src/nautilus-window-menus.c:
      	(show_bogus_bookmark_window): Use nautilus_format_uri_for_display
      	for bookmark uris shown in user messages. Simplify the message you
      	get if you choose a known-bogus URI from the Go menu.
      2bef7d2c
  13. 25 Aug, 2000 1 commit
    • Darin Adler's avatar
      Moved functions to gnome-vfs. · 9fd281ff
      Darin Adler authored
      	* components/music/nautilus-music-view.c: (play_current_file),
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_uri_known_not_to_exist):
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(theme_image_path_to_uri),
      	(nautilus_directory_background_read_desktop_settings),
      	(nautilus_directory_background_write_desktop_settings):
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_get_user_main_directory), (nautilus_is_remote_uri):
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	(nautilus_gdk_pixbuf_load):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(make_thumbnail_path), (path_represents_svg_image),
      	(load_specific_image), (nautilus_icon_factory_make_thumbnails):
      	* libnautilus-extensions/nautilus-link-set.c: (expand_uri):
      	* libnautilus-extensions/nautilus-link.c: (nautilus_link_create),
      	(nautilus_link_set_icon), (nautilus_link_set_link_uri),
      	(nautilus_link_set_type), (nautilus_link_get_root_property),
      	(make_local_path), (nautilus_link_get_image_uri):
      	* libnautilus-extensions/nautilus-preferences-item.c:
      	(add_icon_themes):
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application_parented):
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	(get_volume_vfs_uri_if_writable):
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	(mount_volume_mount):
      	* src/file-manager/fm-desktop-icon-view.c:
      	(startup_create_mount_links), (volume_mounted_callback),
      	(place_home_directory), (get_local_path):
      	* src/file-manager/fm-directory-view.c: (activate_callback):
      	* src/file-manager/fm-icon-view.c: (play_file):
      	* src/file-manager/fm-properties-window.c:
      	(get_and_ref_file_to_display):
      	* src/nautilus-desktop-window.c: (nautilus_desktop_window_new):
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_drag_data_get), (remove_background),
      	(remove_emblem), (emblem_image_file_changed),
      	(add_background_to_browser), (emblem_dialog_clicked),
      	(make_properties_from_directory):
      	* src/nautilus-sidebar.c: (map_local_data_file),
      	(uri_is_local_image):
      	* src/nautilus-theme-selector.c: (populate_list_with_themes):
      	* src/nautilus-view-frame-bonobo-embeddable.c:
      	(bonobo_subdoc_load_location):
      	* src/nautilus-window.c: (nautilus_window_go_home):
      	Changed to use local path functions from gnome-vfs now that
      	they are moved there from Nautilus.
      
      	* libnautilus-extensions/nautilus-file-utilities.h:
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	Removed the local path functions since they are in gnome-vfs
      	now and all callers have been changed to use those.
      9fd281ff
  14. 23 Aug, 2000 1 commit
    • John Sullivan's avatar
      Checked in this patch from Ken Kocienda, which fixes · 16d1c8c7
      John Sullivan authored
      	bug 390 (wrong magic number used when computing alpha
      	threshhold). Thanks Ken!
      
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.h:
      	New #define for NAUTILUS_STANDARD_ALPHA_THRESHHOLD
      
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_get_pixmap_and_mask):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_dnd_begin_drag):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_pixmap_and_mask_for_file):
      	* libnautilus-extensions/nautilus-list-column-title.c:
      	(load_up_indicator):
      	* libnautilus-extensions/nautilus-list.c: (draw_cell):
      	* src/file-manager/fm-properties-window.c:
      	(get_pixmap_and_mask_for_properties_window),
      	(create_image_widget_for_emblem):
      	* src/nautilus-bookmarks-window.c:
      	* src/nautilus-complex-search-bar.c:
      	(load_find_them_pixmap_widget):
      	* src/nautilus-property-browser.c: (set_emblem_image_from_file),
      	(element_clicked_callback), (make_properties_from_directory_path):
      	* src/nautilus-sidebar-title.c: (add_emblem):
      	* src/nautilus-theme-selector.c: (add_theme):
      	* src/nautilus-window.c: (nautilus_window_realize):
      	Replaced all uses of correct or incorrect magic numbers
      	with NAUTILUS_STANDARD_ALPHA_THRESHHOLD in calls to
      	gdk_pixbuf_render_pixmap_and_mask.
      16d1c8c7
  15. 02 Aug, 2000 1 commit
  16. 19 Jul, 2000 1 commit
    • Darin Adler's avatar
      Change include style from <libtrilobite/xxx.h> to "xxx.h" to fix the · 8bd0fdd4
      Darin Adler authored
      2000-07-19  Darin Adler  <darin@eazel.com>
      
      	* components/services/trilobite/libtrilobite/libtrilobite.h:
      	* components/services/trilobite/libtrilobite/trilobite-root-client.c:
      	Change include style from <libtrilobite/xxx.h> to "xxx.h" to fix
      	the build.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(make_uri_canonical), (is_canonical_uri):
      	Add two new elements to the canonical URI rules in here: put a
      	"file:" in front of things that don't have a scheme, and
      	lower-case the scheme.
      
      	* libnautilus-extensions/nautilus-string.h:
      	* libnautilus-extensions/nautilus-string.c:
      	(nautilus_istr_has_prefix), (nautilus_istr_has_suffix):
      	Add case-insensitive versions of these calls. These terse names
      	are maybe a little lame; istr is not completely clear. (I guess I
      	now wish the "nautilus_" namespace was "n_" instead, like those
      	rad Evolution people and their bold "e_").
      
      	* components/music/nautilus-music-view.c: (is_mp3_file),
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_format_uri_for_display),
      	(nautilus_get_local_path_from_uri):
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_contains_text):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_for_file), (make_thumbnail_path),
      	(load_specific_image):
      	* libnautilus-extensions/nautilus-theme.c:
      	(nautilus_theme_make_selector):
      	* src/file-manager/fm-icon-view.c: (play_file), (preview_sound),
      	(icon_container_preview_callback):
      	* src/file-manager/fm-properties-window.c:
      	(get_property_names_from_uri):
      	* src/nautilus-location-bar.c: (try_to_expand_path):
      	* src/nautilus-property-browser.c: (ensure_uri_is_image),
      	(make_properties_from_directory_path):
      	* src/nautilus-sidebar.c: (map_local_data_file),
      	(add_command_buttons):
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(local_data_file_to_uri):
      	Use case-insensitive string functions when dealing with MIME
      	types, URI schemes, or file name extensions for file types that
      	are also used on Windows where file names are not case sensitive.
      
      	* libnautilus-extensions/nautilus-string.c:
      	(nautilus_self_check_string):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_icon_is_different):
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_delete_items_with_uri):
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_reset_title_internal), (handle_go_back),
      	(handle_go_forward), (handle_go_elsewhere):
      	* src/nautilus-window-menus.c:
      	(nautilus_window_add_bookmark_for_current_location):
      	Get rid of uses of nautilus_eat_strcmp since it's yucky.
      
      	* libnautilus-extensions/nautilus-debug.c:
      	(nautilus_str_equal_with_free):
      	Make a debug-only thing kind of like nautilus_eat_strcmp that's
      	good for asserts.
      
      	* src/nautilus-sidebar.c: (add_command_buttons):
      	Fixed a storage leak.
      
      	* libnautilus-extensions/nautilus-link-set.c: (link_set_path_name):
      	Added a FIXME.
      
      	* components/services/install/command-line/.cvsignore:
      	* cut-n-paste-code/freetype/.cvsignore:
      	Ignore some generated files.
      8bd0fdd4
  17. 14 Jul, 2000 1 commit
  18. 12 Jul, 2000 1 commit
    • Darin Adler's avatar
      Change to use bonobo_object_unref now that the leaks have been fixed. This · 41f3913c
      Darin Adler authored
      	* src/nautilus-view-frame.c: (nautilus_view_frame_destroy_client):
      	Change to use bonobo_object_unref now that the leaks have been
      	fixed.  This requires the new Bonobo or you'll have lots of leaked
      	processes. Luckily, Nautilus won't compile without the new Bonobo
      	due to my use of bonobo_object_shutdown in main :-)
      
      	* configure.in:
      	Fix the way -Werror works so it affects all directories, not just
      	ones where we use WERROR.
      
      	* components/hardware/Makefile.am:
      	* components/help/Makefile.am:
      	* components/history/Makefile.am:
      	* components/loser/content/Makefile.am:
      	* components/loser/sidebar/Makefile.am:
      	* components/mozilla/Makefile.am:
      	* components/music/Makefile.am:
      	* components/notes/Makefile.am:
      	* components/rpmview/Makefile.am:
      	* components/sample/Makefile.am:
      	* components/services/install/command-line/Makefile.am:
      	* components/services/install/lib/Makefile.am:
      	* components/services/install/nautilus-view/Makefile.am:
      	* components/services/install/server/Makefile.am:
      	* components/services/inventory/lib/Makefile.am:
      	* components/services/inventory/nautilus-view/Makefile.am:
      	* components/services/inventory/service/Makefile.am:
      	* components/services/login/lib/Makefile.am:
      	* components/services/login/nautilus-view/Makefile.am:
      	* components/services/login/service/Makefile.am:
      	* components/services/startup/command-line/Makefile.am:
      	* components/services/startup/lib/Makefile.am:
      	* components/services/startup/nautilus-view/Makefile.am:
      	* components/services/summary/lib/Makefile.am:
      	* components/services/summary/nautilus-view/Makefile.am:
      	* components/services/summary/service/Makefile.am:
      	* components/services/time/command-line/Makefile.am:
      	* components/services/time/nautilus-view/Makefile.am:
      	* components/services/time/service/Makefile.am:
      	* components/services/trilobite/helper/Makefile.am:
      	* components/services/trilobite/libtrilobite/Makefile.am:
      	* components/services/trilobite/sample/command-line/.cvsignore:
      	* components/services/trilobite/sample/command-line/Makefile.am:
      	* components/services/trilobite/sample/lib/Makefile.am:
      	* components/services/trilobite/sample/nautilus-view/Makefile.am:
      	* components/services/trilobite/sample/service/Makefile.am:
      	* components/services/vault/command-line/Makefile.am:
      	* components/services/vault/lib/Makefile.am:
      	* components/services/vault/nautilus-view/Makefile.am:
      	* components/services/vault/service/Makefile.am:
      	* components/tree/Makefile.am:
      	* components/websearch/Makefile.am:
      	* cut-n-paste-code/widgets/nautilus-druid/Makefile.am:
      	* helper-utilities/authenticate/Makefile.am:
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus/Makefile.am:
      	* librsvg/Makefile.am:
      	* nautilus-installer/src/Makefile.am:
      	* src/Makefile.am:
      	* src/file-manager/Makefile.am:
      	* test/Makefile.am:
      	Got rid of the WERROR shell variable. The -Werror switch is no
      	longer a per-directory thing.
      
      	* librsvg/Makefile.am:
      	Added libpng to the libraries for the test program. Maybe this was
      	the wrong thing to do, but before this change the link failed.
      
      	* components/sample/Makefile.am:
      	* components/sample/main.c:
      	* components/sample/nautilus-sample-content-view.c:
      	* components/sample/nautilus-sample-content-view.h:
      	A clean-up of the sample, including fixing many bugs and adding
      	lots of comments. I figure we want this to be as close to
      	exemplary as possible since people will continue to start with it
      	for new components.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_new_with_icon): Removed a bogus extra ref of a
      	NautilusFile object that I spotted in here.
      
      	* src/nautilus-application.c: (nautilus_application_destroy_window):
      	Re-added the code to quit when the last window is closed that Mike
      	removed in his recent check-in.
      
      	* src/nautilus-main.c: (main): Added a call to bonobo_shutdown.
      	We don't need this call, but I say, "Why not?"
      41f3913c
  19. 27 Jun, 2000 1 commit
    • John Sullivan's avatar
      Finished task 461 (bookmarks to "Bad URI" should have · 2bc0425b
      John Sullivan authored
      	an icon). I picked arbitrary existing icons (gnome foot
      	for "generic bookmark", gnome-foot-question-mark for
      	"bookmark with known-bad URI"); Arlo and/or Susan will
      	have to come up with real ones. I'll write a separate
      	bug report about that.
      
      	* icons/i-bookmark.png:
      	* icons/i-bookmark-20.png:
      	* icons/i-bookmark-missing.png:
      	* icons/i-bookmark-missing-20.png: New icons to use
      	for bookmarks. I supplied the base size and the 20
      	pixel size because that's the one used in menus, where
      	bookmarks usually appear. These need to be replaced with
      	better images.
      
      	* icons/Makefile.am: Add new icons to installed set.
      
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_uri_known_not_to_exist): New public
      	function, moved some code from elsewhere to encapsulate this.
      	(nautilus_bookmark_set_icon_to_default): Choose between the
      	generic and bad-URI icon if there's no better icon.
      
      	* src/nautilus-window-menus.c: (activate_bookmark_in_menu_item):
      	Now calls nautilus_bookmark_uri_known_not_to_exist instead
      	of doing the work here.
      2bc0425b
  20. 19 Jun, 2000 1 commit
    • John Sullivan's avatar
      Fixed uninitialized variable that was masking the real · e3f2dd16
      John Sullivan authored
      	reason why eazel: URIs don't work today (real reason
      	has not been figured out yet).
      
      	* src/nautilus-applicable-views.c: (got_file_info_callback):
      	Initialize default_id to NULL.
      
      	More work towards bug 1401 (bookmark icon never updates).
      	Almost done, but for a bug where bookmark for current
      	location in Go menu doesn't get an icon.
      
      	* libnautilus-extensions/nautilus-string.h,
      	* libnautilus-extensions/nautilus-string.c:
      	(nautilus_str_is_empty): New function, returns TRUE for
      	NULL or zero-length string.
      
      	* libnautilus-extensions/nautilus-file-attributes.h:
      	Added #define for NAUTILUS_FILE_ATTRIBUTE_CUSTOM_ICON
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	Add file_info to Request struct.
      	(request_is_satisfied): Renamed from ready_callback_is_satisfied;
      	now takes a Request and a NautilusFile instead of a ReadyCallback.
      	(call_ready_callbacks): Update existing caller for API change.
      	(set_up_request_by_file_attributes): Set request's file_info
      	field to TRUE if mime type requested; set request's metafile
      	field to TRUE if custom icon requested.
      	(nautilus_directory_check_if_ready_internal): New function,
      	use request_is_satisfied to see whether specified attributes
      	are available.
      	* libnautilus-extensions/nautilus-directory-private.h:
      	Added nautilus_directory_check_if_ready_internal.
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_check_if_ready): Call nautilus_directory_check_
      	if_ready_internal.
      
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_is_icon_ready_for_file): Implemented
      	this formerly nonexistent function by calling
      	nautilus_file_check_if_ready
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_destroy), (nautilus_bookmark_icon_is_different),
      	(nautilus_bookmark_update_icon), (bookmark_file_changed_callback),
      	(nautilus_bookmark_set_icon_to_default), (nautilus_bookmark_new),
      	(nautilus_bookmark_new_with_icon): NautilusBookmark now keeps
      	ahold of a NautilusFile internally so it can notice its
      	"changed" signal. When this signal fires, the bookmark determines
      	whether a changed icon is available.
      e3f2dd16
  21. 17 Jun, 2000 1 commit
    • John Sullivan's avatar
      More work towards bug 1401 (bookmark icon never updates). · a773b187
      John Sullivan authored
      	You can avoid some warnings if you get the latest Bonobo.
      
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name):
      	Define "changed" signal for bookmarks and wire it up (though
      	not yet to the icon-changing case). Remove never-implemented
      	and never-to-be-implemented "nautilus_bookmark_get_file" since
      	I changed my mind on the design.
      	* src/nautilus-window-menus.c: (append_bookmark_to_menu),
      	(clear_appended_bookmark_items): Connect and disconnect
      	signals from the window to the bookmarks in the Go and
      	Bookmarks menus.
      a773b187
  22. 16 Jun, 2000 3 commits
    • Darin Adler's avatar
      New generated files that needed to be ignored. · 341c93f4
      Darin Adler authored
      	* components/services/trilobite/sample/lib/.cvsignore:
      	New generated files that needed to be ignored.
      
      	* libnautilus-extensions/nautilus-bookmark.c: (get_icon_for_uri):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(receive_dropped_keyword):
      	* src/nautilus-sidebar.c: (receive_dropped_keyword),
      	(open_with_callback):
      	* src/nautilus-window-manage-views.c: (handle_unreadable_location),
      	(nautilus_window_end_location_change_callback):
      	* src/nautilus-window.c: (view_menu_choose_view_callback):
      	Added FIXME comments for all cases I might have to revisit to
      	finish with bug 866.
      
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_search_directory_new),
      	(nautilus_directory_new), (nautilus_directory_is_local),
      	(nautilus_directory_is_search_directory):
      	Removed the is_local and is_search_directory booleans since they
      	are very fast to compute.
      	(nautilus_directory_call_when_ready): Removed the special case for
      	search directories that was causing a problem with NULL
      	directories.  This is better handled inside
      	nautilus-directory-async.c.
      	(nautilus_uri_is_search_uri): Greatly simplified the
      	implementation of the function and moved it out of the
      	"self-check-specific" part of the file.
      
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_format_uri_for_display), (nautilus_make_uri_from_input),
      	(nautilus_get_user_main_directory):
      	Renamed SCHEMA -> SCHEME. Converted code to use
      	nautilus_get_uri_from_local_path instead of just adding a file://
      	on the beginning of path names.
      
      	* libnautilus-extensions/nautilus-file.c: (nautilus_file_get):
      	Did part of the work needed to make this function do its work
      	async. It now only does the I/O if the file is not already known,
      	but there's still the issue of doing the I/O only when requested.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(receive_dropped_keyword): Fixed storage leaks.
      	(nautilus_icon_container_receive_dropped_icons),
      	(nautilus_icon_dnd_update_drop_target): Added FIXMEs about
      	file-specific stuff that's in here but should be in FMIconView.
      
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(path_represents_svg_image): Changed local svg check to use
      	gnome-vfs instead of NautilusFile.  This is better since we want
      	it to be sync.
      	(load_specific_image): Change to use
      	nautilus_get_local_path_from_uri instead of doing its own file://
      	checks and unescaping.
      
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	(nautilus_mime_get_default_component_for_uri_internal): Call the
      	new public OAF_ServerInfo_duplicate from liboaf instead of our
      	own copy. The one I checked in liboaf has a number of bugs fixed
      	from the one that was in here.
      	(mime_type_get_supertype): Put in a special case for NULL so we
      	don't return "/*" as a supertype for NULL.
      	(nautilus_do_component_query): Call OAF_ServerInfo_duplicate.
      	Also get rid of a NULL check before CORBA_free.
      
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	(nautilus_timed_wait_start), (nautilus_timed_wait_free):
      	* libnautilus-extensions/nautilus-stock-dialogs.h:
      	Added a window title to the still-not-implemented code in here.
      
      	* src/file-manager/fm-icon-text-window.c:
      	(create_icon_text_window): Changed the window title to match the
      	menu item.
      
      	* src/nautilus-main.c: Formatting tweaks.
      
      	* src/nautilus-sidebar.c: (receive_dropped_keyword), Fixed a
      	storage leak. Put in a FIXME about the code that is a copy of
      	what's in the icon view.
      341c93f4
    • John Sullivan's avatar
      Modernized some NautilusBookmark code that had been written · 4e90eb7b
      John Sullivan authored
      	in the dark ages (by me).
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_compare_with), (nautilus_bookmark_copy),
      	(nautilus_bookmark_get_name),
      	(nautilus_bookmark_get_pixmap_and_mask),
      	(nautilus_bookmark_get_pixbuf), (nautilus_bookmark_get_icon),
      	(nautilus_bookmark_get_uri), (create_pixmap_widget_for_bookmark),
      	(nautilus_bookmark_menu_item_new): Eliminated the use of
      	const NautilusBookmark *; made _get_name and _get_uri return
      	copies instead of the original text; tweaked a little formatting.
      
      	* components/history/nautilus-history-view.c: (install_icon),
      	(hyperbola_navigation_history_load_location),
      	(hyperbola_navigation_history_select_row):
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* src/nautilus-bookmark-list.c: (append_bookmark_node),
      	(nautilus_bookmark_list_append), (nautilus_bookmark_list_contains),
      	(nautilus_bookmark_list_delete_items_with_uri),
      	(nautilus_bookmark_list_insert_item):
      	* src/nautilus-bookmark-list.h:
      	* src/nautilus-bookmarks-window.c: (install_bookmark_icon),
      	(on_select_row), (repopulate):
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_reset_title_internal), (handle_go_back),
      	(handle_go_forward), (handle_go_elsewhere):
      	* src/nautilus-window-menus.c: (bookmark_holder_new),
      	(show_bogus_bookmark_window), (activate_bookmark_in_menu_item),
      	(append_bookmark_to_menu),
      	(nautilus_window_add_bookmark_for_current_location):
      	* src/nautilus-window.c: (nautilus_window_back_or_forward):
      	Eliminated the use of const NautilusBookmark *; changed all
      	callers of nautilus_bookmark_get_name and _get_uri to free
      	the results.
      4e90eb7b
    • John Sullivan's avatar
      Fixed bug 705 (Need to avoid network hit on startup for · 22c0f773
      John Sullivan authored
      	each remote bookmark). Bookmarks now get their icon only
      	when they're initially created, and then store a text
      	version of it to disk for future sessions. We might have
      	to update the icon at certain times later (maybe when it's
      	used?).
      
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_copy), (nautilus_bookmark_get_pixbuf),
      	(nautilus_bookmark_get_icon), (get_icon_for_uri),
      	(nautilus_bookmark_new), (nautilus_bookmark_new_with_icon):
      	Changed guts of NautilusBookmark to keep a
      	NautilusScalableIcon around. Also some miscellaneous
      	cleanup in this ancient file (need to do more).
      
      	* libnautilus-extensions/nautilus-icon-factory.h,
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(get_themed_icon_file_path): Added icon != NULL assert.
      	(get_icon_file_path): Handle NULL icon name by returning NULL;
      	some style fixes.
      	(nautilus_scalable_icon_get_text_pieces): New function,
      	returns all four pieces of text used to define a
      	NautilusScalableIcon.
      	(nautilus_scalable_icon_new_from_text_pieces):
      	Renamed from nautilus_scalable_icon_get and made public.
      	(nautilus_icon_factory_get_icon_for_file),
      	(nautilus_icon_factory_get_emblem_icon_by_name),
      	(load_image_with_embedded_text): Updated for function renaming.
      
      	* src/nautilus-bookmark-list.c: (append_bookmark_node),
      	(make_bookmark_from_node), (nautilus_bookmark_list_load_file):
      	Save & restore NautilusScalableIcon with each bookmark.
      
      	Added custom error message when trying to open a location
      	fails with GNOME_VFS_LOGINFAILED
      
      	* src/nautilus-applicable-views.h: Define
      	NAUTILUS_NAVIGATION_RESULT_LOGIN_FAILED
      	* src/nautilus-applicable-views.c:
      	(get_nautilus_navigation_result_from_gnome_vfs_result):
      	Support GNOME_VFS_LOGINFAILED, and tweak message for
      	unhandled case.
      	* src/nautilus-window-manage-views.c:
      	(nautilus_window_end_location_change_callback):
      	Support NAUTILUS_NAVIGATION_RESULT_LOGIN_FAILED and
      	remove message for unhandled case since complaining
      	about unhandled cases is done elsewhere.
      22c0f773
  23. 02 May, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 641: should check MIME type for SVG files. · 19354d16
      John Sullivan authored
      	Fixed bug 438: Bookmark menu items need to limit icon size
      
      	* libnautilus-extensions/nautilus-icon-factory.h:
      	Defined a new standard icon size, NAUTILUS_ICON_SIZE_FOR_MENUS.
      	None of the existing standard sizes look good in menus.
      
      	* libnautilus-extensions/nautilus-file.h,
      	* libnautilus-extensions/nautilus-file.c
      	(nautilus_file_is_mime_type): New function, compares against
      	a particular MIME type so the caller doesn't have to get the
      	MIME type and worry about whether to free it or not.
      
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(get_larger_icon_size),
      	(get_smaller_icon_size): Include NAUTILUS_ICON_SIZE_FOR_MENUS
      	when looking for the next size.
      	(str_has_svg_suffix): Removed this function.
      	(nautilus_icon_factory_get_icon_for_file): Use
      	nautilus_file_is_mime_type to check for SVG instead
      	of checking file suffix.
      	(path_represents_svg_image): New function.
      	(load_specific_image): Use path_represents_svg_image to
      	check for SVG instead of checking file suffix.
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(create_pixmap_widget_for_bookmark): Use
      	NAUTILUS_ICON_SIZE_FOR_MENUS.
      	* src/nautilus-window-menus.c (append_bookmark_to_menu):
      	Use NAUTILUS_ICON_SIZE_FOR_MENUS.
      19354d16
  24. 20 Apr, 2000 1 commit
    • John Sullivan's avatar
      Darin and I started out thinking we were going to start entering · 406ed6a9
      John Sullivan authored
      	bugs for the FIXME items but we were distracted into fixing bugs
      	and tweaking code that we found while doing so.
      
      	* check-FIXME.pl: Won't search old ChangeLogs for FIXMEs either;
      	changed FIXME format from "FIXME bug xxx" to "FIXME bugzilla.eazel.com xxx"
      
      	* components/history/ntl-history-view.c:
      	(hyperbola_navigation_history_notify_location_change): Moved bookmark
      	naming hack here and added FIXME explaining it.
      
      	* libnautilus-extensions/nautilus-bookmark.h,
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_new), (nautilus_bookmark_new_with_name):
      	Combined these two into one routine that takes both the uri and
      	title; removed hack for trying to come up with good name for
      	bookmark here.
      	(nautilus_bookmark_get_pixmap_and_mask): Changed to call
      	_get_pixbuf instead of duplicating code.
      	(nautilus_bookmark_get_pixbuf): Changed interface to return
      	pixbuf or NULL instead of boolean result & "out" parameter.
      
      	* src/nautilus-bookmark-list.c,
      	* src/nautilus-bookmarks-window.c,
      	* src/nautilus-window-menus.c,
      	* src/ntl-window-msgs.c:
      	Updated callers of nautilus_bookmark_new and _new_with_name.
      406ed6a9
  25. 15 Apr, 2000 1 commit
    • Darin Adler's avatar
      After a chat with Rebecca, named nautilus_str_underscore_escape to · f388c79d
      Darin Adler authored
      	* libnautilus-extensions/nautilus-string.c:
      	* libnautilus-extensions/nautilus-string.h:
      	After a chat with Rebecca, named nautilus_str_underscore_escape to
      	nautilus_str_double_underscores since the latter name more
      	accurately describes what it does.
      	(nautilus_str_double_underscores): Changed the function to allow
      	NULL and return NULL instead of doing g_return_val_if_fail.
      	(Also reformatted a bit and made a few gratuitous changes.)
      
      	* libnautilus-extensions/nautilus-bookmark.c:
      	* libnautilus-extensions/nautilus-bookmark.h:
      	(nautilus_bookmark_get_menu_display_name):
      	Moved the logic about escaping menu characters up one level so
      	the bookmark class doesn't have to know about it. This removes
      	the function from NautilusBookmark completely.
      
      	* src/nautilus-window-menus.c:
      	(append_bookmark_to_menu): Fixed a storage leak and moved the
      	double-underscore escaping in here.
      f388c79d
  26. 14 Apr, 2000 1 commit
  27. 12 Apr, 2000 1 commit
    • Darin Adler's avatar
      This is a new Perl script for searching for FIXME in the code. It reports · baebdb1a
      Darin Adler authored
      	* check-FIXME.pl: This is a new Perl script for searching for FIXME
      	in the code. It reports any FIXME that does not have a bug number
      	next to it, or any with a bug number that's not an open bug.
      	* libnautilus/nautilus-bookmark.c: Attached a bug number to a FIXME
      	for script-testing purposes.
      	* docs/architecture.txt: Removed a FIXME. So sue me!
      
      	* src/file-manager/fm-icon-text-window.c
      	(create_attributes_option_menu): Added a call to gettext since the
      	attribute_labels are now N_ strings.
      	* po/.cvsignore: Ignore the generated files.
      
      	* libnautilus/nautilus-icon-factory.c: Formatting tweak.
      baebdb1a
  28. 11 Apr, 2000 1 commit
    • Gene Z. Ragan's avatar
      components/sample/nautilus-sample-content-view.c Added icon data to · 2ac3c5da
      Gene Z. Ragan authored
      
      
      2000-04-11 Gene Z. Ragan <gzr@eazel.com>
      
      	* components/sample/nautilus-sample-content-view.c
      	Added icon data to BonoboUiHandler.  This is GdkPixbuf
      	data and demonstrates the pixbuf data features
      	added to bonobo ui handlers.
      
      	* libnautilus/nautilus-bookmark.c
      	bonobo_ui_handler_menu_new_item modified to take advantage
      	of new bonobo ui handler pixbuf functionality. Components and
      	menu items can now display pixbuf data.
      	Added nautilus_bookmark_get_pixbuf() routine.
      
      	* libnautilus/nautilus-bookmark.h
      	Added nautilus_bookmark_get_pixbuf() routine.
      
      	* src/nautilus-window-menus.c
      	bonobo_ui_handler_menu_new_item modified to take advantage
      	of new bonobo ui handler pixbuf functionality.
      2ac3c5da
  29. 28 Mar, 2000 1 commit
  30. 16 Mar, 2000 1 commit
    • Darin Adler's avatar
      Tell people about the gnome-xml branch. · ee495dba
      Darin Adler authored
      	* HACKING: Tell people about the gnome-xml branch.
      
      	* libnautilus/Makefile.am:
      	* libnautilus/gnome-icon-container-grid.c:
      	* libnautilus/gnome-icon-container-grid.h:
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c:
      	Broke out the grid code from the main container code.
      	This is a first step toward improving the layout code.
      
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	* src/fm-directory-view.c:
      	Got started on making the directory I/O async.
      	There's still a long way to go, this was a baby step.
      
      	* libnautilus/nautilus-bookmark.c:
      	* libnautilus/nautilus-bookmark.h:
      	* libnautilus/nautilus-self-checks.c:
      	General cleanup.
      
      	* libnautilus/nautilus-file.h:
      	Rearranged a little bit.
      
      	* libnautilus/nautilus-file-utilities.c:
      	Put FIXME in where there's code that needs to be changed.
      ee495dba
  31. 06 Mar, 2000 1 commit
    • Darin Adler's avatar
      Added the concept of separate X and Y scale factors to more · 2d3c87e1
      Darin Adler authored
      	of the code. Even though we don't want to scale the two
      	dimensions separately at the moment, I figured it was better
      	to go in this direction than to remove all the separate X
      	and Y stuff that Seth Nickell added.
      
      	* libnautilus/gnome-icon-container-dnd.c
      	(gnome_icon_container_receive_dropped_icons):
      	* libnautilus/gnome-icon-container-private.h:
      	* libnautilus/gnome-icon-container.c (icon_get_actual_size),
      	(icon_new), (icon_get_size), (start_stretching), (update_icon),
      	(gnome_icon_container_add), (gnome_icon_container_is_stretched),
      	(gnome_icon_container_unstretch),
      	(gnome_icon_container_move_icon):
      	* libnautilus/gnome-icon-container.h:
      	Got rid of the old "scale", "xscale", and "yscale" and replaced
      	them with "scale_x" and "scale_y". Made the code always set the
      	scale factor through the gnome_icon_container_move_icon bottleneck
      	so the changes are all reported throught the icon_moved signal.
      
      	* src/file-manager/fm-directory-view-icons.c:
      	(add_icon_if_already_positioned),
      	(fm_directory_view_icons_icon_moved_cb):
      	Store only a single scale factor if the X and Y are both scaled
      	exactly the same (the normal case). Also, use a default for
      	the scale factor so we don't save 1.0 for every file.
      
      	* libnautilus/nautilus-gtk-extensions.h:
      	* libnautilus/nautilus-gtk-extensions.c:
      	My original change required an additional marshal function. I
      	decided to add it anyway even though I don't need it right now.
      
      	* libnautilus/nautilus/nautilus-bookmark.c
      	(nautilus_bookmark_get_pixmap_and_mask):
      	Changed to use the nautilus_icon_factory_get_pixbuf_for_file
      	convenience function which has a simpler interface.
      
      	* libnautilus/nautilus-icon-factory.h:
      	* libnautilus/nautilus-icon-factory.c:
      	Added separate X and Y scaling of icons for possible future
      	use; the convenience functions still use the same size in
      	both dimentions.
      
      	* components/music/.cvsignore:
      	  New directory, new .cvsignore needed.
      
      	* RENAMING: Some more name change ideas.
      2d3c87e1
  32. 02 Mar, 2000 1 commit
  33. 18 Feb, 2000 1 commit
  34. 15 Feb, 2000 2 commits
  35. 01 Feb, 2000 1 commit
    • Darin Adler's avatar
      Changed the icon factory interface in a few ways: 1) There's no longer a · 39b26449
      Darin Adler authored
      	* libnautilus/nautilus-icon-factory.h:
      	* libnautilus/nautilus-icon-factory.c:
      	(nautilus_icon_factory_new):
      	(nautilus_icon_factory_destroy):
      	(nautilus_get_current_icon_factory):
      	(nautilus_icon_factory_get_icon_for_file):
      	(nautilus_icon_factory_set_theme):
      	(nautilus_icon_factory_get_icon_by_name):
      	(nautilus_icon_factory_get_pixbuf_for_icon):
      	(nautilus_scalable_icon_ref):
      	(nautilus_scalable_icon_unref):
      	(nautilus_scalable_icon_get_name):
      	(scalable_icon_get):
      	(icon_set_possibly_free):
      	(scalable_icon_new):
      	Changed the icon factory interface in a few ways: 1) There's no
      	longer a NautilusIconFactory object. There's just a single global
      	icon factory. If we find that we need multiple factories, we can
      	implement that later. 2) Instead of going straight from a file to
      	a pixbuf, you get a scalable icon, and then get a pixbuf from
      	that. This allows you to choose the icon and then get
      	different-sized versions of it without going through the icon
      	selection process over and over again. There's also a name for
      	each icon which can be stored in the metafile so you can get the
      	same icon again before you have full information on a file.
      
      	* src/nautilus-bookmark.c:
      	(nautilus_bookmark_get_pixmap_and_mask):
      	* src/file-manager/fm-directory-view-list.c:
      	(install_icon):
      	* src/file-manager/fm-icons-controller.c:
      	(fm_icons_controller_get_icon_image):
      	Changed icon factory clients to use the new interface. Maybe
      	after a while I'll add a convenience function that's as simple as
      	the old interface was for the common case where you want to go
      	straight to the pixbuf, but lets try it this way for a while.
      
      	* libnautilus/nautilus-string.h:
      	* libnautilus/nautilus-string.c:
      	(nautilus_has_prefix):
      	Added nautilus_has_prefix. This checks to see if a string has a
      	particular prefix. It's both clearer to read and more efficient
      	than Andy's typical trick of calling strstr.
      
      	* libnautilus/nautilus-lib-self-check-functions.h:
      	* libnautilus/nautilus-string.c:
      	Added self-checks for nautilus-string.c. The tests uncovered a
      	bug in nautilus_string_to_int that I fixed.
      
      	* nautilus-glib-extensions.c:
      	Just a stray new-line.
      39b26449
  36. 28 Jan, 2000 1 commit
  37. 03 Jan, 2000 1 commit