1. 21 Mar, 2001 1 commit
    • John Sullivan's avatar
      Fixed bug 4355: Built-in bookmarks icons change after first view · 65e9e66c
      John Sullivan authored
      	Also reduced the number of times that refresh_bookmarks_menu
      	is called since it was showing up in some profiling.
      
      	* libnautilus-extensions/nautilus-bookmark.h:
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_initialize_class), (nautilus_bookmark_set_name),
      	(bookmark_file_changed_callback): Split the "changed" signal into
      	"appearance_changed" and "content_changed". "appearance_changed" is
      	emitted only if the name or icon change. "content_changed" is emitted
      	if the URI changes.
      
      	* src/nautilus-bookmark-list.c: (insert_bookmark_internal):
      	Connect to both appearance_changed and content_changed.
      
      	* src/nautilus-window-menus.c: (bookmark_holder_new):
      	Refresh menu only on appearance_changed, not content_changed.
      
      	* data/static_bookmarks.xml: Added "i-web" as icon name for
      	all the built-in bookmarks, since this is the icon they will
      	end up with after being visited. (Now, visiting a built-in
      	bookmark will not cause a refresh of the bookmarks menu.)
      65e9e66c
  2. 06 Mar, 2001 1 commit
  3. 01 Mar, 2001 1 commit
  4. 23 Feb, 2001 1 commit
  5. 02 Feb, 2001 1 commit
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 7ce14a0b
      John Sullivan authored
      	Fixed bug 5749 (bookmarks are untranslated)
      
      	* data/static_bookmarks.xml:
      	An earlier checkin to update the bookmarks stripped off
      	all the underscores from "_name=" strings, which was what
      	was causing them to be translated. Fixed by returning the
      	underscores.
      7ce14a0b
  6. 24 Jan, 2001 1 commit
  7. 19 Jan, 2001 1 commit
    • Mike Engber's avatar
      reviewed by: Brian Frank · 9ec707d7
      Mike Engber authored
      
      	reviewed by: Brian Frank
      
      	* data/static_bookmarks.xml:
      	Changes for PR3 default bookmarks. Use redirects.
      9ec707d7
  8. 14 Nov, 2000 1 commit
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · b2609b01
      Darin Adler authored
      	* src/file-manager/fm-directory-view.c:
      	(display_selection_info_idle_callback),
      	(update_menus_idle_callback), (display_pending_idle_callback): Add
      	code to ref the BonoboControl around all three of these idle
      	functions to eliminate the problem where the directory view would
      	get destroyed in the middle of an idle.
      
      	* data/browser.xml:
      	* data/linksets/apps.xml:
      	* data/linksets/desktop.xml:
      	* data/linksets/portals.xml:
      	* data/linksets/search_engines.xml:
      	* data/static_bookmarks.xml:
      	Used "_" prefix on all localizable fields of XML files.
      
      	* po/POTFILES.in: Add all these XML files that need translation.
      
      	* libnautilus-extensions/nautilus-link-set.c:
      	(nautilus_link_set_install), (nautilus_link_set_is_installed),
      	(nautilus_link_set_remove): Fix storage leaks, also use
      	nautilus_xml_get_property_translated to get the property for the
      	"name" property so it can be translated if desired.
      
      	* libnautilus-extensions/nautilus-xml-extensions.h:
      	* libnautilus-extensions/nautilus-xml-extensions.c:
      	(nautilus_xml_get_property_translated): Add a version of
      	xmlGetProp that looks for an untranslated version of the property
      	and runs it through gettext if there is not a pre-translated
      	version present.  For strings downloaded from the service, for
      	example, we'll probably use a pre-translated string, but for
      	things in the Nautilus source tree we can use an untranslated
      	string.
      
      	* src/nautilus-bookmark-parsing.c:
      	(nautilus_bookmark_new_from_node): Use
      	nautilus_xml_get_property_translated to get the bookmark name so
      	that static bookmarks can have names translated with gettext. New
      	versions of the static bookmarks downloaded from the service can
      	use either kind of name. And user-created bookmarks are not run
      	through the gettext mechanism.
      
      	* src/nautilus-window-menus.c: (create_menu_item_from_node): Use
      	nautilus_xml_get_property_translated to get the folder names
      	translated just as the bookmarks themselves.
      
      	* src/nautilus-link-set-window.c: (get_link_set_names): Added a
      	FIXME. The link set names should come from inside the XML, not
      	from the file names.
      
      	* src/nautilus-property-browser.c: (get_xml_path),
      	(read_browser_xml), (write_browser_xml), (get_color_category):
      	(remove_color), (add_color_to_file): Factor out some shared code.
      	(add_reset_property): Make hard-wired font size with FIXME.
      	(make_properties_from_xml_node): Fix storage leaks and get the
      	name of the color using nautilus_xml_get_property_translated so
      	the names can be translated.
      	(set_up_category_width): Fix storage leaks
      	(nautilus_property_browser_update_contents): Fix storage leaks and
      	get the display name and description with
      	nautilus_xml_get_property_translated so they can be translated.
      
      	* check-THANKS.pl: Got rid of extra blank line at end.
      
      	* libnautilus-extensions/nautilus-customization-data.c:
      	(format_name_for_display): Add FIXME to bad-for-localization
      	function that turns "_" into " " and capitalizes the first letter
      	after each " ".
      b2609b01
  9. 31 Oct, 2000 1 commit
  10. 24 Oct, 2000 1 commit
  11. 06 Oct, 2000 1 commit
  12. 07 Sep, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 2875 (update set of built-in bookmarks) · 325450eb
      John Sullivan authored
      	* data/static_bookmarks.xml:
      
      	Fixed bug 2872 (Complaint about bookmark location mismatch
      	when visiting new folder)
      
      	* libnautilus-extensions/nautilus-file-utilities.h:
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_uris_match): New function, compares two uris
      	after canonicalizing each.
      
      	* src/nautilus-window-manage-views.c:
      	(check_last_bookmark_location_matches_window):
      	Use nautilus_uris_match to compare bookmark's uri with
      	window's uri.
      325450eb
  13. 10 Aug, 2000 1 commit
  14. 28 Jul, 2000 1 commit
    • John Sullivan's avatar
      Finished task 1793 (Display hierarchical pre-canned set of bookmarks) · 0430cc6d
      John Sullivan authored
      	There's now a "static_bookmarks.xml" file that gets installed into
      	the Nautilus data directory. Its contents are parsed into menu items
      	that appear above the user's dynamic items. The static items can
      	include hierarchy and separators. I put in silly content; someone
      	else will have to figure out what content we want to ship.
      
      	* data/static_bookmarks.xml: New file, tree of bookmarks to display.
      	* data/Makefile.am: Install the bookmarks file into data directory.
      
      	* src/nautilus-bookmark-parsing.h,
      	* src/nautilus-bookmark-parsing.c: New files, contain xml-bookmark-
      	parsing code that's used by both the static and dynamic bookmarks.
      	* src/Makefile.am: tell build about new files.
      
      	* src/nautilus-bookmark-list.c:
      	(make_bookmark_from_node): Moved and renamed this into new file.
      	(nautilus_bookmark_list_load_file): Call renamed function.
      
      	* src/nautilus-window-menus.c:
      	Renamed BookmarkHolder "in_bookmarks_menu" field to "prompt_for_removal"
      	to clarify its use.
      	(bookmark_holder_new), (show_bogus_bookmark_window): Accounted for
      	name changes.
      	(append_separator): Just moved this function.
      	(get_static_bookmarks_file_path): New function, returns path for
      	static bookmarks file if found.
      	(create_menu_item_from_node): New function, creates a menu item
      	from an xml node, recursing into folders.
      	(append_static_bookmarks): New function, reads xml document and
      	starts the menu-item-creation recursion.
      	(nautilus_window_initialize_bookmarks_menu): Now calls
      	append_static_bookmarks before handling the dynamic ones.
      
      	* src/nautilus-window-private.h: New last_static_bookmark_path field
      	in Details struct.
      	* src/nautilus-window.c: (nautilus_window_destroy): free
      	last_static_bookmark_path field.
      0430cc6d