1. 24 May, 2000 2 commits
    • Gene Z. Ragan's avatar
      Added call to CORBA_Object_duplicate(). This fixed an explosive bug. · 539ae559
      Gene Z. Ragan authored
      2000-05-23  Gene Z. Ragan  <gzr@eazel.com>
      
      	* libnautilus/nautilus-undo-context.c:
      	(impl_Nautilus_Undo_Context__get_undo_manager):
      	Added call to CORBA_Object_duplicate().  This
      	fixed an explosive bug.
      
      	* libnautilus/nautilus-undo-manager.c:
      	* libnautilus/nautilus-undo-manager.h:
      	(nautilus_undo_manager_stash_global_undo),
      	(nautilus_undo_manager_get_global_undo):
      	New functions to save application global instance of Nautilus_Undo_Manager
      
      	* src/ntl-app.c: (nautilus_app_init):
      	Add call to nautilus_undo_manager_stash_global_undo.
      
      	* src/ntl-view.c:
      	(nautilus_view_frame_load_client):
      	Coonected Nautilus_Undo_Context interface to view frame.
      539ae559
    • John Sullivan's avatar
      A few cleanup tweaks inspired by debugging session · e4d87678
      John Sullivan authored
      	with Darin.
      
      	* libnautilus-extensions/nautilus-program-choosing.h,
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_choose_application_for_file): Make callback
      	take a const char * instead of a char *.
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_chose_application_callback): take
      	a const char * instead of a char *.
      	* src/ntl-index-panel.c:
      	(nautilus_index_panel_chose_application_callback):
      	take a const char * instead of a char *.
      	(open_with_callback): unref file
      	(add_command_buttons): Use gtk_signal_connect instead of
      	nautilus_gtk_signal_connect_free_data when passing NULL
      	as the data (Doh!).
      e4d87678
  2. 23 May, 2000 6 commits
    • John Sullivan's avatar
      Some pieces of the application and component-choosing UI. · 08a71e32
      John Sullivan authored
      	They don't do anything useful yet.
      
      	* libnautilus-extensions/nautilus-program-chooser.h,
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	New files with code for creating a program-choosing
      	dialog (which is really degenerate right now).
      
      	* libnautilus-extensions/nautilus-program-choosing.h,
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	New files with functions for choosing a component or other
      	program to display or open a file with. This uses the
      	dialog in nautilus-program-chooser, but callers don't
      	need to know that.
      
      	* libnautilus-extensions/Makefile.am: add these new
      	files to the build.
      
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_chose_application_callback),
      	(fm_directory_view_chose_component_callback), (choose_application),
      	(choose_component), (bonobo_menu_other_program_callback),
      	(other_application_callback), (other_viewer_callback):
      	New functions that connect the program-choosing UI to the
      	menu items.
      	(compute_menu_item_info): Stop desensitizing the "Other ..." items.
      	(append_gtk_menu_item): Eliminated this function, made callers use
      	more elaborate append_gtk_menu_item_with_view instead.
      	(fm_directory_view_real_create_background_context_menu_items),
      	(create_open_with_gtk_menu):
      	Updated callers to append_gtk_menu_item.
      	(fm_directory_view_real_create_selection_context_menu_items):
      	Pass view to create_open_with_gtk_menu.
      	(reset_bonobo_open_with_menu): Now takes an FMDirectoryView and
      	uses it as callback data for "Other..." items.
      	(fm_directory_view_real_merge_menus),
      	(fm_directory_view_real_update_menus): Pass view to
      	reset_bonobo_open_with_menu.
      
      	* src/ntl-index-panel.c: (command_button_callback): Renamed from
      	command_button_cb, also broke out application-launching code and
      	moved it to libnautilus-extensions/nautilus-program-choosing.c.
      	(nautilus_index_panel_chose_application_callback),
      	(open_with_callback): New functions, used to wire up functionality
      	of "Open with ..." button.
      	(add_command_buttons): Stop desensitizing "Open with ..." button,
      	and wire it up to do something.
      
      	* src/ntl-window.h: Renamed field "option_cvtype" to "view_as_option_menu".
      	* src/ntl-window.c:
      	(nautilus_window_constructed): Updated to match field name change.
      	(nautilus_window_switch_views): New function, broken out of
      	view_menu_switch_views_callback; switches window to new content view.
      	(view_menu_switch_views_callback): Now calls nautilus_window_switch_views.
      	(synch_view_as_menu): New function, resets displayed name of "View as"
      	menu to match current content view.
      	(chose_component_callback), (view_menu_choose_view_callback): New
      	functions, used to implement "View as ..." menu item.
      	(nautilus_window_load_content_view_menu): Store iid in menu item;
      	call synch_view_as_menu; wire up "View as ..." menu item.
      
      
      	* src/ntl-window-msgs.c: (handle_unreadable_location):
      	Tweaked wording of an error message.
      
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file): Tweaked wording of an error message.
      08a71e32
    • Darin Adler's avatar
      The ViewFrame <-> View renaming. · 8ce35298
      Darin Adler authored
      	We still have to rename the files.
      
      	* RENAMING: Put in explicit cases for file name renaming.
      
      	* src/Makefile.am:
      	* src/nautilus-desktop-window.c:
      	* src/nautilus-desktop-window.h:
      	Added placeholders. I'll be putting code in here soon.
      
      	* src/ntl-app.c: (display_prototype_caveat):
      	Changed to use nautilus_simple_dialog again since otherwise it
      	comes up behind the main window. Perhaps someone will resolve
      	that issue and change it back.
      
      	* libnautilus-extensions/nautilus-gnome-extensions.h:
      	* libnautilus-extensions/nautilus-gnome-extensions.c:
      	(nautilus_warning_dialog), (nautilus_warning_dialog_parented):
      	Added centered version of the warning dialog as well, since
      	Eskil was using gnome_warning_dialog in a case where he really
      	wanted lines wrapped.
      
      	* components/loser/.cvsignore:
      	* components/loser/content/.cvsignore:
      	* components/loser/sidebar/.cvsignore:
      	Ignore some generated files.
      
      	* components/hardware/main.c: (hardware_view_make_object):
      	* components/hardware/nautilus-hardware-view.c:
      	(nautilus_hardware_view_initialize),
      	(nautilus_hardware_view_destroy),
      	(nautilus_hardware_view_get_nautilus_view),
      	(hardware_view_notify_location_change_callback):
      	* components/hardware/nautilus-hardware-view.h:
      	* components/help/hyperbola-nav-index.c:
      	(hyperbola_navigation_index_select_row),
      	(hyperbola_navigation_index_new):
      	* components/help/hyperbola-nav-search.c:
      	(hyperbola_navigation_search_select_row),
      	(hyperbola_navigation_search_new):
      	* components/help/hyperbola-nav-tree.c:
      	(hyperbola_navigation_tree_new),
      	(hyperbola_navigation_tree_notify_location_change),
      	(hyperbola_navigation_tree_select_row):
      	* components/history/ntl-history-view.c:
      	(hyperbola_navigation_history_notify_location_change),
      	(hyperbola_navigation_history_select_row), (make_obj):
      	* components/html/ntl-web-browser.c: (browser_url_load_done),
      	(browser_vfs_callback), (browser_goto_url_real),
      	(browser_goto_url), (browser_select_url), (browser_title_changed),
      	(browser_notify_location_change), (make_obj):
      	* components/loser/content/main.c: (loser_make_object):
      	* components/loser/content/nautilus-content-loser.c:
      	(nautilus_content_loser_initialize),
      	(nautilus_content_loser_destroy),
      	(nautilus_content_loser_get_nautilus_view),
      	(nautilus_content_loser_load_uri),
      	(loser_notify_location_change_callback), (bonobo_loser_callback):
      	* components/loser/content/nautilus-content-loser.h:
      	* components/loser/sidebar/main.c: (loser_make_object):
      	* components/loser/sidebar/nautilus-sidebar-loser.c:
      	(nautilus_sidebar_loser_initialize),
      	(nautilus_sidebar_loser_destroy),
      	(nautilus_sidebar_loser_get_nautilus_view),
      	(loser_notify_location_change_callback):
      	* components/loser/sidebar/nautilus-sidebar-loser.h:
      	* components/music/main.c: (music_view_make_object):
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_initialize), (nautilus_music_view_destroy),
      	(nautilus_music_view_get_nautilus_view),
      	(music_view_notify_location_change_callback):
      	* components/music/nautilus-music-view.h:
      	* components/notes/ntl-notes.c: (notes_notify_location_change),
      	(make_notes_view):
      	* components/rpmview/main.c: (rpm_view_make_object):
      	* components/rpmview/nautilus-rpm-view.c:
      	(nautilus_rpm_view_initialize), (nautilus_rpm_view_destroy),
      	(nautilus_rpm_view_get_nautilus_view),
      	(rpm_view_notify_location_change_callback):
      	* components/rpmview/nautilus-rpm-view.h:
      	* components/sample/main.c: (sample_make_object):
      	* components/sample/nautilus-sample-content-view.c:
      	(nautilus_sample_content_view_initialize),
      	(nautilus_sample_content_view_destroy),
      	(nautilus_sample_content_view_get_nautilus_view),
      	(sample_notify_location_change_callback):
      	* components/sample/nautilus-sample-content-view.h:
      	* components/services/startup/nautilus-view/main.c:
      	(services_make_object):
      	* components/services/startup/nautilus-view/nautilus-service-startup-view.c:
      	(go_to_uri), (nautilus_service_startup_view_initialize),
      	(nautilus_service_startup_view_get_nautilus_view),
      	(service_main_notify_location_change_cb):
      	* components/services/startup/nautilus-view/nautilus-service-startup-view.h:
      	* components/websearch/ntl-web-search.c:
      	(web_search_notify_location_change), (do_search), (make_obj):
      	* libnautilus/nautilus-clipboard.c:
      	(nautilus_clipboard_info_set_view),
      	(nautilus_clipboard_info_get_view),
      	(nautilus_clipboard_info_get_bonobo_control):
      	* libnautilus/nautilus-clipboard.h:
      	* src/file-manager/fm-directory-view.c:
      	(bonobo_menu_move_to_trash_callback), (get_bonobo_control),
      	(fm_directory_view_initialize), (display_selection_info),
      	(fm_directory_view_send_selection_change),
      	(notify_location_change_callback),
      	(notify_selection_change_callback),
      	(stop_location_change_callback), (done_loading),
      	(fm_directory_view_get_nautilus_view),
      	(fm_directory_view_activate_file_internal), (finish_loading_uri):
      	* src/file-manager/fm-directory-view.h:
      	Updated for new libnautilus where the NautilusViewFrame
      	classes are now named NautilusView.
      
      	* libnautilus/nautilus-content-view-frame.c:
      	(nautilus_content_view_initialize), (nautilus_content_view_new),
      	(nautilus_content_view_new_from_bonobo_control),
      	(nautilus_content_view_destroy),
      	(nautilus_content_view_initialize_class),
      	(nautilus_content_view_request_title_change):
      	* libnautilus/nautilus-content-view-frame.h:
      	* libnautilus/nautilus-meta-view-frame.c:
      	(nautilus_meta_view_initialize), (nautilus_meta_view_new),
      	(nautilus_meta_view_new_from_bonobo_control),
      	(nautilus_meta_view_destroy),
      	(nautilus_meta_view_initialize_class):
      	* libnautilus/nautilus-meta-view-frame.h:
      	Changed Nautilus*ViewFrame classes to Nautilus*View. This is
      	something we had in RENAMING for some time, and it's consistent
      	with Bonobo's naming of BonoboControl and BonoboControlFrame.
      	Also changed interfaces to use actual BonoboControl * instead of
      	using BonobObject * and query_interface.
      
      	* libnautilus/nautilus-undo-manager.c:
      	(nautilus_undo_setup_bonobo_control):
      	* libnautilus/nautilus-undo-manager.h:
      	Changed the BonoboControl parameter to actually be of type
      	BonoboControl * instead of BonoboObject *.
      
      	* libnautilus/nautilus-view-frame-private.h:
      	* libnautilus/nautilus-view-frame.c:
      	(impl_Nautilus_View_save_state), (impl_Nautilus_View_load_state),
      	(impl_Nautilus_View_notify_location_change),
      	(impl_Nautilus_View_show_properties),
      	(impl_Nautilus_View_notify_selection_change),
      	(impl_Nautilus_View_stop_location_change),
      	(impl_Nautilus_View__destroy), (impl_Nautilus_View__create),
      	(nautilus_view_initialize_class), (nautilus_view_set_arg),
      	(nautilus_view_get_arg), (nautilus_view_initialize),
      	(nautilus_view_new), (nautilus_view_new_from_bonobo_control),
      	(nautilus_view_destroy), (nautilus_view_ensure_view_frame),
      	(nautilus_view_request_location_change),
      	(nautilus_view_request_selection_change),
      	(nautilus_view_request_status_change),
      	(nautilus_view_request_progress_change),
      	(nautilus_view_get_bonobo_control),
      	(nautilus_view_get_main_window),
      	(nautilus_view_real_set_bonobo_control):
      	* libnautilus/nautilus-view-frame.h:
      	* libnautilus/nautilus-zoomable.c:
      	(impl_Nautilus_Zoomable__get_zoom_level),
      	(impl_Nautilus_Zoomable__set_zoom_level),
      	(impl_Nautilus_Zoomable__get_min_zoom_level),
      	(impl_Nautilus_Zoomable__get_max_zoom_level),
      	(impl_Nautilus_Zoomable__get_is_continuous),
      	(impl_Nautilus_Zoomable_zoom_in),
      	(impl_Nautilus_Zoomable_zoom_out),
      	(impl_Nautilus_Zoomable_zoom_to_fit),
      	(impl_Nautilus_Zoomable__destroy),
      	(impl_Nautilus_Zoomable__create), (marshal_NONE__DOUBLE),
      	(nautilus_zoomable_initialize_class), (nautilus_zoomable_set_arg),
      	(nautilus_zoomable_get_arg), (nautilus_zoomable_initialize),
      	(nautilus_zoomable_new),
      	(nautilus_zoomable_new_from_bonobo_control),
      	(nautilus_zoomable_destroy),
      	(nautilus_zoomable_ensure_zoomable_frame),
      	(nautilus_zoomable_set_zoom_level),
      	(nautilus_zoomable_get_bonobo_control),
      	(nautilus_zoomable_real_set_bonobo_control):
      	* libnautilus/nautilus-zoomable.h:
      	* src/nautilus-zoomable-frame-svr.c:
      	(impl_Nautilus_ZoomableFrame__destroy),
      	(impl_Nautilus_ZoomableFrame__create),
      	(impl_Nautilus_ZoomableFrame_notify_zoom_level):
      	* src/ntl-app.c: (impl_Nautilus_Application_create_object),
      	* src/ntl-content-view.c:
      	(impl_Nautilus_ContentViewFrame_request_title_change),
      	(nautilus_content_view_frame_get_type),
      	(nautilus_content_view_frame_class_init),
      	(nautilus_content_view_frame_init),
      	(nautilus_content_view_frame_set_active),
      	(nautilus_content_view_frame_request_title_change):
      	* src/ntl-content-view.h:
      	* src/ntl-index-panel.c: (nautilus_index_panel_add_meta_view),
      	(nautilus_index_panel_remove_meta_view):
      	* src/ntl-index-panel.h:
      	* src/ntl-meta-view.c: (nautilus_meta_view_frame_initialize_class),
      	(nautilus_meta_view_frame_initialize),
      	(nautilus_meta_view_frame_set_label),
      	(nautilus_meta_view_frame_get_label):
      	* src/ntl-meta-view.h:
      	* src/ntl-view-bonobo-control.c: (destroy_bonobo_control_view),
      	(nautilus_view_frame_activate_uri),
      	(bonobo_control_try_load_client),
      	(bonobo_control_notify_location_change):
      	* src/ntl-view-bonobo-subdoc.c: (destroy_bonobo_subdoc_view),
      	(bonobo_subdoc_notify_location_change),
      	(bonobo_subdoc_try_load_client):
      	* src/ntl-view-frame-svr.c: (impl_Nautilus_ViewFrame__destroy),
      	(impl_Nautilus_ViewFrame__create),
      	(impl_Nautilus_ViewFrame_request_location_change),
      	(impl_Nautilus_ViewFrame_request_selection_change),
      	(impl_Nautilus_ViewFrame_request_status_change),
      	(impl_Nautilus_ViewFrame_request_progress_change):
      	* src/ntl-view-nautilus.c: (nautilus_view_try_load_client),
      	(destroy_nautilus_view), (nv_show_properties), (nv_save_state),
      	(nv_load_state), (nv_notify_location_change),
      	(nv_notify_selection_change), (nv_stop_location_change):
      	* src/ntl-view-private.h:
      	* src/ntl-view.c: (nautilus_view_frame_get_type),
      	(nautilus_view_frame_class_init), (nautilus_view_frame_set_arg),
      	(nautilus_view_frame_get_arg), (nautilus_view_frame_init),
      	(nautilus_view_frame_destroy_client),
      	(nautilus_view_frame_destroy), (nautilus_view_frame_constructed),
      	(nautilus_view_frame_construct_arg_set),
      	(nautilus_view_frame_size_request),
      	(nautilus_view_frame_size_allocate),
      	(nautilus_view_frame_handle_client_destroy),
      	(nautilus_view_frame_handle_client_destroy_2),
      	(nautilus_view_frame_load_client),
      	(nautilus_view_frame_notify_location_change),
      	(nautilus_view_frame_notify_selection_change),
      	(nautilus_view_frame_load_state), (nautilus_view_frame_save_state),
      	(nautilus_view_frame_show_properties),
      	(nautilus_view_frame_stop_location_change),
      	(nautilus_view_frame_is_zoomable),
      	(nautilus_view_frame_get_zoom_level),
      	(nautilus_view_frame_set_zoom_level),
      	(nautilus_view_frame_get_min_zoom_level),
      	(nautilus_view_frame_get_max_zoom_level),
      	(nautilus_view_frame_get_is_continuous),
      	(nautilus_view_frame_zoom_in), (nautilus_view_frame_zoom_out),
      	(nautilus_view_frame_zoom_to_fit), (nautilus_view_frame_get_iid),
      	(nautilus_view_frame_get_client_objref),
      	(nautilus_view_frame_get_objref),
      	(nautilus_view_frame_request_location_change),
      	(nautilus_view_frame_request_selection_change),
      	(nautilus_view_frame_request_status_change),
      	(nautilus_view_frame_request_progress_change),
      	(nautilus_view_frame_notify_zoom_level), (check_object),
      	(nautilus_view_frame_set_active_errors):
      	* src/ntl-view.h:
      	* src/ntl-window-msgs.c: (nautilus_window_notify_selection_change),
      	(nautilus_window_request_selection_change),
      	(nautilus_window_request_status_change),
      	(nautilus_window_request_progress_change),
      	(nautilus_window_request_title_change),
      	(nautilus_window_update_internals), (nautilus_window_update_view),
      	(nautilus_window_view_destroyed), (nautilus_window_load_meta_view),
      	(nautilus_window_request_location_change),
      	(nautilus_window_load_content_view),
      	(nautilus_window_update_state), (nautilus_window_set_state_info),
      	(nautilus_window_begin_location_change):
      	* src/ntl-window-msgs.h:
      	* src/ntl-window-private.h:
      	* src/ntl-window.c: (zoom_in_cb), (zoom_out_cb),
      	(nautilus_window_set_arg), (nautilus_window_send_show_properties),
      	(view_menu_switch_views_callback),
      	(nautilus_window_set_content_view),
      	(nautilus_window_add_meta_view),
      	(nautilus_window_remove_meta_view_real),
      	(nautilus_window_remove_meta_view),
      	(nautilus_window_request_location_change_cb),
      	(nautilus_window_request_selection_change_cb),
      	(nautilus_window_request_status_change_cb),
      	(nautilus_window_request_progress_change_cb),
      	(nautilus_window_request_title_change_callback),
      	(nautilus_window_connect_view),
      	(nautilus_window_connect_content_view),
      	(nautilus_window_real_set_content_view):
      	* src/ntl-window.h:
      	Changed Nautilus*View classes to Nautilus*ViewFrame. This is
      	something we had in RENAMING for some time, and it's consistent
      	with Bonobo's naming of BonoboControl and BonoboControlFrame.
      	Also changed interfaces to use actual BonoboControl * instead of
      	using BonoboObject * and query_interface.
      8ce35298
    • Gene Z. Ragan's avatar
      Additonal work on making the undo context CORBA object. · f469d19b
      Gene Z. Ragan authored
      2000-05-23  Gene Z. Ragan  <gzr@eazel.com>
      
      	* libnautilus/nautilus-undo-context.c:
      	* libnautilus/nautilus-undo-context.h:
      	(impl_Nautilus_Undo_Context__get_undo_manager),
      	(nautilus_undo_context_new), (nautilus_undo_context_initialize):
      	Additonal work on making the undo context CORBA object.
      
      	* libnautilus/nautilus-undo-manager.c:
      	* libnautilus/nautilus-undo-manager.h:
      	* libnautilus/nautilus-undo-manager-private.h:
      	(impl_Nautilus_Undo_Manager__undo),
      	(nautilus_undo_manager_initialize),
      	(nautilus_undo_manager_add_transaction),
      	(nautilus_undo_manager_unregister_object),
      	(nautilus_get_undo_manager), (nautilus_attach_undo_manager),
      	Changed APIs to accept and return Nautilus_Undo_Manager CORBA
      	object instead of NautilusUndoManager pointer.
      
      	(nautilus_undo_setup_bonobo_control):
      	Added function stub to be filled later.  This function
      	will attach an undo manager to a bonobo control.
      
      	Removed several functions no longer needed in new design,
      	including nautilus_undo_manager_begin_transaction(),
      	and nautilus_undo_manager_end_transaction().
      
      	* src/nautilus-window-menus.c: (edit_menu_undo_callback),
      	(nautilus_window_initialize_menus), (update_undo_menu_item):
      	Changed to use modified undo API
      
      	* src/ntl-app.c:
      	(nautilus_app_init):
      	Changed to use modified undo API
      
      	* src/ntl-window.c: (nautilus_window_constructed)
      	Changed to use modified undo API
      f469d19b
    • Eskil Heyn Olsen's avatar
      Changed to simply use a gnome_warning_dialog instead of a · 731950d1
      Eskil Heyn Olsen authored
      	* src/ntl-app.c (display_prototype_caveat): Changed to simply use
      	a gnome_warning_dialog instead of a nautilus_simple_dialog. We
      	loose the word wrapping though. But now the main window loads
      	while the warning is present, plus it's a real GNOME warning box,
      	so be afraid...
      	(display_prototype_caveat): If NAUTILUS_NO_CAVEAT_DIALOG is set,
      	do not display the caveat warning.
      731950d1
    • Eskil Heyn Olsen's avatar
      Changed to simply use a gnome_warning_dialog instead of a · 8d1a3bb7
      Eskil Heyn Olsen authored
      
      	* src/ntl-app.c (display_prototype_caveat): Changed to simply use
      	a gnome_warning_dialog instead of a nautilus_simple_dialog. We
      	loose the word wrapping though. But now the main window loads
      	while the warning is present, plus it's a real GNOME warning box,
      	so be afraid...
      8d1a3bb7
    • Darin Adler's avatar
      Implemented Reload for directory views. · 503b5255
      Darin Adler authored
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(nautilus_directory_monitor_add_internal),
      	(dequeue_pending_idle_callback), (cancel_directory_load),
      	(directory_load_done),
      	(nautilus_directory_monitor_remove_internal),
      	(nautilus_directory_call_when_ready_internal),
      	(mark_all_files_unconfirmed), (start_monitoring_file_list),
      	(nautilus_directory_stop_monitoring_file_list),
      	(nautilus_directory_force_reload):
      	* libnautilus-extensions/nautilus-directory.c:
      	(call_files_changed_unref_free_list),
      	(nautilus_directory_notify_files_removed),
      	(nautilus_directory_notify_files_moved),
      	(nautilus_directory_file_monitor_add):
      	* libnautilus-extensions/nautilus-file-private.h:
      	* libnautilus-extensions/nautilus-file.c: (nautilus_file_get),
      	(destroy), (nautilus_file_monitor_remove), (nautilus_file_delete),
      	(nautilus_file_mark_gone), (nautilus_file_changed),
      	(nautilus_file_emit_changed):
      	Added the necessary tweaks to the async. I/O so we can handle
      	a reload, not just the initial load.
      
      	* libnautilus-extensions/nautilus-icon-container.h:
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_add): Changed API so it will detect if
      	you try to add the same item twice and indicate it with a return
      	value; needed so we can handle reload.
      
      	* libnautilus-extensions/nautilus-list.c: (set_single_click_mode),
      	(update_single_click_mode_from_preferences),
      	(nautilus_list_initialize), (click_policy_changed_callback):
      	Fixed bug where a change in single click mode would chang the
      	appearance of the names in the list, but not cause a redraw when
      	the setting was changed.
      
      	* libnautilus/nautilus-undoable.c:
      	(undo_atom_destroy_callback_data), (undo_atom_destroy),
      	(undo_atom_destroy_callback_data_g_func_cover),
      	(nautilus_undo_register_full):
      	Fixed a bug where it would try to destroy the undo atom even when
      	it didn't own it.
      
      	* libnautilus/nautilus-undoable.h:
      	Got rid of some cruft I left in here by accident.
      
      	* src/file-manager/fm-icon-view.c: (fm_icon_view_add_file):
      	* src/file-manager/fm-list-view.c: (fm_list_view_add_file):
      	Only add the files if they are not already in the list. This is
      	needed for reload.
      
      	* src/ntl-main.c: (main): Tweaked this function to be easier to
      	understand and better organized. Also added a "desktop" option
      	as a start for my next task.
      503b5255
  3. 22 May, 2000 2 commits
  4. 20 May, 2000 2 commits
    • Ettore Perazzoli's avatar
      154367ab
    • Maciej Stachowiak's avatar
      Fix bugzilla tasks #599 (hex number is bad default for meta view · cf21c9ee
      Maciej Stachowiak authored
      	names) and #631 (nead oaf query to determine metaviews).
      
      	* libnautilus-extensions/nautilus-view-identifier.h,
      	libnautilus-extensions/nautilus-view-identifier.c:
      	(nautilus_view_identifier_new, get_lang_list,
      	nautilus_view_identifier_new_from_oaf_server_info,
      	nautilus_view_identifier_free): Moved NautilusViewIdentifier code
      	here from ntl-uri-map.[ch].
      	(nautilus_view_identifier_new_from_content_view),
      	(nautilus_view_identifier_new_from_sidebar_panel),
      	(nautilus_view_identifier_free_callback),
      	(nautilus_view_identifier_free_list): New functions.
      	* libnautilus-extensions/Makefile.am: Add
      	nautilus-view-identifier.[ch] to build.
      	* src/ntl-types.h: Removed typedef for NautilusViewIdentifier.
      
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	* libnautilus-extensions/nautilus-glib-extensions.c
      	(nautilus_g_list_free_deep_custom): New function, like
      	`nautilus_g_list_free_deep' but lets you pass your own free
      	function.
      	(nautilus_g_list_free_deep): Use `nautilus_g_list_free_deep_custom'
      	(nautilus_g_list_partition): New function to destructively
      	partition a GList into two, depending on whether they satisfy the
      	provided predicate or not.
      	(nautilus_test_predicate), (nautilus_self_check_glib_extensions):
      	Added unit tests for `nautilus_g_list_partition' and for
      	`nautilus_g_list_equal' since the `nautilus_g_list_partition'
      	tests rely on it.
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_notify_files_moved): Use
      	`nautilus_g_list_free_deep_custom'.
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c
      	(nautilus_gdk_pixbuf_list_free): Likewise.
      	* libnautilus-extensions/nautilus-icon-factory.c
      	(nautilus_scalable_icon_list_free): Likewise.
      	* libnautilus-extensions/nautilus-string-list.c
      	(nautilus_string_list_clear): Likewise.
      	* nautilus-widgets/nautilus-preferences.c (pref_hash_node_free,
      	prefs_hash_lookup_with_implicit_registration): Likewise.
      
      	* libnautilus-extensions/nautilus-global-preferences.c,
      	libnautilus-extensions/nautilus-global-preferences.h
      	(global_preferences_create_dialog,
      	nautilus_global_preferences_get_sidebar_panel_view_identifiers,
      	nautilus_global_preferences_get_meta_view_iids,
      	nautilus_preferences_register_meta_view_preferences_for_ui,
      	global_preferences_register_for_ui): Change things around to
      	determine the set of sidebar panel prefs at run time, and to pass
      	around NautilusViewIdentifiers rather than just iid strings so we
      	can use the statically defined name in the oafinfo.
      
      	* src/ntl-uri-map.h, src/ntl-uri-map.c: (set_initial_content_iid,
      	got_file_info_callback, sidebar_panel_preference_is_on,
      	(add_sidebar_panel_identifiers, nautilus_navigation_info_free):
      	Changed things around to better handle sidebar panel (AKA meta
      	view) selection, and pass around both name and iid.
      
      	* src/ntl-window-msgs.c:
      	(nautilus_window_request_selection_change,
      	nautilus_window_has_really_changed,
      	nautilus_window_load_meta_view, nautilus_window_update_state,
      	nautilus_window_set_state_info): Fixed everything to pass around
      	ViewIdentifiers instead of iids for sidebar panels and set the
      	label approrpiately when activating; replaced a whole bunch of
      	GSList usage with GList (we can always optimize this stuff later).
      	* src/ntl-window.h, src/ntl-window.c: (nautilus_window_destroy,
      	nautilus_window_load_content_view_menu,
      	nautilus_window_set_content_view, nautilus_window_add_meta_view,
      	nautilus_window_remove_meta_view_real,
      	nautilus_window_remove_meta_view): Deal with the above changes
      	(mostly GSList -> GList changes).
      
      	* src/ntl-view-bonobo-control.c, src/ntl-view-bonobo-subdoc.c,
      	src/ntl-view-nautilus.c, src/ntl-view-private.h: Remove all
      	get_label related calls since we get that from the oafinfo now.
      	* libnautilus/nautilus-meta-view-frame.h,
      	libnautilus/nautilus-meta-view-frame.c:
      	(nautilus_meta_view_frame_initialize,
      	nautilus_meta_view_frame_new_from_bonobo_control,
      	nautilus_meta_view_frame_destroy): Remove
      	`nautilus_meta_view_frame_set_label' machinery and associated
      	machinery since we now get the label statically from the oafinfo.
      	* components/history/ntl-history-view.c: (make_obj): Don't call
      	`nautilus_meta_view_frame_set_label' any more, the label is now
      	statically determined from the oafinfo file.
      	* components/notes/ntl-notes.c: (make_notes_view): Likewise.
      	* components/websearch/ntl-web-search.c: (make_obj): Likewise.
      	* components/help/hyperbola-nav-index.c: Likewise.
      	(hyperbola_navigation_index_new): Likewise.
      	* components/help/hyperbola-nav-search.c: Likewise.
      	(hyperbola_navigation_search_new): Likewise.
      	* components/help/hyperbola-nav-tree.c: Likewise.
      	(hyperbola_navigation_tree_new): Likewise.
      	* src/ntl-meta-view.h, src/ntl-meta-view.c:
      	(nautilus_meta_view_set_label),
      	(nautilus_meta_view_get_label): Have an explicit value to set,
      	rather than trying to get it through CORBA. This is kind of a
      	hack, really we should pass around a label and a NautilusMetaView
      	separately and remove this stuff.
      	* components/help/hyperbola.oafinfo,
      	components/notes/ntl-notes.oafinfo,
      	components/websearch/ntl-web-search.oafinfo,
      	components/history/ntl-history-view.oafinfo: Updated to include
      	latest Nautilus attributes.
      cf21c9ee
  5. 19 May, 2000 2 commits
    • Darin Adler's avatar
      File name changes. · f3df1c2b
      Darin Adler authored
      	* components/services/trilobite/sample/command-line/.cvsignore:
      	* components/services/trilobite/sample/service/.cvsignore:
      	File name changes.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_file_monitor_add),
      	(nautilus_self_check_directory):
      	* libnautilus-extensions/nautilus-directory.h:
      	* src/file-manager/fm-directory-view.c: (finish_loading_uri):
      	Added reload interface.
      
      	* libnautilus/nautilus-undoable.c: (nautilus_undo_register),
      	(undo_atom_destroy), (undo_atom_destroy_notify_cover),
      	(undo_atom_destroy_g_func_cover), (save_callback),
      	(restore_callback), (nautilus_undo_register_full),
      	(nautilus_undo_unregister), (nautilus_undo):
      	* libnautilus/nautilus-undoable.h:
      	Implemented new simplified Undo API.
      
      	* libnautilus-extensions/nautilus-entry.c:
      	(nautilus_entry_initialize), (nautilus_entry_destroy),
      	(nautilus_entry_key_press), (nautilus_entry_changed),
      	(register_edit_undo), (update_undo_text),
      	(restore_from_undo_snapshot_callback),
      	(nautilus_entry_enable_undo):
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(hide_rename_widget):
      	* libnautilus-extensions/nautilus-icon-text-item.c: (iti_event),
      	(register_rename_undo), (restore_from_undo_snapshot_callback):
      	* src/nautilus-bookmarks-window.c: (on_window_delete_event):
      	* src/nautilus-location-bar.c: (destroy):
      	Use new simplified Undo API.
      
      	* libnautilus/nautilus-undo-manager.h:
      	Remove UNDO_MANAGER_NAME, which is no longer used.
      
      	* src/file-manager/fm-icon-view.c:
      	(icon_position_changed_callback): Fixed a bad g_free that was
      	cause seg faults when you resized an icon.
      f3df1c2b
    • John Sullivan's avatar
      Finished task 598 (Command button layout should account · 68aacef7
      John Sullivan authored
      	for window height)
      
      	* libnautilus-extensions/nautilus-keep-last-vertical-box.h,
      	* libnautilus-extensions/nautilus-keep-last-vertical-box.c:
      	New files, subclass of GtkVBox that truncates contents to
      	fit, except last item which is always kept. (GtkVBox in the
      	same situation just merrily places its child widgets outside
      	of its allocation.)
      	* libnautilus-extensions/Makefile.am: Build the new files.
      
      	* src/ntl-index-panel.c:
      	(make_button_box): Use NautilusKeepLastVerticalBox so only
      	as many command buttons appear as fit, and the "Open with ..."
      	button always appears; also embed this box in a GtkHBox to
      	get horizontal sizing the way we want it.
      	(add_command_buttons): Add (not yet active) "Open with ..."
      	button.
      	(nautilus_index_panel_update_buttons): Throw away the
      	GtkHBox containing the button box instead of the button
      	box itself.
      68aacef7
  6. 18 May, 2000 5 commits
    • Darin Adler's avatar
      Eskil showed me how to fix these so they'd work when orbit-idl was not in · c49ece8a
      Darin Adler authored
      	* libnautilus/Makefile.am:
      	* src/file-manager/Makefile.am:
      	Eskil showed me how to fix these so they'd work when orbit-idl
      	was not in the path at compile time.
      c49ece8a
    • Darin Adler's avatar
      Change format to make popt "pop" out more. · 7e7fc3ec
      Darin Adler authored
      	* HACKING: Change format to make popt "pop" out more.
      
      	* libnautilus-extensions/nautilus-entry.h:
      	* src/file-manager/fm-properties-window.c: (create_basic_page):
      	* src/nautilus-bookmarks-window.c: (on_text_field_focus_in_event),
      	(on_window_delete_event):
      	* src/nautilus-location-bar.c: (nautilus_location_bar_enable_undo):
      	* src/nautilus-location-bar.h:
      	* src/nautilus-window-menus.c: (edit_menu_undo_callback),
      	(bookmarks_menu_add_bookmark_callback),
      	(bookmarks_menu_edit_bookmarks_callback),
      	(get_or_create_bookmarks_window), (nautilus_bookmarks_exiting),
      	(edit_bookmarks), (nautilus_window_initialize_menus),
      	(update_undo_menu_item):
      	* src/ntl-app.c: (nautilus_app_init), (nautilus_app_destroy):
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_start_renaming_selected_item):
      	* libnautilus-extensions/nautilus-entry.c:
      	(nautilus_entry_key_press), (nautilus_entry_enable_undo):
      	* libnautilus/nautilus-undo-manager.c:
      	(nautilus_undo_manager_begin_transaction),
      	(nautilus_undo_manager_unregister_object),
      	(prune_undo_manager_list), (nautilus_get_undo_manager),
      	(nautilus_attach_undo_manager), (nautilus_share_undo_manager):
      	* libnautilus/nautilus-undo-manager.h:
      	* src/ntl-window-private.h:
      	* src/ntl-window.c: (nautilus_window_constructed),
      	(nautilus_window_real_set_content_view),
      	(nautilus_window_get_undo_manager):
      	* src/ntl-window.h:
      	Got rid of the undo manager parameter for the enable_undo
      	operation.
      	Eliminated code that sets up the undo manager except for the top
      	widgets. We only need it attached to windows and to the top widget
      	in each component.
      	Change callers to get the undo manager in a few simple ways
      	instead of calling gtk_object_get_data directly. Added some calls
      	to attach the undo manager to an arbitrary object.
      
      	* libnautilus/nautilus-undo.idl: Added comments to the IDL and
      	also added the Undo::Context class.
      
      	* libnautilus/nautilus-view-component.idl: Removed the dependency
      	on the undo IDL and the undo_manager attribute.
      
      	* src/nautilus-bookmarks-window.h:
      	* src/nautilus-bookmarks-window.c: (create_bookmarks_window):
      	Changed interface to take object to inherit the undo manager from
      	instead of the undo manager itself. Got rid of unnecesary undo
      	manager setting.
      	(nautilus_bookmarks_window_save_geometry): Also changed interface
      	to use GtkWindow instead of GtkWidget.
      7e7fc3ec
    • John Sullivan's avatar
      Added the ability to switch sort order in Icons view. Note · 0c9e0b5b
      John Sullivan authored
      	that one time while developing this I saw a problem at startup
      	where the icons all danced back and forth a few pixels forever.
      	I can't reproduce this, so I don't think my changes caused it,
      	but be wary of the evil jig-dancing icons.
      
      	* libnautilus-extensions/nautilus-metadata.h:
      	Added #define for icon view sort direction.
      
      	* src/file-manager/fm-icon-view.c:
      	Added sort_reversed to FMIconViewDetails;
      	(update_layout_menus): Set sensitivity of "Ascending"/"Descending"
      	menu items appropriately, and activate the right one.
      	(set_sort_reversed), (get_sort_reversed_from_menu_path),
      	(sort_direction_callback): New functions used for setting
      	the sort direction.
      	(fm_icon_view_begin_loading): Read sort direction from metadata.
      	(fm_icon_view_merge_menus): Add sort-direction menu items to
      	Layout menu.
      	(icon_container_compare_icons_callback): Take sort direction
      	into account.
      0c9e0b5b
    • Pavel Cisler's avatar
      Fixed 636 - don't allow copying into Trash. Also added checks for Trashing · 3af2e054
      Pavel Cisler authored
      2000-05-17  Pavel Cisler  <pavel@eazel.com>
      
      	* src/file-manager/dfos-xfer.c: (fs_xfer), (fs_move_to_trash):
      	Fixed 636 -  don't allow copying into Trash. Also added
      	checks for Trashing the Trash, moving or copying the Trash,
      	Trashing the parents of Trash, moving and copying folders in
      	their children.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_selection_items_local):
      	Fix 625: move uri_is_parent into a new call in GnomeVFS and
      	added more features that I needed for the above fix.
      3af2e054
    • John Sullivan's avatar
      A little widget-packing tweaking with the command buttons. It's not right · 90f52330
      John Sullivan authored
      	* src/ntl-index-panel.c: (make_button_box),
      	(nautilus_index_panel_initialize), (add_command_buttons):
      	A little widget-packing tweaking with the command buttons.
      	It's not right yet, but I want to check this in so I can
      	work on it later from home.
      90f52330
  7. 17 May, 2000 8 commits
    • Gene Z. Ragan's avatar
      CVS: · 19159e79
      Gene Z. Ragan authored
      2000-05-17  Gene Z. Ragan  <gzr@eazel.com>
      											      CVS: ----------------------------------------------------------------------
      	First phase of modifying undo code.  These changes				      CVS: Enter Log.  Lines beginning with `CVS:' are removed automatically
      	affect the way undo is handled internally to Nautilus and			      CVS:
      	also defines a new IDL.  This is work in progress.				      CVS: Committing in .
      											      CVS:
      	* libnautilus-extensions/nautilus-entry.c:					      CVS: Modified Files:
      	Modified to use gtk_object_get_data() mechanism to locate undo manager		      CVS:    ChangeLog libnautilus/.cvsignore libnautilus/Makefile.am
      											      CVS:    libnautilus/nautilus-undo-manager-private.h
      	* libnautilus-extensions/nautilus-icon-container.c:				      CVS:    libnautilus/nautilus-undo-manager.c
      	(nautilus_icon_container_start_renaming_selected_item): 			      CVS:    libnautilus/nautilus-undo-manager.h
      	Modified to use gtk_object_get_data() mechanism to locate undo manager		      CVS:    libnautilus/nautilus-undo-transaction.h
      											      CVS:    libnautilus/nautilus-undoable.c
      	* libnautilus-extensions/nautilus-icon-text-item.c: (iti_event),		      CVS:    libnautilus/nautilus-undoable.h
      	(restore_from_undo_snapshot_callback):						      CVS:    libnautilus/nautilus-view-component.idl
      	Modified to use gtk_object_get_data() mechanism to locate undo manager		      CVS:    libnautilus-extensions/nautilus-entry.c
      											      CVS:    libnautilus-extensions/nautilus-entry.h
      	* libnautilus/.cvsignore:							      CVS:    libnautilus-extensions/nautilus-icon-container.c
      	Added generated IDL source and header files to ignore				      CVS:    libnautilus-extensions/nautilus-icon-text-item.c
      											      CVS:    src/nautilus-bookmarks-window.c
      	* libnautilus/Makefile.am:							      CVS:    src/nautilus-bookmarks-window.h src/nautilus-location-bar.c
      	Modified makefile to include new IDL file for undo manager			      CVS:    src/nautilus-location-bar.h src/nautilus-window-menus.c
      											      CVS:    src/ntl-app.c src/ntl-window-private.h src/ntl-window.c
      	* libnautilus/nautilus-undo-manager.c:						      CVS:    src/ntl-window.h src/file-manager/fm-properties-window.c
      	(impl_Nautilus_Undo_Manager__destroy),						      CVS: Added Files:
      	(impl_Nautilus_Undo_Manager__create),						      CVS:    libnautilus/nautilus-undo.idl
      	(impl_Nautilus_Undo_Manager__append),						      CVS: Removed Files:
      	(impl_Nautilus_Undo_Manager__forget),						      CVS:    libnautilus/nautilus-undo-manager-component.idl
      	(nautilus_undo_manager_initialize),						      CVS: ----------------------------------------------------------------------
      	(nautilus_undo_manager_initialize_class),
      	(nautilus_undo_manager_begin_transaction),
      	(nautilus_undo_manager_end_transaction),
      	(nautilus_undo_manager_undo), (nautilus_undo_manager_redo),
      	(nautilus_undo_manager_add_transaction),
      	(nautilus_undo_manager_unregister_object),
      	(nautilus_undo_manager_can_undo), (nautilus_undo_manager_can_redo),
      	(get_current_transaction_name),
      	(nautilus_undo_manager_get_current_undo_transaction_name),
      	(nautilus_undo_manager_get_current_redo_transaction_name),
      	(destroy), (nautilus_undo_manager_enable_redo),
      	(nautilus_undo_manager_set_queue_depth),
      	(free_undo_manager_list_data), (prune_undo_manager_list):
      	Changes to support new IDL and new undo manager mechanism.
      
      	* libnautilus/nautilus-undo.idl:
      	New undo manager IDL file
      
      	* libnautilus/nautilus-undo-manager-component.idl:
      	Removed old undo manager IDL file
      
      	* src/file-manager/fm-properties-window.c:
      	(create_basic_page):
      	Modified to use gtk_object_get_data() mechanism to locate undo manager
      
      	* src/nautilus-bookmarks-window.c:
      	(create_bookmarks_window),
      	(on_text_field_focus_in_event),
      	(on_window_delete_event):
      	Modified to use gtk_object_get_data() mechanism to locate undo manager
      
      	* src/nautilus-location-bar.c:
      	(nautilus_location_bar_set_location),
      	(nautilus_location_bar_enable_undo):
      	Modified to use gtk_object_get_data() mechanism to locate undo manager
      
      	* src/nautilus-window-menus.c:
      	(edit_menu_undo_callback),
      	(edit_menu_cut_callback),
      	(bookmarks_menu_edit_bookmarks_callback),
      	(get_bookmarks_window),
      	(nautilus_bookmarks_exiting),
      	(nautilus_window_edit_bookmarks),
      	(nautilus_window_initialize_menus),
      	(update_undo_menu_item):
      	Modified to use gtk_object_get_data() mechanism to locate undo manager
      
      	* src/ntl-app.c:
      	(impl_Nautilus_Application__get_view_windows),
      	(impl_Nautilus_Application_new_view_window),
      	(impl_Nautilus_Application_supports),
      	(impl_Nautilus_Application_create_object),
      	(impl_Nautilus_Application__create), (nautilus_app_get_type),
      	(nautilus_app_class_init), (nautilus_app_init), (nautilus_app_new),
      	(nautilus_app_destroy), (nautilus_app_startup),
      	(nautilus_app_create_window):
      	Modified to use gtk_object_get_data() mechanism to locate undo manager.
      	Added and modified IDL C stubs to match new IDL interface.
      
      	* src/ntl-window.c:
      	(nautilus_window_constructed),
      	(nautilus_window_set_arg):
      	Changed order that arguments are set at time of main window create so the app instance
      	variable is valid when the main window is contructed.
      19159e79
    • John Sullivan's avatar
      Fixed bug 357 (Text not vertically centered when starting up in List · 6c77cdc3
      John Sullivan authored
      	* src/file-manager/fm-list-view.c: (create_list):
      	Fixed bug 357 (Text not vertically centered when starting
      	up in List View): Wait until after "map" signal before
      	setting row height, to work around bug/design flaw in
      	GtkCList.
      6c77cdc3
    • Darin Adler's avatar
      Added comments. · 170a7b49
      Darin Adler authored
      	* libnautilus-extensions/nautilus-icon-container.h:
      	Added comments.
      
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(scale_image_and_rectangle): Added a minimum height and width to
      	avoid problems with scaling things down to 0.
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_initialize_class), (insert_row):
      	* src/file-manager/fm-list-view.c: (add_to_list):
      	Moved GtkCList workaround into NautilusList so all clients can get
      	the advantage of it instead of just FMListView. Also eliminated
      	some unneeded empty functions for signals, since NULL works for an
      	empty signal handler.
      170a7b49
    • John Sullivan's avatar
      Started tweaking with the command buttons in the sidebar · 9608c884
      John Sullivan authored
      	as a step towards hooking them into the final MIME API.
      
      	* libnautilus-extensions/nautilus-mime-type.c:
      	Removed verbs from display names, since we don't plan
      	to support arbitrary verbs (i.e., alternate verbs to
      	"Open") at least for this release.
      
      	* src/ntl-index-panel.c: (add_command_buttons): Simplify code
      	a little by using gtk_button_new_with_label; use "Open with"
      	terminology; fix memory leak with command string stored in button.
      	(nautilus_index_panel_update_info): Deleted obsolete comment.
      
      	* src/ntl-window.c: (nautilus_window_load_content_view_menu):
      	Added (currently insensitive) "View as ..." item to menu.
      9608c884
    • Pavel Cisler's avatar
      Fix 834 - bad keyboard focus behavior. Added a workaround for GtkCList · ec5d168b
      Pavel Cisler authored
      2000-05-16  Pavel Cisler  <pavel@eazel.com>
      
      	* src/file-manager/fm-list-view.c: (add_to_list):
      	Fix 834 - bad keyboard focus behavior. Added a workaround for
      	GtkCList broken behavior that moved the focused item to a pretty much
      	random point when populating the list.
      ec5d168b
    • Pavel Cisler's avatar
      Fix a problem in my new typeselect code where it would only work properly · 9995e383
      Pavel Cisler authored
      2000-05-16  Pavel Cisler  <pavel@eazel.com>
      
      	* src/file-manager/fm-list-view.c: (make_sorted_row_array),
      	(select_row_common), (select_matching_name_callback),
      	(create_list):
      	Fix a problem in my new typeselect code where it would only
      	work properly if the list was sorted alphabetically to begin with.
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_key_press):
      	* src/file-manager/fm-list-view.c: (make_sorted_row_array),
      	(select_row_common), (select_matching_name_callback),
      	(select_previous_next_common), (select_previous_name_callback),
      	(select_next_name_callback), (create_list):
      	Added support for Tab and Shift-Tab selecting the alphabetically
      	next and previous files. Reorganized the code a bit to share more
      	with the typeselect calls.
      9995e383
    • John Sullivan's avatar
    • John Sullivan's avatar
      Some work getting the menu items for "Open With" in place, · abc4dfdc
      John Sullivan authored
      	and some related cleanup. "Open With" submenus now appear
      	in the File and context menus, but filled with bogus
      	insensitive items.
      
      	* src/file-manager/fm-directory-view.h:
      	Add #defines for bonobo-style menu paths for "Open With"-related
      	items.
      	* src/file-manager/fm-directory-view.c:
      	(compute_menu_item_info): Added new cases.
      	(append_gtk_menu_item_with_view): Renamed from
      	"append_selection_menu_item" because it's now used more
      	generally; checks for view != NULL before using view.
      	(append_gtk_menu_item): New function, calls _with_view
      	with some default values.
      	(append_selection_menu_subtree): New function.
      	(fm_directory_view_real_create_background_context_menu_items):
      	Uses append_gtk_menu_item now instead of duplicating some code/data.
      	(add_open_with_gtk_menu_item), (create_open_with_gtk_menu):
      	New functions, used to create the "Open With" submenu in
      	the context menu.
      	(fm_directory_view_real_create_selection_context_menu_items):
      	Adds "Open With" submenu to context menu.
      	(insert_bonobo_menu_subtree), (add_open_with_bonobo_menu_item),
      	(reset_bonobo_open_with_menu): New functions, used to create
      	the "Open With" submenu in the File menu in the menu bar.
      	(fm_directory_view_real_merge_menus): Adds "Open With" submenu
      	to File menu.
      	(fm_directory_view_real_update_menus): Updates the "Open With"
      	submenu to match selection.
      	(fm_directory_view_get_context_menu_index): Updated to match
      	current reality.
      abc4dfdc
  8. 16 May, 2000 4 commits
    • Darin Adler's avatar
      Quick cleanup pass on FIXMEs. · 6281f2ee
      Darin Adler authored
      	* check-FIXME.pl: Added the count of FIXMEs with bug numbers
      	as well as the count of FIXMEs without.
      
      	* components/services/trilobite/lib/helixcode-utils.c:
      	(xml_get_value), (prune_xml), (check_for_root_user),
      	(check_for_redhat), (determine_redhat_version),
      	(determine_mandrake_version), (determine_turbolinux_version),
      	(determine_suse_version), (determine_debian_version),
      	(determine_distribution_type), (get_distribution_name):
      	A tiny bit of cleanup on these functions. There was some really
      	bad code in here, including code that compared strings with ==.
      	Also a lot of code that does open and then no close, for no
      	good reason, so I added the close.
      
      	* libnautilus-extensions/nautilus-file.c: (rename_callback),
      	(nautilus_file_get_mapped_uri):
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_update_icon):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(confirm_switch_to_manual_layout), (nautilus_icon_dnd_begin_drag):
      	* src/file-manager/fm-icon-view.c: (update_layout_menus),
      	(sort_callback), (manual_layout_callback):
      	* src/ntl-view.c: (nautilus_view_destroy_client):
      	Added bug numbers to some FIXMEs.
      6281f2ee
    • Darin Adler's avatar
      Moved metafile code into its own source file. Also worked on making it all · 42b69946
      Darin Adler authored
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(get_metadata_from_node), (get_metadata_list_from_node),
      	(create_metafile_root), (nautilus_directory_get_metadata),
      	(nautilus_directory_get_metadata_list),
      	(nautilus_directory_get_boolean_metadata),
      	(nautilus_directory_set_boolean_metadata),
      	(nautilus_directory_get_integer_metadata),
      	(nautilus_directory_set_integer_metadata),
      	(nautilus_directory_get_file_metadata_node),
      	(nautilus_directory_get_file_metadata),
      	(nautilus_directory_get_file_metadata_list), (real_set_metadata),
      	(real_set_metadata_list), (metadata_key_new),
      	(metadata_key_destroy), (metadata_key_hash),
      	(metadata_key_hash_equal), (metadata_value_new),
      	(metadata_value_new_list), (metadata_value_destroy),
      	(metadata_value_equal), (set_metadata_in_metafile),
      	(set_metadata_eat_parameters),
      	(free_metadata_changes_hash_table_entry),
      	(destroy_metadata_changes_hash_table),
      	(nautilus_directory_metafile_destroy),
      	(nautilus_directory_set_metadata),
      	(nautilus_directory_set_file_metadata),
      	(nautilus_directory_set_file_metadata_list):
      	* libnautilus-extensions/nautilus-directory-metafile.h:
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_destroy):
      	* libnautilus-extensions/nautilus-file.c:
      	Moved metafile code into its own source file. Also worked on making
      	it all bottleneck so we can store it before we read in a metafile.
      
      	* src/file-manager/fm-list-view.c: (select_matching_name_callback):
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	Added nautilus_boolean_bit for use in bit fields where gboolean
      	results in a signed bitfield.
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	(nautilus_g_list_copy), (nautilus_g_str_list_equal),
      	(nautilus_g_str_list_copy): Added functions for dealing with a
      	list of C strings. Also got rid of const GList *. For GList we
      	don't use const because the functions in <glib.h> don't.
      	(nautilus_g_ptr_array_new_from_list), (nautilus_g_ptr_array_sort),
      	(nautilus_g_ptr_array_search): Renamed the new functions and types
      	to more closely match the standard. For example, the types must
      	have a Nautilus prefix.
      
      	* src/ntl-window.h:
      	* libnautilus-extensions/nautilus-icon-private.h:
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(icon_set_selected), (rubberband_select):
      	Switched to use the nautilus_boolean_bit type.
      
      	* components/html/glibwww-callbacks.c:
      	Moved <config.h> include down to fix some warnings.
      42b69946
    • Pavel Cisler's avatar
      Added keyboard type-ahead selection to the list view. · d9c604f9
      Pavel Cisler authored
      2000-05-16  Pavel Cisler <pavel@eazel.com>
      
      	Added keyboard type-ahead selection to the list view.
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_initialize_class), (select_matching_name),
      	(select_next_name), (select_previous_name):
      	Add new signals to allow hooking in keyboard selection callbacks
      	from fm_list_view.
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_initialize), (nautilus_list_destroy),
      	(nautilus_list_button_press), (nautilus_list_flush_typeselect_state),
      	(nautilus_list_handle_typeahead), (nautilus_list_key_press):
      	Setup/flush the typeselect state properly.
      
      	* libnautilus-extensions/nautilus-list.c:
      	* libnautilus-extensions/nautilus-list.h:
      	(nautilus_list_keyboard_move_to), (nautilus_list_select_row):
      	Add a convenience call to allow selecting an indexed row from
      	fm_list_view.
      
      	* libnautilus-extensions/nautilus-file.c
      	* libnautilus-extensions/nautilus-file.h:
      	(nautilus_file_compare_name):
      	Added a compare function that compares a file's name with a given
      	pattern.
      
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	* libnautilus-extensions/nautilus-glib-extensions.c
      	(nautilus_g_ptr_array_copy_list), (nautilus_g_ptr_array_sort),
      	(nautilus_g_ptr_array_search):
      	Add utility calls to enhance GPtrArray.
      
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	(nautilus_get_system_time):
      	Added more comments.
      
      	* src/file-manager/fm-list-view.c:
      	(fm_list_view_initialize_class),
      	(compare_rows_by_name), (match_row_name),
      	(select_matching_name_callback), :
      	Connect to new NautilusList signals. Add calls for sorting and
      	searching a pointer array by NautilusFile name.
      
      	* src/file-manager/fm-list-view.c:
      	(create_list), (add_to_list):
      	Tweak some white space.
      d9c604f9
    • Andy Hertzfeld's avatar
      started work on cleaning up the music view, but it's still in an interim · 914ab07f
      Andy Hertzfeld authored
      
               started work on cleaning up the music view, but it's still in
      	 an interim state.  Moved routine from property browser to
      	 pixbuf extensions so I can use it in the music view
      914ab07f
  9. 15 May, 2000 2 commits
    • Darin Adler's avatar
      First cut at metadata cleanup in preparation for fixing bug · e259c55e
      Darin Adler authored
      	with setting metadata before the metafile is read.
      
      	* libnautilus-extensions/nautilus-directory.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(get_metadata_list_from_node),
      	(nautilus_directory_get_metadata_list),
      	(nautilus_directory_set_boolean_metadata),
      	(nautilus_directory_set_integer_metadata),
      	(nautilus_directory_get_file_metadata_node),
      	(nautilus_directory_get_file_metadata_list),
      	(nautilus_directory_set_file_metadata),
      	(nautilus_directory_set_file_metadata_list),
      	* libnautilus-extensions/nautilus-file.h:
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_get_metadata), (nautilus_file_get_metadata_list),
      	(nautilus_file_set_metadata), (nautilus_file_set_metadata_list),
      	(nautilus_file_get_keywords), (nautilus_file_set_keywords):
      	Unified code to deal with metadata lists and made both get and
      	set work the same way. Also got rid of the default value. For
      	lists, the default value is always NULL.
      
      	* components/notes/ntl-notes.c: (notes_load_metainfo):
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(nautilus_directory_monitor_add_internal),
      	(nautilus_directory_call_when_ready_internal):
      	* libnautilus-extensions/nautilus-directory-private.h:
      	* libnautilus-extensions/nautilus-directory.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_call_when_ready),
      	(nautilus_directory_file_monitor_add),
      	(nautilus_self_check_directory):
      	* libnautilus-extensions/nautilus-file.h:
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_monitor_add), (nautilus_file_call_when_ready):
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_load_uri), (finish_loading_uri):
      	* src/nautilus-index-title.c: (nautilus_index_title_set_uri):
      	* src/ntl-uri-map.c: (set_initial_content_iid),
      	(get_explicit_content_view_iids_from_metafile),
      	(nautilus_navigation_info_new):
      	Converted to use new API that specifies only that metadata is
      	needed, not which keys. Maciej and I agreed that it's no use
      	to specify which keys you are interested in when you can just
      	get it wrong and have everything work anyway. Also the old API
      	didn't work for metadata lists.
      
      	* components/services/trilobite/sample/command-line/.cvsignore:
      	Added generated files.
      
      	* libnautilus-extensions/nautilus-xml-extensions.c:
      	(nautilus_xml_get_property_for_children): Format tweak.
      
      	* src/file-manager/fm-directory-view.c:
      	(bonobo_menu_delete_callback), (bonobo_menu_duplicate_callback),
      	(bonobo_menu_open_properties_window_callback),
      	(display_selection_info), (notify_selection_change_callback),
      	(queue_pending_files), (append_uri_one),
      	(fm_directory_view_duplicate_selection),
      	(fm_directory_view_trash_selection): Formatting tweaks.
      e259c55e
    • Andy Hertzfeld's avatar
      made property browser respond to preference changes by setting up a · 744904b5
      Andy Hertzfeld authored
      
              made property browser respond to preference changes by setting up
      	a callback and updating the contents when it's invoked
      744904b5
  10. 14 May, 2000 1 commit
  11. 13 May, 2000 3 commits
    • Andy Hertzfeld's avatar
      fixed bug 620, when multiple files are selected, they all should be · c4363bd9
      Andy Hertzfeld authored
      
              fixed bug 620, when multiple files are selected, they all should be
      	activated when any are clicked.  Accomplished this by making the
      	activate signal take a list, and adding code to maintain the list, which
      	was a bit tricky to get double-clicks right.
      c4363bd9
    • Andy Hertzfeld's avatar
      fixed some breakage from changes that Darin must not have compiled · dd77489e
      Andy Hertzfeld authored
      
              fixed some breakage from changes that Darin must not have compiled
      dd77489e
    • Darin Adler's avatar
      Format FIXME comments the way check-FIXME.pl recognizes. · e8ce8594
      Darin Adler authored
      	* components/services/trilobite/src/trilobite-service.c:
      	Format FIXME comments the way check-FIXME.pl recognizes.
      
      	* libnautilus-extensions/nautilus-file.c: (rename_callback):
      	Added a bug number to a FIXME.
      
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_set_selection): Finished fixing bug 613.
      	I had marked it fixed but missed one FIXME.
      
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_initialize): Added a bug number
      	to a FIXME.
      	(make_properties_from_directory_path),
      	(make_properties_from_xml_node), (make_category_link):
      	Fixed storage leaks I noticed earlier today.
      
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_initialize), (fm_directory_view_destroy),
      	(notify_selection_change_callback), (display_pending_files),
      	(fm_directory_view_can_accept_item): Fixed bug 440 by removing
      	the hash table that Maciej added. Each NautilusFile is already
      	unique because of how the class works.
      
      	* src/file-manager/fm-list-view.c: (create_list): Got rid of
      	the FIXME now that Pavel fixed bug 315.
      e8ce8594
  12. 12 May, 2000 3 commits
    • Darin Adler's avatar
      Added the idl directory. · 57d3420b
      Darin Adler authored
      	* Makefile.am: Added the idl directory.
      
      	* libnautilus-extensions/nautilus-gnome-extensions.h:
      	* libnautilus-extensions/nautilus-gnome-extensions.c:
      	(nautilus_simple_dialog): Turned on line wrapping for the label
      	in the simple dialog.
      	(turn_on_line_wrap_flag), (show_ok_box), (nautilus_error_dialog),
      	(nautilus_error_dialog_parented): Made alternate versions of
      	gnome_error_dialog and gnome_error_dialog_parented that turn on
      	line wrapping for the message label.
      
      	* libnautilus-extensions/nautilus-icon-canvas-item.c:
      	(draw_or_measure_label_text): Made the list of characters to break
      	lines on localizable.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(confirm_switch_to_manual_layout): Took newlines out of messages
      	since the dialog now does line wrapping.
      
      	* src/file-manager/dfos-xfer.c: (handle_xfer_vfs_error),
      	(handle_xfer_overwrite): Took out some extraneous spaces. I could
      	have also removed the newlines since the functions call something
      	that does line wrapping, but I decided not to.
      
      	* src/file-manager/fm-properties-window.c:
      	(name_field_update_to_match_file): Fixed a double delete bug.
      	This may have been what Ali was running into when he was clicking
      	quickly on all the emblems in succession.
      
      	* src/nautilus-property-browser.c:
      	Did a cleanup pass on the entire file. Marked things localizable
      	and marked some bugs with FIXME among other things.
      
      	* src/ntl-window-msgs.c: (nautilus_window_update_state): Added
      	code to check for NULL so that we won't core dump when trying
      	to "go back" from the first failed view.
      	(nautilus_window_progress_indicate),
      	(nautilus_window_end_location_change_callback): Got rid of newlines
      	from messages and called the function that now does line wrapping.
      57d3420b
    • Darin Adler's avatar
      Get rid of obsolete requirement for "--without-bonobo" for the gtkhtml · 6886451c
      Darin Adler authored
      	* HACKING: Get rid of obsolete requirement for "--without-bonobo"
      	for the gtkhtml module. The internal modules list at Eazel was
      	updated but someone forgot to update HACKING, as usual.
      
      	* components/services/trilobite/sample/command-line/.cvsignore:
      	* components/services/trilobite/sample/nautilus-view/.cvsignore:
      	* components/services/trilobite/sample/nautilus-view/icons/.cvsignore:
      	* components/services/trilobite/sample/service/.cvsignore:
      	Lots of generated files that need to be ignored for CVS happiness.
      
      	* libnautilus-extensions/nautilus-file.c: (rename_callback):
      	Fixed bug in handling error cases. I couldn't test this until Pavel
      	fixed the GNOME VFS bug that prevented any errors from being
      	reported, but he did and I am ready.
      
      	* libnautilus-extensions/nautilus-icon-canvas-item.c:
      	(draw_or_measure_label_text): Fixed a bug where you'd have a big
      	black box behind the text you are renaming by checking for rename
      	mode before drawing the black background.
      
      	* src/file-manager/fm-icon-view.c:
      	(set_sort_criterion), (get_sort_criterion_by_metadata_text),
      	(get_sort_criterion_by_menu_path), (fm_icon_view_begin_loading),
      	(sort_callback): Add code to save and load the "sort by" setting.
      6886451c
    • Eskil Heyn Olsen's avatar
      Fixed the CLEANFILES so the corba generated file and the dfos_corba_stamp · b95f4d32
      Eskil Heyn Olsen authored
      	* src/file-manager/Makefile.am (CLEANFILES): Fixed the CLEANFILES
      	so the corba generated file and the dfos_corba_stamp get's deleted
      	on make clean - thus build no longer breaks on missing files after
      	a few make all/clean iterations.
      b95f4d32