1. 27 Jan, 2001 1 commit
    • Andy Hertzfeld's avatar
      fixed bug 5750, accepting drops by folders quirky at zoom levels below · 3968d02a
      Andy Hertzfeld authored
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_item_at):
      	fixed bug 5750, accepting drops by folders quirky at zoom levels
      	below 100%. The problem was that nautilus_icon_container_item_at
      	was constructing a single pixel rectangle for hit-testing, that
      	sometimes turned into a zero pixel rectangle when scaled down,
      	depending on how things rounded off.  Fixed by using the
      	canvas scale factor when building the rectangle, ensuring that
      	it never becomes empty.
      3968d02a
  2. 26 Jan, 2001 11 commits
    • Rebecca Schulman's avatar
      Fix bugs 4094, 4425, 5201 and 4106 about inappopriate applications being · 5dfee0c3
      Rebecca Schulman authored
      2001-01-27  Rebecca Schulman  <rebecka@eazel.com>
      	Fix bugs 4094, 4425, 5201 and 4106 about inappopriate
      	applications being offered to view remote files.
      	This change filters applications that don't support
      	a uri scheme from a file's short list.
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	(nautilus_mime_actions_get_minimum_file_attributes),
      	(nautilus_mime_get_short_list_applications_for_file),
      	(application_supports_uri_scheme):
      	Filter out applications from the short list that do not
      	support the uri scheme for the file in question.
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application):
      	Change "can_open_uris" to "expects_uris" to go along with
      	the gnome vfs change
      	* test/test-nautilus-mime-actions.c: (append_comma_and_scheme),
      	(format_supported_uri_schemes_for_display), (print_application):
      	update the tests similarly to the way the gnome-vfs tests were
      	updated, so that all of the fields of the GnomeVFSMimeApplication
      	structure are correctly printed.
      
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	Correct spelling and naming error in a comment
      5dfee0c3
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 2717a5cd
      Darin Adler authored
      	Some preparation work for doing async. activation. This amounts
      	to another pass cleaning up the legendary "state machine" as well
      	as some other cleanups in the async. activation code.
      
      	* libnautilus-extensions/nautilus-bonobo-extensions.h:
      	* libnautilus-extensions/nautilus-bonobo-extensions.c:
      	(oaf_activation_callback), (nautilus_bonobo_activate_from_id),
      	(nautilus_bonobo_activate_cancel): Fix interface of activation to
      	be cleaner. Also handle case where callback is called right away.
      
      	Add queuing to NautilusView so that all incoming CORBA calls are
      	dispatched at idle time. This can fix some otherwise-difficult
      	re-entrancy problems. The widget destroy call can still come in at
      	any time though. Also this same fix may be needed for the
      	NautilusViewFrame side.
      
      	* libnautilus/nautilus-view.h:
      	* libnautilus/nautilus-view.c: (execute_queued_calls): Function
      	to dequeue and execute calls.
      	(dequeue_calls_at_idle): Cover to call it at idle time.
      	(discard_queued_calls): Discard calls without executing them, for
      	use at destroy time.
      	(queue_incoming_call): Simple cover to queue and schedule an
      	idle-time dequeue pass.
      	(nautilus_g_list_from_uri_list): Need to make a full copy, not
      	a shallow copy, now that we are queuing things for a hile.
      	(call_load_location), (call_stop_loading),
      	(call_selection_changed), (call_title_changed),
      	(call_history_changed): Simple functions that get queued.
      	(list_deep_free_cover): GDestroyNotify-compatible function for one
      	destroy case.
      	(history_dup): Function to copy the history list, since that is
      	now queued instead of used right away.
      	(impl_Nautilus_View_load_location),
      	(impl_Nautilus_View_stop_loading),
      	(impl_Nautilus_View_selection_changed),
      	(impl_Nautilus_View_title_changed),
      	(impl_Nautilus_View_history_changed): Change these all to queue
      	the incoming call instead of doing work right away.
      	(nautilus_view_destroy): Discard the queue.
      
      	* src/nautilus-view-frame-corba.c:
      	(impl_Nautilus_ViewFrame_open_location_force_new_window),
      	(impl_Nautilus_ViewFrame_report_selection_change): These calls now
      	use the deep copy, since the shallow one is no longer available.
      	This is good since we probably will be doing queuing here later,
      	so we'll need the deep copy.
      
      	* src/nautilus-view-frame.h:
      	* src/nautilus-view-frame.c:
      	(nautilus_view_frame_initialize_class): Set up a map default signal
      	handler to activate the control. This is better than the old way,
      	where we had an explicit call to do it.
      	(nautilus_view_frame_destroy_client): Remove unused
      	CORBA_Environment.
      	(view_frame_activated): Remove unneeded ACTIVATING state. Also
      	send the client_loaded signal in here, so you can't "forget".
      	(view_frame_wait), (view_frame_underway),
      	(view_frame_wait_is_over), (view_frame_loaded),
      	(view_frame_failed): Remove unneeded ACTIVATING state.
      	(check_if_view_is_gone): Simplify logic and make sure to check the
      	value of the exception and not just the function result.
      	(attach_client): Fix CORBA_Exception that was allocated twice and
      	that could also be allocated and not freed in some cases.
      	(activation_callback), (nautilus_view_frame_load_client_async):
      	Better names, use new API, still not tested.
      	(nautilus_view_frame_load_client): Get rid of function result and
      	use unified interface for telling about success and failure so that
      	sync. and async. interfaces will be the same.
      	(nautilus_view_frame_stop): Renamed this single function, which
      	will soon stop either activation that's in process or loading
      	that's in process with a single call. For now it's just the same
      	as the old stop_loading call.
      	(nautilus_view_frame_map): New override to activate the control.
      	This replaces the old explicit activate call.
      	(send_history), (nautilus_view_frame_get_is_underway): Remove
      	unneeded ACTIVATING state.
      
      	* src/nautilus-window.h:
      	* src/nautilus-window-manage-views.c:
      	(location_has_really_changed): Assume that new_content_view is not
      	NULL. The old code was trying to be inappropriately "general".
      	(disconnect_destroy_unref_view): Remove now-unused function.
      	(load_content_view): Don't use a return value any more, since it's
      	important to set up new_content_view before any signals happen.
      	Get rid of code that handles failure right at the start, since
      	we now get all failures through the signal handler.
      	(handle_view_failure): Add FIXME comments. Minor refactoring.
      	(cancel_location_change): Eliminated now-uneeded views_shown and
      	view_bombed_out booleans.
      	(load_view_for_new_location): New load_content_view doesn't return
      	a value any more.
      	(update_state): Changed this to be a loop instead of returning a
      	boolean and always being called in a loop. Also simplified logic
      	so that views_shown and view_bombed_out aren't needed any more.
      	(nautilus_window_end_location_change_callback): Use update_state
      	directly instead of calling the old clunky change_state cover.
      	(nautilus_window_begin_location_change): Use update_state directly
      	instead of calling the old clunky change_state cover.
      	(stop_loading): Call the new simple nautilus_view_frame_stop
      	instead of nautilus_view_frame_stop_loading.
      	(natuilus_window_stop_loading): Use update_state directly instead
      	of calling the old clunky change_state cover.
      	(nautilus_window_set_content_view): Use update_state directly instead
      	of calling the old clunky change_state cover.
      	(nautilus_window_set_sidebar_panels): Handle failures with
      	callback instead of looking at return value (which no longer
      	exists).
      	(client_loaded_callback): Add this new callback that's done when
      	the view is activated and ready to go.
      	(failed_callback): Use update_state directly instead of calling
      	the old clunky change_state cover.
      	(load_underway_callback): Use update_state directly instead of
      	calling the old clunky change_state cover.
      	(load_complete_callback): Use update_state directly instead of
      	calling the old clunky change_state cover.
      
      	* src/nautilus-window.c:
      	(nautilus_window_set_content_view_widget): Get rid of explicit
      	activation, no longer needed now that NautilusViewFrame handles it
      	directly.
      
      	* test/test-nautilus-async-activation.c: (activation_callback),
      	(main): Change to use new async. API.
      
      	* user-guide/gnufdl/.cvsignore: Add to ignore some missing files.
      2717a5cd
    • Pavel Cisler's avatar
      reviewed by: Michael Engber <engber@eazel.com> · 7379412e
      Pavel Cisler authored
      2001-01-25  Pavel Cisler  <pavel@eazel.com>
      
      	reviewed by: Michael Engber  <engber@eazel.com>
      
      	Fix 5879 (Close copy source & destination windows -> crash at
      		  end of copy operation).
      
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(nautilus_directory_remove_file_metadata):
      	Merge a fix from PR3 branch.
      
      	* libnautilus-extensions/nautilus-gtk-extensions.c:
      	(null_the_reference), (nautilus_gtk_null_reference_if_destroyed),
      	(nautilus_gtk_stop_null_reference_if_destroyed):
      	* libnautilus-extensions/nautilus-gtk-extensions.h:
      	Add new magic calls that set up a reference to get nulled out
      	when the object it points to is destroyed.
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(transfer_info_new), (transfer_info_destroy),
      	(handle_transfer_ok), (nautilus_file_operations_copy_move),
      	(nautilus_file_operations_move_to_trash),
      	(nautilus_file_operations_delete), (do_empty_trash):
      	Null out a saved reference to the parent window so
      	that we don't try to use it after the window gets closed.
      	Clean up creation and destruction of TransferInfo.
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(handle_transfer_ok):
      	Fix a case where TransferInfo could get leaked.
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(new_folder_transfer_callback),
      	(nautilus_file_operations_new_folder):
      	Rework to make deleting of NewFolderTransferState cleaner.
      	Set up parent_view to get nulled out when the view gets closed.
      
      	* libnautilus-extensions/nautilus-preferences-dialog.c:
      	(dialog_clicked), (dialog_show), (dialog_destroy),
      	Tweaks. Get rid of unneeded casts.
      
      	* src/nautilus-property-browser.c: (add_new_pattern),
      	(show_color_selection_window), (add_new_color), (add_new_emblem):
      	* src/nautilus-theme-selector.c: (add_new_theme_button_callback):
      	* src/nautilus-view-frame-corba.c:
      	(impl_Nautilus_ViewFrame__destroy),
      	(impl_Nautilus_ViewFrame__create):
      	Use new magic calls to null out references.
      
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_destroy):
      	Disconnect from the destroy-watching signal.
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(set_pending_icon_to_reveal):
      	(nautilus_preferences_dialog_construct):
      	* src/file-manager/fm-directory-view.c: (copy_move_done_data_free),
      	(pre_copy_move), (copy_move_done_partition_func),
      	(copy_move_done_callback):
      	Use new magic calls to null out references.
      	Fix a memory trasher where CopyMoveDoneData was being destroyed too
      	early.
      7379412e
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · b980d2bf
      Gene Z. Ragan authored
      2001-01-25  Gene Z. Ragan  <gzr@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	Fixed bug 6002, programs run from Nautilus Link files leave zombie processes
      
      	* libnautilus-extensions/nautilus-gnome-extensions.c:
      	* libnautilus-extensions/nautilus-gnome-extensions.h:
      	(nautilus_gnome_shell_execute):
      	Rename function and make it available to outside callers
      
      	(nautilus_gnome_open_terminal):
      	Rename function calls to nautilus_gnome_shell_execute
      
      	* src/file-manager/fm-directory-view.c: (activate_callback):
      	Call nautilus_gnome_shell_execute instaed of calling forking
      	and calling exec.  Using nautilus_gnome_shell_execute does the
      	right thing and avoids creating zombie processes.
      b980d2bf
    • John Harper's avatar
      doh! forgot to remove an unused variable.. · dcc3f043
      John Harper authored
      dcc3f043
    • John Harper's avatar
      Fix bug 5590 (List view uses anti-aliased graphics always) · 7544f777
      John Harper authored
      2001-01-25  John Harper  <jsh@eazel.com>
      
      	Fix bug 5590 (List view uses anti-aliased graphics always)
      
      	* src/file-manager/fm-list-view.c
      	(fm_list_view_update_smooth_graphics_mode): new function, put
      	into the FMDirectoryView method table, and called by
      	set_up_list ()
      
      	* libnautilus-extensions/nautilus-list.c (NautilusListDetails):
      	added an `anti_aliased_mode' boolean field
      
      	(draw_cell_pixbuf): support both normal and anti-aliased
      	drawing styles
      
      	* libnautilus-extensions/nautilus-list.[ch]
      	(nautilus_list_set_anti_aliased_mode): new function
      
      	* libnautilus-extensions/nautilus-list.c
      	(nautilus_list_set_single_click_mode): call
      	gtk_widget_queue_draw () on the list widget. Fixes the
      	(unfiled?) bug where toggling the `Activate items with a foo
      	click' doesn't immediately change how the list view is drawn
      7544f777
    • Mike Engber's avatar
      reviewed by: John Harper · a1b67bf8
      Mike Engber authored
      
      	reviewed by: John Harper
      
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(initialize_background_from_settings),
      	(saved_settings_changed_callback),
      	(nautilus_connect_background_to_file_metadata):
      	Fixed trying to set the background on a window before it was realized.
      a1b67bf8
    • Michael Fleming's avatar
      reviewed by: <sullivan@eazel.com> · 27ee242c
      Michael Fleming authored
       	Bug 6032: summary view was crashing because widget was being
       	destroyed during finish_button_activation.
      
       	Added a ref to the button across the timer callback and
       	avoided calling gtk_button_clicked and gtk_button_released
       	if the widget is already destroyed.
      
       	* libnautilus-extensions/nautilus-gtk-extensions.c:
       	(finish_button_activation), (nautilus_gtk_button_auto_click):
      27ee242c
    • John Harper's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 831b2c68
      John Harper authored
      2001-01-25  John Harper  <jsh@eazel.com>
      
      	reviewed by: Darin Adler <darin@eazel.com>
      
      	Fix bug 5561 (Add a function to nautilus to iterate through
      	windows in stacking order):
      
      	* libnautilus-extensions/nautilus-gtk-extensions.c,
      	libnautilus-extensions/nautilus-gtk-extensions.h
      	(nautilus_get_window_list_ordered_front_to_back): new function,
      	returns a list of all top-level windows in stacking order (from
      	top to bottom)
      
      	Fixed parts of bug 5553 (Enlightenment-related problems)
      
      	* src/nautilus-desktop-window.c
      	(nautilus_desktop_window_delete_event): connected to
      	`delete_event' signal of the desktop window. Unconditionally
      	returns TRUE. This stops GTK+ deleting the window in response
      	to WM_DELETE_WINDOW requests, and thus fixes the bug where it's
      	possible to delete the desktop window in Enlightenment
      
      	* src/nautilus-desktop-window.c (realize): added SKIP_FOCUS to
      	the _WIN_HINTS we set (even though, ages ago, I told Gene not
      	to. Otherwise Enlightenment includes the desktop window in its
      	M-TAB list)
      831b2c68
    • Mike Engber's avatar
      reviewed by: John Harper · 159c3eef
      Mike Engber authored
      
      	reviewed by: John Harper
      
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(saved_settings_changed_callback), (background_reset_callback):
      	The root & desktop pixmaps are now updated in response to changes
      	in the gnome_config settings - bug 6033.
      159c3eef
    • Mike Engber's avatar
      reviewed by: John Harper · 6801f7c9
      Mike Engber authored
      
      	reviewed by: John Harper
      
      	* libnautilus-extensions/nautilus-background.c:
      	(nautilus_background_draw_pixbuf_free), (nautilus_background_draw):
      	Background are now always drawn with the aa code, ensuring
      	their gradients are never striated - bug 5584.
      6801f7c9
  3. 25 Jan, 2001 4 commits
    • John Sullivan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 06f8cb1a
      John Sullivan authored
      	Fixed bug 5506 (Show Properties always shows full path,
      	making window ludicrously wide)
      
      	Also made some other contents of the properties
      	window handle window-stretching more attractively.
      
      	* libnautilus-extensions/nautilus-ellipsizing-label.h:
      	* libnautilus-extensions/nautilus-ellipsizing-label.c:
      	(nautilus_ellipsizing_label_initialize_class),
      	(nautilus_ellipsizing_label_initialize), (real_destroy),
      	(nautilus_ellipsizing_label_new), (recompute_ellipsized_text),
      	(nautilus_ellipsizing_label_set_text), (real_size_request),
      	(real_size_allocate), (real_style_set): New files. This is
      	a subclass of GtkLabel that requests no specific width, and
      	ellipsizes the text to fit whatever width it is given.
      
      	* libnautilus-extensions/Makefile.am: Add new files to build.
      
      	* src/file-manager/fm-properties-window.c:
      	(value_field_update_internal): New function, contains code
      	formerly in value_field_update but takes boolean to handle
      	ellipsized case.
      	(value_field_update): Now just a simple wrapper for
      	value_field_update_internal for the non-ellipsized case.
      	(ellipsizing_value_field_update): New function, simple wrapper
      	for value_field_update_internal for the ellipsized case.
      	(attach_label): added an ellipsize_text boolean to this
      	bottleneck function.
      	(attach_value_label), (attach_title_field): pass FALSE for
      	ellipsize_text to attach_label
      	(attach_ellipsizing_value_label): new function, pass TRUE for
      	ellipsize_text to attach_label
      	(attach_value_field_internal): New function, contains code
      	formerly in attach_value_field but takes boolean to handle
      	ellipsized case.
      	(attach_value_field): Now just a simple wrapper for
      	attach_value_field_internal for the non-ellipsized case.
      	(attach_ellipsizing_value_field): New function, simple wrapper for
      	attach_value_field_internal for the ellipsized case.
      	(attach_option_menu): Don't use GTK_EXPAND, so option menu gets no
      	wider than it needs to be.
      	(append_separator): Don't use GTK_EXPAND, so the presence of
      	separators doesn't cause table columns to stretch.
      	(append_title_and_ellipsizing_value): New function, like
      	append_title_value_pair but uses ellipsizing label.
      	(create_basic_page): Change gtk_table_attach options for icon
      	and name field so that they don't cause table columns
      	to stretch.
      06f8cb1a
    • Arik Devens's avatar
    • Andy Hertzfeld's avatar
      fixed bug 5817, removing the extension from images makes their thumbnails · 7856bf73
      Andy Hertzfeld authored
      
      	* libnautilus-extensions/nautilus-thumbnails.c:
      	(make_thumbnail_path):
      	fixed bug 5817, removing the extension from images makes their
      	thumbnails show up.  Fixed by correcting where it tests for the
      	presence of an extension in make_thumbnail_path by only looking
      	for periods in the leaf part of the path instead of in the
      	entire path.
      7856bf73
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · bf3ddeda
      Gene Z. Ragan authored
      2001-01-24  Gene Z. Ragan  <gzr@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	Fixed bug 5710, Images no longer snap to size after hitting Refresh
      
      	* components/image-viewer/nautilus-image-view.c: (redraw_control),
      	(load_image_from_stream), (scrolled_window_size_allocate_callback):
      	Restore the previous zoom setting when reloading a file from a stream.
      
      	Fixed a logic flaw dealing with renaming NautilusLinks.  The icon view
      	had duplicated some logic that was present in NautilusFile.  There were
      	slight differences in the logic that lead to some confusion in determing
      	if a link could be renamed.
      
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_can_rename):
      	* src/file-manager/fm-icon-view.c: (fm_icon_view_update_menus):
      bf3ddeda
  4. 24 Jan, 2001 5 commits
    • Darin Adler's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 921b14a9
      Darin Adler authored
      	Fix bug 5797 (Critical received when double-clicking on throbber):
      
      	* src/nautilus-window-private.h:
      	* src/nautilus-window.c: (location_change_at_idle_callback):
      	Callback to do actual location change at idle time instead of
      	right inside the property bag callback from the throbber.
      	(throbber_location_change_request_callback): Use the new idle
      	approach instead of changing the location right away.
      	(nautilus_window_destroy): Cancel the idle if it's still
      	outstanding.
      
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_get_string_attribute_with_default): Mark a string
      	for translation.
      	(get_description): Mark some warning strings for translation since
      	they are warnings we think real users might see.
      
      	* applets/launcher/.cvsignore:
      	* applets/preferences-applet/.cvsignore:
      	Ignore some files.
      921b14a9
    • Andy Hertzfeld's avatar
      fixed bug 5972, remove theme button uses aa text, by using a gtk_label · 711a6951
      Andy Hertzfeld authored
      
      	* src/nautilus-theme-selector.c:
      	(nautilus_theme_selector_initialize), (remove_button_callback),
      	(exit_remove_mode):
      	fixed bug 5972, remove theme button uses aa text, by using
      	a gtk_label instead of a nautilus_label.  Also, hide the
      	add button during remove mode so it's less confusing.
      
      	* libnautilus-extensions/nautilus-theme.c:
      	(nautilus_theme_make_selector):
      	fixed a crash when an installed theme lacked a preview icon,
      	cleaned up code and fixed a memory leak.
      711a6951
    • Andy Hertzfeld's avatar
      fixed bug 5908, assert hit when background pattern is deleted, by testing · 4d41b0bb
      Andy Hertzfeld authored
      
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(theme_image_path_to_uri):
      	fixed bug 5908, assert hit when background pattern is deleted, by
      	testing explicitly for the file missing and returning NULL in that
      	case instead of asserting.
      4d41b0bb
    • John Sullivan's avatar
      Fixed bug 2153 (deep count calculation in properties window · aeb4b32c
      John Sullivan authored
      	could be faster)
      
      	Fixed bug 5687 (Sidebar flickers and CPU thrashes during
      	deep count calculation in properties window)
      
      	Changed the deep count calculation to send a specialized
      	signal when the in-progress count updates, instead of using
      	"file_changed", since many parts of the UI react to file_changed
      	by doing (in this case unnecessary) work. My stopwatch measurement
      	on a large directory showed that the time to calculate 20000
      	contained files went from 147 seconds to 8 seconds, and the CPU
      	usage pegged around 15% (formerly 100%).
      
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(deep_count_callback): Call nautilus_file_changed only when
      	count is finished; call nautilus_file_updated_deep_count_in_progress
      	after every new higher value is computed.
      
      	* libnautilus-extensions/nautilus-file-private.h:
      	Added prototype for nautilus_file_updated_deep_count_in_progress.
      
      	* libnautilus-extensions/nautilus-file.h:
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_initialize_class): define "updated_deep_count_in_progres"
      	signal.
      	(nautilus_file_updated_deep_count_in_progress): send this new signal
      	for this file (which must be a directory) and any links pointing to
      	it.
      
      	* src/file-manager/fm-properties-window.c:
      	(attach_directory_contents_value_field): Make text field in properties
      	window react to new signal instead of "changed".
      aeb4b32c
    • John Sullivan's avatar
      Fixed bug 5959 (File name in "no applications available" · c562c9ca
      John Sullivan authored
      	dialog should be in quotes)
      
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_show_no_choices_message):
      	Put quotes around file name in dialog.
      c562c9ca
  5. 23 Jan, 2001 5 commits
    • Rebecca Schulman's avatar
      Fixed "make check." Oh, the woes. Earlier I removed a field from a struct · 957bc539
      Rebecca Schulman authored
      2001-01-22  Rebecca Schulman  <rebecka@eazel.com>
      
      	* libnautilus-extensions/nautilus-search-uri.c:
      	(nautilus_self_check_search_uri):
      	Fixed "make check."  Oh, the woes.
      	Earlier I removed a field from a struct in
      	nautilus-search-uri and broke binary compatibility
      	between the many mysterious structs here.  It seems
      	they all must be the same size.
      	Added a fixme so that we know this in the future,
      	hopefully.  Also added an additional test during
      	debugging.
      957bc539
    • Ramiro Estrugo's avatar
      Dumshit me, forgot to checkin the Makefile. · a0f4e534
      Ramiro Estrugo authored
      	* libnautilus-extensions/Makefile.am:
      	Dumshit me, forgot to checkin the Makefile.
      a0f4e534
    • Mike Engber's avatar
      reviewed by: Ramiro Estrugo · 0084f858
      Mike Engber authored
      
      	reviewed by: Ramiro Estrugo
      
      	* libnautilus-extensions/nautilus-directory-background.c:
      	(desktop_background_realized),
      	(nautilus_connect_desktop_background_to_file_metadata),
      	(image_loading_done_callback),
      	(nautilus_connect_background_to_file_metadata):
      	Desktop backgrounds were being drawn before they were initialized.
      	Bugs 5853 & 5896.
      0084f858
    • Rebecca Schulman's avatar
      Fix bug 5316, that search results code has empty strings marked for · 5baf833f
      Rebecca Schulman authored
      2001-01-22  Rebecca Schulman  <rebecka@eazel.com>
             Fix bug 5316, that search results code has
      	empty strings marked for translation.
      
      	* libnautilus-extensions/nautilus-search-uri.c: (parse_uri):
      	Remove "prefixes" for search criteria that were
      	always blank.
      5baf833f
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 13d57903
      Ramiro Estrugo authored
      	Fix bug 5831 - Clipping problems in summary view draing scrollable
      	labels.
      
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/nautilus-viewport.c:
      	(nautilus_viewport_initialize_class),
      	(nautilus_viewport_initialize), (nautilus_viewport_draw),
      	(nautilus_viewport_paint), (nautilus_viewport_new):
      	* libnautilus-extensions/nautilus-viewport.h:
      	New files.  A sublcass of GtkViewport that takes into account the
      	width and height of the widget style xthickness and ythickness
      	when painting.
      
      	* components/services/summary/nautilus-view/nautilus-summary-view.c
      	: (generate_summary_form):
      	Use NautilusViewport instead of GtkViewport to avoid clipping
      	problems when painting labels inside scrollable viewports.
      13d57903
  6. 22 Jan, 2001 4 commits
    • Ramiro Estrugo's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 47c6d18d
      Ramiro Estrugo authored
      	Fix 5613 - Icon captions in sidebar get cropped when toggling
      	"smooth graphics.
      
      	* libnautilus-extensions/nautilus-label.c:
      	(label_force_cached_requisition_flush),
      	(nautilus_label_set_is_smooth):
      	Flush the GtkLabel's requisition cache when the is_smooth
      	attribute is changed.
      
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_initialize),
      	(nautilus_property_browser_destroy),
      	(nautilus_property_browser_theme_changed):
      	Remove attempt at fixing parts of 5613.  The fix above should fix
      	it everywhere.
      47c6d18d
    • John Sullivan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> (except · 41034749
      John Sullivan authored
      	fix for bug 5884, which nobody reviewed)
      
      	Fixed bug 5766 (assertion when switching views)
      	Fixed bug 5884 (Rename file dialog for missing file
      	quotes intended name rather than current)
      
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	(nautilus_mime_get_default_action_type_for_file),
      	(nautilus_mime_get_default_action_for_file),
      	(nautilus_mime_get_default_application_for_file_internal),
      	(nautilus_mime_get_default_component_for_file_internal),
      	(nautilus_mime_get_short_list_applications_for_file),
      	(nautilus_mime_get_short_list_components_for_file),
      	(nautilus_mime_get_short_list_methods_for_file),
      	(nautilus_mime_get_all_applications_for_file),
      	(nautilus_mime_get_all_components_for_file):
      	These functions were all using return_val_if_fail if
      	nautilus_mime_actions_check_if_minimum_attributes_ready
      	returned FALSE. In keeping with the style used in
      	NautilusFile, changed these to check and return, but
      	not complain, in these cases where the answer is
      	"not enough info yet". I did not change the setters;
      	they still complain.
      
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file): Use "original_name" instead
      	of "new_name" in error message.
      41034749
    • Rebecca Schulman's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · 166a391a
      Rebecca Schulman authored
      2001-01-22  Rebecca Schulman  <rebecka@eazel.com>
      
      	reviewed by: Pavel Cisler <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_default_drop_action_for_icons):
      	Switch the order of the arguments to
      	gnome_vfs_check_same_fs_uris so that
      	the source uri is first and the target uri
      	of the drag second. This is rest of the fix
      	for bugzilla.eazel.com 5498, which necessitated
      	making the uri arguments to this function have
      	a required ordering.
      166a391a
    • Ramiro Estrugo's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · f41ae58c
      Ramiro Estrugo authored
      	Fix bug 5809 - Nautilus is slow to startup because of prefernces
      	setup code.  The reason for the slowdown was the constant
      	suggestion to gconf to sync.  Now, we sync only after setters that
      	ara result of an operation in Nautilus.  All internal setters, such
      	as defaults and visibilities happen with no sync in between each
      	one, making things a lot faster.
      
      	* libnautilus-extensions/nautilus-gconf-extensions.c:
      	(nautilus_gconf_set_boolean), (nautilus_gconf_set_integer),
      	(nautilus_gconf_set_string), (nautilus_gconf_set_string_list),
      	(nautilus_gconf_monitor_directory), (nautilus_gconf_suggest_sync):
      	* libnautilus-extensions/nautilus-gconf-extensions.h:
      	Dont suggest a sync after each set.  Instead make a new function
      	to let callers decide when to suggest a sync.  For example, after
      	a batch of many operations.
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_install_descriptions),
      	(global_preferences_install_defaults),
      	(global_preferences_get_dialog),
      	(global_preferences_install_sidebar_panel_defaults),
      	(global_preferences_install_sidebar_panel_descriptions),
      	(global_preferences_install_home_location_defaults),
      	(nautilus_global_preferences_initialize):
      	Don't install the descriptions until needed when the dialog is
      	about to be created.  Split the sidebar defaults installer into a
      	defaults and a descriptions installer.  Remove the proxy defaults
      	installer which was superfluous.  My last change simplified the
      	usage of proxy settings and a whole separate function for that is
      	no longer needed.
      
      	* libnautilus-extensions/nautilus-preferences.c:
      	(nautilus_preferences_set_boolean),
      	(nautilus_preferences_set_integer), (nautilus_preferences_set),
      	(nautilus_preferences_set_string_list),
      	(nautilus_preferences_set_user_level):
      	Suggest a gconf sync right after all the setters.
      	(preferences_something_changed_notice): Add a fixme.  Also remove
      	unused variables and tweak a tiny bit.
      f41ae58c
  7. 20 Jan, 2001 4 commits
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · a41279bb
      Darin Adler authored
      	Fix for bug 5475 (assertion and crash trying to return using Up
      	from web link):
      
      	* libnautilus-extensions/nautilus-file.c: (get_description): Instead
      	of asserting that the MIME type is not NULL or empty string, just
      	change the code  to return an empty description for those cases.
      
      	* autogen.sh: Fix one silly "ignore non-fatal errors" message.
      a41279bb
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 7da6d84d
      Darin Adler authored
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(top_left_read_callback): Change code so it doesn't send a file
      	changed message and then assume nothing changed.
      
      	* libnautilus-extensions/nautilus-link.c:
      	(nautilus_link_local_get_image_uri): Handle the case where it
      	can't create the directory without seg faulting.
      7da6d84d
    • John Sullivan's avatar
      Fixed bug 1404 (Preferences panes should be in some · f18d8bc0
      John Sullivan authored
      	sensible order)
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_create_dialog): Reordered panes to
      	match Arlo's simplest-to-least-simple design.
      f18d8bc0
    • John Sullivan's avatar
      Fixed bug 5830 ("Show only folders in tree" shown at · a7af28f3
      John Sullivan authored
      	wrong user level)
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_install_visibility): Made it visible
      	starting at intermediate level.
      a7af28f3
  8. 19 Jan, 2001 6 commits
    • Ramiro Estrugo's avatar
      Accidentally checked in a huge default font size. · ee1e5513
      Ramiro Estrugo authored
      	* libnautilus-extensions/nautilus-label.c:
      	Accidentally checked in a huge default font size.
      ee1e5513
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · d23bb1b5
      John Sullivan authored
      	Finished bug 2146 (Properties window for desktop Trash
      	should show Trash properties). The last two changes were
      	to remove the "accessed" field for all directories, since
      	it seems useless, and to fill in the "where" field with
      	"on the desktop".
      
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_get_where_string): New function, calls
      	virtual function so trash and normal files can report
      	different strings.
      	(nautilus_file_get_string_attribute): Changed "parent_uri"
      	string attribute to "where", since it is not the parent_uri
      	in the Trash case.
      	* libnautilus-extensions/nautilus-file.h: Virtual function
      	pointer for get_where_string.
      	* libnautilus-extensions/nautilus-trash-file.c:
      	(trash_file_get_where_string),
      	(nautilus_trash_file_initialize_class): Supply get_where_string
      	function that returns "on the desktop".
      	* libnautilus-extensions/nautilus-vfs-file.c:
      	(vfs_file_get_where_string), (nautilus_vfs_file_initialize_class):
      	Supply get_where_string function that returns parent_uri string.
      	* src/file-manager/fm-properties-window.c:
      	(should_show_accessed_date): New function, returns FALSE for
      	directories and TRUE for other files.
      	(create_basic_page): Honor should_show_accessed_date, and use
      	"where" instead of "parent_uri" string attribute.
      	* src/file-manager/fm-search-list-view.c:
      	(real_get_column_specification): Use "where" instead of "parent_uri"
      	string attribute.
      d23bb1b5
    • Ramiro Estrugo's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 773ec652
      Ramiro Estrugo authored
      	* components/services/install/nautilus-view/nautilus-service-instal
      	l-view.c: (install_message_new):
      	Add a tiny bit of padding to this label to prevent the bottom from
      	being cut off.  Im not sure exactly why the bottom is getting cut
      	off.  I suspect that the part container is constraining the widget
      	somehow, perhaps to match the geometry of the label on the right.
      
      	* libnautilus-extensions/nautilus-label.c:
      	(label_composite_pixbuf_callback), (nautilus_label_expose_event):
      	Fix for bugs 5607, 5608 and 5611.  Remove previous workaround for
      	bug 5608.  Do the clipping of the area that we need to copy into
      	the temporary buffer more carefully.  The temporary buffer itself
      	is a workaround for a related bug (2784).
      773ec652
    • Ramiro Estrugo's avatar
      Remove a debug printf that I stupidly left in. · 6985d198
      Ramiro Estrugo authored
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdkimage.c:
      	(NAUTILUS_BUG_5712_PR3_WORKAROUND__gdk_image_get):
      	Remove a debug printf that I stupidly left in.
      6985d198
    • Ramiro Estrugo's avatar
      reviewed by: Nobody, because the "fix" is so revolting that none · 0be1195b
      Ramiro Estrugo authored
      	of the high integrity Nautilus hackers would approve it.
      
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdk-pixbuf-drawable.c:
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdk-pixbuf-private.h:
      	* libnautilus-extensions/bug-5712-pr3-workaround--gdkimage.c:
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	(nautilus_gdk_pixbuf_get_from_window_safe):
      	Workaround for bug 5712.  This is a temporary evil until GTK+
      	1.2.9 is released.
      0be1195b
    • John Sullivan's avatar
      Ramiro sent me this patch, which I tweaked slightly. · f425b335
      John Sullivan authored
      	Fix for bug 5792 (Sidebar panel choices visible at beginner
      	user level, but shouldn't be)
      
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	add visible_user_level field to known_sidebar_panels struct.
      	Set this field appropriately for each of the 4 known sidebar
      	panels. Remove the 5th known sidebar panel since it was an
      	accidental duplication of the 2nd one.
      	(global_preferences_install_sidebar_panel_defaults): Set the
      	visible user level when installing default values.
      f425b335