1. 03 Apr, 2000 2 commits
    • Darin Adler's avatar
      Fix the build. Changes in GtkHtml and Bonobo required us · 2fe15f16
      Darin Adler authored
      	to catch up.
      
      	* libnautilus/ntl-meta-view-frame.h:
      	* libnautilus/ntl-meta-view-frame.c:
      	Rewrote to use the new property bag. This requires us to
      	store our own properties, since the bag no longer provides
      	any storage.
      	(nautilus_meta_view_frame_initialize): Set up the label.
      	(nautilus_meta_view_frame_new_from_bonobo_control): Make it
      	actually take a BonoboControl instead of a BonoboObject and
      	make it set up the property bag.
      	(nautilus_meta_view_destroy): Free the label.
      	(autilus_meta_view_frame_set_label): Just set the label.
      	The property bag simply uses our stored label.
      
      	* components/html/ntl-web-browser.c (browser_url_load_gone):
      	Changed call to match name in new version of GtkHtml.
      	Unfortunately, the new name makes it clear the call is
      	intended to be private.
      
      	* components/rpmview/.cvsignore: Ignore the actual binary,
      	not nautilus-music-view.
      	* components/rpmview/Makefile.am: Turned on -Werror.
      	* components/music/Makefile.am: Turned on -Werror.
      	* components/rpmview/nautilus-rpm-view.c: Fixed warnings.
      2fe15f16
    • Andy Hertzfeld's avatar
      first cut at rpm view component · 2ee8f838
      Andy Hertzfeld authored
      
              first cut at rpm view component
      2ee8f838
  2. 02 Apr, 2000 3 commits
  3. 01 Apr, 2000 1 commit
  4. 31 Mar, 2000 4 commits
    • Pavel Cisler's avatar
      Disable copy as a drag&drop operation for now. The current copy engine · 227b517d
      Pavel Cisler authored
      
      
      2000-03-31  Pavel Cisler  <pavel@eazel.com>
      
      	Disable copy as a drag&drop operation for now. The current
      	copy engine doesn't handle conflicts properly yet and can
      	erase your files.
      227b517d
    • Darin Adler's avatar
      Fixed a bug that Pavel reported where he got a crash in · a1f24785
      Darin Adler authored
      	nautilus_directory_monitor_files_unref when he pushed the
      	"Up" button.
      
      	* libnautilus/nautilus-glib-extensions.c:
      	* libnautilus/nautilus-glib-extensions.h:
      	(nautilus_g_strv_find): Renamed the existing function
      	nautilus_g_strfindv to be more consistent with the rest
      	of glib, even though it's less consistent with the other
      	strv functions.
      	(nautilus_g_list_safe_for_each): Added an alternate
      	version of g_list_foreach that works even when the current
      	item is removed from the list inside the function.
      
      	* libnautilus/nautilus-gtk-extensions.c:
      	(nautilus_gtk_object_list_unref): Use the new safe version
      	of g_list_foreach so this works even on lists where the
      	objects remove themselves in their destroy/finalize methods.
      	This is the change that fixes the bug.
      
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_load_file): Replaced some explicit
      	code with a call to nautilus_gtk_object_list_free.
      
      	* src/nautilus-index-title.c:
      	(nautilus_index_title_update_icon): Fixed a bug that would
      	prevent you from viewing the root level. The current version
      	of nautilus_file_get returns NULL for the root.
      
      	* src/nautilus-window-menus.c:
      	(clear_appended_bookmark_items): Replaced some explicit
      	code with a call to nautilus_g_list_free_deep.
      
      	* src/file-manager/fm-icon-text-window.c:
      	(synch_menus_with_preference): Updated to use the
      	nautilus_g_strv_find call by its new name.
      
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_set_keywords): Did some minor tweaks to
      	simplify the no-keywords case.
      a1f24785
    • John Sullivan's avatar
      Show icon emblems in list view. · 16acc134
      John Sullivan authored
      16acc134
    • Darin Adler's avatar
      Finished task 62 (Set custom icon by drag/drop on index panel) · 1fb5a14a
      Darin Adler authored
      	and fixed some problems from my earlier check-ins today.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_monitor_files_ref):
      	Fixed a bad assert from my last check-in.
      
      	* src/file-manager/fm-list-view.c: (add_to_list):
      	The list view had the same missing ref that I fixed for icon
      	view in my last check-in.
      
      	* src/nautilus-index-title.c: (release_file),
      	(nautilus_index_title_destroy),
      	(nautilus_index_title_update_icon),
      	(nautilus_index_title_update_label),
      	(nautilus_index_title_update_info),
      	(nautilus_index_title_set_uri): Changed to hold around the
      	NautilusFile object and connect to its "changed" message to update
      	the file information. This causes the icon to get updated right
      	away when the custom icon is changed.
      
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-file-private.h:
      	* libnautilus/nautilus-file.c:
      	* libnautilus/nautilus-file.h:
      	Converted NautilusFile to be a GtkObject instead of a plain struct,
      	so it can have a "changed" signal. We still recommend using the
      	"files_changed" signal on the directory to avoid the overhead
      	of a signal connection for each file.
      
      	* libnautilus/nautilus-gtk-extensions.c:
      	* libnautilus/nautilus-gtk-extensions.h:
      	(nautilus_gtk_object_list_ref), (nautilus_gtk_object_list_unref),
      	(nautilus_gtk_object_list_free): Added some functions to be used
      	with a list of GtkObjects.
      
      	* libnautilus/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_name_for_file):
      	Had to change the name of nautilus_file_get_type to avoid conflict
      	with the GtkObject standard get_type routine.
      1fb5a14a
  5. 30 Mar, 2000 5 commits
    • Darin Adler's avatar
      Added missing ref that caused very bad things to happen now that the file · e5c04283
      Darin Adler authored
      	* src/file-manager/fm-icon-view.c: (add_icon_if_already_positioned),
      	(add_icon_at_free_position): Added missing ref that caused very bad
      	things to happen now that the file ref. counts are working.
      
      	* components/music/nautilus-music-view.c:
      	Did a bunch of cleanup and fixed some memory trashing bugs where
      	the result of g_basename was passed to g_free.
      e5c04283
    • Darin Adler's avatar
      Added convenience functions so people don't have to be constantly reminded · 4c8d9b0b
      Darin Adler authored
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	(nautilus_directory_ref), (nautilus_directory_unref):
      	Added convenience functions so people don't have to be constantly
      	reminded that a NautilusDirectory is a a GtkObject.
      
      	* libnautilus/nautilus-directory.c: (nautilus_directory_destroy):
      	Fixed a problem where the pending files callback might fire after
      	the NautilusDirectory is gone.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_destroy),
      	(nautilus_directory_monitor_files_ref),
      	(nautilus_directory_monitor_files_unref),
      	(dequeue_pending_idle_callback), (nautilus_directory_new_file):
      	* libnautilus/nautilus-file-private.h:
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_get), (nautilus_file_ref), (nautilus_file_unref),
      	(nautilus_file_free), (nautilus_file_delete):
      	To prepare for changing NautilusFile to a GtkObject, made it use
      	ref counts in a way that is standard. Now the directory keeps a
      	list of the files, but only keeps a ref to the files if it is
      	monitoring them.
      
      	* src/file-manager/fm-directory-view.c: Tiny formatting tweak.
      4c8d9b0b
    • Andy Hertzfeld's avatar
      made the selection rectangle have a semi transparent light blue fill · f95b9532
      Andy Hertzfeld authored
      
              made the selection rectangle have a semi transparent light blue fill
      	color; also tweaked the selection darkening to be a little lighter
      f95b9532
    • Pavel Cisler's avatar
      More copy/move operations. Fixes a problem I introduced earlier where drop · 1c93ed15
      Pavel Cisler authored
      2000-03-28  Pavel Cisler  <pavel@eazel.com>
      
      	More copy/move operations. Fixes a problem I introduced earlier where
      	drop onto a file would lock up Nautilus.
      1c93ed15
    • Maciej Stachowiak's avatar
      Connect to the "destroy" signal of the view_frame rather than the sample · 4f01fe36
      Maciej Stachowiak authored
      	* components/sample/main.c (sample_make_object): Connect to the
      	"destroy" signal of the view_frame rather than the sample content
      	view object, to avoid a race condition where we might exit before
      	the view_frame is fully unreffed and has a chance to clean up.
      	components/sample/nautilus-sample-content-view.c
      	(nautilus_sample_content_view_destroy): Unref the
      	NautilusViewFrame when we are destroyed.
      
      	* libnautilus/nautilus-zoomable.c, libnautilus/ntl-view-frame.c,
      	libnautilus/ntl-content-view-frame.c,
      	libnautilus/ntl-meta-view-frame.c: Use boilerplate macros for
      	get_type method and to invoke parent destroy method.
      
      	* libnautilus/nautilus-zoomable.c, libnautilus/ntl-view-frame.c:
      	Unref the interface we query_local_interface for, to avoid holding
      	a superfluous ref to ourselves, since we eventually add_interface
      	that interface.
      
      	* src/ntl-view.c (nautilus_view_destroy_client): Use
      	bonobo_object_unref instead of bonobo_object_destroy.
      4f01fe36
  6. 29 Mar, 2000 4 commits
    • Andy Hertzfeld's avatar
      fixed bug #312, index tabs not resizing properly, by overriding size · ac2b76be
      Andy Hertzfeld authored
      
      	fixed bug #312, index tabs not resizing properly, by overriding
      	size allocate and adjusting the height accordingly
      ac2b76be
    • Pavel Cisler's avatar
      Started on copy/move operations · 713828f4
      Pavel Cisler authored
      2000-03-28  Pavel Cisler  <pavel@eazel.com>
      
      	Started on copy/move operations
      713828f4
    • Darin Adler's avatar
      Preparing for support for background images. · 39d18967
      Darin Adler authored
      	* libnautilus/nautilus-background.h:
      	* libnautilus/nautilus-background.c:
      	Preparing for support for background images.
      
      	* libnautilus/nautilus-background.c:
      	* libnautilus/nautilus-debug.c:
      	* libnautilus/nautilus-icon-canvas-item.c:
      	* libnautilus/nautilus-icon-dnd.c:
      	Add those braces that Maciej, John, and the style guide all prefer.
      
      	* libnautilus/nautilus-file.c: (nautilus_file_set_metadata):
      	A change to metadata is considered a change to the file.
      
      	* libnautilus/nautilus-graphic-effects.c:
      	* libnautilus/nautilus-graphic-effects.h:
      	Added nautilus_ prefix to all the functions in here.
      
      	* libnautilus/nautilus-gtk-extensions.c:
      	* libnautilus/nautilus-gtk-extensions.h:
      	(nautilus_point_in_allocation),	(nautilus_point_in_widget):
      	Added hit testing help functions that check if a point is
      	in a particular allocation/widget.
      
      	* libnautilus/nautilus-icon-dnd.c: (get_gnome_icon_list_selection):
      	Fixed a bug that happens when you get a 0-length piece of
      	selection data.
      
      	* libnautilus/nautilus-icon-dnd.h:
      	Changed the icon list back to "x-gnome-icon-list".
      	That's how the other GNOME folks want it, not "x-nautilus-icon-list".
      
      	* src/nautilus-index-tabs.c:
      	* src/nautilus-index-tabs.h:
      	* src/nautilus-index-title.c:
      	* src/nautilus-index-title.h:
      	* src/ntl-index-panel.c:
      	* src/ntl-index-panel.h:
      	lite -> light, Other cleanup.
      
      	* src/nautilus-index-title.c:
      	* src/nautilus-index-title.h:
      	(nautilus_index_title_hit_test_icon):
      	* src/ntl-index-panel.c:
      	(hit_test), (uri_is_local_image), (receive_dropped_uri_list),
      	(receive_dropped_color):
      	Added code needed to support dropping an image on the icon to set
      	a custom icon. This doesn't yet update the icon in the panel itself,
      	but I'll do that soon.
      39d18967
    • John Sullivan's avatar
      Removed notify_title_change call and removed initial_title parameter of · 66d503d1
      John Sullivan authored
      notify_location_change call.
      66d503d1
  7. 28 Mar, 2000 8 commits
  8. 26 Mar, 2000 2 commits
  9. 25 Mar, 2000 3 commits
  10. 24 Mar, 2000 1 commit
  11. 23 Mar, 2000 2 commits
    • John Sullivan's avatar
    • Darin Adler's avatar
      Fixed bug 336 (merged menu items don't go away when component · e14985a9
      Darin Adler authored
      	is swapped out).
      
      	* src/file-manager/fm-directory-view.c: (fm_directory_view_destroy):
      	While debugging, I noticed that the view_frame was allocated by the
      	FMDirectoryView and never unref'd. The exact connection of this to
      	why the widgets don't go away is now lost in time. We added a call
      	to bonobo_object_unref to get rid of the view frame.
      
      	* src/ntl-window.h, src/ntl-window.c, src/ntl-window-msgs.c:
      	(Nautilus_NavigationInfo_free): Got rid of this routine. It turns
      	out that this was an incorrect hack to work around the error in
      	the surrounding code that was copying CORBA object references
      	without calling	CORBA_Object_duplicate.
      	(nautilus_window_destroy), (nautilus_window_request_selection_change):
      	Changed code that was calling Nautilus_NavigationInfo_free to just
      	call CORBA_free now that the incorrect hack is not needed.
      	(nautilus_window_request_selection_change),
      	(nautilus_window_update_view),
      	(nautilus_window_update_internals),
      	(nautilus_window_load_content_view): Changed all code that was
      	manipulating content_view to use CORBA_Object_duplicate when
      	storing a reference and CORBA_Object_release when overwriting
      	a reference.
      e14985a9
  12. 22 Mar, 2000 5 commits