1. 30 Apr, 2008 4 commits
    • Cosimo Cecchi's avatar
      Do not unref the file info before checking the mime type, otherwise the · 568b6d29
      Cosimo Cecchi authored
      2008-04-30  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-property-browser.c: (ensure_file_is_image):
      	Do not unref the file info before checking the mime type,
      	otherwise the mime_type string will be invalidated. (#530549).
      
      svn path=/trunk/; revision=14117
      568b6d29
    • Andrew Walton's avatar
      Remove false dependency for ESound. Closes bug #311445. · f5c16e3d
      Andrew Walton authored
      2008-04-30  A. Walton  <awalton@gnome.org>
      
      	* configure.in:
      	* src/file-manager/fm-icon-view.c:
      	Remove false dependency for ESound. Closes bug #311445.
      
      
      svn path=/trunk/; revision=14115
      f5c16e3d
    • Andrew Walton's avatar
      Replace g_return_*() with g_assert() in private, internal functions. · a9b02ab3
      Andrew Walton authored
      2008-04-30  A. Walton  <awalton@gnome.org>
      
      	* libnautilus-private/nautilus-clipboard.c:
      	* libnautilus-private/nautilus-directory-async.c:
      	* libnautilus-private/nautilus-directory.c:
      	* libnautilus-private/nautilus-entry.c:
      	* libnautilus-private/nautilus-file.c:
      	* libnautilus-private/nautilus-horizontal-splitter.c:
      	* libnautilus-private/nautilus-icon-canvas-item.c:
      	* libnautilus-private/nautilus-icon-container.c:
      	* libnautilus-private/nautilus-metafile.c:
      	* libnautilus-private/nautilus-users-groups-cache.c:
      	* libnautilus-private/nautilus-vfs-directory.c:
      	* src/nautilus-emblem-sidebar.c:
      	* src/nautilus-file-management-properties.c:
      	* src/nautilus-window-manage-views.c:
      	* src/nautilus-window.c:
      	* src/nautilus-zoom-control.c:
      	Replace g_return_*() with g_assert() in private, internal
      	functions. Closes #530321.
      
      
      svn path=/trunk/; revision=14114
      a9b02ab3
    • David Zeuthen's avatar
      Fix how autorunning works. Instead of inhibiting autorunning every time we · 0e85a1ca
      David Zeuthen authored
      2008-04-29  David Zeuthen  <davidz@redhat.com>
      
              * libnautilus-private/nautilus-autorun.c:
              * libnautilus-private/nautilus-autorun.h:
              * libnautilus-private/nautilus-file-operations.c:
              (volume_mount_cb), (nautilus_file_operations_mount_volume):
              * libnautilus-private/nautilus-file-operations.h:
              * libnautilus-private/nautilus-mime-actions.c:
              (activation_mount_not_mounted_callback):
              * libnautilus-private/nautilus-vfs-file.c:
              (vfs_file_mount_callback):
              * src/nautilus-application.c: (startup_volume_mount_cb),
              (volume_added_callback):
              * src/nautilus-places-sidebar.c: (open_selected_bookmark),
              (mount_shortcut_cb):
              * src/nautilus-window-manage-views.c: (mount_not_mounted_callback):
              Fix how autorunning works. Instead of inhibiting autorunning
              every time we run something, we turn things around and instead
              allow automounting only in the instance where Nautilus automounted
              something itself. So in essence this patch is s/inhibit/allow/.
              This fixes an annoying problem where Nautilus would do autorun
              everytime something was mounted even from the command line. A
              consequence of this are windows popping up and other annoyances.
              This patch fixes that problem.
      
              * src/nautilus-x-content-bar.c: (nautilus_x_content_bar_init):
              Make sure the label is ellipsized.
      
      
      svn path=/trunk/; revision=14112
      0e85a1ca
  2. 27 Apr, 2008 7 commits
    • Cosimo Cecchi's avatar
      Report user cancel when all the files we're about to trash or delete are · dbd34bda
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_files),
      	(trash_files), (delete_job):
      	Report user cancel when all the files we're about to trash or delete
      	are skipped in the operation. This allows to use the same selection for
      	requesting another deletion from the view. (#519746).
      
      svn path=/trunk/; revision=14106
      dbd34bda
    • Christian Neumair's avatar
      Quote schema. Fixes #522029. · 082c843c
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* src/nautilus-window-manage-views.c
      	(display_view_selection_failure):
      	Quote schema. Fixes #522029.
      
      svn path=/trunk/; revision=14104
      082c843c
    • Cosimo Cecchi's avatar
      Always use single click policy in the Places sidebar. (#355760). · 1699ec31
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-places-sidebar.c: (nautilus_places_sidebar_init):
      	Always use single click policy in the Places sidebar. (#355760).
      
      svn path=/trunk/; revision=14102
      1699ec31
    • Cosimo Cecchi's avatar
      Always properly remember window size, also in the case the window is · 5bbc8307
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-navigation-window.c:
      	(nautilus_navigation_window_save_geometry):
      	Always properly remember window size, also in the case the window is
      	closed being maximized. (#385176).
      
      svn path=/trunk/; revision=14100
      5bbc8307
    • Cosimo Cecchi's avatar
      Reverse the order in which the keybindings are processed by the · 60328a43
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-window.c: (nautilus_window_key_press_event):
      	Reverse the order in which the keybindings are processed by the
      	NautilusWindow, and use the same approach as GEdit.
      	This fixes some bugs where the GtkWindow accelerators were executed
      	before the focused widget one. (#314431).
      
      svn path=/trunk/; revision=14098
      60328a43
    • Christian Neumair's avatar
      Do not activate twice if the activated paths are already selected. Always · c2305aff
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* src/file-manager/fm-list-view.c (button_press_callback):
      	Do not activate twice if the activated paths are already selected.
      	Always expand when an expander is clicked, even when the activation
      	paths are already selected. Add 4 to the GtkTreeView's claimed
      	expander size, which accounts for hard coded internal GtkTreeView
      	expander padding. Fixes #448562. Thanks to Paweł Paprota.
      
      svn path=/trunk/; revision=14095
      c2305aff
    • Andrew Walton's avatar
      reviewed by: Christian Neumair · f78a9799
      Andrew Walton authored
      2008-04-26  A. Walton  <awalton@gnome.org>
      
      	reviewed by: Christian Neumair
      
      	* libnautilus-private/nautilus-file-private.h:
      	* libnautilus-private/nautilus-file-utilities.c
      	(nautilus_compute_title_for_location):
      	* libnautilus-private/nautilus-file.c (update_info_internal),
      	(nautilus_file_get_description):
      	* libnautilus-private/nautilus-file.h:
      	Use standard::description in the window title when it's available.
      	Closes bug #516007.
      
      
      svn path=/trunk/; revision=14094
      f78a9799
  3. 26 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Properly handle selection changes when using keyboard navigation. We did · a6f7e3a2
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(emit_atk_focus_tracker_notify), (set_keyboard_focus),
      	(select_range), (select_one_unselect_others), (rubberband_select),
      	(keyboard_move_to):
      	Properly handle selection changes when using keyboard navigation. We
      	did not emit a "selection-change" signal when keyboard rubberbanding
      	was used, and all except one icon were deselected. Fixes #509432.
      	Thanks to Paweł Paprota.
      
      svn path=/trunk/; revision=14092
      a6f7e3a2
  4. 23 Apr, 2008 2 commits
  5. 21 Apr, 2008 4 commits
  6. 15 Apr, 2008 1 commit
  7. 10 Apr, 2008 4 commits
    • A. Walton's avatar
      Remove GSequence directory and files (for real this time). · 23b84c87
      A. Walton authored
      2008-04-10  A. Walton  <awalton@svn.gnome.org>
      	Remove GSequence directory and files (for real this time).
      
      
      svn path=/trunk/; revision=14064
      23b84c87
    • A. Walton's avatar
      Remove GSequence hack as it is no longer necessary; we require a newer · 85427124
      A. Walton authored
      2008-04-10  A. Walton  <awalton@svn.gnome.org>
      
      	* configure.in:
      	* cut-n-paste-code/Makefile.am:
      	* cut-n-paste-code/gsequence/Makefile.am:
      	* cut-n-paste-code/gsequence/gsequence.c:
      	* cut-n-paste-code/gsequence/gsequence.h:
      	* src/Makefile.am:
      	* src/file-manager/fm-list-model.c:
      	Remove GSequence hack as it is no longer necessary;
      	we require a newer GLib in order to support GIO.
      	More work towards bug #520773.
      
      
      svn path=/trunk/; revision=14062
      85427124
    • A. Walton's avatar
      Remove the first-time-druid dead code (#520773). · 6eb74f59
      A. Walton authored
      2008-04-10  A. Walton  <awalton@svn.gnome.org>
      
      	* src/Makefile.am:
      	* src/nautilus-application.c: (nautilus_application_startup):
      	* src/nautilus-application.h:
      	* src/nautilus-first-time-druid.c:
      	* src/nautilus-first-time-druid.h:
      	* src/nautilus-main.c: (main):
      	Remove the first-time-druid dead code (#520773).
      
      
      svn path=/trunk/; revision=14061
      6eb74f59
    • Cosimo Cecchi's avatar
      Add a missing comma to fix build with Autoconf 2.62. (#527315). · fd9258ae
      Cosimo Cecchi authored
      2008-04-10  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* configure.in: Add a missing comma to fix build with
      	Autoconf 2.62. (#527315).
      
      svn path=/trunk/; revision=14054
      fd9258ae
  8. 08 Apr, 2008 1 commit
  9. 07 Apr, 2008 1 commit
  10. 06 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Remove show/hide buttons. The entries can be toggled directly using mouse · cb037e32
      Christian Neumair authored
      2008-04-07  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-column-chooser.c (update_buttons),
      	(add_buttons):
      	Remove show/hide buttons. The entries can be toggled directly using
      	mouse or keyboard. Do not remove buttons to move entries, since
      	list DND may not be obvious for some users (#514394). Thanks to Marcin
      	Galazka.
      
      svn path=/trunk/; revision=14044
      cb037e32
  11. 05 Apr, 2008 2 commits
  12. 04 Apr, 2008 3 commits
    • Christian Neumair's avatar
      Move finalize to dispose, unset pointers to window/tree_view, use · a85b467e
      Christian Neumair authored
      2008-04-04  Christian Neumair  <cneumair@gnome.org>
      
      	* src/nautilus-places-sidebar.c (nautilus_places_sidebar_init),
      	(nautilus_places_sidebar_dispose),
      	(nautilus_places_sidebar_class_init):
      
      	Move finalize to dispose, unset pointers to window/tree_view, use
      	eel_preferences_add_callback_while_alive().
      
      svn path=/trunk/; revision=14039
      a85b467e
    • Cosimo Cecchi's avatar
      Add new APIs for extensions to NautilusFileInfo (can_write, get_mount and · 957f93fd
      Cosimo Cecchi authored
      2008-04-04  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-extension/nautilus-file-info.c:
      	(nautilus_file_info_get_parent_info),
      	(nautilus_file_info_get_mount), (nautilus_file_info_can_write):
      	* libnautilus-extension/nautilus-file-info.h:
      	* libnautilus-private/nautilus-file.c:
      	(nautilus_file_info_iface_init):
      	Add new APIs for extensions to NautilusFileInfo (can_write, get_mount
      	and get_parent_info). (#521612).
      
      svn path=/trunk/; revision=14036
      957f93fd
    • Christian Neumair's avatar
      Inhibit autorun in mount callbacks after finishing mounts rather than · 00a42fe8
      Christian Neumair authored
      2008-04-04  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c (volume_mount_cb),
      	(nautilus_file_operations_mount_volume):
      	* libnautilus-private/nautilus-file-operations.h:
      	* libnautilus-private/nautilus-mime-actions.c
      	(activation_mount_not_mounted_callback),
      	(activation_mount_not_mounted):
      	* src/nautilus-application.c (startup_volume_mount_cb),
      	(automount_all_volumes), (volume_added_callback):
      	* src/nautilus-places-sidebar.c (open_selected_bookmark),
      	(mount_shortcut_cb):
      	* src/nautilus-window-manage-views.c (mount_not_mounted_callback),
      	(got_file_info_for_view_selection_callback):
      	Inhibit autorun in mount callbacks after finishing mounts rather than
      	before mounting.
      
      	It is neccessary because the mount may take a very long time (floppy,
      	password prompt), which may take longer than the inhibition timeout.
      
      	This approach works because with the current HAL volume monitor
      	implementation, GVolumeMonitor signal emission is scheduled, while the
      	mount callbacks are invoked synchronously.
      
      	This should also fix the not working inhibition on startup, which
      	could happen because parallel mounts in the background and the rest of
      	the startup process eat resources, so the mounts may also take longer
      	than the inhibition timeout.
      
      svn path=/trunk/; revision=14034
      00a42fe8
  13. 03 Apr, 2008 3 commits
  14. 02 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Subtract 1 from icon rectangle's x2/y2 positions before setting scroll · a5cf591c
      Christian Neumair authored
      2008-04-02  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(nautilus_icon_container_update_scroll_region),
      	(lay_down_icons_horizontal), (get_max_icon_dimensions),
      	(lay_down_icons_vertical),
      	(nautilus_icon_container_start_renaming_selected_item),
      	(nautilus_icon_container_is_layout_vertical):
      	* libnautilus-private/nautilus-icon-container.h:
      	* src/nautilus-window.c
      	(nautilus_window_set_initial_window_geometry):
      	Subtract 1 from icon rectangle's x2/y2 positions before setting scroll
      	area since the entire canvas codes requests 1 px more than it needs.
      	Wrap when the icon hits the canvas, rather than wrapping to late.
      	Fixes most of the "text besides icons" glitches.
      
      	Add container padding on the RHS for vertical layout, and consider
      	max. emblem rectangles when deciding whether to wrap. This may wrap
      	slightly to early in some (high zoom level) situations, but we will
      	never get scroll glitches.
      
      svn path=/trunk/; revision=14025
      a5cf591c
  15. 01 Apr, 2008 4 commits
    • Christian Neumair's avatar
      Remove unused "label" field of NautilusViewInfo and · 2966e3f4
      Christian Neumair authored
      2008-04-01  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-view-factory.h:
      	* src/file-manager/fm-desktop-icon-view.c
      	(fm_desktop_icon_view_register):
      	* src/file-manager/fm-icon-view.c:
      	* src/file-manager/fm-list-view.c (fm_list_view_register):
      	* src/nautilus-navigation-window.c (load_view_as_menu):
      	* src/nautilus-window-manage-views.c:
      	* src/nautilus-window-manage-views.h:
      	* src/nautilus-window.c (add_view_as_menu_item):
      	Remove unused "label" field of NautilusViewInfo and
      	nautilus_window_get_view_label().
      	Rename two other fields of NautilusViewInfo and make their use
      	more explicit. Remove redundand "View" from view menu label.
      
      svn path=/trunk/; revision=14024
      2966e3f4
    • Michael J. Chudobiak's avatar
      Skip the thumbnailing of unreadable files. This is more efficient than · e5085870
      Michael J. Chudobiak authored
      2008-04-01  Michael J. Chudobiak  <mjc@svn.gnome.org>
      
              * libnautilus-private/nautilus-file.c: (nautilus_file_get_icon):
              Skip the thumbnailing of unreadable files. This is more efficient
              than relying on failed thumbnails. (#525594).
      
      
      svn path=/trunk/; revision=14022
      e5085870
    • Andrew Walton's avatar
      Add advice about patches adding strings to Nautilus. · b565a0e6
      Andrew Walton authored
      	* HACKING:
      	Add advice about patches adding strings to Nautilus.
      
      
      svn path=/trunk/; revision=14018
      b565a0e6
    • Cosimo Cecchi's avatar
      Do not use contractions in strings. (#145356). · 10053a33
      Cosimo Cecchi authored
      2008-04-01  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_dir),
      	(prompt_empty_trash), (verify_destination), (copy_move_directory),
      	(remove_target_recursively), (copy_move_file):
      	* libnautilus-private/nautilus-mime-actions.c:
      	(report_broken_symbolic_link), (activate_files):
      	* libnautilus-private/nautilus-program-choosing.c:
      	(application_cannot_open_location), (nautilus_launch_application),
      	(nautilus_launch_desktop_file):
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_loading_directory),
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/file-manager/fm-properties-window.c:
      	(fm_properties_window_drag_data_received),
      	(create_permissions_page):
      	* src/nautilus-application.c: (nautilus_application_startup):
      	* src/nautilus-connect-server-dialog-main.c:
      	(display_error_dialog):
      	* src/nautilus-connect-server-dialog.c: (connect_to_server):
      	* src/nautilus-emblem-sidebar.c:
      	(nautilus_emblem_sidebar_delete_cb), (rename_dialog_response_cb):
      	* src/nautilus-information-panel.c: (receive_dropped_uri_list):
      	* src/nautilus-property-browser.c: (remove_pattern),
      	(remove_emblem), (add_pattern_to_browser):
      	* src/nautilus-window-manage-views.c:
      	(display_view_selection_failure):
      	Do not use contractions in strings. (#145356).
      
      svn path=/trunk/; revision=14017
      10053a33
  16. 31 Mar, 2008 1 commit
    • Cosimo Cecchi's avatar
      Do not ask twice if we want to empty the trash when unmounting a volume. · 07810ad9
      Cosimo Cecchi authored
      2008-04-01  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c:
      	(nautilus_file_operations_unmount_mount), (empty_trash_job),
      	(nautilus_file_operations_empty_trash):
      	Do not ask twice if we want to empty the trash when unmounting
      	a volume. (#525269).
      
      svn path=/trunk/; revision=14015
      07810ad9