1. 08 May, 2008 1 commit
    • Federico Mena Quintero's avatar
      bgo364843 - Don't exceed max path len when forming filenames for duplicates · 0e85321f
      Federico Mena Quintero authored
      2008-05-08  Federico Mena Quintero  <federico@novell.com>
      
      	http://bugzilla.gnome.org/show_bug.cgi?id=364843
      
      
      
      	Keep the generated names for "reallylongfilename (copy).txt" from
      	overflowing the maximum allowed length for path names.
      
      	Original patch by Dave Camp <campd@campd.org>
      
      	* libnautilus-private/nautilus-file-operations.c
      	(shorten_utf8_string): New function; takes an UTF8 string and
      	hygienically truncates it to a given number of bytes.
      	(get_link_name): Ensure the final name doesn't exceed a maximum length.
      	(make_next_duplicate_name): Likewise.
      	(get_max_name_length): Wrapper around pathconf() for basename lengths.
      	(get_unique_target_file): Use a maximum length for the target name.
      	(get_target_file_for_link): Likewise.
      Signed-off-by: default avatarFederico Mena Quintero <federico@gnu.org>
      
      svn path=/trunk/; revision=14147
      0e85321f
  2. 05 May, 2008 1 commit
  3. 30 Apr, 2008 1 commit
    • David Zeuthen's avatar
      Fix how autorunning works. Instead of inhibiting autorunning every time we · 0e85a1ca
      David Zeuthen authored
      2008-04-29  David Zeuthen  <davidz@redhat.com>
      
              * libnautilus-private/nautilus-autorun.c:
              * libnautilus-private/nautilus-autorun.h:
              * libnautilus-private/nautilus-file-operations.c:
              (volume_mount_cb), (nautilus_file_operations_mount_volume):
              * libnautilus-private/nautilus-file-operations.h:
              * libnautilus-private/nautilus-mime-actions.c:
              (activation_mount_not_mounted_callback):
              * libnautilus-private/nautilus-vfs-file.c:
              (vfs_file_mount_callback):
              * src/nautilus-application.c: (startup_volume_mount_cb),
              (volume_added_callback):
              * src/nautilus-places-sidebar.c: (open_selected_bookmark),
              (mount_shortcut_cb):
              * src/nautilus-window-manage-views.c: (mount_not_mounted_callback):
              Fix how autorunning works. Instead of inhibiting autorunning
              every time we run something, we turn things around and instead
              allow automounting only in the instance where Nautilus automounted
              something itself. So in essence this patch is s/inhibit/allow/.
              This fixes an annoying problem where Nautilus would do autorun
              everytime something was mounted even from the command line. A
              consequence of this are windows popping up and other annoyances.
              This patch fixes that problem.
      
              * src/nautilus-x-content-bar.c: (nautilus_x_content_bar_init):
              Make sure the label is ellipsized.
      
      
      svn path=/trunk/; revision=14112
      0e85a1ca
  4. 27 Apr, 2008 1 commit
    • Cosimo Cecchi's avatar
      Report user cancel when all the files we're about to trash or delete are · dbd34bda
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_files),
      	(trash_files), (delete_job):
      	Report user cancel when all the files we're about to trash or delete
      	are skipped in the operation. This allows to use the same selection for
      	requesting another deletion from the view. (#519746).
      
      svn path=/trunk/; revision=14106
      dbd34bda
  5. 04 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Inhibit autorun in mount callbacks after finishing mounts rather than · 00a42fe8
      Christian Neumair authored
      2008-04-04  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c (volume_mount_cb),
      	(nautilus_file_operations_mount_volume):
      	* libnautilus-private/nautilus-file-operations.h:
      	* libnautilus-private/nautilus-mime-actions.c
      	(activation_mount_not_mounted_callback),
      	(activation_mount_not_mounted):
      	* src/nautilus-application.c (startup_volume_mount_cb),
      	(automount_all_volumes), (volume_added_callback):
      	* src/nautilus-places-sidebar.c (open_selected_bookmark),
      	(mount_shortcut_cb):
      	* src/nautilus-window-manage-views.c (mount_not_mounted_callback),
      	(got_file_info_for_view_selection_callback):
      	Inhibit autorun in mount callbacks after finishing mounts rather than
      	before mounting.
      
      	It is neccessary because the mount may take a very long time (floppy,
      	password prompt), which may take longer than the inhibition timeout.
      
      	This approach works because with the current HAL volume monitor
      	implementation, GVolumeMonitor signal emission is scheduled, while the
      	mount callbacks are invoked synchronously.
      
      	This should also fix the not working inhibition on startup, which
      	could happen because parallel mounts in the background and the rest of
      	the startup process eat resources, so the mounts may also take longer
      	than the inhibition timeout.
      
      svn path=/trunk/; revision=14034
      00a42fe8
  6. 01 Apr, 2008 1 commit
    • Cosimo Cecchi's avatar
      Do not use contractions in strings. (#145356). · 10053a33
      Cosimo Cecchi authored
      2008-04-01  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_dir),
      	(prompt_empty_trash), (verify_destination), (copy_move_directory),
      	(remove_target_recursively), (copy_move_file):
      	* libnautilus-private/nautilus-mime-actions.c:
      	(report_broken_symbolic_link), (activate_files):
      	* libnautilus-private/nautilus-program-choosing.c:
      	(application_cannot_open_location), (nautilus_launch_application),
      	(nautilus_launch_desktop_file):
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_loading_directory),
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/file-manager/fm-properties-window.c:
      	(fm_properties_window_drag_data_received),
      	(create_permissions_page):
      	* src/nautilus-application.c: (nautilus_application_startup):
      	* src/nautilus-connect-server-dialog-main.c:
      	(display_error_dialog):
      	* src/nautilus-connect-server-dialog.c: (connect_to_server):
      	* src/nautilus-emblem-sidebar.c:
      	(nautilus_emblem_sidebar_delete_cb), (rename_dialog_response_cb):
      	* src/nautilus-information-panel.c: (receive_dropped_uri_list):
      	* src/nautilus-property-browser.c: (remove_pattern),
      	(remove_emblem), (add_pattern_to_browser):
      	* src/nautilus-window-manage-views.c:
      	(display_view_selection_failure):
      	Do not use contractions in strings. (#145356).
      
      svn path=/trunk/; revision=14017
      10053a33
  7. 31 Mar, 2008 1 commit
    • Cosimo Cecchi's avatar
      Do not ask twice if we want to empty the trash when unmounting a volume. · 07810ad9
      Cosimo Cecchi authored
      2008-04-01  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c:
      	(nautilus_file_operations_unmount_mount), (empty_trash_job),
      	(nautilus_file_operations_empty_trash):
      	Do not ask twice if we want to empty the trash when unmounting
      	a volume. (#525269).
      
      svn path=/trunk/; revision=14015
      07810ad9
  8. 28 Mar, 2008 5 commits
  9. 23 Mar, 2008 1 commit
    • Christian Neumair's avatar
      Fix compiler warnings about unused value by casting va_arg calls with · da4c64e2
      Christian Neumair authored
      2008-03-23  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c
      	(custom_full_name_skip), (custom_basename_skip),
      	(custom_size_skip), (custom_time_skip), (custom_mount_skip):
      	Fix compiler warnings about unused value by casting va_arg calls with
      	unused return values to void. (#523908).
      
      svn path=/trunk/; revision=13975
      da4c64e2
  10. 07 Mar, 2008 1 commit
    • Cosimo Cecchi's avatar
      Fix a crash due to a missing NULL check (#520947). · 05165ece
      Cosimo Cecchi authored
      2008-03-07  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c:
      	(callback_for_move_to_trash):
      	Fix a crash due to a missing NULL check (#520947).
      
      svn path=/trunk/; revision=13897
      05165ece
  11. 06 Mar, 2008 1 commit
  12. 21 Feb, 2008 1 commit
    • David Zeuthen's avatar
      Use g_volume_should_automount() to determine if we should autorun programs · 00e59a6b
      David Zeuthen authored
      2008-02-21  David Zeuthen  <davidz@redhat.com>
      
      	* libnautilus-private/nautilus-autorun.c: (should_autorun_mount):
      	Use g_volume_should_automount() to determine if we should autorun
      	programs on a mount.
      
      	* libnautilus-private/nautilus-directory-async.c:
      	(nautilus_directory_set_up_request),
      	(nautilus_async_destroying_file), (lacks_filesystem_info),
      	(wants_filesystem_info), (request_is_satisfied),
      	(directory_count_start), (mime_list_start),
      	(filesystem_info_cancel), (filesystem_info_stop),
      	(filesystem_info_state_free), (got_filesystem_info),
      	(query_filesystem_info_callback), (filesystem_info_start),
      	(start_or_stop_io), (nautilus_directory_cancel),
      	(cancel_filesystem_info_for_file), (cancel_loading_attributes),
      	(nautilus_directory_cancel_loading_file_attributes):
      	* libnautilus-private/nautilus-directory-private.h:
      	* libnautilus-private/nautilus-file-attributes.h: Add new
      	filesystem info attribute; right now two bits in NautilusFile's
      	private structure are set; the filesystem::use-preview and
      	filesystem:readonly.
      
      	* libnautilus-private/nautilus-file-operations.c:
      	(nautilus_file_operations_mount_volume):
      	* src/nautilus-places-sidebar.c: (open_selected_bookmark),
      	(mount_shortcut_cb): Don't inhibit automount from
      	nautilus_file_operations_mount_volume() because then everything
      	will be inhibited as the mount_added callback use it as
      	well. Rather, move the call to inhibit out to the proper call
      	sites.
      
      	* libnautilus-private/nautilus-file-private.h:
      	* libnautilus-private/nautilus-file.c:
      	(nautilus_file_get_filesystem_use_preview),
      	(nautilus_file_should_show_thumbnail),
      	(get_speed_tradeoff_preference_for_file),
      	(nautilus_file_get_mount):
      	* libnautilus-private/nautilus-file.h:
      	* src/file-manager/fm-directory-view.c: (load_directory):
      	* src/file-manager/fm-icon-view.c: (should_preview_sound):
      	* src/nautilus-window-manage-views.c: (update_for_new_location):
      	Use the new filesystem::use-preview hint to determine if we should
      	preview non-native files (such as gphoto2:// and cdda://
      	mounts). 
      
      
      svn path=/trunk/; revision=13795
      00e59a6b
  13. 20 Feb, 2008 1 commit
  14. 19 Feb, 2008 2 commits
    • Cosimo Cecchi's avatar
      Reset selection_was_removed in FMDirectoryView if the user cancels the · 69a8b942
      Cosimo Cecchi authored
      2008-02-19  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c:
      	(delete_job_done), (delete_job), (trash_or_delete_internal),
      	(callback_for_move_to_trash), (nautilus_file_operations_copy_move):
      	* libnautilus-private/nautilus-file-operations.h:
      	* src/file-manager/fm-directory-view.c:
      	(trash_or_delete_selected_files), (trash_or_delete_done_cb),
      	(trash_or_delete_files), (action_location_trash_callback):
      	Reset selection_was_removed in FMDirectoryView if the user
      	cancels the deletion from trash (#337937).
      
      svn path=/trunk/; revision=13772
      69a8b942
    • Alexander Larsson's avatar
      Removed unused files. (#515259) · 33fad395
      Alexander Larsson authored
      2008-02-19  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/Makefile.am:
              * libnautilus-private/nautilus-file-operations-progress-icons.h:
              * libnautilus-private/nautilus-file-operations-progress.[ch]:
      	Removed unused files. (#515259)
      	
              * libnautilus-private/nautilus-file-operations.c:
      	Don't include removed file
      
      
      
      svn path=/trunk/; revision=13769
      33fad395
  15. 14 Feb, 2008 3 commits
  16. 13 Feb, 2008 2 commits
    • Alexander Larsson's avatar
      Add paused status to progress infos and use it to avoid poping up the · 6a08b24c
      Alexander Larsson authored
      2008-02-13  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-progress-info.[ch]:
              * libnautilus-private/nautilus-file-operations.c:
      	Add paused status to progress infos and use it
      	to avoid poping up the progress dialog while dialogs
      	are up. (#512406)
      	Patch from Cosimo Cecchi
      
      
      svn path=/trunk/; revision=13741
      6a08b24c
    • Alexander Larsson's avatar
      Don't free NULL GError. · 16c058b3
      Alexander Larsson authored
      2008-02-13  Alexander Larsson  <alexl@redhat.com>
      
      	* libnautilus-private/nautilus-file-operations.c (verify_destination):
      	Don't free NULL GError.
      
      
      svn path=/trunk/; revision=13732
      16c058b3
  17. 12 Feb, 2008 1 commit
    • Cosimo Cecchi's avatar
      Remove unneeded gnome-vfs includes. · 2c4eea1b
      Cosimo Cecchi authored
      2008-02-12  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c:
      	Remove unneeded gnome-vfs includes.
      
      svn path=/trunk/; revision=13731
      2c4eea1b
  18. 11 Feb, 2008 2 commits
    • Alexander Larsson's avatar
      Make progress setting be ratio based and not percent based and then ensure · 057c7f82
      Alexander Larsson authored
      2008-02-11  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-progress-info.[ch]:
              * libnautilus-private/nautilus-file-operations.c:
      	Make progress setting be ratio based and not
      	percent based and then ensure we handle division
      	by zero correctly in all cases.
      
      
      
      svn path=/trunk/; revision=13725
      057c7f82
    • Alexander Larsson's avatar
      Update for new gio mount flags argument · 0082cd73
      Alexander Larsson authored
      2008-02-11  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-file-operations.c:
              * libnautilus-private/nautilus-mime-actions.c:
              * libnautilus-private/nautilus-vfs-file.c:
              * src/nautilus-application.c:
              * src/nautilus-window-manage-views.c:
      	Update for new gio mount flags argument
      
      
      svn path=/trunk/; revision=13724
      0082cd73
  19. 05 Feb, 2008 1 commit
    • Alexander Larsson's avatar
      Escape characters that won't work in GMarkup. · 107a0cd6
      Alexander Larsson authored
      2008-02-05  Alexander Larsson  <alexl@redhat.com>
      
      	* libnautilus-private/nautilus-file-operations.c (custom_basename_to_string):
      	Escape characters that won't work in GMarkup.
      
      
      svn path=/trunk/; revision=13695
      107a0cd6
  20. 04 Feb, 2008 1 commit
  21. 30 Jan, 2008 1 commit
    • Alexander Larsson's avatar
      Add functions to inhibit autorun for a volume or for the volume of a file. · 075ab7a0
      Alexander Larsson authored
      2008-01-30  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-autorun.[ch]:
      	Add functions to inhibit autorun for a volume
      	or for the volume of a file.
      	
              * src/nautilus-application.c:
      	Convert automount code to new way to inhibit autorun.
      	
              * libnautilus-private/nautilus-file-operations.c:
              * libnautilus-private/nautilus-mime-actions.c:
              * libnautilus-private/nautilus-vfs-file.c:
              * src/nautilus-window-manage-views.c:
      	Inhibit autorun if we manually mount stuff.
      
      
      svn path=/trunk/; revision=13674
      075ab7a0
  22. 29 Jan, 2008 1 commit
    • Alexander Larsson's avatar
      Fix string wrt plural · 4d61cdb7
      Alexander Larsson authored
      2008-01-29  Alexander Larsson  <alexl@redhat.com>
      
      	* libnautilus-private/nautilus-file-operations.c (report_link_progress):
      	Fix string wrt plural
      
      
      
      svn path=/trunk/; revision=13668
      4d61cdb7
  23. 28 Jan, 2008 1 commit
  24. 25 Jan, 2008 1 commit
  25. 23 Jan, 2008 1 commit
    • Alexander Larsson's avatar
      Don't leak enumerators · 699de191
      Alexander Larsson authored
      2008-01-23  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-file-operations.c:
      	Don't leak enumerators
      	
              * libnautilus-private/nautilus-trash-monitor.c:
      	Don't leak file info
      
      	Fixes from Matthias Clasen
      
      
      svn path=/trunk/; revision=13643
      699de191
  26. 22 Jan, 2008 2 commits
    • Alexander Larsson's avatar
      Clean up strings for l10n. (#510327) · 5269cb7c
      Alexander Larsson authored
      2008-01-22  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/apps_nautilus_preferences.schemas.in:
              * libnautilus-private/nautilus-file-operations.c:
              * src/Nautilus_shell.server.in:
              * src/file-manager/fm-directory-view.c:
              * src/file-manager/fm-properties-window.c:
              * src/nautilus-connect-server-dialog-main.c:
              * src/nautilus-file-management-properties.glade:
              * src/nautilus-navigation-window-menus.c:
      	Clean up strings for l10n. (#510327)
      
      
      svn path=/trunk/; revision=13635
      5269cb7c
    • Alexander Larsson's avatar
      Use thousands separators (#41455) · 60b242bf
      Alexander Larsson authored
      2008-01-22  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-file-operations.c:
              * libnautilus-private/nautilus-file.c:
              * libnautilus-private/nautilus-progress-info.c:
              * src/file-manager/fm-directory-view.c:
              * src/file-manager/fm-properties-window.c:
      	Use thousands separators (#41455)
      
      
      svn path=/trunk/; revision=13634
      60b242bf
  27. 14 Jan, 2008 1 commit
    • Alexander Larsson's avatar
      Add check_trash arg to nautilus_file_operations_unmount_mount. Add · 2761f4f9
      Alexander Larsson authored
      2008-01-14  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-file-operations.[ch]:
      	Add check_trash arg to nautilus_file_operations_unmount_mount.
      	Add nautilus_file_operations_mount_volume().
      	
              * libnautilus-private/nautilus-desktop-icon-file.c:
              * src/nautilus-places-sidebar.c:
              * src/file-manager/fm-tree-view.c:
      	Update to API change.
      	
              * data/nautilus.xml.in:
              * libnautilus-private/Makefile.am:
              * libnautilus-private/apps_nautilus_preferences.schemas.in:
              * libnautilus-private/nautilus-autorun.[ch]: Added.
              * libnautilus-private/nautilus-global-preferences.[ch]:
              * src/nautilus-application.c:
              * src/nautilus-file-management-properties.c:
              * src/nautilus-file-management-properties.glade:
      	Add new autorun setup (by David Zeuthen)
      
      
      svn path=/trunk/; revision=13594
      2761f4f9
  28. 09 Jan, 2008 2 commits
  29. 08 Jan, 2008 1 commit
    • Alexander Larsson's avatar
      Implement some missing mount/unmount functionallity. Patch from Tomas · 0059140a
      Alexander Larsson authored
      2008-01-08  Alexander Larsson  <alexl@redhat.com>
      
              * libnautilus-private/nautilus-desktop-icon-file.c:
              * libnautilus-private/nautilus-file-operations.c:
              * libnautilus-private/nautilus-vfs-file.c:
      	Implement some missing mount/unmount functionallity.
      	Patch from Tomas Bzatek <tbzatek@redhat.com>
      
      
      svn path=/trunk/; revision=13571
      0059140a