1. 08 May, 2008 2 commits
    • Cosimo Cecchi's avatar
      Plugged some leaks around. Cleaned up this bit of code. · 0b7f4638
      Cosimo Cecchi authored
      2008-05-09  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-dnd.c:
      	(nautilus_drag_file_local_internal), (nautilus_drag_drag_data_get):
      	* libnautilus-private/nautilus-open-with-dialog.c:
      	(add_or_find_application):
      	* libnautilus-private/nautilus-program-choosing.c:
      	(nautilus_launch_application):
      	* src/nautilus-sidebar-title.c: (update_icon):
      	* src/nautilus-spatial-window.c:
      	(got_file_info_for_location_menu_callback):
      	* libnautilus-private/nautilus-file.c: (get_custom_icon):
      	Plugged some leaks around.
      	* libnautilus-private/nautilus-file.c: (is_uri_relative):
      	Cleaned up this bit of code.
      
      	Bug #532126.
      
      svn path=/trunk/; revision=14149
      0b7f4638
    • Federico Mena Quintero's avatar
      bgo364843 - Don't exceed max path len when forming filenames for duplicates · 0e85321f
      Federico Mena Quintero authored
      2008-05-08  Federico Mena Quintero  <federico@novell.com>
      
      	http://bugzilla.gnome.org/show_bug.cgi?id=364843
      
      
      
      	Keep the generated names for "reallylongfilename (copy).txt" from
      	overflowing the maximum allowed length for path names.
      
      	Original patch by Dave Camp <campd@campd.org>
      
      	* libnautilus-private/nautilus-file-operations.c
      	(shorten_utf8_string): New function; takes an UTF8 string and
      	hygienically truncates it to a given number of bytes.
      	(get_link_name): Ensure the final name doesn't exceed a maximum length.
      	(make_next_duplicate_name): Likewise.
      	(get_max_name_length): Wrapper around pathconf() for basename lengths.
      	(get_unique_target_file): Use a maximum length for the target name.
      	(get_target_file_for_link): Likewise.
      Signed-off-by: default avatarFederico Mena Quintero <federico@gnu.org>
      
      svn path=/trunk/; revision=14147
      0e85321f
  2. 07 May, 2008 1 commit
  3. 06 May, 2008 1 commit
    • Christian Neumair's avatar
      Wrap to next row/column when pressing arrow key, except if a11y is used. · f9be809b
      Christian Neumair authored
      2008-05-06  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(next_row_leftmost), (previous_row_rightmost),
      	(next_column_highest), (previous_column_lowest),
      	(last_column_lowest), (keyboard_end), (keyboard_arrow_key),
      	(keyboard_right), (keyboard_left), (keyboard_down), (keyboard_up):
      	Wrap to next row/column when pressing arrow key, except if a11y is
      	used. Fixes #526802.
      	For vertical layout, make the "End" key select bottom item in last
      	column, instead of the last item in the bottom row.
      
      svn path=/trunk/; revision=14143
      f9be809b
  4. 05 May, 2008 7 commits
  5. 03 May, 2008 2 commits
  6. 01 May, 2008 1 commit
  7. 30 Apr, 2008 4 commits
    • Cosimo Cecchi's avatar
      Do not unref the file info before checking the mime type, otherwise the · 568b6d29
      Cosimo Cecchi authored
      2008-04-30  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-property-browser.c: (ensure_file_is_image):
      	Do not unref the file info before checking the mime type,
      	otherwise the mime_type string will be invalidated. (#530549).
      
      svn path=/trunk/; revision=14117
      568b6d29
    • Andrew Walton's avatar
      Remove false dependency for ESound. Closes bug #311445. · f5c16e3d
      Andrew Walton authored
      2008-04-30  A. Walton  <awalton@gnome.org>
      
      	* configure.in:
      	* src/file-manager/fm-icon-view.c:
      	Remove false dependency for ESound. Closes bug #311445.
      
      
      svn path=/trunk/; revision=14115
      f5c16e3d
    • Andrew Walton's avatar
      Replace g_return_*() with g_assert() in private, internal functions. · a9b02ab3
      Andrew Walton authored
      2008-04-30  A. Walton  <awalton@gnome.org>
      
      	* libnautilus-private/nautilus-clipboard.c:
      	* libnautilus-private/nautilus-directory-async.c:
      	* libnautilus-private/nautilus-directory.c:
      	* libnautilus-private/nautilus-entry.c:
      	* libnautilus-private/nautilus-file.c:
      	* libnautilus-private/nautilus-horizontal-splitter.c:
      	* libnautilus-private/nautilus-icon-canvas-item.c:
      	* libnautilus-private/nautilus-icon-container.c:
      	* libnautilus-private/nautilus-metafile.c:
      	* libnautilus-private/nautilus-users-groups-cache.c:
      	* libnautilus-private/nautilus-vfs-directory.c:
      	* src/nautilus-emblem-sidebar.c:
      	* src/nautilus-file-management-properties.c:
      	* src/nautilus-window-manage-views.c:
      	* src/nautilus-window.c:
      	* src/nautilus-zoom-control.c:
      	Replace g_return_*() with g_assert() in private, internal
      	functions. Closes #530321.
      
      
      svn path=/trunk/; revision=14114
      a9b02ab3
    • David Zeuthen's avatar
      Fix how autorunning works. Instead of inhibiting autorunning every time we · 0e85a1ca
      David Zeuthen authored
      2008-04-29  David Zeuthen  <davidz@redhat.com>
      
              * libnautilus-private/nautilus-autorun.c:
              * libnautilus-private/nautilus-autorun.h:
              * libnautilus-private/nautilus-file-operations.c:
              (volume_mount_cb), (nautilus_file_operations_mount_volume):
              * libnautilus-private/nautilus-file-operations.h:
              * libnautilus-private/nautilus-mime-actions.c:
              (activation_mount_not_mounted_callback):
              * libnautilus-private/nautilus-vfs-file.c:
              (vfs_file_mount_callback):
              * src/nautilus-application.c: (startup_volume_mount_cb),
              (volume_added_callback):
              * src/nautilus-places-sidebar.c: (open_selected_bookmark),
              (mount_shortcut_cb):
              * src/nautilus-window-manage-views.c: (mount_not_mounted_callback):
              Fix how autorunning works. Instead of inhibiting autorunning
              every time we run something, we turn things around and instead
              allow automounting only in the instance where Nautilus automounted
              something itself. So in essence this patch is s/inhibit/allow/.
              This fixes an annoying problem where Nautilus would do autorun
              everytime something was mounted even from the command line. A
              consequence of this are windows popping up and other annoyances.
              This patch fixes that problem.
      
              * src/nautilus-x-content-bar.c: (nautilus_x_content_bar_init):
              Make sure the label is ellipsized.
      
      
      svn path=/trunk/; revision=14112
      0e85a1ca
  8. 27 Apr, 2008 7 commits
    • Cosimo Cecchi's avatar
      Report user cancel when all the files we're about to trash or delete are · dbd34bda
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* libnautilus-private/nautilus-file-operations.c: (delete_files),
      	(trash_files), (delete_job):
      	Report user cancel when all the files we're about to trash or delete
      	are skipped in the operation. This allows to use the same selection for
      	requesting another deletion from the view. (#519746).
      
      svn path=/trunk/; revision=14106
      dbd34bda
    • Christian Neumair's avatar
      Quote schema. Fixes #522029. · 082c843c
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* src/nautilus-window-manage-views.c
      	(display_view_selection_failure):
      	Quote schema. Fixes #522029.
      
      svn path=/trunk/; revision=14104
      082c843c
    • Cosimo Cecchi's avatar
      Always use single click policy in the Places sidebar. (#355760). · 1699ec31
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-places-sidebar.c: (nautilus_places_sidebar_init):
      	Always use single click policy in the Places sidebar. (#355760).
      
      svn path=/trunk/; revision=14102
      1699ec31
    • Cosimo Cecchi's avatar
      Always properly remember window size, also in the case the window is · 5bbc8307
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-navigation-window.c:
      	(nautilus_navigation_window_save_geometry):
      	Always properly remember window size, also in the case the window is
      	closed being maximized. (#385176).
      
      svn path=/trunk/; revision=14100
      5bbc8307
    • Cosimo Cecchi's avatar
      Reverse the order in which the keybindings are processed by the · 60328a43
      Cosimo Cecchi authored
      2008-04-27  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* src/nautilus-window.c: (nautilus_window_key_press_event):
      	Reverse the order in which the keybindings are processed by the
      	NautilusWindow, and use the same approach as GEdit.
      	This fixes some bugs where the GtkWindow accelerators were executed
      	before the focused widget one. (#314431).
      
      svn path=/trunk/; revision=14098
      60328a43
    • Christian Neumair's avatar
      Do not activate twice if the activated paths are already selected. Always · c2305aff
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* src/file-manager/fm-list-view.c (button_press_callback):
      	Do not activate twice if the activated paths are already selected.
      	Always expand when an expander is clicked, even when the activation
      	paths are already selected. Add 4 to the GtkTreeView's claimed
      	expander size, which accounts for hard coded internal GtkTreeView
      	expander padding. Fixes #448562. Thanks to Paweł Paprota.
      
      svn path=/trunk/; revision=14095
      c2305aff
    • Andrew Walton's avatar
      reviewed by: Christian Neumair · f78a9799
      Andrew Walton authored
      2008-04-26  A. Walton  <awalton@gnome.org>
      
      	reviewed by: Christian Neumair
      
      	* libnautilus-private/nautilus-file-private.h:
      	* libnautilus-private/nautilus-file-utilities.c
      	(nautilus_compute_title_for_location):
      	* libnautilus-private/nautilus-file.c (update_info_internal),
      	(nautilus_file_get_description):
      	* libnautilus-private/nautilus-file.h:
      	Use standard::description in the window title when it's available.
      	Closes bug #516007.
      
      
      svn path=/trunk/; revision=14094
      f78a9799
  9. 26 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Properly handle selection changes when using keyboard navigation. We did · a6f7e3a2
      Christian Neumair authored
      2008-04-27  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-icon-container.c
      	(emit_atk_focus_tracker_notify), (set_keyboard_focus),
      	(select_range), (select_one_unselect_others), (rubberband_select),
      	(keyboard_move_to):
      	Properly handle selection changes when using keyboard navigation. We
      	did not emit a "selection-change" signal when keyboard rubberbanding
      	was used, and all except one icon were deselected. Fixes #509432.
      	Thanks to Paweł Paprota.
      
      svn path=/trunk/; revision=14092
      a6f7e3a2
  10. 23 Apr, 2008 2 commits
  11. 21 Apr, 2008 4 commits
  12. 15 Apr, 2008 1 commit
  13. 10 Apr, 2008 4 commits
    • A. Walton's avatar
      Remove GSequence directory and files (for real this time). · 23b84c87
      A. Walton authored
      2008-04-10  A. Walton  <awalton@svn.gnome.org>
      	Remove GSequence directory and files (for real this time).
      
      
      svn path=/trunk/; revision=14064
      23b84c87
    • A. Walton's avatar
      Remove GSequence hack as it is no longer necessary; we require a newer · 85427124
      A. Walton authored
      2008-04-10  A. Walton  <awalton@svn.gnome.org>
      
      	* configure.in:
      	* cut-n-paste-code/Makefile.am:
      	* cut-n-paste-code/gsequence/Makefile.am:
      	* cut-n-paste-code/gsequence/gsequence.c:
      	* cut-n-paste-code/gsequence/gsequence.h:
      	* src/Makefile.am:
      	* src/file-manager/fm-list-model.c:
      	Remove GSequence hack as it is no longer necessary;
      	we require a newer GLib in order to support GIO.
      	More work towards bug #520773.
      
      
      svn path=/trunk/; revision=14062
      85427124
    • A. Walton's avatar
      Remove the first-time-druid dead code (#520773). · 6eb74f59
      A. Walton authored
      2008-04-10  A. Walton  <awalton@svn.gnome.org>
      
      	* src/Makefile.am:
      	* src/nautilus-application.c: (nautilus_application_startup):
      	* src/nautilus-application.h:
      	* src/nautilus-first-time-druid.c:
      	* src/nautilus-first-time-druid.h:
      	* src/nautilus-main.c: (main):
      	Remove the first-time-druid dead code (#520773).
      
      
      svn path=/trunk/; revision=14061
      6eb74f59
    • Cosimo Cecchi's avatar
      Add a missing comma to fix build with Autoconf 2.62. (#527315). · fd9258ae
      Cosimo Cecchi authored
      2008-04-10  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* configure.in: Add a missing comma to fix build with
      	Autoconf 2.62. (#527315).
      
      svn path=/trunk/; revision=14054
      fd9258ae
  14. 08 Apr, 2008 1 commit
  15. 07 Apr, 2008 1 commit
  16. 06 Apr, 2008 1 commit
    • Christian Neumair's avatar
      Remove show/hide buttons. The entries can be toggled directly using mouse · cb037e32
      Christian Neumair authored
      2008-04-07  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-column-chooser.c (update_buttons),
      	(add_buttons):
      	Remove show/hide buttons. The entries can be toggled directly using
      	mouse or keyboard. Do not remove buttons to move entries, since
      	list DND may not be obvious for some users (#514394). Thanks to Marcin
      	Galazka.
      
      svn path=/trunk/; revision=14044
      cb037e32