Skip to content

GitLab

Commit 7c1de70b authored by John Sullivan's avatar John Sullivan
Browse files

Activate on single-click in list view.

parent 8080e76f
Hide whitespace changes
Inline Side-by-side
ChangeLog-20000414
View file @ 7c1de70b
2000-01-21 John Sullivan <sullivan@eazel.com>
Made list view activation work on single click, like icon view.
* libnautilus/gtkflist.c
(struct _GtkFListDetails): Added single_click_mode
and button_down_time, renamed dnd_select_pending_row to
button_down_row.
Added #define MAX_CLICK_TIME, copied from gnome_icon_container.
(gtk_flist_initialize): Initialize single_click_mode to TRUE
(activate_row): New function, extracts code needed to activate
an item from its row number.
(gtk_flist_button_press): Save button_down_time, save
button_down_row more often, use activate_row () for double-click.
(gtk_flist_button_release): Activate on single click if single_click_mode
is true, selection isn't being extended, mouse hasn't moved to a different
row, and not too much time has passed.
(gtk_flist_motion): Deploy button_down_row name change.
2000-01-20 Andy Hertzfeld <andy@eazel.com>
* libnautilus/gnome-icon-container.c:
......@@ -9,8 +29,9 @@
* src/ntl-window-msgs.c:
Missed piece in last commit.
I added this entry for Elliot, who made this change three
hours later than his last checkin.
John added this entry for Elliot, who made this change three
hours later than his last checkin. The comment is from the
cvs commit.
2000-01-20 Darin Adler <darin@eazel.com>
......
libnautilus-extensions/gtkflist.c
View file @ 7c1de70b
......@@ -24,21 +24,29 @@
struct _GtkFListDetails
{
/* Preferences */
gboolean single_click_mode;
/* The anchor row for range selections */
int anchor_row;
/* Mouse button and position saved on button press */
/* Mouse information saved on button press */
int dnd_press_button;
int dnd_press_x, dnd_press_y;
int button_down_row;
guint32 button_down_time;
/* Delayed selection information */
int dnd_select_pending;
guint dnd_select_pending_state;
int dnd_select_pending_row;
};
#define ARRAY_LENGTH(a) (sizeof(a) / sizeof((a)[0]))
/* maximum amount of milliseconds the mouse button is allowed to stay down and still be considered a click */
#define MAX_CLICK_TIME 1500
enum {
ROW_POPUP_MENU,
EMPTY_POPUP_MENU,
......@@ -56,6 +64,8 @@ static GtkTargetEntry gtk_flist_dnd_target_table[] = {
{ "application/x-color", 0, TARGET_COLOR }
};
static void activate_row (GtkFList *flist, gint row);
static void gtk_flist_initialize_class (GtkFListClass *class);
static void gtk_flist_initialize (GtkFList *flist);
......@@ -160,6 +170,9 @@ gtk_flist_initialize (GtkFList *flist)
flist->details = g_new0 (GtkFListDetails, 1);
flist->details->anchor_row = -1;
/* This should be read from preferences */
flist->details->single_click_mode = TRUE;
/* GtkCList does not specify pointer motion by default */
gtk_widget_add_events (GTK_WIDGET (flist), GDK_POINTER_MOTION_MASK);
......@@ -172,6 +185,18 @@ gtk_flist_initialize (GtkFList *flist)
GDK_ACTION_COPY);
}
static void
activate_row (GtkFList *flist, gint row)
{
GtkCListRow *elem;
elem = g_list_nth (GTK_CLIST (flist)->row_list,
row)->data;
gtk_signal_emit (GTK_OBJECT (flist),
flist_signals[ACTIVATE],
elem->data);
}
static gboolean
row_selected (GtkFList *flist, gint row)
{
......@@ -258,17 +283,23 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
return NAUTILUS_CALL_PARENT_CLASS (GTK_WIDGET_CLASS, button_press_event, (widget, event));
on_row = gtk_clist_get_selection_info (clist, event->x, event->y, &row, &col);
flist->details->button_down_time = event->time;
switch (event->type) {
case GDK_BUTTON_PRESS:
if (event->button == 1 || event->button == 2) {
if (on_row) {
/* Save the clicked row for DnD and single-click activate */
flist->details->button_down_row = row;
/* Save the mouse info for DnD */
flist->details->dnd_press_button = event->button;
flist->details->dnd_press_x = event->x;
flist->details->dnd_press_y = event->y;
/* Handle selection */
if ((row_selected (flist, row)
......@@ -277,7 +308,6 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
&& !(event->state & GDK_SHIFT_MASK))) {
flist->details->dnd_select_pending = TRUE;
flist->details->dnd_select_pending_state = event->state;
flist->details->dnd_select_pending_row = row;
}
select_row (flist, row, event->state);
......@@ -304,17 +334,15 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
case GDK_2BUTTON_PRESS:
if (event->button == 1) {
GtkCListRow *elem;
flist->details->dnd_select_pending = FALSE;
flist->details->dnd_select_pending_state = 0;
if (on_row) {
elem = g_list_nth (GTK_CLIST (flist)->row_list,
row)->data;
gtk_signal_emit (GTK_OBJECT (flist),
flist_signals[ACTIVATE],
elem->data);
/* Activate on double-click even if single_click_mode
* is set, so second click doesn't get passed to child
* directory.
*/
activate_row (flist, row);
}
retval = TRUE;
......@@ -361,12 +389,29 @@ gtk_flist_button_release (GtkWidget *widget, GdkEventButton *event)
flist->details->dnd_press_y = 0;
if (on_row) {
/* Clean up after abortive drag-and-drop attempt (since user can't
* reorder list view items, releasing mouse in list view cancels
* drag-and-drop possibility).
*/
if (flist->details->dnd_select_pending) {
/* select_row (flist, row, flist->details->dnd_select_pending_state); */
flist->details->dnd_select_pending = FALSE;
flist->details->dnd_select_pending_state = 0;
}
/* Activate on single click if not extending selection, mouse hasn't moved to
* a different row, and not too much time has passed.
*/
if (flist->details->single_click_mode &&
!(event->state & (GDK_CONTROL_MASK | GDK_SHIFT_MASK)))
{
gint elapsed_time = event->time - flist->details->button_down_time;
if (elapsed_time < MAX_CLICK_TIME && flist->details->button_down_row == row)
{
activate_row (flist, row);
}
}
retval = TRUE;
}
......@@ -406,7 +451,7 @@ gtk_flist_motion (GtkWidget *widget, GdkEventMotion *event)
if (flist->details->dnd_select_pending) {
select_row (flist,
flist->details->dnd_select_pending_row,
flist->details->button_down_row,
flist->details->dnd_select_pending_state);
flist->details->dnd_select_pending = FALSE;
......
libnautilus-private/gtkflist.c
View file @ 7c1de70b
......@@ -24,21 +24,29 @@
struct _GtkFListDetails
{
/* Preferences */
gboolean single_click_mode;
/* The anchor row for range selections */
int anchor_row;
/* Mouse button and position saved on button press */
/* Mouse information saved on button press */
int dnd_press_button;
int dnd_press_x, dnd_press_y;
int button_down_row;
guint32 button_down_time;
/* Delayed selection information */
int dnd_select_pending;
guint dnd_select_pending_state;
int dnd_select_pending_row;
};
#define ARRAY_LENGTH(a) (sizeof(a) / sizeof((a)[0]))
/* maximum amount of milliseconds the mouse button is allowed to stay down and still be considered a click */
#define MAX_CLICK_TIME 1500
enum {
ROW_POPUP_MENU,
EMPTY_POPUP_MENU,
......@@ -56,6 +64,8 @@ static GtkTargetEntry gtk_flist_dnd_target_table[] = {
{ "application/x-color", 0, TARGET_COLOR }
};
static void activate_row (GtkFList *flist, gint row);
static void gtk_flist_initialize_class (GtkFListClass *class);
static void gtk_flist_initialize (GtkFList *flist);
......@@ -160,6 +170,9 @@ gtk_flist_initialize (GtkFList *flist)
flist->details = g_new0 (GtkFListDetails, 1);
flist->details->anchor_row = -1;
/* This should be read from preferences */
flist->details->single_click_mode = TRUE;
/* GtkCList does not specify pointer motion by default */
gtk_widget_add_events (GTK_WIDGET (flist), GDK_POINTER_MOTION_MASK);
......@@ -172,6 +185,18 @@ gtk_flist_initialize (GtkFList *flist)
GDK_ACTION_COPY);
}
static void
activate_row (GtkFList *flist, gint row)
{
GtkCListRow *elem;
elem = g_list_nth (GTK_CLIST (flist)->row_list,
row)->data;
gtk_signal_emit (GTK_OBJECT (flist),
flist_signals[ACTIVATE],
elem->data);
}
static gboolean
row_selected (GtkFList *flist, gint row)
{
......@@ -258,17 +283,23 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
return NAUTILUS_CALL_PARENT_CLASS (GTK_WIDGET_CLASS, button_press_event, (widget, event));
on_row = gtk_clist_get_selection_info (clist, event->x, event->y, &row, &col);
flist->details->button_down_time = event->time;
switch (event->type) {
case GDK_BUTTON_PRESS:
if (event->button == 1 || event->button == 2) {
if (on_row) {
/* Save the clicked row for DnD and single-click activate */
flist->details->button_down_row = row;
/* Save the mouse info for DnD */
flist->details->dnd_press_button = event->button;
flist->details->dnd_press_x = event->x;
flist->details->dnd_press_y = event->y;
/* Handle selection */
if ((row_selected (flist, row)
......@@ -277,7 +308,6 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
&& !(event->state & GDK_SHIFT_MASK))) {
flist->details->dnd_select_pending = TRUE;
flist->details->dnd_select_pending_state = event->state;
flist->details->dnd_select_pending_row = row;
}
select_row (flist, row, event->state);
......@@ -304,17 +334,15 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
case GDK_2BUTTON_PRESS:
if (event->button == 1) {
GtkCListRow *elem;
flist->details->dnd_select_pending = FALSE;
flist->details->dnd_select_pending_state = 0;
if (on_row) {
elem = g_list_nth (GTK_CLIST (flist)->row_list,
row)->data;
gtk_signal_emit (GTK_OBJECT (flist),
flist_signals[ACTIVATE],
elem->data);
/* Activate on double-click even if single_click_mode
* is set, so second click doesn't get passed to child
* directory.
*/
activate_row (flist, row);
}
retval = TRUE;
......@@ -361,12 +389,29 @@ gtk_flist_button_release (GtkWidget *widget, GdkEventButton *event)
flist->details->dnd_press_y = 0;
if (on_row) {
/* Clean up after abortive drag-and-drop attempt (since user can't
* reorder list view items, releasing mouse in list view cancels
* drag-and-drop possibility).
*/
if (flist->details->dnd_select_pending) {
/* select_row (flist, row, flist->details->dnd_select_pending_state); */
flist->details->dnd_select_pending = FALSE;
flist->details->dnd_select_pending_state = 0;
}
/* Activate on single click if not extending selection, mouse hasn't moved to
* a different row, and not too much time has passed.
*/
if (flist->details->single_click_mode &&
!(event->state & (GDK_CONTROL_MASK | GDK_SHIFT_MASK)))
{
gint elapsed_time = event->time - flist->details->button_down_time;
if (elapsed_time < MAX_CLICK_TIME && flist->details->button_down_row == row)
{
activate_row (flist, row);
}
}
retval = TRUE;
}
......@@ -406,7 +451,7 @@ gtk_flist_motion (GtkWidget *widget, GdkEventMotion *event)
if (flist->details->dnd_select_pending) {
select_row (flist,
flist->details->dnd_select_pending_row,
flist->details->button_down_row,
flist->details->dnd_select_pending_state);
flist->details->dnd_select_pending = FALSE;
......
libnautilus/gtkflist.c
View file @ 7c1de70b
......@@ -24,21 +24,29 @@
struct _GtkFListDetails
{
/* Preferences */
gboolean single_click_mode;
/* The anchor row for range selections */
int anchor_row;
/* Mouse button and position saved on button press */
/* Mouse information saved on button press */
int dnd_press_button;
int dnd_press_x, dnd_press_y;
int button_down_row;
guint32 button_down_time;
/* Delayed selection information */
int dnd_select_pending;
guint dnd_select_pending_state;
int dnd_select_pending_row;
};
#define ARRAY_LENGTH(a) (sizeof(a) / sizeof((a)[0]))
/* maximum amount of milliseconds the mouse button is allowed to stay down and still be considered a click */
#define MAX_CLICK_TIME 1500
enum {
ROW_POPUP_MENU,
EMPTY_POPUP_MENU,
......@@ -56,6 +64,8 @@ static GtkTargetEntry gtk_flist_dnd_target_table[] = {
{ "application/x-color", 0, TARGET_COLOR }
};
static void activate_row (GtkFList *flist, gint row);
static void gtk_flist_initialize_class (GtkFListClass *class);
static void gtk_flist_initialize (GtkFList *flist);
......@@ -160,6 +170,9 @@ gtk_flist_initialize (GtkFList *flist)
flist->details = g_new0 (GtkFListDetails, 1);
flist->details->anchor_row = -1;
/* This should be read from preferences */
flist->details->single_click_mode = TRUE;
/* GtkCList does not specify pointer motion by default */
gtk_widget_add_events (GTK_WIDGET (flist), GDK_POINTER_MOTION_MASK);
......@@ -172,6 +185,18 @@ gtk_flist_initialize (GtkFList *flist)
GDK_ACTION_COPY);
}
static void
activate_row (GtkFList *flist, gint row)
{
GtkCListRow *elem;
elem = g_list_nth (GTK_CLIST (flist)->row_list,
row)->data;
gtk_signal_emit (GTK_OBJECT (flist),
flist_signals[ACTIVATE],
elem->data);
}
static gboolean
row_selected (GtkFList *flist, gint row)
{
......@@ -258,17 +283,23 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
return NAUTILUS_CALL_PARENT_CLASS (GTK_WIDGET_CLASS, button_press_event, (widget, event));
on_row = gtk_clist_get_selection_info (clist, event->x, event->y, &row, &col);
flist->details->button_down_time = event->time;
switch (event->type) {
case GDK_BUTTON_PRESS:
if (event->button == 1 || event->button == 2) {
if (on_row) {
/* Save the clicked row for DnD and single-click activate */
flist->details->button_down_row = row;
/* Save the mouse info for DnD */
flist->details->dnd_press_button = event->button;
flist->details->dnd_press_x = event->x;
flist->details->dnd_press_y = event->y;
/* Handle selection */
if ((row_selected (flist, row)
......@@ -277,7 +308,6 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
&& !(event->state & GDK_SHIFT_MASK))) {
flist->details->dnd_select_pending = TRUE;
flist->details->dnd_select_pending_state = event->state;
flist->details->dnd_select_pending_row = row;
}
select_row (flist, row, event->state);
......@@ -304,17 +334,15 @@ gtk_flist_button_press (GtkWidget *widget, GdkEventButton *event)
case GDK_2BUTTON_PRESS:
if (event->button == 1) {
GtkCListRow *elem;
flist->details->dnd_select_pending = FALSE;
flist->details->dnd_select_pending_state = 0;
if (on_row) {
elem = g_list_nth (GTK_CLIST (flist)->row_list,
row)->data;
gtk_signal_emit (GTK_OBJECT (flist),
flist_signals[ACTIVATE],
elem->data);
/* Activate on double-click even if single_click_mode
* is set, so second click doesn't get passed to child
* directory.
*/
activate_row (flist, row);
}
retval = TRUE;
......@@ -361,12 +389,29 @@ gtk_flist_button_release (GtkWidget *widget, GdkEventButton *event)
flist->details->dnd_press_y = 0;
if (on_row) {
/* Clean up after abortive drag-and-drop attempt (since user can't
* reorder list view items, releasing mouse in list view cancels
* drag-and-drop possibility).
*/
if (flist->details->dnd_select_pending) {
/* select_row (flist, row, flist->details->dnd_select_pending_state); */
flist->details->dnd_select_pending = FALSE;
flist->details->dnd_select_pending_state = 0;
}
/* Activate on single click if not extending selection, mouse hasn't moved to
* a different row, and not too much time has passed.
*/
if (flist->details->single_click_mode &&
!(event->state & (GDK_CONTROL_MASK | GDK_SHIFT_MASK)))
{
gint elapsed_time = event->time - flist->details->button_down_time;
if (elapsed_time < MAX_CLICK_TIME && flist->details->button_down_row == row)
{
activate_row (flist, row);
}
}
retval = TRUE;
}
......@@ -406,7 +451,7 @@ gtk_flist_motion (GtkWidget *widget, GdkEventMotion *event)
if (flist->details->dnd_select_pending) {
select_row (flist,
flist->details->dnd_select_pending_row,
flist->details->button_down_row,
flist->details->dnd_select_pending_state);
flist->details->dnd_select_pending = FALSE;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment