Commit 75d9047c authored by John Sullivan's avatar John Sullivan
Browse files

Added more bug numbers to FIXMEs. 49 to go.

	* components/services/install/lib/eazel-install-rpm-glue.c:
	(eazel_uninstall_downward_traverse):
	* libnautilus-extensions/nautilus-merged-directory.c:
	(nautilus_merged_directory_add_real_directory):
	* libnautilus-extensions/nautilus-mime-actions.c:
	(make_oaf_query_with_known_mime_type),
	(make_oaf_query_with_uri_scheme_only):
	* libnautilus-extensions/nautilus-preferences.c:
	(nautilus_preferences_set_string_list):
	* libnautilus-extensions/nautilus-program-chooser.c:
	(program_file_pair_compute_status), (get_supertype_from_file):
	* libnautilus-extensions/nautilus-scalable-font.c:
	(nautilus_scalable_font_measure_text):
	* libnautilus/nautilus-view.c: (view_frame_call_begin):
	* nautilus-installer/src/support.c: (create_pixmap),
	(create_image):
	* src/file-manager/fm-desktop-icon-view.c: (create_mount_link),
	(volume_unmounted_callback), (place_home_directory):
	* src/file-manager/fm-icon-view.c: (get_next_position),
	(play_file), (get_icon_text_callback):
	* src/file-manager/fm-list-view.c: (fm_list_view_initialize),
	(create_list), (fm_list_view_set_zoom_level),
	(fm_list_view_font_family_changed):
	* src/file-manager/nautilus-indexing-info.c:
	(nautilus_indexing_info_show_dialog):
	* src/nautilus-application.c: (nautilus_application_startup):
	* src/nautilus-first-time-druid.c:
	(next_proxy_configuration_page_callback), (initiate_file_download):
	* src/nautilus-property-browser.c: (add_background_to_browser):
	* src/nautilus-shell.c:
parent 7d9425e3
2000-08-29 John Sullivan <sullivan@eazel.com>
Added more bug numbers to FIXMEs. 49 to go.
* components/services/install/lib/eazel-install-rpm-glue.c:
(eazel_uninstall_downward_traverse):
* libnautilus-extensions/nautilus-merged-directory.c:
(nautilus_merged_directory_add_real_directory):
* libnautilus-extensions/nautilus-mime-actions.c:
(make_oaf_query_with_known_mime_type),
(make_oaf_query_with_uri_scheme_only):
* libnautilus-extensions/nautilus-preferences.c:
(nautilus_preferences_set_string_list):
* libnautilus-extensions/nautilus-program-chooser.c:
(program_file_pair_compute_status), (get_supertype_from_file):
* libnautilus-extensions/nautilus-scalable-font.c:
(nautilus_scalable_font_measure_text):
* libnautilus/nautilus-view.c: (view_frame_call_begin):
* nautilus-installer/src/support.c: (create_pixmap),
(create_image):
* src/file-manager/fm-desktop-icon-view.c: (create_mount_link),
(volume_unmounted_callback), (place_home_directory):
* src/file-manager/fm-icon-view.c: (get_next_position),
(play_file), (get_icon_text_callback):
* src/file-manager/fm-list-view.c: (fm_list_view_initialize),
(create_list), (fm_list_view_set_zoom_level),
(fm_list_view_font_family_changed):
* src/file-manager/nautilus-indexing-info.c:
(nautilus_indexing_info_show_dialog):
* src/nautilus-application.c: (nautilus_application_startup):
* src/nautilus-first-time-druid.c:
(next_proxy_configuration_page_callback), (initiate_file_download):
* src/nautilus-property-browser.c: (add_background_to_browser):
* src/nautilus-shell.c:
2000-08-29 Andy Hertzfeld <andy@eazel.com>
* src/nautilus-first-time-druid.c: (proxy_selection_changed),
......
......@@ -2008,7 +2008,7 @@ eazel_uninstall_downward_traverse (EazelInstall *service,
g_list_free (second_matches);
} else {
g_message ("D: must lookup %s", require_name[j]);
/* FIXME bugzilla.eazel.com 1539:
/* FIXME bugzilla.eazel.com 1541:
lookup package "p" that provides requires[j],
if packages that that require "p" are not in "packages"
don't add it, otherwise add to requires */
......
......@@ -485,13 +485,13 @@ nautilus_merged_directory_add_real_directory (NautilusMergedDirectory *merged,
"files_changed",
forward_files_changed_cover,
merged);
/* FIXME: Hook up the done_loading signal too? */
/* FIXME bugzilla.eazel.com 2540: Hook up the done_loading signal too? */
/* Add the directory to any extant monitors. */
g_hash_table_foreach (merged->details->monitors,
monitor_add_directory,
real_directory);
/* FIXME: Do we need to add the directory to callbacks too? */
/* FIXME bugzilla.eazel.com 2541: Do we need to add the directory to callbacks too? */
}
static void
......
......@@ -1169,7 +1169,7 @@ make_oaf_query_with_known_mime_type (const char *mime_type, const char *uri_sche
/* One of two possibilties */
/* FIXME: this comment is not very clear. */
/* FIXME bugzilla.eazel.com 2542: this comment is not very clear. */
/* 1 The mime type and URI scheme match the supported
attributes. */
......@@ -1261,7 +1261,7 @@ make_oaf_query_with_uri_scheme_only (const char *uri_scheme, GList *explicit_iid
*/
"AND (NOT bonobo:supported_mime_types.defined ()))"
/* FIXME: improve the comment explaining this. */
/* FIXME bugzilla.eazel.com 2542: improve the comment explaining this. */
/* This attribute allows uri schemes to be supported
even for unsupported mime types or no mime type. */
......
......@@ -773,7 +773,7 @@ nautilus_preferences_set_string_list (const char *name,
key = nautilus_user_level_manager_make_current_gconf_key (name);
g_assert (key != NULL);
/* FIXME: Make sure the preference value is indeed different
/* FIXME bugzilla.eazel.com 2543: Make sure the preference value is indeed different
before setting, like the other functions */
gconf_client_set_list (GLOBAL.gconf_client, key,
......
......@@ -102,7 +102,7 @@ program_file_pair_compute_status (ProgramFilePair *pair)
{
ProgramFileStatus new_status;
/* FIXME: Need to check whether it's the default or in short list for the supertype */
/* FIXME bugzilla.eazel.com 1459: Need to check whether it's the default or in short list for the supertype */
if (program_file_pair_is_default_for_file_type (pair)) {
new_status = PROGRAM_DEFAULT_FOR_TYPE;
} else if (program_file_pair_is_default_for_file (pair)) {
......@@ -194,7 +194,7 @@ program_file_pair_get_program_name_for_display (ProgramFilePair *pair)
static char *
get_supertype_from_file (NautilusFile *file)
{
/* FIXME: Needs implementation */
/* FIXME bugzilla.eazel.com 1459: Needs implementation */
return nautilus_file_get_string_attribute (file, "type");
}
......
......@@ -628,7 +628,7 @@ nautilus_scalable_font_measure_text (const NautilusScalableFont *font,
art_affine_identity (affine);
/* FIXME: We need to change rsvg_ft_render_string() to accept
/* FIXME bugzilla.eazel.com 2544: We need to change rsvg_ft_render_string() to accept
* a 'do_render' flag so that we can use to to compute metrics
* without actually having to render
*/
......
......@@ -485,13 +485,13 @@ nautilus_merged_directory_add_real_directory (NautilusMergedDirectory *merged,
"files_changed",
forward_files_changed_cover,
merged);
/* FIXME: Hook up the done_loading signal too? */
/* FIXME bugzilla.eazel.com 2540: Hook up the done_loading signal too? */
/* Add the directory to any extant monitors. */
g_hash_table_foreach (merged->details->monitors,
monitor_add_directory,
real_directory);
/* FIXME: Do we need to add the directory to callbacks too? */
/* FIXME bugzilla.eazel.com 2541: Do we need to add the directory to callbacks too? */
}
static void
......
......@@ -1169,7 +1169,7 @@ make_oaf_query_with_known_mime_type (const char *mime_type, const char *uri_sche
/* One of two possibilties */
/* FIXME: this comment is not very clear. */
/* FIXME bugzilla.eazel.com 2542: this comment is not very clear. */
/* 1 The mime type and URI scheme match the supported
attributes. */
......@@ -1261,7 +1261,7 @@ make_oaf_query_with_uri_scheme_only (const char *uri_scheme, GList *explicit_iid
*/
"AND (NOT bonobo:supported_mime_types.defined ()))"
/* FIXME: improve the comment explaining this. */
/* FIXME bugzilla.eazel.com 2542: improve the comment explaining this. */
/* This attribute allows uri schemes to be supported
even for unsupported mime types or no mime type. */
......
......@@ -773,7 +773,7 @@ nautilus_preferences_set_string_list (const char *name,
key = nautilus_user_level_manager_make_current_gconf_key (name);
g_assert (key != NULL);
/* FIXME: Make sure the preference value is indeed different
/* FIXME bugzilla.eazel.com 2543: Make sure the preference value is indeed different
before setting, like the other functions */
gconf_client_set_list (GLOBAL.gconf_client, key,
......
......@@ -102,7 +102,7 @@ program_file_pair_compute_status (ProgramFilePair *pair)
{
ProgramFileStatus new_status;
/* FIXME: Need to check whether it's the default or in short list for the supertype */
/* FIXME bugzilla.eazel.com 1459: Need to check whether it's the default or in short list for the supertype */
if (program_file_pair_is_default_for_file_type (pair)) {
new_status = PROGRAM_DEFAULT_FOR_TYPE;
} else if (program_file_pair_is_default_for_file (pair)) {
......@@ -194,7 +194,7 @@ program_file_pair_get_program_name_for_display (ProgramFilePair *pair)
static char *
get_supertype_from_file (NautilusFile *file)
{
/* FIXME: Needs implementation */
/* FIXME bugzilla.eazel.com 1459: Needs implementation */
return nautilus_file_get_string_attribute (file, "type");
}
......
......@@ -628,7 +628,7 @@ nautilus_scalable_font_measure_text (const NautilusScalableFont *font,
art_affine_identity (affine);
/* FIXME: We need to change rsvg_ft_render_string() to accept
/* FIXME bugzilla.eazel.com 2544: We need to change rsvg_ft_render_string() to accept
* a 'do_render' flag so that we can use to to compute metrics
* without actually having to render
*/
......
......@@ -303,7 +303,7 @@ view_frame_call_begin (NautilusView *view, CORBA_Environment *ev)
{
g_return_val_if_fail (NAUTILUS_IS_VIEW (view), CORBA_OBJECT_NIL);
/* FIXME: Do we have to handle failure in this query? */
/* FIXME bugzilla.eazel.com 2545: Do we have to handle failure in this query? */
CORBA_exception_init (ev);
return Bonobo_Unknown_query_interface
(bonobo_control_get_control_frame (nautilus_view_get_bonobo_control (view)),
......
......@@ -91,7 +91,7 @@ create_pixmap (GtkWidget *widget,
GdkBitmap *mask;
gchar *pathname;
/* FIXME: If we try to use this to get "nautilus/" pixmaps it
/* FIXME bugzilla.eazel.com 2546: If we try to use this to get "nautilus/" pixmaps it
* won't work unless our prefix matches the one from gnome-libs.
*/
pathname = gnome_pixmap_file (filename);
......@@ -132,7 +132,7 @@ create_image (const gchar *filename)
GdkImlibImage *image;
gchar *pathname;
/* FIXME: If we try to use this to get "nautilus/" pixmaps it
/* FIXME bugzilla.eazel.com 2546: If we try to use this to get "nautilus/" pixmaps it
* won't work unless our prefix matches the one from gnome-libs.
*/
pathname = gnome_pixmap_file (filename);
......
......@@ -236,7 +236,7 @@ create_mount_link (const NautilusVolume *volume)
/* Create link */
result = nautilus_link_create (desktop_path, volume->volume_name, icon_name,
target_uri, NAUTILUS_LINK_MOUNT);
/* FIXME: Ignoring the result here OK? */
/* FIXME bugzilla.eazel.com 2526: Ignoring the result here OK? */
g_free (desktop_path);
g_free (target_uri);
......@@ -527,7 +527,7 @@ volume_unmounted_callback (NautilusVolumeMonitor *monitor,
result = gnome_vfs_unlink (link_uri);
if (result != GNOME_VFS_OK) {
/* FIXME: Is a message to the console acceptable here? */
/* FIXME bugzilla.eazel.com 2526: OK to ignore error? */
}
g_free (link_uri);
}
......@@ -627,7 +627,7 @@ place_home_directory (FMDesktopIconView *icon_view)
home_dir_uri, NAUTILUS_LINK_HOME);
g_free (home_dir_uri);
if (!made_link) {
/* FIXME: Is a message to the console acceptable here? */
/* FIXME bugzilla.eazel.com 2526: Is a message to the console acceptable here? */
g_message ("Unable to create home link");
}
......
......@@ -1198,16 +1198,17 @@ fm_icon_view_start_renaming_item (FMDirectoryView *view, const char *uri)
(get_icon_container (FM_ICON_VIEW (view)));
}
/**
* FIXME: this whole function is a workaround for a Bonobo bug in
* which asking for the position of the last item returns -1.
*/
static int
get_next_position (BonoboUIHandler *ui_handler, const char *path)
{
int position;
position = bonobo_ui_handler_menu_get_pos (ui_handler, path);
/**
* FIXME bugzilla.eazel.com 2527: this is a workaround for a Bonobo bug in
* which asking for the position of the last item returns -1.
* This code can be removed when the bug is fixed in Bonobo.
*/
if (position < 0) {
return position;
}
......@@ -1425,7 +1426,7 @@ play_file (NautilusFile *file)
if (mp3_pid == (pid_t) 0) {
file_uri = nautilus_file_get_uri (file);
file_path = gnome_vfs_get_local_path_from_uri (file_uri);
/* FIXME: This can return NULL for non-local files. */
/* FIXME bugzilla.eazel.com 2529: This can return NULL for non-local files. */
mime_type = nautilus_file_get_mime_type (file);
......@@ -1449,7 +1450,7 @@ play_file (NautilusFile *file)
return 0;
}
/* FIXME: Hardcoding this here sucks. We should be using components
/* FIXME bugzilla.eazel.com 2530: Hardcoding this here sucks. We should be using components
* for open ended things like this.
*/
......@@ -1767,7 +1768,7 @@ get_icon_text_callback (NautilusIconContainer *container,
/* Handle link files specially. */
actual_uri = nautilus_file_get_uri (file);
if (nautilus_file_is_nautilus_link (file)) {
/* FIXME: Does sync. I/O. */
/* FIXME bugzilla.eazel.com 2531: Does sync. I/O. */
*additional_text = nautilus_link_get_additional_text (actual_uri);
g_free (actual_uri);
return;
......
......@@ -240,7 +240,8 @@ fm_list_view_initialize (gpointer object, gpointer klass)
* to create_list) until later, when the function pointers
* have been initialized by the subclass.
*/
/* FIXME: This code currently relies on there being a call to
/* FIXME bugzilla.eazel.com 2533:
* This code currently relies on there being a call to
* get_list before the widget is shown to the user. It would
* be better to do something explicit, like connecting to
* "realize" instead of just relying on the various get_list
......@@ -703,7 +704,7 @@ create_list (FMListView *list_view)
for (i = 0; i < number_of_columns; ++i) {
get_column_specification (list_view, i, &column);
/* FIXME: Make a cover to do this trick. */
/* FIXME bugzilla.eazel.com 2532: Make a cover to do this trick. */
gtk_clist_set_column_max_width (clist, i, column.maximum_width);
gtk_clist_set_column_min_width (clist, i, column.minimum_width);
/* work around broken GtkCList that pins the max_width to be no less than
......@@ -1248,7 +1249,7 @@ fm_list_view_set_zoom_level (FMListView *list_view,
/* This little dance is necessary due to bugs in GtkCList.
* Must set min, then max, then min, then actual width.
*/
/* FIXME: Make a cover to do this trick. */
/* FIXME bugzilla.eazel.com 2532: Make a cover to do this trick. */
gtk_clist_set_column_min_width (clist,
LIST_VIEW_COLUMN_ICON,
new_width);
......@@ -1520,7 +1521,7 @@ fm_list_view_font_family_changed (FMDirectoryView *view)
{
GdkFont *font;
/* FIXME: need to use the right font size for a given zoom level here */
/* FIXME bugzilla.eazel.com 143: need to use the right font size for a given zoom level here */
font = nautilus_font_factory_get_font_from_preferences (10);
g_assert (font != NULL);
nautilus_gtk_widget_set_font (GTK_WIDGET (get_list (FM_LIST_VIEW (view))), font);
......
......@@ -122,7 +122,7 @@ nautilus_indexing_info_show_dialog (void)
char *time_str;
char *label_str;
/* FIXME: is it ok to show the index dialog if
/* FIXME bugzilla.eazel.com 2534: is it ok to show the index dialog if
we can't use the index right now?
This assumes not */
if (medusa_indexed_search_is_available () != GNOME_VFS_OK) {
......
......@@ -27,8 +27,8 @@
#include <config.h>
#include "nautilus-application.h"
/* FIXME: This is a workaround for ORBit bug where including idl files
* in other idl files causes trouble.
/* FIXME bugzilla.eazel.com 2535: This is a workaround for ORBit bug where including idl files
* in other idl files causes trouble. We should remove this workaround when the bug is fixed.
*/
#include "nautilus-shell-interface.h"
#define nautilus_view_component_H
......@@ -350,7 +350,7 @@ nautilus_application_startup (NautilusApplication *application,
message = _("Nautilus can't be used now. "
"Rebooting the computer or installing "
"Nautilus again may fix the problem.");
/* FIXME: The guesses and stuff here are lame. */
/* FIXME bugzilla.eazel.com 2536: The guesses and stuff here are lame. */
detailed_message = _("Nautilus can't be used now. "
"Rebooting the computer or installing "
"Nautilus again may fix the problem.\n\n"
......@@ -371,7 +371,7 @@ nautilus_application_startup (NautilusApplication *application,
* version of OAF). Show dialog and terminate the
* program.
*/
/* FIXME: Looks like this does happen with the
/* FIXME bugzilla.eazel.com 2537: Looks like this does happen with the
* current OAF. I guess I read the code
* wrong. Need to figure out when and make a
* good message.
......@@ -393,7 +393,7 @@ nautilus_application_startup (NautilusApplication *application,
* we better stop looping.
*/
if (result == OAF_REG_SUCCESS) {
/* FIXME: When can this happen? */
/* FIXME bugzilla.eazel.com 2538: When can this happen? */
message = _("Nautilus can't be used now, due to an unexpected error.");
detailed_message = _("Nautilus can't be used now, due to an unexpected error "
"from OAF when attempting to locate the factory.");
......
......@@ -611,7 +611,7 @@ static gboolean
next_proxy_configuration_page_callback (GtkWidget *button, NautilusDruid *druid)
{
/* FIXME: here's where we configuration the proxy server information - Mike Fleming will do that soon */
/* FIXME bugzilla.eazel.com 1812: here's where we configuration the proxy server information - Mike Fleming will do that soon */
/* including unconfiguring the proxy server if last_proxy_choice == 0 */
g_message ("proxy server name is %s, port is %s", gtk_entry_get_text (GTK_ENTRY(proxy_address_entry)), gtk_entry_get_text (GTK_ENTRY(port_number_entry)));
......@@ -859,7 +859,7 @@ initiate_file_download (NautilusDruid *druid)
{
NautilusReadFileHandle *file_handle;
/* FIXME: for testing; this needs to move to the real service */
/* FIXME bugzilla.eazel.com 1826: for testing; this needs to move to the real service */
const char *file_uri = "http://linus.differnet.com/eazel-services/updates.tgz";
/* disable the next and previous buttons during the file loading process */
......
......@@ -969,7 +969,7 @@ add_background_to_browser (GtkWidget *widget, gpointer *data)
g_free(directory_path);
/* FIXME: Should use a quoting function that handles strings
/* FIXME bugzilla.eazel.com 2539: Should use a quoting function that handles strings
* with "'" in them.
*/
command_str = g_strdup_printf ("cp '%s' '%s'", path_name, destination_name);
......
......@@ -29,7 +29,7 @@
#include <stdlib.h>
#include "nautilus-shell.h"
/* FIXME: This is a workaround for ORBit bug where including idl files
/* FIXME bugzilla.eazel.com 2535: This is a workaround for ORBit bug where including idl files
* in other idl files causes trouble.
*/
#include "nautilus-shell-interface.h"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment