Commit 7540b533 authored by John Sullivan's avatar John Sullivan

More FIXME-to-bug work.

	* configure.in
	* components/services/startup/nautilus-service-startup-view.c,
	* libnautilus-extensions/nautilus-directory-async.c,
	* libnautilus-extensions/nautilus-global-preferences.c,
	* libnautilus-extensions/nautilus-icon-canvas-item.c,
	* src/ntl-uri-map.c:

	Wrote bug reports for all FIXMEs in these files. With
	this checkin and Darin's next one, there should be no
	more FIXMEs in Nautilus without a bug report.
parent ee510e45
2000-04-27 John Sullivan <sullivan@eazel.com>
More FIXME-to-bug work.
* configure.in
* components/services/startup/nautilus-service-startup-view.c,
* libnautilus-extensions/nautilus-directory-async.c,
* libnautilus-extensions/nautilus-global-preferences.c,
* libnautilus-extensions/nautilus-icon-canvas-item.c,
* src/ntl-uri-map.c:
Wrote bug reports for all FIXMEs in these files. With
this checkin and Darin's next one, there should be no
more FIXMEs in Nautilus without a bug report.
2000-04-27 Joe Shaw <joe@helixcode.com>
* components/rpmview/nautilus-rpm-view.c
......
......@@ -61,7 +61,7 @@ struct _NautilusServicesContentViewDetails {
#define SERVICE_VIEW_DEFAULT_BACKGROUND_COLOR "rgb:BBBB/DDDD/FFFF"
/* FIXME: the service domain name should be settable and kept with the other preferences. */
/* FIXME bugzilla.eazel.com 728: the service domain name should be settable and kept with the other preferences. */
#define SERVICE_DOMAIN_NAME "eazel24.eazel.com"
static void nautilus_service_startup_view_initialize_class (NautilusServicesContentViewClass *klass);
......@@ -140,7 +140,7 @@ make_http_post_request(char *uri, char *post_body, char *auth_token)
ghttp_set_header(request, http_hdr_Accept, "text/xml");
ghttp_set_header(request, http_hdr_Content_Type, "text/xml");
ghttp_set_header(request, http_hdr_Host, SERVICE_DOMAIN_NAME);
/* FIXME: user agent version and OS should be substituted on the fly */
/* FIXME bugzilla.eazel.com 726: user agent version and OS should be substituted on the fly */
ghttp_set_header(request, http_hdr_User_Agent, "Nautilus/0.1 (Linux)");
if (auth_token)
......@@ -184,7 +184,7 @@ show_feedback(NautilusServicesContentView *view, char* error_message)
/* callback to handle the configuration button. First, make the configuration xml file,
then feed it to the service over HTTP. Display an error message, or move on to the summary
screen if successful */
/* FIXME: text strings should be gotten from a file */
/* FIXME bugzilla.eazel.com 727: text strings should be gotten from a file */
static void
gather_config_button_cb (GtkWidget *button, NautilusServicesContentView *view)
......@@ -266,7 +266,7 @@ gather_config_button_cb (GtkWidget *button, NautilusServicesContentView *view)
}
/* handle the registration command */
/* FIXME: get error messages from a file somewhere */
/* FIXME bugzilla.eazel.com 727: get error messages from a file somewhere */
static void
register_button_cb (GtkWidget *button, NautilusServicesContentView *view)
......@@ -372,7 +372,9 @@ register_button_cb (GtkWidget *button, NautilusServicesContentView *view)
go_to_uri(view, "eazel:config?signup");
}
/* FIXME: this routine should be somewhere else, and should take user preferences into account */
/* FIXME bugzilla.eazel.com 729:
* this routine should be somewhere else, and should take user preferences into account
*/
static char*
get_home_uri (void)
{
......@@ -443,7 +445,7 @@ static void setup_form_title(NautilusServicesContentView *view, const char* titl
g_free (file_name);
view->details->form_title = gtk_label_new (title_text);
/* FIXME: don't use hardwired font like this */
/* FIXME bugzilla.eazel.com 667: don't use hardwired font like this */
nautilus_gtk_widget_set_font_by_name (view->details->form_title,
"-*-helvetica-medium-r-normal-*-18-*-*-*-*-*-*-*"); ;
gtk_box_pack_start (GTK_BOX (temp_container), view->details->form_title, 0, 0, 8);
......@@ -468,7 +470,7 @@ static void setup_signup_form(NautilusServicesContentView *view)
setup_form_title(view, "Eazel Service Registration Form");
/* display an image and a descriptive message */
/* FIXME: get the text from a file or from the service */
/* FIXME bugzilla.eazel.com 727: get the text from a file or from the service */
temp_box = gtk_hbox_new(FALSE, 4);
gtk_box_pack_start(GTK_BOX(view->details->form), temp_box, 0, 0, 12);
gtk_widget_show (temp_box);
......@@ -581,7 +583,7 @@ static void setup_config_form(NautilusServicesContentView *view)
setup_form_title(view, "Eazel Service Configuration Gathering");
/* if we came from signup, add a congrats message */
/* FIXME: get the text from a file or from the service */
/* FIXME bugzilla.eazel.com 727: get the text from a file or from the service */
if (nautilus_str_has_suffix(view->details->uri, "signup")) {
message = "Congratulations, you have successfully signed up with the Eazel service!";
......@@ -592,7 +594,7 @@ static void setup_config_form(NautilusServicesContentView *view)
}
/* make label containing text about uploading the configuration data */
/* FIXME: It should get this text from a file or from the service */
/* FIXME bugzilla.eazel.com 727: It should get this text from a file or from the service */
temp_box = gtk_hbox_new(FALSE, 4);
gtk_box_pack_start(GTK_BOX(view->details->form), temp_box, 0, 0, 12);
......@@ -662,7 +664,7 @@ static void setup_overview_form(NautilusServicesContentView *view)
setup_form_title(view, "Eazel Service Overview");
/* if we came from signup, add a congrats message */
/* FIXME: get the text from a file or from the service */
/* FIXME bugzilla.eazel.com 727: get the text from a file or from the service */
if (nautilus_str_has_suffix(view->details->uri, "config")) {
message = "Congratulations, you have successfully transmitted your configuration!";
......
......@@ -81,7 +81,7 @@ AC_ARG_WITH(mozilla,
fi
)
dnl FIXME: there obviously needs to be a better test that checking for libxpcom.so
dnl FIXME bugzilla.eazel.com 724: there obviously needs to be a better test that checking for libxpcom.so
if test "$try_mozilla" = "true"
then
found_mozilla="false"
......
......@@ -190,7 +190,8 @@ metafile_read_complete (NautilusDirectory *directory)
g_assert (NAUTILUS_IS_DIRECTORY (directory));
/* FIXME: the following assertion shouldn't be disabled, but
/* FIXME bugzilla.eazel.com 720:
* The following assertion shouldn't be disabled, but
* it gets in the way when you set metadata before the
* metafile is completely read. Currently, the old metadata
* in the file will be lost. One way to test this is to
......@@ -241,7 +242,8 @@ metafile_read_callback (GnomeVFSAsyncHandle *handle,
directory->details->read_state->bytes_read += bytes_read;
/* FIXME: Is the call allowed to return fewer bytes than I requested
/* FIXME bugzilla.eazel.com 719:
* Is the call allowed to return fewer bytes than I requested
* when I'm not at the end of the file? If so, then I need to fix this
* check. I don't want to stop until the end of the file.
*/
......
......@@ -361,7 +361,7 @@ user_level_changed_callback (gpointer user_data)
nautilus_preferences_set_boolean (NAUTILUS_PREFERENCES_SHOW_REAL_FILE_NAME,
show_real_file_name);
/* FIXME: This call needs to be spanked to conform. Should return a strduped string */
/* FIXME bugzilla.eazel.com 715: This call needs to be spanked to conform. Should return a strduped string */
user_main_directory = nautilus_user_main_directory ();
if (use_real_home)
......
......@@ -216,7 +216,7 @@ nautilus_icon_canvas_item_initialize_class (NautilusIconCanvasItemClass *class)
item_class->bounds = nautilus_icon_canvas_item_bounds;
item_class->event = nautilus_icon_canvas_item_event;
/* FIXME: the font shouldn't be hard-wired like this */
/* FIXME bugzilla.eazel.com 667: the font shouldn't be hard-wired like this */
embedded_text_font = gdk_font_load("-bitstream-charter-medium-r-normal-*-9-*-*-*-*-*-*-*");
}
......@@ -722,10 +722,10 @@ draw_label_text (NautilusIconCanvasItem *item, GdkDrawable *drawable,
}
/* utility routine to draw the mini-text inside text files */
/* FIXME: We should cache the text in the object instead
/* FIXME bugzilla.eazel.com 709: We should cache the text in the object instead
* of reading each time we draw, so we can work well over the network.
*/
/* FIXME: The text reading does not belong here at all, but rather in the caller. */
/* FIXME bugzilla.eazel.com 711: The text reading does not belong here at all, but rather in the caller. */
static void
nautilus_art_irect_to_gdk_rectangle (GdkRectangle *destination,
......@@ -756,7 +756,7 @@ draw_embedded_text (GnomeCanvasItem* item,
details = icon_item->details;
/* Draw the first few lines of the text file until we fill up the icon */
/* FIXME: need to use gnome_vfs to read the file */
/* FIXME bugzilla.eazel.com 713: need to use gnome_vfs to read the file */
file_name = details->embedded_text_file_URI;
if (file_name == NULL) {
......@@ -969,7 +969,9 @@ emblem_layout_next (EmblemLayout *layout,
static void
draw_pixbuf (GdkPixbuf *pixbuf, GdkDrawable *drawable, int x, int y)
{
/* FIXME: Dither would be better if we passed dither values. */
/* FIXME bugzilla.eazel.com 703:
* Dither would be better if we passed dither values.
*/
gdk_pixbuf_render_to_drawable_alpha (pixbuf, drawable, 0, 0, x, y,
gdk_pixbuf_get_width (pixbuf),
gdk_pixbuf_get_height (pixbuf),
......
......@@ -190,7 +190,8 @@ metafile_read_complete (NautilusDirectory *directory)
g_assert (NAUTILUS_IS_DIRECTORY (directory));
/* FIXME: the following assertion shouldn't be disabled, but
/* FIXME bugzilla.eazel.com 720:
* The following assertion shouldn't be disabled, but
* it gets in the way when you set metadata before the
* metafile is completely read. Currently, the old metadata
* in the file will be lost. One way to test this is to
......@@ -241,7 +242,8 @@ metafile_read_callback (GnomeVFSAsyncHandle *handle,
directory->details->read_state->bytes_read += bytes_read;
/* FIXME: Is the call allowed to return fewer bytes than I requested
/* FIXME bugzilla.eazel.com 719:
* Is the call allowed to return fewer bytes than I requested
* when I'm not at the end of the file? If so, then I need to fix this
* check. I don't want to stop until the end of the file.
*/
......
......@@ -361,7 +361,7 @@ user_level_changed_callback (gpointer user_data)
nautilus_preferences_set_boolean (NAUTILUS_PREFERENCES_SHOW_REAL_FILE_NAME,
show_real_file_name);
/* FIXME: This call needs to be spanked to conform. Should return a strduped string */
/* FIXME bugzilla.eazel.com 715: This call needs to be spanked to conform. Should return a strduped string */
user_main_directory = nautilus_user_main_directory ();
if (use_real_home)
......
......@@ -216,7 +216,7 @@ nautilus_icon_canvas_item_initialize_class (NautilusIconCanvasItemClass *class)
item_class->bounds = nautilus_icon_canvas_item_bounds;
item_class->event = nautilus_icon_canvas_item_event;
/* FIXME: the font shouldn't be hard-wired like this */
/* FIXME bugzilla.eazel.com 667: the font shouldn't be hard-wired like this */
embedded_text_font = gdk_font_load("-bitstream-charter-medium-r-normal-*-9-*-*-*-*-*-*-*");
}
......@@ -722,10 +722,10 @@ draw_label_text (NautilusIconCanvasItem *item, GdkDrawable *drawable,
}
/* utility routine to draw the mini-text inside text files */
/* FIXME: We should cache the text in the object instead
/* FIXME bugzilla.eazel.com 709: We should cache the text in the object instead
* of reading each time we draw, so we can work well over the network.
*/
/* FIXME: The text reading does not belong here at all, but rather in the caller. */
/* FIXME bugzilla.eazel.com 711: The text reading does not belong here at all, but rather in the caller. */
static void
nautilus_art_irect_to_gdk_rectangle (GdkRectangle *destination,
......@@ -756,7 +756,7 @@ draw_embedded_text (GnomeCanvasItem* item,
details = icon_item->details;
/* Draw the first few lines of the text file until we fill up the icon */
/* FIXME: need to use gnome_vfs to read the file */
/* FIXME bugzilla.eazel.com 713: need to use gnome_vfs to read the file */
file_name = details->embedded_text_file_URI;
if (file_name == NULL) {
......@@ -969,7 +969,9 @@ emblem_layout_next (EmblemLayout *layout,
static void
draw_pixbuf (GdkPixbuf *pixbuf, GdkDrawable *drawable, int x, int y)
{
/* FIXME: Dither would be better if we passed dither values. */
/* FIXME bugzilla.eazel.com 703:
* Dither would be better if we passed dither values.
*/
gdk_pixbuf_render_to_drawable_alpha (pixbuf, drawable, 0, 0, x, y,
gdk_pixbuf_get_width (pixbuf),
gdk_pixbuf_get_height (pixbuf),
......
......@@ -272,7 +272,7 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
query = NULL;
if (vfs_result_code == GNOME_VFS_OK) {
/* FIXME: disgusting hack to make rpm view work. Why
/* FIXME bugzilla.eazel.com 697: disgusting hack to make rpm view work. Why
is the mime type not being detected properly in the
first place? */
......@@ -283,7 +283,8 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
(gnome_vfs_file_info_get_mime_type (file_result->file_info));
}
/* FIXME: hack for lack of good type descriptions. Can
/* FIXME bugzilla.eazel.com 699:
hack for lack of good type descriptions. Can
we remove this now? */
......@@ -307,7 +308,7 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
" bonobo:supported_mime_types.has('*/*')) AND (NOT bonobo:supported_uri_schemes.defined()"
" OR bonobo:supported_uri_schemes.has('%s') OR bonobo:supported_uri_schemes.has('*')) "
" AND nautilus:view_as_name.defined()"
/* FIXME: hack until music view is handled right. */
/* FIXME bugzilla.eazel.com 701: hack until music view is handled right. */
" AND iid != 'OAFIID:nautilus_music_view:9456b5d2-60a8-407f-a56e-d561e1821391'"
, mime_type, mime_supertype, uri_scheme);
......@@ -354,7 +355,7 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
for (i = 0; i < oaf_result->_length; i++) {
server = &oaf_result->_buffer[i];
iid = server->iid;
/* FIXME MJS: need to pass proper set of languages as
/* FIXME bugzilla.eazel.com 694: need to pass proper set of languages as
the last arg for i18 purposes */
view_as_name = oaf_server_info_attr_lookup (server, "nautilus:view_as_name", NULL);
if (view_as_name == NULL) {
......
......@@ -272,7 +272,7 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
query = NULL;
if (vfs_result_code == GNOME_VFS_OK) {
/* FIXME: disgusting hack to make rpm view work. Why
/* FIXME bugzilla.eazel.com 697: disgusting hack to make rpm view work. Why
is the mime type not being detected properly in the
first place? */
......@@ -283,7 +283,8 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
(gnome_vfs_file_info_get_mime_type (file_result->file_info));
}
/* FIXME: hack for lack of good type descriptions. Can
/* FIXME bugzilla.eazel.com 699:
hack for lack of good type descriptions. Can
we remove this now? */
......@@ -307,7 +308,7 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
" bonobo:supported_mime_types.has('*/*')) AND (NOT bonobo:supported_uri_schemes.defined()"
" OR bonobo:supported_uri_schemes.has('%s') OR bonobo:supported_uri_schemes.has('*')) "
" AND nautilus:view_as_name.defined()"
/* FIXME: hack until music view is handled right. */
/* FIXME bugzilla.eazel.com 701: hack until music view is handled right. */
" AND iid != 'OAFIID:nautilus_music_view:9456b5d2-60a8-407f-a56e-d561e1821391'"
, mime_type, mime_supertype, uri_scheme);
......@@ -354,7 +355,7 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah,
for (i = 0; i < oaf_result->_length; i++) {
server = &oaf_result->_buffer[i];
iid = server->iid;
/* FIXME MJS: need to pass proper set of languages as
/* FIXME bugzilla.eazel.com 694: need to pass proper set of languages as
the last arg for i18 purposes */
view_as_name = oaf_server_info_attr_lookup (server, "nautilus:view_as_name", NULL);
if (view_as_name == NULL) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment