Commit 4d83a5d8 authored by John Sullivan's avatar John Sullivan

Added bug numbers to FIXMEs.

	* libnautilus-extensions/nautilus-file.c:
	(nautilus_file_get_type_as_string):
	* src/file-manager/fm-directory-view.c:
	(bonobo_control_activate_callback), (new_folder_done),
	(fm_directory_view_real_create_background_context_menu_items):
	* src/file-manager/fm-icon-view.c:
	* src/file-manager/fm-list-view.c: (fm_list_handle_dropped_icons):
	* src/nautilus-application.c: (nautilus_app_startup):
	* src/nautilus-desktop-window.c:
	(nautilus_desktop_window_initialize),
	(nautilus_desktop_window_new), (realize):
	* src/nautilus-property-browser.c: (remove_background),
	(remove_emblem), (add_background_to_browser):
	* src/nautilus-sidebar.c:
	* src/nautilus-view-frame-bonobo-embeddable.c:
	(bonobo_subdoc_notify_location_change):
	* src/nautilus-window-manage-views.c:
	(nautilus_window_request_location_change):
	Added bug numbers to FIXMEs.
parent 2901a55b
2000-06-06 John Sullivan <sullivan@eazel.com>
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_get_type_as_string):
* src/file-manager/fm-directory-view.c:
(bonobo_control_activate_callback), (new_folder_done),
(fm_directory_view_real_create_background_context_menu_items):
* src/file-manager/fm-icon-view.c:
* src/file-manager/fm-list-view.c: (fm_list_handle_dropped_icons):
* src/nautilus-application.c: (nautilus_app_startup):
* src/nautilus-desktop-window.c:
(nautilus_desktop_window_initialize),
(nautilus_desktop_window_new), (realize):
* src/nautilus-property-browser.c: (remove_background),
(remove_emblem), (add_background_to_browser):
* src/nautilus-sidebar.c:
* src/nautilus-view-frame-bonobo-embeddable.c:
(bonobo_subdoc_notify_location_change):
* src/nautilus-window-manage-views.c:
(nautilus_window_request_location_change):
Added bug numbers to FIXMEs.
2000-06-06 John Sullivan <sullivan@eazel.com>
* components/music/nautilus-music-view.c:
......
......@@ -1731,9 +1731,16 @@ nautilus_file_get_type_as_string (NautilusFile *file)
/* We want to update nautilus/data/nautilus.keys to include
* English (& localizable) versions of every mime type anyone ever sees.
*/
g_warning ("No description found for mime type \"%s\" (file is \"%s\"), tell sullivan@eazel.com",
mime_type,
file->details->info->name);
if (strcmp (mime_type, "special/directory") == 0) {
g_warning ("Can't find description even for \"special/directory\". This "
"probably means that your gnome-vfs.keys file is in the wrong place "
"or isn't being found for some other reason.");
} else {
g_warning ("No description found for mime type \"%s\" (file is \"%s\"), tell sullivan@eazel.com",
mime_type,
file->details->info->name);
}
return g_strdup (mime_type);
}
......
......@@ -1731,9 +1731,16 @@ nautilus_file_get_type_as_string (NautilusFile *file)
/* We want to update nautilus/data/nautilus.keys to include
* English (& localizable) versions of every mime type anyone ever sees.
*/
g_warning ("No description found for mime type \"%s\" (file is \"%s\"), tell sullivan@eazel.com",
mime_type,
file->details->info->name);
if (strcmp (mime_type, "special/directory") == 0) {
g_warning ("Can't find description even for \"special/directory\". This "
"probably means that your gnome-vfs.keys file is in the wrong place "
"or isn't being found for some other reason.");
} else {
g_warning ("No description found for mime type \"%s\" (file is \"%s\"), tell sullivan@eazel.com",
mime_type,
file->details->info->name);
}
return g_strdup (mime_type);
}
......
......@@ -629,7 +629,9 @@ bonobo_control_activate_callback (BonoboObject *control, gboolean state, gpointe
local_ui_handler = bonobo_control_get_ui_handler (BONOBO_CONTROL (control));
if (state) {
/* FIXME: Doesn't the remote UI handler leak here? */
/* FIXME bugzilla.eazel.com 1259:
* Doesn't the remote UI handler leak here?
*/
bonobo_ui_handler_set_container
(local_ui_handler,
bonobo_control_get_remote_ui_handler (BONOBO_CONTROL (control)));
......@@ -1648,7 +1650,7 @@ new_folder_done (const char *new_folder_uri, gpointer data)
parameters->uri = g_strdup (new_folder_uri);
parameters->view = directory_view;
/* FIXME:
/* FIXME bugzilla.eazel.com 1260:
* runing the start_renaming_item with a delay because at this point
* it's not in the icon container's icon list.
* There are two problems with this besides clunkiness - by the time the
......@@ -1931,7 +1933,8 @@ fm_directory_view_real_create_background_context_menu_items (FMDirectoryView *vi
NULL,
NAUTILUS_MENU_PATH_SELECT_ALL_ITEM,
select_all_callback);
/* FIXME: Need to think clearly about what items to include here.
/* FIXME bugzilla.eazel.com 1261:
* Need to think clearly about what items to include here.
* We want the list to be pretty short, but not degenerately short.
* Zoom In and Out don't really seem to belong. Maybe "Show Properties"
* (for the current location, not selection -- but would have to not
......
......@@ -1103,7 +1103,7 @@ icon_container_activate_callback (NautilusIconContainer *container,
/* handle the preview signal by inspecting the mime type. For now, we only preview sound files. */
/* here's the timer task that actually plays the file using mpg123. */
/* FIXME: we should get the application from our mime-type stuff */
/* FIXME bugzilla.eazel.com 1258: we should get the application from our mime-type stuff */
static gint play_file(NautilusFile *file)
{
......
......@@ -488,7 +488,7 @@ static void
fm_list_handle_dropped_icons (NautilusList *list, GList *drop_data, int x, int y,
int action, FMListView *list_view)
{
/* FIXME:
/* FIXME bugzilla.eazel.com 1257:
* Merge this with nautilus_icon_container_receive_dropped_icons
*/
FMDirectoryView *directory_view;
......
......@@ -422,7 +422,7 @@ nautilus_app_startup (NautilusApp *app,
/* Show the "not ready for prime time" dialog after the first
* window appears, so it's on top.
*/
/* FIXME: It's not on top of the other windows. */
/* FIXME bugzilla.eazel.com 1256: It's not on top of the other windows. */
if (g_getenv ("NAUTILUS_NO_CAVEAT_DIALOG") == NULL) {
if (first_window == NULL) {
display_caveat (NULL);
......
......@@ -55,7 +55,8 @@ nautilus_desktop_window_initialize (NautilusDesktopWindow *window)
{
window->details = g_new0 (NautilusDesktopWindowDetails, 1);
/* FIXME: Although Havoc had this call to set_default_size in
/* FIXME bugzilla.eazel.com 1251:
* Although Havoc had this call to set_default_size in
* his code, it seems to have no effect for me. But the
* gdk_window_move_resize below does seem to work. Not sure if
* this should stay or not.
......@@ -103,7 +104,8 @@ nautilus_desktop_window_new (NautilusApp *application)
*/
nautilus_link_set_install (desktop_directory_path, "desktop");
/* FIXME: This little ditty is just the way you convert a
/* FIXME bugzilla.eazel.com 1252:
* This little ditty is just the way you convert a
* local path to a file: URI. Should be a utility somewhere
* to do the two steps at once.
*/
......@@ -170,7 +172,8 @@ realize (GtkWidget *widget)
/* Do the work of realizing. */
NAUTILUS_CALL_PARENT_CLASS (GTK_WIDGET_CLASS, realize, (widget));
/* FIXME: Looking at the gnome_win_hints implementation,
/* FIXME bugzilla.eazel.com 1253:
* Looking at the gnome_win_hints implementation,
* it looks like you can call these with an unmapped window,
* but when I tried doing it in initialize it didn't work.
* We'd like to set these earlier so the window doesn't show
......@@ -194,7 +197,8 @@ realize (GtkWidget *widget)
/* Make sure that focus, and any window lists or task bars also
* skip the window.
*/
/* FIXME: Is having no ability to focus on the window going to
/* FIXME bugzilla.eazel.com 1254:
* Is having no ability to focus on the window going to
* be a problem for renaming icons?
*/
gnome_win_hints_set_hints (widget,
......@@ -202,7 +206,8 @@ realize (GtkWidget *widget)
| WIN_HINTS_SKIP_WINLIST
| WIN_HINTS_SKIP_TASKBAR);
/* FIXME: Should we do a gdk_window_set_hints or a
/* FIXME bugzilla.eazel.com 1255:
* Should we do a gdk_window_set_hints or a
* gdk_window_move_resize here too?
*/
#if 0
......
......@@ -93,7 +93,7 @@ static void add_command_buttons (NautilusSidebar *sidebar,
#define DEFAULT_BACKGROUND_COLOR "rgb:DDDD/DDDD/FFFF"
#define DEFAULT_TAB_COLOR "rgb:9999/9999/9999"
/* FIXME: Hardcoded sizes? */
/* FIXME bugzilla.eazel.com 1245: Hardcoded sizes? */
#define SIDEBAR_WIDTH 136
#define SIDEBAR_HEIGHT 400
......
......@@ -569,7 +569,9 @@ remove_background(NautilusPropertyBrowser *property_browser, const char* backgro
/* delete the background from the background directory */
if (gnome_vfs_unlink (background_uri) != GNOME_VFS_OK) {
/* FIXME: Is a g_warning a reasonable way to report this to the user? */
/* FIXME bugzilla.eazel.com 1249:
* Is a g_warning a reasonable way to report this to the user?
*/
g_warning ("couldnt delete background %s", background_uri);
}
......@@ -590,7 +592,9 @@ remove_emblem(NautilusPropertyBrowser *property_browser, const char* emblem_name
/* delete the emblem from the emblem directory */
if (gnome_vfs_unlink (emblem_uri) != GNOME_VFS_OK) {
/* FIXME: Is a g_warning a reasonable way to report this to the user? */
/* FIXME bugzilla.eazel.com 1249:
* Is a g_warning a reasonable way to report this to the user?
*/
g_warning ("couldnt delete emblem %s", emblem_uri);
}
......@@ -779,7 +783,9 @@ add_background_to_browser (GtkWidget *widget, gpointer *data)
}
/* copy the image file to the backgrounds directory */
/* FIXME: do we need to do this with gnome-vfs? */
/* FIXME bugzilla.eazel.com 1250:
* do we need to do this with gnome-vfs?
*/
directory_path = nautilus_make_path (nautilus_get_user_directory (),
property_browser->details->category);
source_file_name = strrchr (path_name, '/');
......
......@@ -93,7 +93,7 @@ static void add_command_buttons (NautilusSidebar *sidebar,
#define DEFAULT_BACKGROUND_COLOR "rgb:DDDD/DDDD/FFFF"
#define DEFAULT_TAB_COLOR "rgb:9999/9999/9999"
/* FIXME: Hardcoded sizes? */
/* FIXME bugzilla.eazel.com 1245: Hardcoded sizes? */
#define SIDEBAR_WIDTH 136
#define SIDEBAR_HEIGHT 400
......
......@@ -64,7 +64,8 @@ bonobo_subdoc_notify_location_change (NautilusViewFrame *view,
nautilus_view_frame_request_progress_change(view, &pri);
if (stream != NULL)
{
/* FIXME: Dan Winship points out that we should pass the
/* FIXME bugzilla.eazel.com 1248:
* Dan Winship points out that we should pass the
* MIME type here to work with new implementers of
* PersistStream that pay attention to the MIME type. It
* doesn't matter right now, but we should fix it
......
......@@ -49,7 +49,8 @@
#include "nautilus-window-private.h"
#include "nautilus-location-bar.h"
/* FIXME: We should use inheritance instead of these special cases
/* FIXME bugzilla.eazel.com 1243:
* We should use inheritance instead of these special cases
* for the desktop window.
*/
#include "nautilus-desktop-window.h"
......@@ -662,7 +663,8 @@ nautilus_window_request_location_change (NautilusWindow *window,
create_new_window = loc->new_window_requested;
/* FIXME: We should use inheritance instead of these special cases
/* FIXME bugzilla.eazel.com 1243:
* We should use inheritance instead of these special cases
* for the desktop window.
*/
if (NAUTILUS_IS_DESKTOP_WINDOW (window) && window->content_view != NULL) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment