ChangeLog-20000414 78.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64
2000-01-18  Darin Adler  <darin@eazel.com>

	* libnautilus/nautilus-directory.c:
	(nautilus_directory_read_metafile):
	(nautilus_directory_try_to_read_metafile):
	(nautilus_directory_write_metafile):
	(nautilus_directory_try_to_write_metafile):
	(nautilus_directory_switch_to_alternate_metafile_uri):
	(nautilus_directory_escape_slashes):
	(nautilus_make_directory_and_parents): Added first cut at code to
	put metafiles in the user's home directory if the directory is not
	accessible and you can't read and write a metafile in the
	directory itself. We'll have to refine this later to handle cases
	where you end up with two metafiles.

	* libnautilus/Makefile.am: libnautilus/nautilus-debug.h:
	libnautilus/nautilus-debug.c: Took trick for getting into the
	debugger and put it into a public header file so it can be used
	outside of the nautilus executable.

	* src/ntl-main.c: (stop_in_debugger):
	(nautilus_stop_after_default_log_handler): (main): Use the new
	calls from libnautilus to set up the drop into debugger for
	criticals and warnings.

	* src/file-manager/fm-main.c: (main): Minimized includes and used
	the new calls from libnautilus to set up the drop into debugger
	for criticals and warnings.

	* src/ntl-uri-map.c: (nautilus_navinfo_add_mapping):
	src/ntl-window.c: (nautilus_window_constructed):
	src/file-manager/fm-directory-view.c:
	(fm_directory_view_initialize): (fm_directory_view_destroy):
	(notify_location_change_cb): (stop_location_change_cb):
	(fm_directory_view_sort): Removed some messages that aren't so
	useful.

	* libnautilus/ntl-view-frame.h: Minimized includes.
	* libnautilus/ntl-view-frame.c: Include "ntl-view-frame.h" first
	so it tests to see that it has sufficient includes in it.

	* src/ntl-view.c: (nautilus_view_load_client): Changed function so
	that NULL for an iid is allowed and simply results in a failed
	load instead of being illegal.

	* src/ntl-window-msgs.c:
	(nautilus_window_change_location_internal): src/ntl-window.c:
	(nautilus_window_up): Got rid of calls to gnome_vfs_uri_destroy;
	use gnome_vfs_uri_unref instead since it's safer and Federico is
	getting rid of gnome_vfs_uri_destroy.

	* src/file-manager/fm-directory-view-icons.h:
	src/file-manager/fm-directory-view-icons.c:
	(fm_directory_view_icons_new):
	src/file-manager/fm-directory-view-list.h:
	src/file-manager/fm-directory-view-list.c:
	(fm_directory_view_list_new):
	src/file-manager/fm-directory-view.h:
	src/file-manager/fm-directory-view.c: (fm_directory_view_new):
	Minimized includes and got rid of the unused _new functions.

	* libnautilus/nautilus-directory.h: Added a missing 2000 copyright
	date.

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
2000-01-17  John Sullivan  <sullivan@eazel.com>
	First steps towards making the list view non-degenerate.

	* src/file-manager/fm-directory-view.h:
	* src/file-manager/fm-directory-view.c:
	(nautilus_file_date_as_string): New function, returns string suitable
	for displaying in a list view column.
	(nautilus_file_size_as_string): New function, calls newly-publicized
	gnome_vfs_file_size_to_string.
	(display_selection_info): Now calls gnome_vfs_file_size_to_string
	instead of redoing the string-creation code here.

	* src/file-manager/fm-directory-view-list.c
	(create_flist): Creates new columns for icon, size, and mod date.
	(add_to_flist): Fills columns for size & mod date. Icon column
	is empty for the moment. Columns do not yet sort.

82 83 84 85 86 87 88 89 90 91
2000-01-17      Andy Hertzfeld <andy@eazel.com>

        *libnautilus/gnome-icon-container-dnd.c:
        made dragging work right by using gdk_pixbuf_render_pixmap_and_mask
        to make a pixmap and mask to pass to the gtk dragging machinery
        *libnautilus/gnome-icon-container.c:
        changed xoffset constant for the icon mode positioning to make the
        feedback box line up with the icon.
                     
2000-01-16	Andy Hertzfeld <andy@eazel.com>
92 93

	*libnautilus/gnome-icon-container-dnd.c:
94 95
        made dragging use an image of the canvas item dragged
        still disabled, though, because it's not handling the mask yet
96
    
97 98 99 100 101 102 103 104 105 106 107 108 109
2000-01-16	Andy Hertzfeld <andy@eazel.com>

	*libnautilus/gnome-icon-container-private.h:
	added "single_click_mode" boolean
	
	*libnautilus/gnome-icon-container.h
	made single-click open optionally work by adding code in button_release_event to activate the icon if appropriate
	enabled single-click mode by default
	
	*libnautilus/gnome-icon-container-dnd.c
	made dragging to desktop and else work by cleaning up code in set_uri_list_selection
	did work toward better dragging feedback using an image but didn't finish that yet
	
110 111 112 113 114 115 116 117 118 119
2000-01-15	Andy Hertzfeld <andy@eazel.com>

	*libnautilus/gnome-icon-container-dnd.c:
	made dragging files within a window actually work graphically, and set the stage for dragging between windows
	made drag_leave_cb no longer delete the selection_list
	made drag_data_received_cb delete selection if present instead of asserting it's gone
	made drag_drop_cb use the selection_list to determine the directory we're dragging from,
	if it's the same, move within the window, otherwise copy between (coming soon)
	didn't update positions in the metafile yet
	
120 121 122 123 124 125
2000-01-14  John Sullivan  <sullivan@eazel.com>

	* src/file-manager/fm-directory-view.c:
	(display_selection_info):
	Fixed a killer typo that caused selection to crash.

126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
2000-01-14  John Sullivan  <sullivan@eazel.com>

	Finished refactoring FMDirectoryView and subclasses. I
	don't plan any more major reworking on these files, so
	feel free to change things without fear of stomping on
	me.

	* src/file-manager/fm-directory-view.c:
	* src/file-manager/fm-directory-view.h:
	* src/file-manager/fm-directory-view-icons.c:
	* src/file-manager/fm-directory-view-icons.h:
	* src/file-manager/fm-directory-view-list.c:
	* src/file-manager/fm-directory-view-list.h:
 	Moved icon_layout and icons_not_in_layout fields from
 	FMDirectoryView to FMDirectoryViewIcons (where they hide
 	inside a details structure in fm-directory-view-icons.c)
 	Commented .h files and all public functions in .c files.
 	Removed unnecessary #includes.
 	Changed signatures on many static functions in subclasses
 	to take subclass type instead of superclass type.
 	(display_selection_info_idle_cb):
 	(fm_directory_view_get_selection): 
 	(fm_directory_view_icons_get_selection):
 	(fm_directory_view_list_get_selection):
 	(fm_directory_view_notify_selection_changed):
 	New functions used to handle subclasses telling
 	superclass about the selection, so superclass can
 	display info about it.
 	(display_icon_container_selection_info_idle_cb):
 	(display_flist_selection_info_idle_cb): Removed these
 	old functions in favor of new cleaner mechanism.
 	(flist_activate_cb), (icon_container_activate_cb): Moved
 	common code into new superclass function...
 	(fm_directory_view_activate_entry): New home of that common
 	code.

	* src/file-manager/fm-directory-view.c:
	* src/file-manager/fm-directory-view.h:
 	Moved remaining fields of FMDirectoryView inside a private 
 	details structure so they can change without affecting clients.
 	(fm_directory_view_get_uri): (fm_directory_view_get_view_frame): 
 	New functions to use instead of peeking at structure directly.
 	(init): (class_init): (fm_directory_view_get_type): Renamed
 	the former two functions and removed the latter while
 	deploying NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
		
	* src/file-manager/fm-main.c:
	(make_obj): Use fm_directory_view_get_view_frame() where it
	had been peeking at structure directly.

176 177 178 179 180 181 182 183 184 185
2000-01-14  Darin Adler  <darin@eazel.com>

	Fixed our handling of warnings and criticals.

	* src/ntl-main.c: Added new functions that stop in the debugger
	when you hit a g_warning or a critical error, only if the
	environment variable NAUTILUS_DEBUG is set. This is better than
	the way the old code made everything fatal, since it doesn't do
	anything if the debugger isn't running.

186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216
2000-01-14  Darin Adler  <darin@eazel.com>

	Turned on gradients for backgrounds.
	
	* src/ntl-index-panel.c:
	(nautilus_index_panel_drag_data_received): Use the new
	accept_dropped_color function in NautilusBackground instead of
	code in here. (nautilus_index_panel_background_changed):
	(nautilus_index_panel_set_up_info): Save background to metadata
	when the NautilusBackground object emits the changed signal.

	* libnautilus/nautilus-background.h:
	libnautilus/nautilus-background.c:
	(nautilus_background_accept_dropped_color): Moved logic about
	dropping a color coupon to change the background into the
	NautilusBackground class. This includes a first cut at the rules
	about gradients.

	* libnautilus/nautilus-background.c:
	(nautilus_background_get_color): Implemented this missing
	function. It's used by the code in index panel now to save the
	current background.

	* libnautilus/nautilus-background.c:
	(nautilus_background_draw_flat_box): Implemented gradient fills
	through the GtkStyle subclass.

	* src/ntl-main.c: (main): Made criticals and warnings be always
	fatal. Next step is to make them drop into the debugger, but not
	result in a core dump if the debugger is not running.
	
217 218 219 220 221 222
2000-01-14  Darin Adler  <darin@eazel.com>

	* src/ntl-index-panel.c: (nautilus_index_panel_set_up_label):
	Changed code to use the new gnome_vfs_uri_extract_short_name
	instead of its own private function.

223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
2000-01-14  Darin Adler  <darin@eazel.com>

	First cut at some actual saving of metadata.
	Neither the interface nor the implementation is great yet.
	But it's a start.

	* libnautilus/Makefile.am:
	libnautilus/nautilus-directory.h:
	libnautilus/nautilus-directory.c:
	libnautilus/nautilus-lib-self-check-functions.h:
	libnautilus/nautilus-lib-self-check-functions.c:
	src/file-manager/Makefile.am:
	src/file-manager/fm-directory-protected.h:
	src/file-manager/fm-directory.h:
	src/file-manager/fm-directory.c:
	src/file-manager/fm-vfs-directory.h:
	src/file-manager/fm-vfs-directory.c:
	Moved the old FMDirectory class into the library and named it
	NautilusDirectory. Added functions for reading and writing
	metadata.

	* src/ntl-index-panel.c: Added the code to save the index panel's
	background color in metadata.
	
	* libnautilus/Makefile.am: Added gnome-vfs and gnome-xml,
	since the new code uses them.

	* libnautilus/nautilus-self-checks.h:
	libnautilus/nautilus-lib-self-check-functions.h:
	libnautilus/nautilus-lib-self-check-functions.c:
	src/nautilus-self-check-functions.h:
	src/nautilus-self-check-functions.c:
	Added macros to the self-check framework so the list of self check
	functions appears in exactly one place for each directory/module.

	* src/ntl-index-panel.h: src/ntl-index-panel.c: Moved the fields
	of the index panel inside a private details structure so they can
	change without affecting clients.

	* libnautilus/nautilus-background.c: Just some reformatting.

264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285
2000-01-13  John Sullivan  <sullivan@eazel.com>

	More work pushing code from FMDirectoryView into subclasses.
	Almost done now.

	* src/file-manager/fm-directory-view.h:
	Removed enum _FMDirectoryViewMode and its typedef.
	Removed field entries_to_display.
	Removed transition section holding function prototypes that
	were on their way into subclasses.
	(fm_directory_view_is_valid_mode): Removed.
	(fm_directory_view_get_mode): Removed.
	(fm_directory_view_set_mode): Removed.

	(fm_directory_view_begin_adding_entries):  New function & signal.
	(fm_directory_view_add_entry):  New function & signal.
	(fm_directory_view_done_adding_entries):  New function & signal.
	(fm_directory_view_done_sorting_entries):  New function & signal.
	(fm_directory_view_begin_loading): New function & signal.

	(fm_directory_view_display_selection_info): Newly exposed function.

286
	* src/file-manager/fm-directory-view.c:
287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
	Removed some now-unnecessary #includes.
	Added constants for new signals to enum.
	Removed global variable for icon cache in favor of already-extant
	fm_get_current_icon_cache().
	Removed all references to entries_to_display.
	(display_selection_info): Renamed to 
	fm_directory_view_display_selection_info now that it's public.
	(view_has_icon_container): Removed.
	(get_icon_container): Moved into subclass FMDirectoryViewIcons.
	(add_to_icon_container): Moved into subclass FMDirectoryViewIcons.
	(load_icon_container): Moved into subclass FMDirectoryViewIcons.
	(display_icons_not_in_layout): Moved into subclass FMDirectoryViewIcons.
	(setup_base_uri): Moved into subclass FMDirectoryViewIcons (and renamed
	to set_up_base_uri).
	(view_has_flist): Removed.
	(get_flist): Moved into subclass FMDirectoryViewList.
	(add_to_flist): Moved into subclass FMDirectoryViewList.
	(class_init): Signal initialization code for begin_adding_entries,
	add_entry, done_adding_entries, done_sorting_entries, and begin_loading.
	(init): Removed mode-setting line.
	(display_pending_entries): Replaced the bulk of this function with three
	new signals: begin_adding_entries, add_entry, done_adding_entries. The
	loop structure and GnomeVFSFileInfo retrieving part remains.
	(directory_load_cb): Deployed new signal begin_loading where setup_base_uri
	used to be.
	(fm_directory_view_is_valid_mode): Removed.
	(fm_directory_view_get_mode): Removed.
	(fm_directory_view_set_mode): Removed.
	(fm_directory_view_begin_adding_entries): New function, emits signal.
	(fm_directory_view_add_entry): New function, emits signal.
	(fm_directory_view_done_adding_entries): New function, emits signal.
	(fm_directory_view_done_sorting_entries): New function, emits signal.
	(fm_directory_view_begin_loading): New function, emits signal.
	(fm_directory_view_sort): Replaced some icon-container-specific
	code with fm_directory_view_done_sorting_entries().

323
	* src/file-manager/fm-directory-view-icons.c:
324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340
	(fm_directory_view_icons_initialize_class): Wired up signal handlers
	for add_entry, done_adding_entries, done_sorting_entries, and begin_loading.
	(fm_directory_view_icons_initialize): Removed set_mode call.
	(display_icons_not_in_layout): Moved here from superclass FMDirectoryView.
	(get_icon_container): Moved here from superclass FMDirectoryView.
	(add_to_icon_container): Moved here from superclass FMDirectoryView.
	(load_icon_container): Moved here from superclass FMDirectoryView.
	(set_up_base_uri): Moved here from superclass FMDirectoryView.
	(fm_directory_view_icons_add_entry): New signal handler function, code 
	taken and simplified from superclass FMDirectoryView.
	(fm_directory_view_icons_done_adding_entries): New signal handler 
	function, code taken and simplified from superclass FMDirectoryView.
	(fm_directory_view_icons_done_sorting_entries): New signal handler 
	function, code taken and simplified from superclass FMDirectoryView.
	(fm_directory_view_icons_begin_loading): New signal handler function, 
	code taken and simplified from superclass FMDirectoryView.
	
341
	* src/file-manager/fm-directory-view-list.c:
342 343 344 345 346 347 348 349 350 351 352 353
	(fm_directory_view_list_initialize_class): Wired up signal handlers
	for begin_adding_entries, add_entry, and done_adding_entries
	(fm_directory_view_list_initialize): Removed set_mode call.
	(get_flist): Moved here from superclass FMDirectoryView.
	(add_to_flist): Moved here from superclass FMDirectoryView.
	(fm_directory_view_list_begin_adding_entries): New signal handler 
	function, code taken and simplified from superclass FMDirectoryView.
	(fm_directory_view_list_add_entry): New signal handler function, code 
	taken and simplified from superclass FMDirectoryView.
	(fm_directory_view_list_done_adding_entries): New signal handler 
	function, code taken and simplified from superclass FMDirectoryView.	

354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
2000-01-13  John Sullivan  <sullivan@eazel.com>

	* libnautilus/nautilus-gtk-macros.h: Defined macros
	for use when a signal must be overridden by subclasses.
	* src/file-manager/fm-directory-view.c: Deployed these
	new macros for the "clear" signal. 
	NAUTILUS_IMPLEMENT_MUST_OVERRIDE_SIGNAL is outside any 
	function, and
	(class_init): NAUTILUS_MUST_OVERRIDE_SIGNAL is in here.
	(fm_directory_view_real_clear): Eliminated this in favor
	of the above macros.
	* src/file-manager/fm-directory-view-icons.c:   
	(fm_directory_view_icons_get_type): Replaced function with
	NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
	(fm_directory_view_icons_init): Renamed to 
	fm_directory_view_icons_initialize and standardized parameters 
	to work with NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
	(fm_directory_view_icons_class_init): Renamed to 
	fm_directory_view_icons_initialize_class and standardized 
	parameters to work with NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
	(fm_directory_view_icons_destroy): Deployed
	NAUTILUS_CALL_PARENT_CLASS macro.
	* src/file-manager/fm-directory-view-list.c:   
	(fm_directory_view_list_get_type): Replaced function with
	NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
	(fm_directory_view_list_init): Renamed to 
	fm_directory_view_list_initialize and standardized parameters 
	to work with NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
	(fm_directory_view_list_class_init): Renamed to 
	fm_directory_view_list_initialize_class and standardized 
	parameters to work with NAUTILUS_DEFINE_GET_TYPE_FUNCTION macro.
	(fm_directory_view_list_destroy): Deployed
	NAUTILUS_CALL_PARENT_CLASS macro.
	
388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431
2000-01-12  John Sullivan  <sullivan@eazel.com>

	More work at pushing appropriate fm_directory_view code
	into subclasses.

	* src/file-manager/fm-directory-view.c:
	(class_init): Register "clear" signal, make 
	fm_directory_view_real_clear be default handler.
	(fm_directory_view_real_clear): New function, does
	nothing but complain when it's called. (I'm going to
	replace this with a debug-only mechanism soon.)
	(fm_directory_view_clear): New function, emits "clear" signal.
	(fm_directory_view_load_uri): Replaced "if icons clear this way,
	if list clear that way" code with call to fm_directory_view_clear.
	(mode_uses_flist): Eliminated, wrapped into only remaining caller
	view_has_flist (which will itself go away soon).
	(mode_uses_icon_container): Eliminated, wrapped into only remaining caller
	view_has_icon_container (which will itself go away soon).

	* src/file-manager/fm-directory-view-icons.c:
	(fm_directory_view_icons_clear): New function, erases icon container.
	(fm_directory_view_icons_init): Replace fm_directory_view's
	"clear" signal handler with fm_directory_view_icons_clear
	(fm_directory_view_icons_get_icon_layout): Moved to here.
	(fm_directory_view_icons_set_icon_layout): Moved to here.
	(fm_directory_view_icons_line_up_icons): Moved to here.
	
	* src/file-manager/fm-directory-view-list.c:
	(fm_directory_view_list_clear): New function, erases list contents.
	(fm_directory_view_list_init): Replace fm_directory_view's
	"clear" signal handler with fm_directory_view_list_clear
	
	* src/file-manager/fm-directory-view.h:
	(fm_directory_view_clear): Added "clear" signal, and
	fm_directory_view_clear prototype.
	(fm_directory_view_icons_get_icon_layout): Moved out of here.
	(fm_directory_view_icons_set_icon_layout): Moved out of here.
	(fm_directory_view_icons_line_up_icons): Moved out of here.
	
	* src/file-manager/fm-directory-view-icons.h:
	(fm_directory_view_icons_get_icon_layout): Moved to here.
	(fm_directory_view_icons_set_icon_layout): Moved to here.
	(fm_directory_view_icons_line_up_icons): Moved to here.

432 433 434 435 436
2000-01-12  John Sullivan  <sullivan@eazel.com>

	* src/ntl-window-msgs.c (nautilus_window_load_content_view_menu):
	Made option menu say "View as Icons" (e.g.) instead of just "Icons"

437 438 439 440 441
2000-01-11  Andy Hertzfeld <andy@eazel.com>

	* src/ntl-window:
    added a debug menu, and it's first item to show a color picker to test dropping colors
    
442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478
2000-01-11  John Sullivan  <sullivan@eazel.com>

	Started moving icon-specific and list-specific code
	into the subclasses. As a transition step, added some
	private prototypes to the .h file (clearly marked).	
	
	* src/file-manager/fm-directory-view.c:
	(setup_flist), (setup_icon_container): eliminated completely.
	(display_icon_container_selection_info_idle_cb), 
	(icon_container_selection_changed_cb), (icon_container_activate_cb),
	(create_icon_container), (display_flist_selection_info_idle_cb),
	(flist_activate_cb), (flist_selection_changed_cb), 
	(create_flist): moved out.
	(fm_directory_view_set_mode): removed the guts, which are now
	in the init functions for the subclasses; now just sets the
	field (which will go away eventually).
	* src/file-manager/fm-directory-view.h:
	(add_to_flist), (display_selection_info), (get_flist),
	(get_icon_container), (load_icon_container): temporarily
	added to .h file.
	* src/file-manager/fm-directory-view-icons.c:
	(display_icon_container_selection_info_idle_cb), 
	(icon_container_selection_changed_cb), (icon_container_activate_cb),
	(create_icon_container): moved in.
	(fm_directory_view_icons_init): Now creates icon_container here instead of
	in fm_directory_view_set_mode (which will eventually go away).
	* src/file-manager/fm-directory-view-list.c:
	(display_flist_selection_info_idle_cb),	(flist_activate_cb), 
	(flist_selection_changed_cb), (create_flist): moved in.
	(fm_directory_view_list_init): Now creates flist here instead of
	in fm_directory_view_set_mode (which will eventually go away).

	* src/ntl-window.c:
	(real_nautilus_window_set_content_view): Renamed to
	nautilus_window_real_set_content_view. Also added
	self as an author.

479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529
2000-01-11  Darin Adler  <darin@eazel.com>

	NautilusBackground is now used for the index panel background.

	* libnautilus/nautilus-background.c:
	(nautilus_background_attach_to_canvas):
	(nautilus_get_widget_background):
	(nautilus_gtk_style_get_default_class):
	(nautilus_gdk_window_update_sizes):
	(nautilus_background_draw_flat_box):
	(nautilus_background_get_gtk_style_class):
	(nautilus_background_set_widget_style):
	(nautilus_background_set_up_canvas):
	(nautilus_widget_background_changed):
	(nautilus_get_widget_background):
	Added new code that changes the background of a widget by
	modifying the GtkStyle. For solid colors and tiled images we
	can just modify the GtkStyle. For gradients we need to make
	a GtkStyle subclass.
	
	* libnautilus/nautilus-background.h:
	(nautilus_background_attach_to_canvas):
	(nautilus_get_widget_background):
	Changed the old interface that was canvas-specific, to a new one
	that allows attacking a background to any widget.

	* src/ntl-index-panel.h:
	Now that the background is attached to the widget, we don't need
	a background field in NautilusIndexPanel.

	* src/ntl-index-panel.c:
	(nautilus_index_panel_set_up_background)
	(nautilus_index_panel_finalize):
	(nautilus_index_panel_drag_data_received):
	(nautilus_index_panel_set_up_info):
	Changed the index panel to use NautilusBackground.

	* libnautilus/nautilus-background-canvas-group.h:
	libnautilus/nautilus-background-canvas-group.c:
	(nautilus_background_canvas_group_get_background):
	(nautilus_background_canvas_group_set_background):
	Moved the code that manages the background object out of the
	canvas group code, since we can now attach a background to
	any widget.

	* libnautilus/gdk-extensions.c:
	(nautilus_gdk_color_parse_with_white_default): Changed this helper
	to accept NULLs and return the default instead of prohibiting
	NULL. This is consistent with the gradient's use of NULL to
	represent the default color.

530 531 532 533 534 535 536 537 538 539 540 541
2000-01-11  John Sullivan  <sullivan@eazel.com>

	* libnautilus/nautilus-gtk-extensions.h:
	* libnautilus/nautilus-gtk-extensions.c:
	(nautilus_gtk_signal_connect_free_data): New function,
	convenience wrapper for gtk_signal_connect_full where
	the destroy-function is g_free() and the other extra
	values are the defaults.
	* src/ntl-window-msgs.c: (nautilus_window_load_content_view_menu):
	Use nautilus_gtk_signal_connect_free_data to avoid leaking the menu item's
	signal's copy of the iid string. 

542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572
2000-01-11  John Sullivan  <sullivan@eazel.com>

	Content view menu now works (can switch between List and Icon views).

	* src/ntl-window-msgs.c:
	(nautilus_window_load_content_view): Made it return the new
	content view, so callers don't need a load_info structure to
	determine the new view. Also made it accept NULL for
	requesting_view.
	(view_menu_switch_views_cb): New function, callback for when
	a view is chosen from the list of available content views.
	Elliot told me that this requires further work, so I checked
	it in with comments for later fixing by Elliot or someone
	else who understands the loading process better.
	(nautilus_view_load_content_view_menu): Added explicit
	parameter for NautilusNavigationInfo for clarity (had been
	getting this from deep in window temporary state guts).
	Connected view_menu_switch_views_cb to menu items.
	* src/ntl-window.c: 
	(nautilus_window_set_arg): Fixed bug in ARG_CONTENT_VIEW case where
	new view was sometimes being added to view hierarchy twice. Then
	moved this code into...
	(real_nautilus_window_set_content_view): New function, implements
	guts of content-view changing so set_arg doesn't have a big block
	of code in a switch statement.
	(nautilus_window_set_content_view): Moved the gtk_widget_show call
	from here to real_nautilus_window_set_content_view so it happens
	even if set_arg is called from elsewhere.
	(gtk_option_menu_do_resize): Removed this
	obsolete function (I removed the callers yesterday but forgot this).

573 574 575 576 577
2000-01-11  Darin Adler  <darin@eazel.com>

	* libnautilus/ntl-view-frame.c:	Fixed typos and oversights in
	Maciej's check-in. He didn't compile his changes :-(

578 579
2000-01-11  Maciej Stachowiak  <mjs@eazel.com>

580 581 582
	* libnautilus/ntl-view-frame.c, libnautilus/ntl-view-frame.h: Redo
	signals the conventional way, to avoid array size mismatches in
	the future.
583

584 585
2000-01-10  Maciej Stachowiak  <mjs@eazel.com>

586 587 588 589 590
	* docs/architecture.txt: Some documentation on the nautilus
	architecture including a block diagram and some conrol flow
	explanations. Needs editing for both style and technical
	completeness/accuracy, but it's a start.

591 592 593 594
	* libnautilus/gnome-icon-container.c (handle_icon_button_press):
	Reorder code so "context_click" is actually emitted on a button 3
	press.

595 596 597 598 599
	* src/file-manager/fm-main.c,
	src/file-manager/fm-directory-view.c,
	src/file-manager/fm-directory-view.h: Changed FMDirectoryView to
	use a NautilusViewFrame rather than inheriting from one.

600 601 602 603
	* libnautilus/ntl-view-frame.c (nautilus_view_frame_class_init):
	Fixed marshall type for "stop_location_change" signal. How could
	this ever have worked?

604 605 606
	* src/ntl-view.c (nautilus_view_load_client): Once an appropriate
	component type is found, do not keep looping.

607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638
2000-01-10  John Sullivan  <sullivan@eazel.com>

	First step at splitting the directory view into separate
	icon and list views. List view compiles and runs now,
	but is still inaccessible from the UI.

	* src/file-manager/fm-directory-view-icons.h:
	* src/file-manager/fm-directory-view-icons.c:
	* src/file-manager/fm-directory-view-list.h:
	* src/file-manager/fm-directory-view-list.c:
	New files. These implement two subclasses of FMDirectoryView.
	Currently the subclasses are trivial; the only code in the 
	subclasses other than boilerplate is the one line that sets 
	the view mode. Later I'll push the rest of the relevant code
	down into the subclasses.
	* src/file-manager/Makefile.am
	Added the four new files to the build.
	* src/file-manager/fm-directory-view.c: (init): Removed the
	call to fm_directory_view_set_mode since the subclasses are
	responsible for this now.
	(setup_base_uri): Don't call get_icon_container for non-icon
	views, as it asserts if you do; this was broken but since
	you couldn't switch to a non-icon view we didn't realize it.
	* src/file-manager/fm-main.c: (make_obj): Now calls either
	fm_directory_view_icons_get_type() or fm_directory_view_list_get_type()
	depending on the goad_id.
	* src/file-manager/ntl-file-manager.goad: Replaced entry for
	ntl_file_manager with two, one for ntl_file_manager_icon_view
	and one for ntl_file_manager_list_view
	* src/ntl-uri-map.c: (nautilus_navinfo_new): Now it sets up
	the two content views for directories with their new goad ids.

639 640
2000-01-10  Maciej Stachowiak  <mjs@eazel.com>

641 642 643 644 645
	* libnautilus/ntl-view-frame.c, libnautilus/ntl-view-frame.c:
	Fixed mismatch between declared signal array size and actual
	number of signals (this should still be rewritten to follow proper
	style).

646 647 648 649 650 651 652 653 654 655 656 657 658 659
	* libnautilus/ntl-content-view-frame.c,
	libnautilus/ntl-content-view-frame.h,
	libnautilus/ntl-meta-view-frame.c,
	libnautilus/ntl-meta-view-frame.h, libnautilus/ntl-view-frame.c,
	libnautilus/ntl-view-frame.h, src/ntl-app.c,
	src/ntl-view-bonobo-control.c, src/ntl-view-bonobo-subdoc.c,
	src/ntl-view-frame-svr.c, src/ntl-view-nautilus.c,
	src/ntl-view-private.h, src/ntl-view.c, src/ntl-view.h,
	src/ntl-window-msgs.c, src/ntl-window-msgs.h,
	src/ntl-window-state.c, src/ntl-window.c, src/ntl-window.h,
	src/file-manager/fm-directory-view.c,
	src/file-manager/fm-directory-view.h, src/file-manager/fm-main.c:
	Added Eazel copyright to files I've changed non-trivially.

660 661 662 663 664
2000-01-10  Darin Adler  <darin@eazel.com>

	* src/ntl-index-panel.c: (nautilus_index_panel_set_up_label):
	Added workaround to problem with basename and gnome-vfs.

665 666 667 668 669 670 671 672 673 674 675 676 677 678 679
2000-01-10  Maciej Stachowiak  <mjs@eazel.com>

	* libnautilus/ntl-view-frame.c, libnautilus/ntl-view-frame.h,
	libnautilus/ntl-content-view-frame.c,
	libnautilus/ntl-content-view-frame.h,
	libnautilus/ntl-meta-view-frame.c,
	libnautilus/ntl-meta-view-frame.h: Renamed from
	libnautilus/ntl-view-client.c, libnautilus/ntl-view-client.h,
	libnautilus/ntl-content-view-client.c,
	libnautilus/ntl-content-view-client.h,
	libnautilus/ntl-meta-view-client.c,
	libnautilus/ntl-meta-view-client.h.
	* libnautilus/Makefile.am, libnautilus/libnautilus.h: reflect this
	renaming.
	
680 681 682 683 684 685 686 687 688 689 690 691 692 693
2000-01-10  Darin Adler  <darin@eazel.com>

	* ntl-window-msgs.c: (nautilus_window_request_progress_change):
	(nautilus_window_advance_state):
	(nautilus_window_switch_to_new_views):
	(nautilus_window_revert_to_old_views):
	(nautilus_window_free_load_info):
	(nautilus_window_end_location_change):
	(nautilus_window_change_location_2):
	(nautilus_window_change_location): Got rid of the race condition
	in the existing code and cleaned up the state machine a bit. The
	new code separates the state of the nautilus window from the state
	of the content view, which makes things a bit simpler.

694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728
2000-01-10  John Sullivan  <sullivan@eazel.com>

	Added some of the framework for supporting multiple
	content views for the same uri. More to come later.

	* src/ntl-types.h: added NautilusViewIdentifier struct
	to keep track of iid and human-readable name. Renamed
	NautilusNavigationInfo.content_iid to default_content_iid,
	and added content_identifiers GSList.
	* src/ntl-uri-map.c: 
	(nautilus_view_identifier_new): New function.
	(nautilus_view_identifier_free): New function.
	(nautilus_navinfo_new): Create a human-readable-name
	for each content iid, and store them together in
	content_identifiers list. I included a currently
	unworking "List" choice for the directory case, to
	test the framework.
	(nautilus_navinfo_free): Free the content_identifiers list.
	* src/ntl-window-msgs.c:
	(nautilus_window_load_content_view_menu): New function,
	iterates through the content_identifiers list to fill in
	the menu of content view choices. The menu items don't do
	anything yet.
	(nautilus_window_change_location_internal): Added call to
	nautilus_window_load_content_view_menu.
	(nautilus_window_change_location_2): Fixed spelling and
	grammar in a couple of error messages.
	* src/ntl-window.c: (nautilus_window_constructed): Removed
	"View as (placeholder)" text in menu; now it has no text
	until the actual choices appear. Removed some option-menu-sizing
	trickery that didn't work correctly when items were added later.
	Now the entire menu is replaced when its contents change.
	* src/ntl-window.h: Removed menu_cvtype field; code all uses
	just option_cvtype now.

729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
2000-01-10  Darin Adler  <darin@eazel.com>

	* libnautilus/Makefile.am, libnautilus/nautilus-background.h,
	libnautilus/nautilus-background.c,
	libnautilus/nautilus-background-canvas-group.h,
	libnautilus/nautilus-background-canvas-group.c,
	libnautilus/nautilus-lib-self-check-functions.h,
	libnautilus/nautilus-lib-self-check-functions.c: Added first cut
	at a new class to manage backgrounds that can be colors, color
	gradients, or tiled images.

	* libnautilus/Makefile.am, libnautilus/nautilus-string.h,
	libnautilus/nautilus-string.c: Added functions that manipulate
	strings that allow NULLs to reduce NULL checks in code that
	treats NULL the same as an empty string.

	* libnautilus/gdk_extensions.c: (nautilus_gradient_new):
	(nautilus_gradient_is_gradient):
	(nautilus_gradient_is_horizontal):
	(nautilus_gradient_strip_trailing_direction_if_any):
	(nautilus_gradient_get_start_color_spec):
	(nautilus_gradient_get_end_color_spec):
	(nautilus_gradient_set_edge_color): Changed gradient functions to
	allow NULL and treat it the same as an empty string.

	* libnautilus/gdk_extensions.h: libnautilus/gdk_extensions.c:
	(nautilus_gdk_color_parse_with_default):
	(nautilus_gdk_color_parse_with_white_default): Added alternate
	version of gdk_color_parse that uses a default color instead of
	just returning false. Added self-checks and updated some existing
	self checks at the same time.

	* src/ntl-index-panel.h, src/ntl-index-panel.c: Wholesale
	cleanup and reformatting of NautilusIndexPanel. Fixed a number of
	bugs, including storage leaks, and took first step toward using
	NautilusBackground class.

	* src/ntl-window.c: (nautilus_window_get_requested_uri):
	Changed this so it works when window->ni is NULL.

	* src/ntl-window.h: Changed index_panel to be a NautilusIndexPanel
	now that the index panel interface uses the class instead of using
	GtkWidget everywhere.

	* src/file-manager/.cvsignore: Added *.la.

	* src/file-manager/fm-directory.c: Minor reformatting to match
	GNOME code style better.

John Sullivan's avatar
John Sullivan committed
778 779 780 781 782
2000-01-10  John Sullivan  <sullivan@eazel.com>

	* src/ntl-index-panel.c: (nautilus_index_panel_set_up_label):
	Check for NULL filename

783 784
2000-01-10  Maciej Stachowiak  <mjs@eazel.com>

785 786 787
	* src/file-manager/.cvsignore: ignore ntl-file-manager rather than
	libntl-file-manager.la

788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806
	Made file manager view a CORBA server that lives in a separate
	executable:
	
	* src/file-manager/fm-main.c: New file which includes main()
	function and basic framework to make the file manager an
	executable CORBA server.
	* src/file-manager/ntl-file-manager.goad: gnorba activation file
	for the file manager.
	* src/file-manager/Makefile.am: Build ntl-file-manager as an
	executable rather than a library. Add fm-main.c to build. Install
	ntl-file-manager.goad. Link in appropriate libraries.
	* src/ntl-app.c: Remove nautilus_make_object() and other vestiges
	of the attempt to be a CORBA server for file manager view objects.
	* src/nautilus.gnorba: Removed.
	* nautilus-self-check-functions.c: Remove call to test of
	functions now in the separate ntl-file-manager executable.
	* src/Makefile.am: Don't try to link in file manager. Don't try to
	install nautilus.goad.

807 808 809 810
2000-01-10  Maciej Stachowiak  <mjs@eazel.com>

	* src/ntl-main.c (main): Added missing CORBA_exception_init() call.

811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827
2000-01-09  Maciej Stachowiak  <mjs@eazel.com>

	* libnautilus/ntl-view-client.c, libnautilus/ntl-view-client.h,
	libnautilus/ntl-content-view-client.c,
	libnautilus/ntl-content-view-client.h,
	libnautilus/ntl-meta-view-client.c,
	libnautilus/ntl-meta-view-client.h,: Rename NautilusViewClient to
	NautilusViewFrame, NautilusContentViewClient to
	NautilusContentViewFrame, and NautilusMetaViewClient to
	NautilusMetaViewFrame.
	* components/help/hyperbola-nav-tree.c,
	components/history/ntl-history-view.c,
	components/html/ntl-web-browser.c,
	components/websearch/ntl-web-search.c, src/ntl-app.c,
	src/file-manager/fm-directory-view.c,
	src/file-manager/fm-directory-view.h: Reflect the above renaming.

828 829
2000-01-09  Andy Hertzfeld <andy@eazel.com>

830 831 832
	* src/ntl-index-panel.c: made dropping a color from the color
	picker set the background accordingly.  It doesn't save the
	meta-data yet, thought
833
	    
834 835 836 837 838
2000-01-09  Maciej Stachowiak  <mjs@eazel.com>

	* components/websearch/.cvsignore: Added .deps, .libs,
	ntl-web-search

839 840 841 842 843 844 845 846 847 848 849 850 851 852 853
2000-01-07  Andy Hertzfeld <andy@eazel.com>

        changed the way the index panel gets notified of location changes
        removed the index_panel_connect stuff
        instead, calls index_panel_set_uri directly from nautilus_window_change_location
        
        * src/ntl-index-panel.c, src/ntl-index-panel.h:
        restructured the code that populates the view with the info,
        added logic to use as large a font as possible for the title
        fixed bug involving the path ending with a slash.
        * src/ntl-window-msgs.c:
          added explicit call to index_panel_set_uri as mentioned above 
        * src/ntl-window.c
          removed call to index_panel_connect as mentioned above
        
854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
2000-01-07  John Sullivan  <sullivan@eazel.com>

	Added and deployed utility routine for presenting a
	window (in any current state) to user.

	* libnautilus/nautilus-gtk-extensions.h:
	* libnautilus/nautilus-gtk-extensions.c: New files
	(nautilus_gtk_window_present): New function, presents
	a window to user (opens it, brings it to front w/focus)
	regardless of whether it was showing, buried, hidden, or
	minimized.
	* libnautilus/Makefile.am: added these two new files. Also
	changed ".c" to ".h" for two self-check files in the HEADERS
	list (apparent typo).
	* src/nautilus-bookmarks-menu.c: (edit_bookmarks_cb):
	Replaced call to nautilus_bookmarks_window_present with
	call to nautilus_gtk_window_present.
	* src/nautilus-bookmarks-window.c:
	* src/nautilus-bookmarks-window.h:
	(nautilus_bookmarks_window_present): Deleted this function.
	* src/nautilus-bookmarks-window.c:
	(create-bookmarks-window): Now calls nautilus_bookmarks_
	window_restore_geometry just once here, instead of every
	time window was shown.
	* src/ntl-window.c: (nautilus_about_window_cb):
	Now it keeps around a single About window, instead of
	creating a new one each time (you could litter the screen
	with About windows before). Also removed some obsolete
	gtk_widget_set_sensitive calls.

884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929
2000-01-07  John Sullivan  <sullivan@eazel.com>

	Bookmarks window position is now saved & restored within
	a session and across sessions. Some of this work can be
	turned into general-purpose utilities but I didn't do
	that yet (I will when we have a second need for it)

	* src/nautilus-bookmarklist.c:
	* src/nautilus-bookmarklist.h:
	(nautilus_bookmarklist_set_window_geometry):
	(nautilus_bookmarklist_get_window_geometry): New functions,
	take/return a string representing the window position.
	* src/nautilus-bookmarklist.c:
	(nautilus_bookmarklist_load_file):
	(nautilus_bookmarklist_save_file): read/write xml node for
	window geometry in addition to bookmarks. Also cleaned up
	a couple of leaked results from xmlGetProp and reformatted.
	(set_window_geometry_internal): New utility function.
	* src/nautilus-bookmarks-menu.c: (edit_bookmarks_cb): Moved
	window-displaying logic out of this routine and into new
	routine nautilus_bookmarks_window_present(), which is now
	called here.
	* src/nautilus-boomarks-menu.c:
	* src/nautilus-boomarks-menu.h:
	(nautilus_bookmarks_menu_exiting): New function, handles telling
	bookmarks window to save itself when application exits.
	* src/ntl-app.c: (nautilus_app_exiting): Now calls
	nautilus_bookmarks_menu_exiting.
	* src/nautilus.h: Now #includes "nautilus-bookmarks-menu.h"
	* src/nautilus-bookmarks-window.h:
	* src/nautilus-bookmarks-window.c:
	(nautilus_bookmarks_window_present): New function, handles
	presenting the bookmarks window on screen regardless of current state.
	(nautilus_bookmarks_window_save_geometry): New function, reads window
	position & size and passes them along to 
	nautilus_bookmarklist_set_window_geometry for safe-keeping.
	* src/nautilus-bookmarks-window.c:
	(nautilus_bookmarks_window_restore_geometry): New function, gets
	window geometry from bookmarklist and sets window size & position
	from it (after adjusting with some sanity checks)
	(create_bookmarks_window): Replaced set_default_size call with
	nautilus_bookmarks_window_restore_geometry call.
	
	

2000-01-07  Elliot Lee  <sopwith@redhat.com>
Elliot Lee's avatar
Elliot Lee committed
930 931 932

	* src/ntl-window.c, src/ntl-index-panel.c: Fix warnings.

933 934 935 936 937 938 939 940 941 942 943 944 945 946 947
2000-01-07  Andy Hertzfeld <andy@eazel.com>

	* src/ntl-index-panel.h, src/ntl-index-panel.c: new files for index panel class
      Initial bare-bones implementation of index panel still using notebook object instead of custom tabs
      
    * src/ntl-window.h, src/ntl-window.c
      just use box instead of pane for nautilus window content,
      index_panel now responsible for the meta-views
      allocate and install index_panel instead of meta_notebook
      connect_signals calls index_panel so it can connect, too
      added myself as an author
    
    * src/Makefile.am
       added index_panel class
        
948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974
2000-01-06  Darin Adler  <darin@eazel.com>

	* libnautilus/Makefile.am,
	libnautilus/nautilus-lib-self-check-functions.c,
	libnautilus/nautilus-lib-self-check-functions.h,
	libnautilus/nautilus-self-checks.c,
	libnautilus/nautilus-self-checks.h, src/Makefile.am,
	src/nautilus-self-check-functions.c,
	src/nautilus-self-check-functions.h, src/nautilus-self-checks.c,
	src/nautilus-self-checks.h, src/ntl-main.c (main),
	src/file-manager/fm-directory.c,
	src/file-manager/fm-vfs-directory.c: Moved self-check framework
	into libnautilus. Added functions so each check will report if it
	fails instead of just aborting.

	* src/gdk-extensions.c, src/gdk-extensions.h
	(nautilus_gradient_new, nautilus_gradient_is_gradient,
	nautilus_gradient_get_start_color_spec,
	nautilus_gradient_get_end_color_spec,
	nautilus_gradient_is_horizontal,
	nautilus_gradient_set_left_color_spec,
	nautilus_gradient_set_top_color_spec,
	nautilus_gradient_set_right_color_spec,
	nautilus_gradient_set_bottom_color_spec): Added new functions to
	manage a string that specifies a color or gradient, and added
	tests for the new functions.

975 976 977 978 979 980 981 982 983 984
2000-01-06  John Sullivan  <sullivan@eazel.com>

	* src/ntl-app.h: src/ntl-app.c: (nautilus_app_exiting):
	New function for doing app-wide cleanup. Moved call to
	nautilus_prefs_save in here.
	* src/ntl-app.c: (nautilus_app_destroy_window): Former
	home of call to nautilus_prefs_save.
	* src/ntl-main.c: (main): After event loop concludes,
	call nautilus_app_exiting.

Elliot Lee's avatar
Elliot Lee committed
985 986 987 988
2000-01-06  Elliot Lee  <sopwith@redhat.com>

	* libnautilus/gnome-icon-container.c: Relayout when size changes.

989 990 991 992 993
2000-01-06  Andy Hertzfeld  <andy@eazel.com>

        * ntl-window.c: made location bar draggable to be consistent with the others by removing DOCK_LOCKED
        flag
        
Elliot Lee's avatar
Elliot Lee committed
994 995
2000-01-06  Elliot Lee  <sopwith@redhat.com>

Elliot Lee's avatar
Elliot Lee committed
996 997
	* libnautilus/gnome-icon-container.c: Eliminate gratuitous scroll bars.

Elliot Lee's avatar
Elliot Lee committed
998 999
	* src/ntl-window-msgs.c, components/help/hyperbola-filefmt.c, components/html/gnome-dialogs.c: Bug fixes.

John Sullivan's avatar
John Sullivan committed
1000 1001 1002 1003 1004
2000-01-06  John Sullivan  <sullivan@eazel.com>

	* src/ntl-prefs.c: added NULLs to array initializers to
	eliminate compiler warnings.

1005 1006 1007 1008 1009 1010 1011 1012 1013
2000-01-06  Elliot Lee  <sopwith@redhat.com>

	* src/ntl-prefs.c, src/ntl-uri-map.c: Implement preferences for
	which meta-views to always load with a page. Loading doesn't seem to quite work.

	* src/ntl-window.c, src/ntl-view.c: Try to fix a crash that
	happens when going to a new page, and a meta view is being
	destroyed in the process. Still crashes.

Maciej Stachowiak's avatar
Maciej Stachowiak committed
1014 1015 1016 1017
2000-01-05  Maciej Stachowiak  <mjs@eazel.com>

	* src/ntl-uri-map.c (nautilus_navinfo_free): Fix warning.

1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
2000-01-05  Elliot Lee  <sopwith@redhat.com>

	* src/ntl-types.h, src/ntl-uri-map.[ch], src/ntl-window-msgs.c, src/ntl-window.[ch]:
	  Add support for the location change state machine and related notifications,
          to allow much better error handling.
	* src/ntl-view.[ch]: Catch client failures, also allow for active sensing of client death.
	* src/file-manager/fm-directory-view.c: Send progress notifications.
	* components/html/ntl-web-browser.c: Send progress
	notifications. Try to fix crashes caused by ending an error stream
	twice.

Elliot Lee's avatar
Elliot Lee committed
1029 1030
	* src/file-manager/fm-icon-cache.c: Update for gdk-pixbuf changes.

1031 1032 1033 1034 1035
2000-01-05  John Sullivan  <sullivan@eazel.com>

	* src/nautilus-bookmarks-window.c: (create_bookmarks_window):
	Remove horizontal scroll bar from list via set_policy.

1036 1037 1038 1039 1040 1041
2000-01-05  John Sullivan  <sullivan@eazel.com>

	* src/nautilus-bookmarks-menu.c: (nautilus_bookmarks_menu_fill):
	Stopped using GNOMEUIINFO_ITEM_DATA macro, because it doesn't work
	right (on some machines) when there's no pixmap for the item.

1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053
2000-01-04  John Sullivan  <sullivan@eazel.com>

	* src/nautilus-bookmarks-menu.c: comment changes only

	* src/nautilus-bookmarks-window.c:
	(create_bookmarks_window): added padding to "Remove" button
	so it isn't so scrawny.
	(on_remove_button_clicked): Removed item from clist explicitly
	instead of relying on notification that bookmark list changed;
	this correctly moves the selection to the next item instead of
	jumping it back to the top of the list.

1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070
2000-01-04  Darin Adler  <darin@eazel.com>

	A couple of quick fixes to make "make check" work again.
	
	* src/file-manager/fm-directory.c (fm_directory_initialize):
	src/file-manager/fm-vfs-directory.c (fm_vfs_directory_initialize):
	Use g_new0 instead of g_new for details structure to better
	mimic what gtk_object_new does.

	* src/file-manager/fm-directory.c (fm_directory_get):
	Added an assert to check that the hash table key is set up
	correctly. This was failing when John did a "make check".

	* src/file-manager/fm-vfs-directory.c (fm_vfs_directory_new):
	Set up the hash table key when creating the object. This
	was causing a failure in "make check".

1071 1072 1073 1074 1075 1076 1077
2000-01-04  John Sullivan  <sullivan@eazel.com>

	* src/nautilus-bookmarks-window.c (create_bookmarks_window):
	Replaced hardwired numbers with constants; specified a minimum
	size separate from default size and changed parameter to
	gtk_window_set_policy to prevent shrinking below minimum size.

1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093
2000-01-04  John Sullivan  <sullivan@eazel.com>

	After talking with Sopwith and Darin, removed
	my changes from earlier today. The current framework
	handles bogus URIs better than I thought, though still
	with some known problems. I can't implement the bookmarks
	part until the problems are fixed. And the new functions
	don't seem to be required in any case.
	* libnautilus/nautilus-uri-utilities.c: removed file
	* libnautilus/nautilus-uri-utilities.h: removed file
	* libnautilus/Makefile.am: removed these two files
	from the build, and removed GnomeVFS
	* src/ntl-window.c: removed #include for nautilus-uri-utilitie.h.
	Sopwith had removed the call from (nautilus_window_goto_uri_cb)
	earlier (without a ChangeLog entry).

1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
2000-01-04  Darin Adler  <darin@eazel.com>

	* src/Makefile.am, src/check-nautilus,
	src/nautilus-self-check-functions.h, src/nautilus-self-checks.c,
	src/nautilus-self-checks.h, src/ntl-main.c (main): Added self
	checks to nautilus. The checks are invoked by "make check"
	(actually need to do "make install check" if you changed
	libnautilus) or by invoking the nautilus executable with "--check".
	Later, nautilus-self-checks.h may include various helpful
	functions for use by the self-checking code.

	* src/file-manager/Makefile.am, src/file-manager/fm-directory.c,
	src/file-manager/fm-directory.h,
	src/file-manager/fm-directory-protected.h,
	src/file-manager/fm-vfs-directory.c,
	src/file-manager/fm-vfs-directory.h: Started work on an abstract
	FMDirectory class that provides a model for what's viewed by the
	file manager. Also began work on the FMVFSDirectory concrete child
	class that implements this on top of VFS. It's not hooked up yet,
	and there's a lot that needs to be done before it's ready to use.

	* libnautilus/gdk-extensions.c, libnautilus/gdk-extensions.h:
	Renamed functions to use nautilus_ prefix instead of gdk_
	prefix. Added a tiny bit of self-check code.

	* libnautilus/nautilus-gtk-macros.h: Added some macros (that will
	no doubt be controversial) to do some basic GTK object
	boilerplate.

1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143
2000-01-04  John Sullivan  <sullivan@eazel.com>

	Made location-entering field handle bogus URIs better
	(next: bookmarks)

	* libnautilus/nautilus-uri-utilities.c: new file
	* libnautilus/nautilus-uri-utilities.h: new file
	At this point there's just one uri utility function,
	nautilus_path_known_not_to_exist(), which is a quick
	check for a bogus URI. (It's not guaranteed to return
	TRUE for all bad URIs, just the ones it can tell quickly
	are bogus).
	* libnautilus/Makefile.am: added these two new files
	to the build, and linked with GnomeVFS (needed for new
	function)
	* src/ntl-window.c: (nautilus_window_goto_uri_cb):
	If typed path can quickly be rejected, puts an error
	message in the status bar and doesn't try to go there.

	* components/websearch/.cvsignore: added Makefile

1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
2000-01-03  Maciej Stachowiak  <mjs@eazel.com>

	* idl/nautilus.idl: Added stop_location_change method to NautilusView interface.
	* ntl-view-client.c, ntl-view-client.h (stop_location_change): New
	signal, triggered on receipt of stop_location_change request via
	CORBA.

	* ntl-view.c, ntl-view.h, ntl-view-private.h, ntl-view-nautilus.c,
	ntl-view-bonobo-control.c, ntl-view-bonobo-subdoc.c
	(nautilus_view_stop_location_change): Added this function; also
	added implementation to nautilus view type function table and
	NULL'd out for now for Bonobo control and subdoc view types (need
	to find out if loading is synchronous or asynchronous for those,
	and if there is a way to abort).

	* ntl-window.c: Stop loading for all views when Stop button is
	pressed.
	
	* ntl-window-msgs.c: Enable stop button when we start loading;
	enable Stop button when

	* src/file-manager/fm-directory-view.c: Call
	request_progress_change() when loading is done or an error is
	reached; implement handler for stop_location_change signal.
	
Maciej Stachowiak's avatar
Maciej Stachowiak committed
1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214
2000-01-03  Maciej Stachowiak  <mjs@eazel.com>

	* src/ntl-prefs.c: Fix warnings.

	* src/ntl-view.c, src/ntl-view.h, src/ntl-view-frame-svr.c
	(nautilus_view_notify_location_change,
	nautilus_view_notify_selection_change, nautilus_view_load_state,
	nautilus_view_save_state, nautilus_view_show_properties): Made
	these functions public and removed the corresponding signals;
	these are operations you do to the NautilusView, not something it
	informs other parts of the program of.
	(request_location_change, request_selection_change,
	request_status_change, request_progress_change): New
	signals. These allow NautilusView to have less dependence on
	NautilusWindow.
	(nautilus_view_signals): Moved signal number table from view to
	this static variable.
	(nautilus_view_request_location_change,
	nautilus_view_request_selection_change,
	nautilus_view_request_status_change,
	nautilus_view_request_progress_change): Move to ntl-view.c and
	make them emit the proper signals in lieu of hardcoded handling.
	* src/ntl-window.c, src/ntl-window.h src/ntl-window-msgs.c,
	src/ntl-window-msgs.h, src/ntl-window-state.c
	(request_location_change, request_selection_change,
	request_status_change, request_progress_change): Removed these
	signals; they are operations you do on a NautilusWindow, not
	something it notifies you of, and any usefulness for inheritance
	purposes is purely speculative right now.
	(nautilus_window_connect_view, nautilus_window_disconnect_view):
	Use these new helper functions to connect callbacks to
	NautilusView's signals instead of expecting them to just get
	called.
	(nautilus_view_request_location_change,
	nautilus_view_request_selection_change,
	nautilus_view_request_status_change,
	nautilus_view_request_progress_change): Execute bodies of real_
	versions instead of emitting singals.
	(nautilus_view_real_request_location_change,
	nautilus_view_real_request_selection_change,
	nautilus_view_real_request_status_change,
	nautilus_view_real_request_progress_change): Removed these.
	Finally, always call nautilus_winodow_set_content_view or
	nautilus_window_add_meta_view before calling
	nautilus_view_load_client to make sure no signals are lost.
	
1215 1216 1217 1218 1219 1220 1221 1222
2000-01-03  Elliot Lee  <sopwith@redhat.com>

	* components/websearch, configure.in: The ten minute version of kwebsearch.
	* components/html/ntl-web-browser.c: Handle forms (POST is untested and probably buggy).
	* src/ntl-uri-map.c: Check result of file_info retrieval. Load web search by default.
	* src/ntl-prefs.[ch]: First (lame) attempt at implementing application preferences.
	* src/ntl-app.c: Load prefs at startup

1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239
2000-01-03  John Sullivan  <sullivan@eazel.com>

	Added underline-accelerators to Add Bookmark and
	Edit Bookmarks in Bookmarks menu. This was much
	more difficult than I expected.

	* src/nautilus-bookmarks-menu.c:
	  (init): Removed all the guts of this function.
	  (nautilus_bookmarks_menu_new): Now calls
	  nautilus_bookmarks_menu_fill() on freshly-created menu.
	  (nautilus_bookmarks_menu_fill): New function, takes over
	  the chore of initially populating the Bookmarks menu.
	  Uses GnomeUIInfo structs to set up Add Bookmarks and
	  Edit Bookmarks so they'll have underline-accelerators.
	  Also they now have tooltip strings (and I added a call
	  to gnome_app_install_menu_hints() to make the tooltips work).

1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251
2000-01-03  John Sullivan  <sullivan@eazel.com>

	Fixed memory leaks in bookmarks stuff

	* src/nautilus-bookmarklist.c: (nautilus_bookmarklist_delete_item_at):
	  Destroy the bookmark when removing it from list.
	* src/nautilus-bookmarks-menu.c: 
	  (nautilus_bookmarks_menu_repopulate):
	  Store an index rather than a bookmark in the menu item, since the
	  item will be destroyed if the menu is reordered.
	  (bookmark_activated_cb): Find bookmark from the index stored in item.

1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263
2000-01-03  John Sullivan  <sullivan@eazel.com>

	Started new file for file-related utilities in Nautilus.

	* libnautilus/nautilus-file-utilities.h : new file
	* libnautilus/nautilus-file-utilities.c : new file
	* libnautilus/Makefile.am : added these two new files to the build.

 	* src/nautilus_bookmarklist.c:
 	  (nautilus_bookmarklist_get_file_path): Deployed
 	  nautilus_make_path() and nautilus_user_directory()

1264
2000-01-03  Darin Adler  <darin@eazel.com>
1265

1266 1267 1268 1269 1270 1271
        * configure.in: Added "-Wall -Wno-unused" to list of warnings.
	It seems to me that at one point we got these from the gnome
	default warnings, but this seems to have stopped. There's no
	harm in repeating them in here and it fixes the problem for
	now, but I'd like to know what happened.
        * components/html/.cvsignore: Added some generated files.
1272
	* components/html/gnome-dialogs.c: (glibwww_progress):
1273 1274 1275
	Replaced an incorrect "%l" in a printf format string with
	the correct "%ld".
	* libnautilus/.cvsignore: Added some generated files.
1276

1277 1278 1279 1280 1281 1282 1283
2000-01-03  John Sullivan  <sullivan@eazel.com>

 	* src/nautilus_bookmarklist.c:
 	  (nautilus_bookmarklist_save_file): Took out unused local 
 	  variables. My compiler didn't notice these because -Wall
 	  isn't in our compile flags. Darin is fixing the compile flags.

Elliot Lee's avatar
Elliot Lee committed
1284 1285 1286 1287
2000-01-03  Elliot Lee  <sopwith@redhat.com>

	* All files: Update copyright notices.

1288 1289 1290 1291 1292 1293 1294
1999-12-30  John Sullivan  <sullivan@eazel.com>

	* src/nautilus_bookmarklist.c: (nautilus_bookmarklist_get_file_path):
	  Create directory that contains bookmarks file if it's not already
	  there. Saving bookmarks would have failed (silently) for anyone
	  who didn't already have a ~/.gnomad directory without this change.

1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
1999-12-30  John Sullivan  <sullivan@eazel.com>

	Made NautilusBookmark use gchar * instead of GString
	since it wasn't using any special GString features.

	* src/nautilus-bookmark.h: changed definition in struct
	* str/nautilus-bookmark.c:
	  (nautilus_bookmark_destroy): changed g_string_free to g_free
	  (init): eliminated g_string_new
	  (nautilus_bookmark_get_name): replaced bookmark->uri->name
	  with bookmark->name
	  (nautilus_bookmark_get-uri): replaced bookmark->uri->str
	  with bookmark->uri
	  (nautilus_bookmark_new): changed initializers from
	  GString style to gchar * style

	Save/restore bookmarks across sessions with XML file.

	* src/nautilus_bookmarklist.c:
	  (append_bookmark_node): new foreach static function
	  (destroy_bookmark): new foreach static function
	  (nautilus_bookmarklist_get_file_path): new static function
	  (nautilus_bookmarklist_load_file): new static function
	  (nautilus_bookmarklist_save_file): new static function
	  (init): renamed to nautilus_bookmark_init
	  (class_init): renamed to nautilus_bookmark_class_init
	  (nautilus_bookmarklist_contents_changed): now calls
	  nautilus_bookmarklist_save_file
	  (nautilus_bookmarklist_init): now calls
	  nautilus_bookmarklist_load_file

1326 1327 1328 1329 1330 1331 1332
1999-12-30  John Sullivan  <sullivan@eazel.com>

	Linked in GNOME-XML library, since I'll need it for bookmarks.

	* configure.in: defined XML-related macros (copied from gconf)
	* src/Makefile.am: included $(XML_CFLAGS) and $(XML_LIBS)

1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365
1999-12-30  John Sullivan  <sullivan@eazel.com>

	The bookmark-editing window is now functional, though simple.
	It allows editing names & uris, reordering bookmarks via
	dragging in the list, and removing bookmarks. Coming next:
	bookmarks persisting across sessions.

	* src/nautilus-bookmarks-window.h: New file.
	* src/nautilus-bookmarks-window.c: New file.
	* src/Makefile.am: added nautilus-bookmarks-window.[ch]
	* src/nautilus-bookmarklist.h, nautilus-bookmarklist.c:
	  (nautilus_bookmarklist_delete_item_at): New function
	  (nautilus_bookmarklist_insert_item): New function
	* src/nautilus-bookmarks-menu.c: (init): Removed
	  insensitization of Edit Bookmarks item.

	Added parameter names to prototypes where they were missing

	* src/nautilus-bookmark.h
	* src/nautilus-bookmarklist.h
	* src/nautilus-bookmarks-menu.h

	Fixed bug where activating bookmarks failed in any but the
	first window

	* src/nautilus-bookmarks-menu.c 
	  (bookmark_activated_cb):
	  (nautilus_bookmarks_menu_repopulate):
	  Changed bookmark menu items to keep a pointer to their
	  menu, rather than the menu's window, because sometimes
	  the menu's window isn't set when the menu item is created.

1999-12-29  John Sullivan  <sullivan@eazel.com>
1366 1367 1368 1369 1370 1371 1372

	* src/nautilus-bookmarklist.c: 
	  (nautilus_bookmarklist_contains):
	  changed two g_return_if_fail to g_return_val_if_fail. Eek! I
	  accidentally checked this in yesterday without compiling. I
	  should be tarred and feathered.
	  (nautilus_bookmarklist_append): Now calls new nautilus_bookmark_copy
1373 1374 1375
	* src/nautilus-bookmark.c:
	  (nautilus_bookmark_copy): New method
	* src/nautilus-bookmark.h:
1376 1377
	  (nautilus_bookmark_copy): New method

1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388
1999-12-28  John Sullivan  <sullivan@eazel.com>

	* src/nautilus-bookmark.c: 
	* src/nautilus-bookmarklist.c:
	* src/nautilus-bookmarks-menu.c:

	  Removed unnecessary g_return_if_fail (obj != NULL) calls
	  since the g_return_if_fail (NAUTILUS_IS_WHATEVER (obj)) call
	  also handles the NULL case. Also added some more calls of
	  the latter type.

1389 1390
1999-12-28  John Sullivan  <sullivan@eazel.com>

1391 1392
	* src/nautilus-bookmark.c, src/nautilus-bookmark.h: 			
	  (nautilus_bookmark_compare_with): 
1393
	  new function, compares two bookmarks for equivalence, used by:
1394 1395
	* src/nautilus-bookmarklist.c, src/nautilus-bookmarklist.h: 
	  (nautilus_bookmarklist_contains): 
1396 1397
	  new function, checks whether a given bookmark is already in the 
	  list, used by:
1398
	* src/nautilus-bookmarks-menu.c, src/nautilus-bookmarks-menu.h:
1399 1400 1401 1402 1403 1404 1405 1406 1407
	  (add_bookmark_cb): now silently refuses to add another bookmark
	  for the current location if there's one already in the list.
	  (init): now uses connect_signal_while_alive to avoid nastiness
	  when trying to add a bookmark after one or more windows were closed.
	* src/ntl-window.c: (file_menu_new_window_cb): Now calls
	  nautilus_app_create_window() instead of creating the new window
	  in line, so that the window count gets properly updated and closing
	  windows works correctly.
	  
1408 1409 1410 1411 1412 1413 1414 1415
1999-12-28  John Sullivan  <sullivan@eazel.com>

	* src/ntl-view.c: (nautilus_view_load_client):
	  Undid the previous change. It turned out I
	  needed to rebuild the latest ORBit and then
	  the latest gnome-libs. I had built them in
	  the wrong order before.
	  
1416 1417 1418 1419 1420 1421 1422 1423
1999-12-28  John Sullivan  <sullivan@eazel.com>

	* src/ntl-view.c: (nautilus_view_load_client): cast
	  a const CORBA_char * to a CORBA_char * in call to
	  GNOME_Unknown_query_interface to fix the build.
	  Darin thinks this is a mistake in the API and is
	  investigating fixing the API.

1424 1425
1999-12-22  Elliot Lee  <sopwith@redhat.com>

1426 1427
	* src/ntl-uri-map.[ch]: Add initialization function. Implement scheme mapping.

1428 1429 1430 1431 1432
	* components/history/ntl-history-view.c: Testbed for UIHandler usage.
	* src/ntl-*view*.c: Better error checking, support UIHandler usage.
	* src/ntl-window-msgs.c: Better error checking.
	* src/ntl-window.c: Better error checking, plus move menu creation so that UIHandler usage is easier.

1433
1999-12-21  Elliot Lee  <sopwith@redhat.com>
1434 1435 1436 1437 1438 1439 1440

	* idl/nautilus.idl, libnautilus/ntl-view-client.[ch], src/ntl-window*.[ch], src/ntl-view-frame-svr.c:
	  Add request_progress_change notification

	* src/ntl-view-*: Fix/finish various mjs changes: Do the component type abstraction properly,
	lose ntl-view-frame-svr.h, add ntl-view-private.h, add various component type implementations.

1441 1442 1443
	* src/ntl-view-frame-svr.h: Add 'extern' so everyone doesn't get their
	  own vepv variable.

1444 1445
1999-12-20  Maciej Stachowiak  <mjs@eazel.com>

1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464
	* src/ntl-view.h: Remove request_* calls from public API (they are
	just an implementation detail of the fact that NautilusView
	implements a Nautilus:ViewFrame CORBA server - the nautilus app
	should not need to call these).

	* src/ntl-view.c: Split all the three way conditional stuff out so
	there is a separate function for each branch of the condition. Not
	a big win yet, but will provide opportunities for more
	refactoring.

	* src/ntl-view-frame-svr.c, ntl-view-frame-svr.h: Move
	implementation of Nautilus:ViewFrame CORBA server here as much as
	possible.
	* src/ntl-view.c: Remove it from here.
	* src/nautilus.h: #include ntl-view-frame-svr.h
	* src/Makefile.am: add ntl-view-frame-svr.[ch] to build.
		
	* src/ntl-window.c: Add myself to About box (pout).

Maciej Stachowiak's avatar
Maciej Stachowiak committed
1465 1466
	* components/html/ntl-web-browser.c: Fix warnings.	

1467 1468 1469 1470 1471 1472 1473 1474 1475 1476
1999-12-20  Elliot Lee  <sopwith@redhat.com>

	* configure.in, components/Makefile.am: Add HTML component to build.
	* components/help/hyperbola-main.c, components/history/ntl-history-view.c: Make process die when
	  all objects have been destroyed.
	* components/history/ntl-history-view.c: Bug fixes.
	* components/html/*.[ch]: Copy glibwww over, write new NautilusViewClient for HTML browsing.
	* src/ntl-uri-map.c: Cleanup, and use ntl_web_browser as default HTML display engine.
	* src/ntl-view.c: Try to handle Bonobo views for data display.

1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493
1999-12-20  John Sullivan  <sullivan@eazel.com>
	* src/nautilus-bookmark.h,c: new files
	* src/nautilus-bookmarklist.h,c: new files
	* src/nautilus-bookmarks-menu.h,c: new files
	* src/Makefile.am: added these six new files to nautilus_SOURCES
	* src/ntl-window.c: now #includes nautilus-bookmarks-menu.h
	  (bookmarks_menu_info[]): removed all items except GNOMEUIINFO_END;
	  subtree is added dynamically later.
	  (nautilus-window-constructed): insert bookmarks menu
	  (nautilus-window-constructed): add padding to status bar so text
	  isn't jammed against frame.

	The bookmark menu is now limping along. The Add Bookmark item works,
	and the items that get added do the right thing. Edit Bookmarks is
	still insensitive, so there's no way to remove items. Except by
	quitting, because they aren't yet being saved/restored across sessions.
	
1494 1495 1496 1497 1498 1499 1500 1501 1502
1999-12-20  Havoc Pennington  <hp@redhat.com>

	* src/file-manager/fm-icon-cache.c: Add inline RGB data for
	default icon. 
	(fm_icon_cache_load_icon): only
	ref the pixbuf if it exists
	(fm_icon_cache_new): add a new fallback special icon set
	(fm_icon_cache_load_icon): load fallback if the icon name is ""

1503 1504 1505 1506 1507 1508
1999-12-20  Havoc Pennington  <hp@redhat.com>

	* libnautilus/gnome-icon-container.c (set_kbd_current): return if 
	the icon being set is NULL. This may be fixing a symptom rather
	than a problem.

1509 1510 1511 1512 1513 1514
1999-12-20  Elliot Lee  <sopwith@redhat.com>

	* src/ntl-*.[ch]: Support multiple view types (Nautilus/View, GNOME/Control, GNOME/Embeddable)
	* src/ntl-window.[ch]: Add nautilus_window_get_uih()
	* idl/*.idl: Reindent.

1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529
1999-12-19  Havoc Pennington  <hp@pobox.com>

	* src/file-manager/desktop-window.c (desktop_window_realize): turn
	on window decorations for debugging
	(desktop_window_init): debug comment-out the no-resize policy

	* src/file-manager/desktop-layout.c (desktop_layout_arrange):
	fool with layout routines
	
	* src/file-manager/desktop-canvas.c
	(desktop_canvas_size_allocate): debugging border to detect layout screwups

	* src/file-manager/desktop-item.c (icon_realize): set the canvas
	item, oops.

1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548
1999-12-19  Havoc Pennington  <hp@pobox.com>

	* src/file-manager/desktop-layout.c: don't do an arrangement
	on every change

	* src/file-manager/desktop-canvas.c
	(desktop_canvas_load_desktop_icons): connect to finished_load and
	arrange the icons when we get it. This is a temporary hack,
	because the DesktopLayout engine isn't progressive yet.

	* src/file-manager/fm-directory-list.c
	(fm_directory_list_class_init): add a finished_load signal

	* src/file-manager/desktop-window.c (desktop_window_init): for
	now, don't fill the whole screen so we can see gdb.

	* src/file-manager/desktop-item.c: Move user data accessors into
	the .c file, these are private.	

1549 1550
1999-12-17  Havoc Pennington  <hp@redhat.com>

Havoc Pennington's avatar
Havoc Pennington committed
1551 1552 1553
        * src/file-manager/desktop-item.h: New module, for items 
	on the desktop
	
1554 1555 1556 1557 1558 1559 1560
	* src/file-manager/fm-directory-view.c: Change to use
	get_current_icon_cache() (it wasn't ever freeing the icon cache anyway)

	* src/file-manager/fm-icon-cache.c (fm_get_current_icon_cache):
	function to get a global icon cache, we will share this throughout 
	the program.

1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577
1999-12-19  Havoc Pennington  <hp@pobox.com>

	* src/file-manager/desktop-canvas.c
	(desktop_canvas_load_desktop_icons): new function, loads icons 
	from a given directory - don't get too excited, it doesn't yet
	_display_ any icons!

	* src/file-manager/desktop-canvas.h: Add directory list field.

	* src/file-manager/Makefile.am (gnome_desktop_SOURCES): Add
	fm-directory-list.[hc]
	(libntl_file_manager_la_SOURCES): add fm_directory_list.[hc]

	* src/file-manager/fm-directory-list.h, fm-directory-list.c:
	New files, the non-GUI portion of a directory listing. Handles
	loading the dir listing and the icons.

1578 1579 1580 1581 1582 1583 1584 1585 1586
1999-12-17  Maciej Stachowiak  <mjs@eazel.com>

	* src/ntl-window.c, src/ntl-window-msgs.c: Added up, reload, home,
	stop toolbar buttons. Stop is not implemented yet. Up needs more
	thought with respect to various protocols.
	
	* src/ntl-window.c, src/ntl-window.h: Added calls to
	allow/disallow some of the toolbar operations.

Havoc Pennington's avatar
Havoc Pennington committed
1587 1588 1589 1590 1591 1592 1593 1594 1595
1999-12-17  Havoc Pennington  <hp@redhat.com>

	* src/file-manager/fm-directory-view.c: Change to use
	get_current_icon_cache() (it wasn't ever freeing the icon cache anyway)

	* src/file-manager/fm-icon-cache.c (fm_get_current_icon_cache):
	function to get a global icon cache, we will share this throughout 
	the program.

1596 1597 1598 1599 1600 1601 1602 1603
1999-12-17  Havoc Pennington  <hp@redhat.com>

	* src/ntl-window.c (nautilus_window_realize): set the mini icon.
	(nautilus_window_class_init): init parent_class and install
	realize method

	* src/ntl-miniicon.c: new files, to set mini icon

1604 1605 1606 1607 1608 1609 1610 1611 1612 1613
1999-12-16  Elliot Lee  <sopwith@redhat.com>
	* libnautilus/{gdk-extensions.c,gnome-icon-container.c}: Fix warnings
	* libnautilus/gnome-icon-container.c: Try (unsuccessfully) to get
	  proper icon reflow by calling icon_grid_resize() instead of
	  icon_grid_set_visible_width(), in size_allocate().
	* src/*.*: Add ntl-app.[ch].
	* src/file-manager/desktop-*.c: Fix warnings.
	* src/file-manager/fm-directory-view.c: Remove incorrect warning,
	  allow turning off use of icon_layout altogether.
	
1614 1615 1616 1617 1618 1619 1620 1621 1622
1999-12-16  John Sullivan  <sullivan@eazel.com>

	* src/ntl-window.c:
	* src/ntl-main.c:
	* src/file-manager/fm-directory-view.c:
	Changed evil // comments to /* */. Sorry about that!

	* src/ntl-window.c: added insensitive rudimentary Bookmark menu

1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636
1999-12-16  Havoc Pennington  <hp@redhat.com>

	* src/ntl-window-state.c (nautilus_window_save_state): lookup
	signum before it's first used.
	
	* src/file-manager/desktop-layout.c: new layout module, not yet
	done

	* src/file-manager/desktop-canvas.c (desktop_canvas_init): Create
	the right-click menu.

	* src/file-manager/desktop-menu.c (desktop_menu_new): New module
	to stick the right-click menu code in

1637 1638
1999-12-16  Maciej Stachowiak  <mjs@eazel.com>

1639 1640 1641 1642 1643 1644 1645
	* src/ntl-window.c: Put meta-views on the right.

	* src/ntl-window.c, src/ntl-main.c, src/ntl-window.h,
	src/ntl-window-msgs.c, src/ntl-window-state.c: Enabled multiple
	main windows and new window menu entry. In the process replaced
	url with uri where appropriate and added
	nautilus_window_get_requested_uri accessor.
1646

Darin Adler's avatar
Darin Adler committed
1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666
1999-12-16  Darin Adler  <darin@eazel.com>

	* libnautilus/.cvsignore: Ignore all *.lo instead of listing each.
	* libnautilus/Makefile.am: Added gdk-extensions.c and $(WERROR).
	* libnautilus/gdk-extensions.[ch]: Added functions for filling with a
	gradient. Currently they are named gdk_fill_rectangle_with_gradient
	and gdk_interpolate_color, but perhaps the gdk_ prefix should be
	replaced with another one. These functions are not yet tested, but they
	compile and I want to get them in here before I leave for vacation.

	* src/ntl-uri-map.c: (nautilus_navinfo_new): Some null checks in
	the "click on an item" hack. This was a halfhearted attempt to get
	the program to not segfault when you open icons.
	* src/ntl-window-msgs.c: (nautilus_window_load_content_view):
	Some g_return_if_fail in here. I'll add a ton more at some point.
	These were part of the halfhearted attempt to get the program to
	not segfault when you open icons.

	* src/file-manager/.cvsignore: Igore all *.lo instead of listing each.

1667 1668 1669 1670 1671 1672 1673 1674 1675
1999-12-16  Elliot Lee  <sopwith@redhat.com>

	* components/history/ntl-history-view.c: Now works.
	* src/ntl-uri-map.c: Duplicate the URI being requested, since we
	don't know what the lifetime of the original value will be.
	* src/ntl-window.c: Use the paned instead of hbox, use create_menus_with_data instead.
	* src/file-manager: Misc warning fixes.
	* src/gtkscrollframe.c: Try to get rid of scrollbar chopping.

1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697
1999-12-16  John Sullivan  <sullivan@eazel.com>

	* src/ntl-window.c (file_menu_new_window_cb):
	New, currently empty callback.

	* src/ntl-window.c (file_menu_info[]):
	Added New Window item.
	
	* src/ntl-window.c (edit_menu_info[]):
	Added standard menu items, all unimplemented as of now.
	
	* src/ntl-window.c (help_menu_info[]):
	Added About item, unimplemented as of now.

	* src/ntl-window.c (main_menu[]):
	Now includes edit and help menus.
	
	* src/ntl-window.c (nautilus_window_constructed):
	Changed the way the toolbar is created, to fix bug
	where Back failed because data parameter was NULL.
	Also desensitized all the new unimplemented menu items.

Maciej Stachowiak's avatar
Maciej Stachowiak committed
1698 1699 1700 1701
1999-12-16  Maciej Stachowiak  <mjs@eazel.com>

	* src/file-manager/gnome-desktop.c (main): Quiet some warnings.

Havoc Pennington's avatar
Havoc Pennington committed
1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714
1999-12-16  Havoc Pennington  <hp@redhat.com>

	* src/file-manager/gnome-desktop.c (main): warning fixes

	* src/file-manager/desktop-canvas.c
	(desktop_canvas_update_background): start actually honoring
	background settings.

	* src/file-manager/fm-icon-cache.c: add copyright and Emacs magic.

	* src/file-manager/fm-icon-cache.h (fm_icon_cache_get_icon): Run
	egtk-format-protos on these prototypes, add copyright and Emacs magic

1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725
1999-12-16  Havoc Pennington  <hp@redhat.com>

	* src/file-manager/desktop-canvas.h: Added API for controlling the 
	background, so we can connect that to the IDL interface.

	* src/file-manager/desktop-canvas.h: New file
	
	* src/file-manager/desktop-window.h: tweaks
	
	* idl/gnome-desktop.idl: Change BackgroundInfo to not be a union.

1726
1999-12-16  John Sullivan  <sullivan@eazel.com>
1727 1728 1729 1730

	* src/file-manager/fm-directory-view.c (directory_load_cb): 
	changed assert to warning

Elliot Lee's avatar
Elliot Lee committed
1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750
1999-12-16  Elliot Lee  <sopwith@redhat.com>

	* components/help/hyperbola-nav-tree.c: Translate strings.

	* components/history/ntl-history-view.c: Bug fixes, use API
 	function for setting meta-view label.

	* libnautilus/ntl-meta-view-client.[ch]:
 	s/meta_view_set_label/meta_view_client_set_label/

	* src/ntl-uri-map.c: Use history view instead of help view as the
 	default meta view for now.

	* src/ntl-window.c: As per the comment that was removed from
 	ntl-window.c, gnome_app_install_menu_hints() needs to be called
 	_after_ statusbar creation

	* src/file-manager/fm-directory-view.c: Add more debugging assertions
	and messages.

1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762
1999-12-15  John Sullivan  <sullivan@eazel.com>

	* src/ntl-window.c: (nautilus_window_constructed): Added beginnings
	of a menu bar, and reorganized toolbar a little. There's a rudimentary
	File menu now. The View As option menu moved down to the location bar
	line. This is by no means a complete or final organization, but it's
	a start.
	* (file_menu_close_cb): new callback for File/Close menu item
	* (file_menu_exit_cb): new callback for File/Quit menu item
	* file_menu_info[]: new GNOMEUIINFO struct for File menu
	* toolbar_info[]: new GNOMEUIINFO struct for toolbar

1763 1764 1765 1766 1767
1999-12-15  Elliot Lee  <sopwith@redhat.com>

	* Warning fixes throughout.
	* Use $(WERROR) in Makefiles to get -Werror.

Darin Adler's avatar
Darin Adler committed
1768 1769 1770 1771 1772 1773 1774
1999-12-15  Darin Adler  <darin@eazel.com>

	* components/help/.cvsignore: Ignore more generated files.
	* components/help/hyperbols-filefmt.c: Fix warnings.
	* components/help/hyperbols-main.c: Fix warnings.
	* components/help/hyperbols-nav-tree.c: Fix warnings.

1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785
1999-12-15  Elliot Lee  <sopwith@redhat.com>

	* components/Makefile.am: Turn on compilation of hyperbola component.
	* components/help/*: Compile and run.
	* libnautilus/ntl-meta-view-client.c: Create & set the property bag if it doesn't exist.
	* src/ntl-uri-map.c: Load the hyperbola nav tree component as a test meta view.
	* src/ntl-view.c: Fill in NULL fields with empty strings, so that ORBit doesn't segfault.
	* src/ntl-window-msgs.c: When creating new meta views, they should
	be meta views and not content views (cut & paste error).
	* src/file-manager/fm-directory-view.c: Don't redisplay every time a new entry comes in.

1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808
1999-12-15  Darin Adler  <darin@eazel.com>

	* configure.in: Turned "-Wshadow" and "-Wundef" off for now, since they
	fire in some existing code.
	* gnome-icon-container.c: (handle_icon_button_press): Null out the drag
	variables before sending the activate signal. This makes activating an
	icon with a double-click work without crashing.
	* ntl-main.c: (main): Make critical and warning messages fatal if
	NAUTILUS_DEBUG is set in the environment. Make sure you have a new
	gnome-vfs that doesn't use g_warning for status messages.
	* ntl-window-msgs.c: (nautilus_window_change_location_internal):
	Made the history store away the current position as the new "previous"
	instead of storing away the new position. This makes the forward and
	back buttons work better.
	* ntl-window.c: (nautilus_window_back, nautilus_window_fwd):
	Had to make a corresponding change here after the change to the
	history mechanism.
	* fm-directory-view.c: (display_selection_info): Some fixes to the
	selection info display: "file"/"files" was backwards, text said "in"
	before the file size, and the display was not cleared when the
	selection was made empty. I still see problems where the selection
	info gets cleared when the window is lowered and then raised.
	 
1809 1810 1811 1812 1813 1814
1999-12-15  Andy Hertzfeld <andy@eazel.com>

	* my first change: changed ntl-window-state.c
	(nautilus_window_set_initial_state): changed initial path
	to be the user's home directory, getting rid of confusing "localhost"
	 
1815 1816 1817 1818 1819
1999-12-15  Elliot Lee  <sopwith@redhat.com>

	* configure.in: Add --enable-more-warnings and --enable-fatal-warnings switches.
	* src/ntl-uri-map.c: Add comment about functionality-in-waiting. 

1820 1821 1822 1823 1824 1825
1999-12-15  Darin Adler  <darin@eazel.com>

	* libnautilus/gtkscrollframe.c (gtk_scroll_frame_size_allocate):
        Rolled out my change. I was confused. Elliot had this fixed
        already but I forgot to "make install".

1826 1827 1828 1829 1830
1999-12-15  Darin Adler  <darin@eazel.com>

	* libnautilus/gtkscrollframe.c (gtk_scroll_frame_size_allocate):
        Fixed overflow problem caused by gint16 local variable.

1831 1832 1833 1834 1835 1836 1837
1999-12-15  Darin Adler  <darin@eazel.com>

	* src/ntl-window.c (nautilus_window_constructed):
        Fixed signal handler to point to nautilus_window_goto_url_cb
        instead of nautilus_window_goto_url. This was causing a bad
        cast when a new URL was typed.

1838 1839 1840 1841 1842 1843
1999-12-15  Darin Adler  <darin@eazel.com>

	* src/ntl-uri-map.c (nautilus_navinfo_new): Changed back to
        const gchar*. To compile, you need to install the latest
        gnome-vfs.

Elliot Lee's avatar
Elliot Lee committed
1844 1845 1846 1847
1999-12-15  Elliot Lee  <sopwith@redhat.com>

	* libnautilus/gtkscrollframe.c: Fix size_allocate.

1848 1849 1850 1851 1852
1999-12-14  Maciej Stachowiak  <mjs@eazel.com>

	* src/ntl-uri-map.c (nautilus_navinfo_new): a const char* can't be
	passed where a gchar* is expected.

1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881
1999-12-14  Darin Adler  <darin@eazel.com>

	* configure.in: Turned on more warnings, including -Werror.
	  I found one or two real bugs, and made some minor changes
	  to quiet the compiler so I could turn on some useful warnings
	  that triggered on the existing code.
	
	* src/file-manager/dfos-xfer.c: (handle_xfer_vfs_error):
	  Fixed a place where it was calling the gnome error(), but using
	  the parameters from the old gnome-fm error() function.

	* libnautilus/ntl-meta-view-client.c:
	  (nautilus_meta_view_set_label): Fixed a place where we
	  were passing in string literals to code that will free them.
	  We need to call g_strdup before passing them to gnome_property_bag_add.

	* libnautilus/gnome-icon-container.c: Fixed a warning.
	* libnautilus/gtkscrollframe.c: Fixed a warning.
	* libnautilus/ntl-content-view-client.c: Fixed a warning.
	* libnautilus/ntl-view-client.c: Fixed a warning.
	* libnautilus/ntl-content-view.c: Fixed a warning.
	* src/ntl-main.c: Fixed a warning.
	* src/ntl-meta-view.c: Fixed a warning.
	* src/ntl-types.h: Fixed a warning.
	* src/ntl-view.c: Fixed a warning.
	* src/ntl-window.c: Fixed a warning.
	* src/file-manager/dfos-xfer-progress-dialog.c: Fixed a warning.
	* src/file-manager/fm-icon-cache.c: Fixed a warning.

1882 1883 1884 1885 1886 1887 1888
1999-12-14  Elliot Lee  <sopwith@redhat.com>

	* src/*.c: Restructure the whole NautilusWindow code for sanity's sake.
	* src/ntl-uri-map.[ch]: Instead of just passing in various pieces of information about the old URL,
	  pass in the Nautilus_NavigationInfo that has to be kept around anyways.
	* idl/nautilus.idl: Allow a selection to be multiple URI's.

Darin Adler's avatar
Darin Adler committed
1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904
1999-12-14  Darin Adler  <darin@eazel.com>

	* src/ntl-window.c: (nautilus-window-constructed): Forward-button signal
	was connected with NULL parameter instead of window. Fixed that so it
	has a chance of working.

	* .cvsignore: Ignore more generated files.
	* components/.cvsignore: Ignore more generated files.
	* help/.cvsignore: Ignore more generated files.
	* history/.cvsignore: Ignore more generated files.
	* icons/.cvsignore: Ignore more generated files.
	* idl/.cvsignore: Ignore more generated files.
	* libnautilus/.cvsignore: Ignore more generated files.
	* src/.cvsignore: Ignore more generated files.
	* src/file-manager/.cvsignore: Ignore more generated files.

1905 1906 1907 1908 1909 1910 1911
1999-12-14  John Sullivan  <sullivan@eazel.com>

	* src/ntl-window.c: (nautilus-window-constructed): Reordered option menu
	creation code to fix bug where it wasn't sizing itself properly. Changed
	label of placeholder item and desensitized it to make it more obvious that
	it's a non-working placeholder.

Elliot Lee's avatar
Elliot Lee committed
1912 1913 1914 1915 1916 1917
1999-12-14  Elliot Lee  <sopwith@redhat.com>

	* configure.in, Makefile.am, icons/: Add icons

	* src/file-manager/fm-directory-view.c: Everything goes inside the scroll-frame, not the view itself.

1918 1919 1920 1921 1922 1923 1924
1999-12-13  Elliot Lee  <sopwith@redhat.com>

	* libnautils/g*.[ch]: Switch from imlib to pixbuf.
	* src/file-manager: Import from gnome-fm.

	* idl/nautilus.idl: Add a 'main_window' attribute on a ViewFrame, so that views can talk to the main window.

1925 1926 1927 1928 1929 1930 1931 1932 1933 1934
1999-12-10  Elliot Lee  <sopwith@redhat.com>

	* libnautilus/ntl-meta-view.[ch]: Add a convenience function for
	setting the label.

	* Throughout: Rename the meta view "description" property to "label",
	which more accurately describes its use.

	* components/help: Start turning hyperbola into component.

Elliot Lee's avatar
Elliot Lee committed
1935 1936 1937 1938
1999-12-09  Elliot Lee  <sopwith@redhat.com>

	* Start migration from gnome-fm.

1939 1940 1941 1942
src/explorer-location-bar.[ch]:
	Copy over from gnome-fm, change signal to include new URI.
src/ntl-window.c:
	Make NautilusWindow use it.