plugin-manager: Kill window effects on destroy
We do so for all other window effects already. Why this was left out is unknow (cfa89ceb6b8a82ec), but we will need it for a fix in GS.
Related: #655 (closed)
Merge request reports
Activity
mentioned in commit rmader/mutter@9e69d165
added 1 commit
- 9e69d165 - plugin-manager: Kill window effects on destroy
- Resolved by Robert Mader
Why this was left out is unknow (cfa89ceb6b8a82ec)
That's not a commit?
- Resolved by Georges Basile Stavracas Neto
Tried some history research to find out why there wasn't any effects being killed on destroy, but, I ended up in a commit from 2008 that says "Basic plugin infastructure and a sample simple plugin." and nothing else. Sounds sane that we do this however, lets land this.
mentioned in commit rmader/mutter@40a65a8c
added 1 commit
- 40a65a8c - plugin-manager: Kill window effects on destroy
enabled an automatic merge when the pipeline for 40a65a8c succeeds
- Resolved by Georges Basile Stavracas Neto
Seems the CI failure is not flakyness; the minimize test case fails.
mentioned in commit rmader/mutter@a4f51da1
assigned to @jadahl
changed milestone to %GNOME 3.34
added 1. Bug label
mentioned in commit 403d8fcc
mentioned in merge request !875 (closed)
mentioned in issue #655 (closed)
@rmader Is there a chance that this gets backported to 3.28, i.e. the version used by some of the long-term supported distros like Ubuntu LTS and RHEL?
To me, it sounds very inefficient to have all distributions (and as we all know, there are too many of them) apply this patch independently (instead of just pulling from upstream).
I couldn't find information on the lifecycle of GNOME. The last commit to branch
gnome-3-28
is not that old. Will a MR still be accepted if I provide one against this branch?Ubuntu bug (gnome-shell): https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1844222
Edited by Christian RauchFrom IRC:
(21:52:27) robert_mader: Hm, I was just asked if we would accept MRs backporting fixes to older branches like 3.28. Do we do that? (21:53:13) feaneron: uh, 3.28 is almost 2 years old (21:54:06) feaneron: a new 3.28 release is not going to happen, so distros would still have to cherry-pick the patch anyway (21:54:27) feaneron: well, it's not going to happen unless someone is paid to do that :) (21:55:15) robert_mader: well, rhel and ubuntu 18.04 both use it if I'm not mistaken... (21:55:51) robert_mader: but would we simply reject it or give it a chance if it looks alright? (21:57:06) feaneron: if it cherry-picks cleanly, why not... (21:57:35) feaneron: (but, again, distros would have to cherry-pick anyway, since there's no release)
So I'd say give it a go. Note that you'd need this, gnome-shell!815 (merged) and !925 (merged), so I'm not too optimistic that everything applies somewhat cleanly.
Edited by Robert Mader
mentioned in issue gnome-shell#1300 (closed)
mentioned in issue #397 (closed)
mentioned in issue gnome-shell#1166 (closed)