Skip to content

backends/x11: Flush connection after ungrab

Carlos Garnacho requested to merge wip/carlosg/help-cleanup-gtk-usage into master

(Note: This is a supporting commit for gnome-shell!317 (merged))

Modal ungrabs may be followed by other clients trying to grab themselves, flush the connection so we ensure the right order of events on the Xserver side.

An example of this is js/ui/modalDialog.js in gnome-shell, as the alt-F2 dialog may launch X11 clients trying to grab themselves, commit a40daa3c22 in gnome-shell handled the case and added a gdk_display_sync() call to ensure no grab existed at the time of executing.

This commit aims to achieve the same built in MetaBackend. A full sync seems excessive though, as we just need to make sure the server got the messages queued before the other side tries to grab, a XFlush seems sufficient for this.

Merge request reports