Skip to content

clutter-text: Avoid clipping the wrong framebuffer

Daniel van Vugt requested to merge vanvugt/mutter:clutter-text-clipping into master

ClutterText painting for editable single_line_mode actors like StEntry is always clipped by:

cogl_framebuffer_push_rectangle_clip (fb, 0, 0, alloc_width, alloc_height)

So it's difficult to get the rectangle wrong. However in cases where the target framebuffer has changed (cogl_push_framebuffer) such as when updating ClutterOffscreenEffect we had the wrong old value of fb. And so would be clipping the wrong framebuffer, effectively not clipping at all.

This is intended to unblock gnome-shell!73 (merged) and maybe also !98 (merged) which both exhibit a lack of StEntry clipping in Alt+F2 command text editing.

Edited by Daniel van Vugt

Merge request reports