Skip to content
  • Robert Bragg's avatar
    Add support for stacking X and Wayland windows together · 40e820f5
    Robert Bragg authored and Jasper St. Pierre's avatar Jasper St. Pierre committed
    This breaks down the assumptions in stack-tracker.c and stack.c that
    Mutter is only stacking X windows.
    
    The stack tracker now tracks windows using a MetaStackWindow structure
    which is a union with a type member so that X windows can be
    distinguished from Wayland windows.
    
    Some notable changes are:
    
    Queued stack tracker operations that affect Wayland windows will not be
    associated with an X serial number.
    
    If an operation only affects a Wayland window and there are no queued
    stack tracker operations ("unvalidated predictions") then the operation
    is applied immediately since there is no server involved with changing
    the stacking for Wayland windows.
    
    The stack tracker can no longer respond to X events by turning them into
    stack operations and discarding the predicted operations made prior to
    that event because operations based on X events don't know anything
    about the stacking of Wayland windows.
    
    Instead of discarding old predictions the new approach is to trust the
    predictions but whenever we receive an event from the server that
    affects stacking we cross-reference with the predicted stack and check
    for consistency. So e.g. if we have an event that says ADD window A then
    we apply the predictions (up to the serial for that event) and verify
    the predicted state includes a window A. Similarly if an event says
    RAISE_ABOVE(B, C) we can apply the predictions (up to the serial for
    that event) and verify that window B is above C.
    
    If we ever receive spurious stacking events (with a serial older than we
    would expect) or find an inconsistency (some things aren't possible to
    predict from the compositor) then we hit a re-synchronization code-path
    that will query the X server for the full stacking order and then use
    that stack to walk through our combined stack and force the X windows to
    match the just queried stack but avoiding disrupting the relative
    stacking of Wayland windows. This will be relatively expensive but
    shouldn't be hit for compositor initiated restacking operations where
    our predictions should be accurate.
    
    The code in core/stack.c that deals with synchronizing the window stack
    with the X server had to be updated quite heavily. In general the patch
    avoids changing the fundamental approach being used but most of the code
    did need some amount of re-factoring to consider what re-stacking
    operations actually involve X or not and when we need to restack X
    windows we sometimes need to search for a suitable X sibling to restack
    relative too since the closest siblings may be Wayland windows.
    40e820f5