Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,029
    • Issues 1,029
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 134
    • Merge requests 134
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • muttermutter
  • Merge requests
  • !895

window: Don't use override redirect parent window workspace

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Trevisan requested to merge 3v1n0/mutter:override-redirect-child-workspace-fix into master Oct 29, 2019
  • Overview 22
  • Commits 4
  • Pipelines 38
  • Changes 4

Java applications might use override-redirect windows as parent windows.

In such case, the first non-override-redirect child window that is created will be marked as being on_all_workspaces since the call to should_be_on_all_workspaces() will return TRUE for its parent, and this even though the on_all_workspaces_requested bit is unset. When a further child of this window is then added, it will be set as not having a workspace and not being on_all_workspaces, since the call to should_be_on_all_workspaces() for its parent would return FALSE (unless if it's in a different monitor, and the multiple-monitors workspaces are disabled).

Since per commit 09bab98b we don't recompute the workspace if the on_all_workspaces bit is unset, let's just ignore the workspace settings for the parent window if that is an override redirect window, as those are in fact part of no-workspace by definition.

Add a stacking test to verify this scenario (was failing before of this commit) and ignore override-redirect parents while showing a child.

Fixes #885 (closed) !895 (merged)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: override-redirect-child-workspace-fix