Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,101
    • Issues 1,101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !82

x11/clutter-device-manager-xi2: Added checking for device and source_device are NULL

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Jos Collin requested to merge jcollin/mutter:wip-source-device-fix into master Apr 17, 2018
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Added checking for device and source_device becomes NULL under the case XI_Enter|XI_Leave. We have encountered instances in which the source_device becomes NULL and as a consequence the call to _clutter_input_device_reset_scroll_info() causes a crash. Please verify the fix and let me know if I can combine the two 'if(source_device)' conditions into one. I think those calls are supposed to be in that sequence?

Signed-off-by: Jos Collin jcollin@redhat.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip-source-device-fix