Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,022
    • Issues 1,022
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 130
    • Merge requests 130
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • muttermutter
  • Merge requests
  • !602

cogl: Remove GLX "threaded swap wait" used on Nvidia

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel van Vugt requested to merge vanvugt/mutter:remove-threaded-swap-wait into master May 31, 2019
  • Overview 49
  • Commits 1
  • Pipelines 26
  • Changes 7

It was hurting performance because it requires stalling both the GL pipeline (GPU) and the event loop (CPU) by calling glFinish as part of _cogl_winsys_wait_for_gpu on every frame.

Threaded swap wait was definitely a good idea when it was written. It was written to avoid unthrottled (high CPU) rendering on the Nvidia driver. But more recently commit e415cc53 has fixed that permanently. So now we can remove threaded swap wait and avoid the performance hit it incurs.

Partial fix for #700 (closed)

Edited Aug 28, 2019 by Daniel van Vugt
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove-threaded-swap-wait