Skip to content

clutter: Drop misguided assert

Carlos Garnacho requested to merge carlosg/mutter:wip/carlosg/get-source-device-assert into main

The clutter_seat_handle_event_post() function wants to handle CLUTTER_DEVICE_ADDED/REMOVED to perform signal emission, but checks (and asserts) that every event going through it has a source device.

This is no longer quite true for IM events (they are attached to the ClutterSeat's keyboard, not a HW device), so the assert can now fire off (of course undesiredly).

But anyways, for events built through clutter_event_device_notification_new() (the ones this function is interested in, after all), it is already a precondition check that the device is proper at the time of creating the event, so asserting for it here is redundant.

We can drop this overly generic assert, this is already ensured for the events that matter, anyways.

Merge request reports