Skip to content

backends/x11: Fix type confusion about object data

Barnabás Pőcze requested to merge pobrn/mutter:x11_backend_fix_obj_data_type_confusion into main 
Since c390f70edca40d ("backend: Set up and use ownership chains")
the type of the ClutterInputDevice object's "meta-input-settings-xdevice"
data is `DeviceHandle`, but that commit failed to change the one place
where the object data is queried. As a consequence, that part still
considers it to be an `XDevice`, so everything that uses the return
value of `device_ensure_xdevice()` works with invalid data. Furthermore,
`device_handle_free()` incorrectly uses the `user_data` as the argument
for `XCloseDevice()` leading to a double free.

Fixes: c390f70edca40d ("backend: Set up and use ownership chains")

Merge request reports