Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.2k
    • Issues 1.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 137
    • Merge requests 137
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !2910

window: Slow down decoration changes when (un)fullscreening

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Jonas Ådahl requested to merge jadahl/mutter:wip/toggle-fullscreen-grace-time into main Mar 13, 2023
  • Overview 2
  • Commits 3
  • Pipelines 3
  • Changes 9

Old SDL versions causes a feedback loop when a decorated client toggles fullscreen, where the reparent events makes it revert its fullscreen change over and over indefinitely. While this is fixed in newer versions of SDL, many games still use the old version, statically built into their binaries, and will likely never update.

To mitigate these feedback loops, don't update the decoration state for 250 ms after it changed. This gives clients enough time to settle into the state they expect to be, and we'll avoid the feedback loop.

Closes: #2678 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/toggle-fullscreen-grace-time