Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,015
    • Issues 1,015
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • mutter
  • Merge requests
  • !281

clutter/stage-cogl: Reschedule update on present

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel van Vugt requested to merge vanvugt/mutter:reschedule-on-present into master Nov 01, 2018
  • Overview 51
  • Commits 1
  • Pipelines 47
  • Changes 2

If an update (new frame) had been scheduled already before _clutter_stage_cogl_presented was called then that means it was scheduled for the wrong time. Because the last_presentation_time has changed since then. And using an update_time based on an outdated presentation time results in scheduling frames too early, filling the buffer queue (triple buffering or worse) and high visual latency.

So if we do receive a presentation event when an update is already scheduled, remember to reschedule the update based on the newer last_presentation_time. This way we avoid overfilling the buffer queue and limit ourselves to double buffering for less visible lag.

Closes: #334 (closed)

Prerequisite: !520 (merged)

Edited May 20, 2019 by Marco Trevisan
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: reschedule-on-present