Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,152
    • Issues 1,152
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !2592

wayland: Add destruction listener to activation token surface

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Carlos Garnacho requested to merge wip/carlosg/activation-surface-listener into main Aug 23, 2022
  • Overview 10
  • Commits 1
  • Pipelines 4
  • Changes 1

In the timespan between an activation token being created and the token being used by the activated application, the surface that started the activation request may end up destroyed/disposed.

In that case, the token would be left with a stale surface pointer, maybe causing crashes later on. Set up a destroy notification listener so that we do know to unset the token surface if that situation arises, this will result in Mutter not considering the token activatable, thus maybe issuing the "Application needs attention" if the activated surface did not immediately get focus. In any case this is better than a compositor crash.

A typical situation where this may happen is "Open With..." dialogs, since those don't live long after launching the application.

Fixes: #2390 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/carlosg/activation-surface-listener