Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,147
    • Issues 1,147
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !2504

wayland/data-device: Prefer copy when shift+control used in dnd

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Corey Berla requested to merge coreyberla/mutter:coreyberla-main-patch-59445 into main Jul 09, 2022
  • Overview 2
  • Commits 1
  • Pipelines 8
  • Changes 1

X11 provides the ability to create a link by holding CTRL+SHIFT during a DnD operation.

In Wayland, the modifiers CTRL and SHIFT are checked independently to either use the MOVE or COPY action. Given that COPY is non-destructive, prefer COPY over MOVE when both control and shift are used.

Furthermore, the Wayland protocol states "If no modifiers are pressed, the first match (in bit order) will be used" (i.e. COPY before MOVE). This change would be more consistent with that default behavior.

This has been a problem in Nautilus where users are mistakenly moving data nautilus#1302 (moved)

Edited Jul 10, 2022 by Corey Berla
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: coreyberla-main-patch-59445