Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,101
    • Issues 1,101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !2502

wayland/actor-surface: Consider clones in is_on_logical_monitor()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Robert Mader requested to merge rmader/mutter:clones_on_logicol_monitor into main Jul 08, 2022
  • Overview 10
  • Commits 1
  • Pipelines 14
  • Changes 1

While the check for clutter_actor_has_mapped_clones clearly indicates an intention to take clones into account, the following code does not do so, likely because it predates the introduction of clutter_actor_is_effectively_on_stage_view().

Switch to that newer API in order to take clones into account. This avoids unnecessary wl_surface_send_enter() and wl_surface_send_leave() events when entering the overview, reducing client work.


Note: wl_surface_send_leave() and wl_surface_send_enter() may trigger a buffer_scale or buffer_transform change. Depending on the client implementation this may result in a buffer resize, potentially a quite heavy operation.

Edited Jul 11, 2022 by Robert Mader
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: clones_on_logicol_monitor