Skip to content

Window: Guard minimize()

Florian Müllner requested to merge fmuellner/mutter:guard-minimize into main

Not all windows can be minimized: X11 clients can disable the functionality, and so do we for windows that aren't shown in the alt-tab popup or the shell overview, so there would be no way of getting them back.

While we make sure that we respect that ourselves (keybinding, window menu, etc.), we don't guard meta_window_minimize(), so clients or extensions can still minimize a window that isn't supposed to be minimized.

That can lead to all kinds of issues, from the hidden window being lost (as far as users are concerned) to a crash when the minimzed window has a transient parent.

Just add an explicit check to make sure the unexpected doesn't happen after all, and print a warning if it does.

This is an alternative to !2472 (closed) and !2473 (closed).

Merge request reports