Skip to content

Draft: keybindings: Split X11 specific part

Bilal Elmoussaoui requested to merge bilelmoussaoui/keybindings into main

The PR does two changes:

  • Move (un)freeze/(un)grab keyboard to per MetaBackend and make the default implementation no-op.
  • Move the remaining x11 specific functions to keybindings-x11. In the 2nd commit, I tried to guard those functions but that become very ugly a big portion of the file being guarded with HAVE_X11_CLIENT & then I decided to move it to a separate file. I tried to think of some way to clean things up a bit more, but couldn't come with any. Suggestions would be very appreciated here.

Marked as a draft because I am not sure about the 2nd/3rd commit and how to move forward here.

Depends on: !2466 (closed)

Relevant #2272

Merge request reports