Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.2k
    • Issues 1.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 123
    • Merge requests 123
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !2333

clutter/stage: Repick when pointer actor goes unmapped

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jonas Dreßler requested to merge verdre/mutter:repick-on-unmap into main Mar 09, 2022
  • Overview 8
  • Commits 1
  • Pipelines 14
  • Changes 3

I've overseen quite an important case in commit 98a5cb37: Repicking only when actors get destroyed is not enough, we actually need to repick when actors go hidden/unmapped.

While we could also listen to notify::mapped just like we listen to notify::reactive, it seems better to avoid using property notifications here due to the usage of g_object_freeze/thaw_notify() in ClutterActor. It can lead to the stage receiving a notify::mapped with mapped = true for a pointer actor, which really shouldn't happen (just like notify::reactive with reactive = true shouldn't happen).

Fixes: gnome-shell#5124 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: repick-on-unmap