Skip to content
Snippets Groups Projects

xprops: Validate text properties that claim to be UTF8

Merged Sebastian Keller requested to merge skeller/mutter:invalid-utf8-wm-name into master
All threads resolved!

Some clients such as mpv might set the WM_TITLE as a UTF8_STRING based on some unconverted/unvalidated metadata that is not actually UTF8. This would then be set as the title of a MetaWindow (in the absence of a valid UTF8 _NET_WM_TITLE). The shell then tries to use this window title for things like the overview or the window switcher where it would trigger an UTF8 validation error and leave the shell in an unusable state.

Fixes: #1794 (closed)

Merge request reports

Merge request pipeline #281990 passed

Merge request pipeline passed for e4236530

Test coverage 47.00% (0.00%) from 2 jobs

Merged by Marge BotMarge Bot 3 years ago (May 11, 2021 3:43pm UTC)

Loading

Pipeline #282001 failed

Pipeline failed for e4236530 on master

Test coverage 47.00% (0.00%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastian Keller resolved all threads

    resolved all threads

  • Marge Bot added 34 commits

    added 34 commits

    Compare with previous version

  • merged

  • mentioned in issue #212 (closed)

  • Please register or sign in to reply
    Loading