Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,020
    • Issues 1,020
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 130
    • Merge requests 130
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • muttermutter
  • Merge requests
  • !1846

Reenable touch-mode on touchscreen devices with pointers.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Simon Sherred requested to merge simonraindrum/mutter:simonraindrum-master-patch-34337 into main Apr 30, 2021
  • Overview 16
  • Commits 1
  • Pipelines 30
  • Changes 1

This is a partial revert of !1710 (merged) in order to resolve #1686, #1732, and #1760.

!1710 (merged) was based on the premise that touch-mode (i.e. auto-rotation and onscreen keyboard availability) should never be enabled when a device has a touchpad currently enabled. This would be a good assumption if all 2-in-1 laptops correctly disabled their touchpads when folded into tablet mode. But many don't, unless they are listed on a per-device basis in the Linux kernel.

Adding a gsetting would probably be the ideal solution here, but I think a reversion is the best option in the short term, since the issue has been unsolved for months and has been mentioned in multiple places:

  • https://www.reddit.com/r/gnome/comments/n0kar3/screen_autorotation_stopped_working_after/
  • https://www.reddit.com/r/gnome/comments/mgstkm/onscreen_keyboard_no_longer_displays_on_gnome_40/
  • https://extensions.gnome.org/extension/4191/screen-autorotate/
  • https://www.reddit.com/r/gnome/comments/n8371y/does_gnome_40_dropped_support_for_screen/
  • https://www.reddit.com/r/gnome/comments/r0wv6e/screen_rotation_broken_in_wayland_gnome_411_arch/
Edited Dec 21, 2021 by Simon Sherred
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: simonraindrum-master-patch-34337