Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,152
    • Issues 1,152
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !1766

[3.38] frame: Fix crash when clicking below titlebar with broken gtk themes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonas Ådahl requested to merge cherry-pick-c2968c89 into gnome-3-38 Mar 09, 2021
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

When a gtk theme uses larger shadows for the unfocused state than for the focused one, this can cause a crash in meta_frame_left_click_event. Since whether to call meta_frame_left_click_event is decided based on the decoration size before focusing and the control that was clicked on after focusing, this can result in an event handled in meta_frame_left_click_event being on the client area.

Fixes #1668 (closed)

Part-of: !1748 (merged)

(cherry picked from commit c2968c89)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cherry-pick-c2968c89