Skip to content

monitor-config-manager: Handle multiple builtin panels gracefully

Jonas Ådahl requested to merge jadahl/mutter:wip/dont-crash-on-multiple-builtin-panels into master

While multiple built-in panels isn't actually supported in any meaningful manner, if we would ever end up with such a situation, e.g. due to kernel bugs[0], we shouldn't crash when trying to set an 'external only' without any external monitors.

While we could handle this with more degraded functionality (e.g. don't support the 'switch' method of monitor configuration at all), handle it by simply not trying to switch to external-only when there are no, according to the kernel, external monitors available. This would e.g. still allow betwene 'mirror-all', and 'linear' switches.

The crash itself was disguised as an arbitrary X11 BadValue error, due to mutter trying to resize the root window to 0x0, as the monitor configuration that was applied consisted of zero logical monitors, thus was effectively empty.

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1896904

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1899260

Merge request reports