Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,151
    • Issues 1,151
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !1335

surface-actor: Add culling offset for geometry scale - take 2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Robert Mader requested to merge rmader/mutter:issue1312 into master Jun 28, 2020
  • Overview 11
  • Commits 1
  • Pipelines 12
  • Changes 1

41130b08 added a fix for culling subsurfaces with geometry scale. Unfortunately it only did so for the opaque regions, not for clip and unobscured regions, as the effect was hidden by bug that was only fixed by 3187fe8e.

Apply the same fix to clip and unobscured regions and use the chance to move most of the slightly hackish geometry scale related code into a single place.

We need to scale slightly differently in the two cases, indicated by the new ScalePerspectiveType enum, as the scale is dependent on the perspective - once from outside, once from inside of the scaled actor.

Closes #1312 (closed)

Edited Jun 30, 2020 by Robert Mader
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue1312