Skip to content

backends/native: Drop external keyboard detection for ::touch-mode

Carlos Garnacho requested to merge wip/carlosg/drop-external-keyboard-detection into master

This cannot be made to work reliably. Some factoids:

  • Internal devices may be connected via USB.
  • The ACPI spec provides the _PLD (Physical location of device) hook to determine how is an USB device connected, with an anecdotal success rate. Internal devices may be seen as external and vice-versa, there is also an "unknown" value that is widely used.
  • There may be non-USB keyboards, the old "AT Translated Set 2 Keyboard" interface does not change on hotplugging.
  • Libinput has an internal series of quirks to classify keyboards as internal of external, also with an "unknown" value.

These heuristics are kinda hopeless to get right by our own hand. Drop this external keyboard detection in the hope that there will be something more deterministic to rely on in the future (e.g. the libinput quirks made available to us directly or indirectly).

Fixes: gnome-shell#2378 (closed) Related: gnome-shell#2353

Merge request reports