Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
M
mutter
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 788
    • Issues 788
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 102
    • Merge Requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • mutter
  • Merge Requests
  • !1022

Merged
Created Jan 28, 2020 by Olivier Fourdan@ofourdan🛠Developer

Window stream fixes

  • Overview 39
  • Commits 3
  • Pipelines 18
  • Changes 6

Window streaming has a couple of issues because of the various scaling factors with and without scaled-framebuffer.

One of the issue, as described in #1018 (closed), is that the video crop, based on meta_window_actor_get_frame_bounds() values might be wrong with a scaled output.

The second issue that this MR fixes is that the clipping rectangle needs to be scaled by the buffer scale rather than the geometry scale prior to call meta_shaped_texture_get_image(), otherwise with scaled-framebuffer enabled, we may not clip appropriately and copy too much data.

Third issue, with mutliple children, the clipping rectangle should not be scaled up, otherwise, same, we may copy too much data and overflow the buffer, and eventually crash mutter/gnome-shell when streaming a window at scale > 1.

Edited Jan 28, 2020 by Olivier Fourdan
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: window-stream-fixes