meta-seat-x11: Uninitialized group and mode params to clutter_event_pad_button_new without libwacom
The group
and mode
variables in src/backends/x11/meta-seat-x11.c:2209
are declared uninitialized and only initialized in a #ifdef HAVE_LIBWACOM
block, and then used right after outside that:
[428/1567] Compiling C object src/libmutter-13.so.0.0.0.p/backends_x11_meta-seat-x11.c.o
../src/backends/x11/meta-seat-x11.c:212:37: warning: cast from 'XIAnyClassInfo *' to 'XIValuatorClassInfo *' increases required alignment from 4 to 8 [-Wcast-align]
212 | (XIValuatorClassInfo *) class_info);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/backends/x11/meta-seat-x11.c:217:46: warning: cast from 'XIAnyClassInfo *' to 'XIScrollClassInfo *' increases required alignment from 4 to 8 [-Wcast-align]
217 | XIScrollClassInfo *scroll_info = (XIScrollClassInfo *) class_info;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/backends/x11/meta-seat-x11.c:404:39: warning: cast from 'XIAnyClassInfo *' to 'XIValuatorClassInfo *' increases required alignment from 4 to 8 [-Wcast-align]
404 | XIValuatorClassInfo *valuator = (XIValuatorClassInfo*) info->classes[i];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/backends/x11/meta-seat-x11.c:2245:51: warning: variable 'group' is uninitialized when used here [-Wuninitialized]
2245 | group,
| ^~~~~
../src/backends/x11/meta-seat-x11.c:2209:35: note: initialize the variable 'group' to silence this warning
2209 | uint32_t button, group, mode;
| ^
| = 0
../src/backends/x11/meta-seat-x11.c:2246:51: warning: variable 'mode' is uninitialized when used here [-Wuninitialized]
2246 | mode);
| ^~~~
../src/backends/x11/meta-seat-x11.c:2209:41: note: initialize the variable 'mode' to silence this warning
2209 | uint32_t button, group, mode;
| ^
| = 0
5 warnings generated.
Is there a safe default that can be used here to not feed clutter_event_pad_button_new()
potentially garbage in such a build configuration?
This happens in gnome-45 branch, but confirmed in main
after local workarounds for #3226 (closed)