Skip to content

Uninitialized data when sending request to X

IDK which of gjs or mutter is the culprit here.

With bac7b3f4 and !1441 applied, I'm getting the following valgrind report:

==153784== Syscall param writev(vector[...]) points to uninitialised byte(s)
==153784==    at 0x5CED66D: __writev (writev.c:26)
==153784==    by 0x5CED66D: writev (writev.c:24)
==153784==    by 0x920343D: UnknownInlinedFun (xcb_conn.c:296)
==153784==    by 0x920343D: _xcb_conn_wait.part.0 (xcb_conn.c:551)
==153784==    by 0x92035AF: UnknownInlinedFun (xcb_out.c:469)
==153784==    by 0x92035AF: _xcb_out_send (xcb_out.c:470)
==153784==    by 0x9204848: UnknownInlinedFun (xcb_out.c:416)
==153784==    by 0x9204848: xcb_writev (xcb_out.c:409)
==153784==    by 0x6231E05: _XSend (xcb_io.c:587)
==153784==    by 0x6235DF9: _XReply (xcb_io.c:679)
==153784==    by 0x6236310: XSync (Sync.c:44)
==153784==    by 0x5B2AA9F: meta_prop_get_values.constprop.0 (xprops.c:909)
==153784==    by 0x5A81836: UnknownInlinedFun (group-props.c:80)
==153784==    by 0x5A81836: UnknownInlinedFun (group-props.c:57)
==153784==    by 0x5A81836: meta_group_property_notify (group.c:318)
==153784==    by 0x5A83380: handle_other_xevent (events.c:1647)
==153784==    by 0x5A8638F: UnknownInlinedFun (events.c:2001)
==153784==    by 0x5A8638F: xevent_filter.lto_priv.0 (events.c:2048)
==153784==    by 0x5F1386E: gdk_event_apply_filters (gdkeventsource.c:79)
==153784==  Address 0x31d4d3e4 is 244 bytes inside a block of size 16,384 alloc'd
==153784==    at 0x4846A73: calloc (vg_replace_malloc.c:1328)
==153784==    by 0x6221996: XOpenDisplay (OpenDis.c:241)
==153784==    by 0x5F16BFD: _gdk_x11_display_open (gdkdisplay-x11.c:1565)
==153784==    by 0x5EC2C36: gdk_display_manager_open_display (gdkdisplaymanager.c:462)
==153784==    by 0x5A905DA: UnknownInlinedFun (meta-x11-display.c:1086)
==153784==    by 0x5A905DA: meta_x11_display_new (meta-x11-display.c:1241)
==153784==    by 0x5AE384A: UnknownInlinedFun (display.c:753)
==153784==    by 0x5AE384A: on_init_x11_cb (meta-xwayland.c:760)
==153784==    by 0x4BD20D3: ??? (in /usr/lib/libgio-2.0.so.0.7503.0)
==153784==    by 0x4BD5ECC: ??? (in /usr/lib/libgio-2.0.so.0.7503.0)
==153784==    by 0x67574F5: ffi_call_unix64 (unix64.S:104)
==153784==    by 0x6753F5D: ffi_call_int.lto_priv.0 (ffi64.c:673)
==153784==    by 0x6756B72: ffi_call (ffi64.c:710)
==153784==    by 0x56F9427: Gjs::Function::invoke(JSContext*, JS::CallArgs const&, JS::Handle<JSObject*>, _GIArgument*) (function.cpp:969)